Cache::offsetSet() - Code Metrics - Inspection of "Nette 2.4 fix" - h4kuna/exchange - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#20)

unknown

created 2016-07-11 19:58 UTC

Cache::offsetSet() A

↳ Parent: Cache

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	1	Features	0

Metric	Value
c	1
b	1
f	0
dl	0
loc	4
rs	10
cc	1
eloc	2
nc	1
nop	2

<?php

namespace h4kuna\Exchange\Nette;

use DateTime,
	h4kuna\Exchange\Currency,
	h4kuna\Exchange\Storage,
	Nette\Caching;

final class Cache extends Caching\Cache implements Storage\IStock
{

	/** @var string represent time */
	private $refresh = '15:30';

	/** @return DateTime */
	private function getRefresh()
	{
		if (is_string($this->refresh)) {
			$this->refresh = new DateTime('today ' . $this->refresh);

			if (new DateTime >= $this->refresh) {
				$this->refresh->modify('+1 day');
			}
		}
		return $this->refresh;
	}

	/**
	 * @param string $hour
	 * @return Storage
	 */
	public function setRefresh($hour)
	{
		$this->refresh = $hour;
		return $this;
	}

	/**
	 * @param Currency\IProperty $currency
	 */
	public function saveCurrency(Currency\IProperty $currency)
	{
		$refresh = $this->getRefresh();
		$expire = NULL;
		if ($refresh) {
			$expire = [self::EXPIRE => $refresh];
		}

		$this->save($currency->getCode(), $currency, $expire);
	}

	/**
	 * @param array $currencies
	 */
	public function saveCurrencies(array $currencies)
	{
		foreach ($currencies as $currency) {
			$this->saveCurrency($currency);
		}
		$this->save(self::ALL_CURRENCIES, array_keys($currencies));
	}

	public function loadCurrency($code)
	{
		return $this->load($code);
	}

	/** @return array */
	public function getListCurrencies()
	{
		return $this->loadCurrency(self::ALL_CURRENCIES);
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
	}

	/** Nette 2.4 interface fix **/

    public function offsetSet($key, $data)
	{
		$this->save($key, $data);
	}

	public function offsetGet($key)
	{
		return $this->load($key);
	}

	public function offsetExists($key)
	{
        return $this->load($key);
	}

    public function offsetUnset($key)
	{
        return $this->remove($key);
    }

}


1			<?php
2
3			namespace h4kuna\Exchange\Nette;
4
5			use DateTime,
6			h4kuna\Exchange\Currency,
7			h4kuna\Exchange\Storage,
8			Nette\Caching;
9
10			final class Cache extends Caching\Cache implements Storage\IStock
11			{
12
13			/** @var string represent time */
14			private $refresh = '15:30';
15
16			/** @return DateTime */
17			private function getRefresh()
18			{
19			if (is_string($this->refresh)) {
20			$this->refresh = new DateTime('today ' . $this->refresh);
			0 ignored issues – show Documentation Bug introduced 2016-01-19 08:59 UTC by Report Bug Copy Issue Report It seems like `new \DateTime('today ' . $this->refresh)` of type `object<DateTime>` is incompatible with the declared type `string` of property `$refresh`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
21			if (new DateTime >= $this->refresh) {
22			$this->refresh->modify('+1 day');
23			}
24			}
25			return $this->refresh;
26			}
27
28			/**
29			* @param string $hour
30			* @return Storage
31			*/
32			public function setRefresh($hour)
33			{
34			$this->refresh = $hour;
35			return $this;
36			}
37
38			/**
39			* @param Currency\IProperty $currency
40			*/
41			public function saveCurrency(Currency\IProperty $currency)
42			{
43			$refresh = $this->getRefresh();
44			$expire = NULL;
45			if ($refresh) {
46			$expire = [self::EXPIRE => $refresh];
47			}
48
49			$this->save($currency->getCode(), $currency, $expire);
50			}
51
52			/**
53			* @param array $currencies
54			*/
55			public function saveCurrencies(array $currencies)
56			{
57			foreach ($currencies as $currency) {
58			$this->saveCurrency($currency);
59			}
60			$this->save(self::ALL_CURRENCIES, array_keys($currencies));
61			}
62
63			public function loadCurrency($code)
64			{
65			return $this->load($code);
66			}
67
68			/** @return array */
69			public function getListCurrencies()
70			{
71			return $this->loadCurrency(self::ALL_CURRENCIES);
			0 ignored issues – show Bug Best Practice introduced 2016-01-19 08:59 UTC by Report Bug Copy Issue Report The return type of `return $this->loadCurrency(self::ALL_CURRENCIES);` (`h4kuna\Exchange\Storage\ICurrency`) is incompatible with the return type declared by the interface `h4kuna\Exchange\Storage\IStock::getListCurrencies` of type `array`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
72			}
73
74			/ Nette 2.4 interface fix /
75
76			public function offsetSet($key, $data)
77			{
78			$this->save($key, $data);
79			}
80
81			public function offsetGet($key)
82			{
83			return $this->load($key);
84			}
85
86			public function offsetExists($key)
87			{
88			return $this->load($key);
89			}
90
91			public function offsetUnset($key)
92			{
93			return $this->remove($key);
94			}
95
96			}
97

h4kuna / exchange

Pull Request — master (#20)

Cache::offsetSet() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like