IpTools::getClientIp() - Code Metrics - h-wang/defender - Measure and Improve Code Quality continuously with Scrutinizer

IpTools::getClientIp() B
last analyzed 2018-07-12 10:06 UTC

↳ Parent: IpTools

Complexity

Conditions	6
Paths	9

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	26
rs	8.8817
c	0
b	0
f	0
cc	6
nc	9
nop	0

<?php

namespace Hongliang\Defender\Utility;

class IpTools
{
    public static function getClientIp()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $ip_keys = [
            'HTTP_CLIENT_IP',
            'REMOTE_ADDR',
            'HTTP_X_FORWARDED_FOR',
            'HTTP_X_FORWARDED',
            'HTTP_X_CLUSTER_CLIENT_IP',
            'HTTP_FORWARDED_FOR',
            'HTTP_FORWARDED',
        ];
        foreach ($ip_keys as $key) {
            if (array_key_exists($key, $_SERVER) === true) {
                foreach (explode(',', $_SERVER[$key]) as $ip) {
                    // trim for safety measures
                    $ip = trim($ip);
                    // attempt to validate IP
                    if (self::validateIp($ip)) {
                        return $ip;
                    }
                }
            }
        }

        return isset($_SERVER['REMOTE_ADDR']) ? $_SERVER['REMOTE_ADDR'] : false;
    }

    /**
     * Ensures an ip address is both a valid IP and does not fall within
     * a private network range.
     */
    public static function validateIp($ip)
    {
        if (filter_var($ip, FILTER_VALIDATE_IP, FILTER_FLAG_IPV4 | FILTER_FLAG_NO_PRIV_RANGE | FILTER_FLAG_NO_RES_RANGE) === false) {
            return false;
        }

        return true;
    }
}


1			<?php
2
3			namespace Hongliang\Defender\Utility;
4
5			class IpTools
6			{
7			public static function getClientIp()
			0 ignored issues – show Coding Style introduced 2016-03-24 12:42 UTC by Report Bug Copy Issue Report `getClientIp` uses the super-global variable `$_SERVER` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
8			{
9			$ip_keys = [
10			'HTTP_CLIENT_IP',
11			'REMOTE_ADDR',
12			'HTTP_X_FORWARDED_FOR',
13			'HTTP_X_FORWARDED',
14			'HTTP_X_CLUSTER_CLIENT_IP',
15			'HTTP_FORWARDED_FOR',
16			'HTTP_FORWARDED',
17			];
18			foreach ($ip_keys as $key) {
19			if (array_key_exists($key, $_SERVER) === true) {
20			foreach (explode(',', $_SERVER[$key]) as $ip) {
21			// trim for safety measures
22			$ip = trim($ip);
23			// attempt to validate IP
24			if (self::validateIp($ip)) {
25			return $ip;
26			}
27			}
28			}
29			}
30
31			return isset($_SERVER['REMOTE_ADDR']) ? $_SERVER['REMOTE_ADDR'] : false;
32			}
33
34			/**
35			* Ensures an ip address is both a valid IP and does not fall within
36			* a private network range.
37			*/
38			public static function validateIp($ip)
39			{
40			if (filter_var($ip, FILTER_VALIDATE_IP, FILTER_FLAG_IPV4 \| FILTER_FLAG_NO_PRIV_RANGE \| FILTER_FLAG_NO_RES_RANGE) === false) {
41			return false;
42			}
43
44			return true;
45			}
46			}
47

h-wang / defender

IpTools::getClientIp() B last analyzed 2018-07-12 10:06 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

IpTools::getClientIp() B
last analyzed 2018-07-12 10:06 UTC