BaseVoter - Code Metrics - h-wang/defender - Measure and Improve Code Quality continuously with Scrutinizer

BaseVoter A
last analyzed 2018-07-12 10:06 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	32
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	0

Importance

Changes

Metric	Value
wmc	6
c	0
b	0
f	0
lcom	0
cbo	0
dl	0
loc	32
rs	10

4 Methods

Rating	Name	Size	Complexity
A	__construct()	9	3
A	vote()	4	1
A	getAssets()	4	1
A	setAssets()	6	1

<?php

namespace Hongliang\Defender\Voter;

class BaseVoter implements VoterInterface
{
    protected $assets = null;
    protected $target = null;

    public function __construct()
    {
        if (method_exists($this, 'setDefaultTarget')) {
            $this->setDefaultTarget();
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        }
        if (method_exists($this, 'getDefaultAssets')) {
            $this->assets = $this->getDefaultAssets();
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        }
    }

    public function vote($key = null)
    {
        throw new \Exception('The vote method must be implemented in '.static::class);
    }

    protected function getAssets()
    {
        return $this->assets;
    }

    public function setAssets($assets)
    {
        $this->assets = $assets;

        return $this;
    }
}


1			<?php
2
3			namespace Hongliang\Defender\Voter;
4
5			class BaseVoter implements VoterInterface
6			{
7			protected $assets = null;
8			protected $target = null;
9
10			public function __construct()
11			{
12			if (method_exists($this, 'setDefaultTarget')) {
13			$this->setDefaultTarget();
			0 ignored issues – show Bug introduced 2016-03-25 00:34 UTC by Report Bug Copy Issue Report It seems like you code against a specific sub-type and not the parent class `Hongliang\Defender\Voter\BaseVoter` as the method `setDefaultTarget()` does only exist in the following sub-classes of `Hongliang\Defender\Voter\BaseVoter`: `Hongliang\Defender\Voter\IpRangeVoter`, `Hongliang\Defender\Voter\UriKeywordVoter`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history...
14			}
15			if (method_exists($this, 'getDefaultAssets')) {
16			$this->assets = $this->getDefaultAssets();
			0 ignored issues – show Bug introduced 2016-04-16 16:34 UTC by Report Bug Copy Issue Report It seems like you code against a specific sub-type and not the parent class `Hongliang\Defender\Voter\BaseVoter` as the method `getDefaultAssets()` does only exist in the following sub-classes of `Hongliang\Defender\Voter\BaseVoter`: `Hongliang\Defender\Voter\IpRangeVoter`, `Hongliang\Defender\Voter\SpiderVoter`, `Hongliang\Defender\Voter\UriKeywordVoter`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history...
17			}
18			}
19
20			public function vote($key = null)
21			{
22			throw new \Exception('The vote method must be implemented in '.static::class);
23			}
24
25			protected function getAssets()
26			{
27			return $this->assets;
28			}
29
30			public function setAssets($assets)
31			{
32			$this->assets = $assets;
33
34			return $this;
35			}
36			}
37

h-wang / defender

BaseVoter A last analyzed 2018-07-12 10:06 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

4 Methods

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like

BaseVoter A
last analyzed 2018-07-12 10:06 UTC