Workflow::import() - Code Metrics - Inspection of "Merge pull request #25 from gyselroth/dev" - gyselroth/tubee - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( e50616...a5acb0 )

by Raffael

created 2019-02-07 14:26 UTC

Workflow::import() C

↳ Parent: Project

Complexity

Conditions	10
Paths	19

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	110

Importance

Changes

Metric	Value
dl	0
loc	75
ccs	0
cts	61
cp	0
rs	6.6787
c	0
b	0
f	0
cc	10
nc	19
nop	4
crap	110

How to fix Long Method Complexity

<?php

declare(strict_types=1);

/**
 * tubee
 *
 * @copyright   Copryright (c) 2017-2019 gyselroth GmbH (https://gyselroth.com)
 * @license     GPL-3.0 https://opensource.org/licenses/GPL-3.0
 */

namespace Tubee;

use Psr\Http\Message\ServerRequestInterface;
use Psr\Log\LoggerInterface;
use Tubee\AttributeMap\AttributeMapInterface;
use Tubee\Endpoint\EndpointInterface;
use Tubee\Resource\AbstractResource;
use Tubee\Resource\AttributeResolver;
use Tubee\V8\Engine as V8Engine;
use Tubee\Workflow\Map;
use Tubee\Workflow\WorkflowInterface;
use V8Js;

class Workflow extends AbstractResource implements WorkflowInterface
{
    /**
     * Kind.
     */
    public const KIND = 'Workflow';

    /**
     * Workflow name.
     *
     * @var string
     */
    protected $name;

    /**
     * Endpoint.
     *
     * @var EndpointInterface
     */
    protected $endpoint;

    /**
     * Logger.
     *
     * @var LoggerInterface
     */
    protected $logger;

    /**
     * Attribute map.
     *
     * @var AttributeMap
     */
    protected $attribute_map;

    /**
     * Condition.
     *
     * @var string
     */
    protected $ensure = WorkflowInterface::ENSURE_EXISTS;

    /**
     *  Condiditon.
     */
    protected $condition;

    /**
     * V8 engine.
     *
     * @var V8Engine
     */
    protected $v8;

    /**
     * Initialize.
     */
    public function __construct(string $name, string $ensure, V8Engine $v8, AttributeMapInterface $attribute_map, EndpointInterface $endpoint, LoggerInterface $logger, array $resource = [])
    {
        $this->name = $name;
        $this->ensure = $ensure;
        $this->v8 = $v8;
        $this->attribute_map = $attribute_map;
class Alien {}

class Dalek extends Alien {}

class Plot
{
    /** @var  Dalek */
    public $villain;
}

$alien = new Alien();
$plot = new Plot();
if ($alien instanceof Dalek) {
    $plot->villain = $alien;
}
        $this->endpoint = $endpoint;
        $this->logger = $logger;
        $this->resource = $resource;
        $this->condition = $resource['data']['condition'];
    }

    /**
     * {@inheritdoc}
     */
    public function getIdentifier(): string
    {
        return $this->endpoint->getIdentifier().'::'.$this->name;
    }

    /**
     * Get ensure.
     */
    public function getEnsure(): string
    {
        return $this->ensure;
    }

    /**
     * {@inheritdoc}
     */
    public function decorate(ServerRequestInterface $request): array
    {
        $namespace = $this->endpoint->getCollection()->getResourceNamespace()->getName();
        $collection = $this->endpoint->getCollection()->getName();
        $endpoint = $this->endpoint->getName();

        $resource = [
            '_links' => [
                'namespace' => ['href' => (string) $request->getUri()->withPath('/api/v1/namespaces/'.$namespace)],
                'collection' => ['href' => (string) $request->getUri()->withPath('/api/v1/namespaces/'.$namespace.'/collections/'.$collection)],
                'endpoint' => ['href' => (string) $request->getUri()->withPath('/api/v1/namespaces/'.$namespace.'/collections/'.$collection.'/endpoints/'.$endpoint)],
           ],
            'namespace' => $namespace,
            'collection' => $collection,
            'endpoint' => $endpoint,
            'data' => $this->getData(),
        ];

        return AttributeResolver::resolve($request, $this, $resource);
    }

    /**
     * {@inheritdoc}
     */
    public function getEndpoint(): EndpointInterface
    {
        return $this->endpoint;
    }

    /**
     * {@inheritdoc}
     */
    public function getAttributeMap(): AttributeMapInterface
    {
        return $this->attribute_map;
    }

    /**
     * check condition.
     */
    protected function checkCondition(array $object): bool
    {
        if ($this->condition === null) {
            $this->logger->debug('no workflow condition set for workflow ['.$this->getIdentifier().']', [
                'category' => get_class($this),
            ]);

            return true;
        }

        $this->logger->debug('execute workflow condiditon ['.$this->condition.'] for workflow ['.$this->getIdentifier().']', [
            'category' => get_class($this),
        ]);

        try {
            $this->v8->object = $object;
            $this->v8->executeString($this->condition, '', V8Js::FLAG_FORCE_ARRAY);

            return (bool) $this->v8->getLastResult();
        } catch (\Exception $e) {
            $this->logger->error('failed execute workflow condition ['.$this->condition.']', [
                'category' => get_class($this),
                'exception' => $e,
            ]);

            return false;
        }
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			/**
6			* tubee
7			*
8			* @copyright Copryright (c) 2017-2019 gyselroth GmbH (https://gyselroth.com)
9			* @license GPL-3.0 https://opensource.org/licenses/GPL-3.0
10			*/
11
12			namespace Tubee;
13
14			use Psr\Http\Message\ServerRequestInterface;
15			use Psr\Log\LoggerInterface;
16			use Tubee\AttributeMap\AttributeMapInterface;
17			use Tubee\Endpoint\EndpointInterface;
18			use Tubee\Resource\AbstractResource;
19			use Tubee\Resource\AttributeResolver;
20			use Tubee\V8\Engine as V8Engine;
21			use Tubee\Workflow\Map;
22			use Tubee\Workflow\WorkflowInterface;
23			use V8Js;
24
25			class Workflow extends AbstractResource implements WorkflowInterface
26			{
27			/**
28			* Kind.
29			*/
30			public const KIND = 'Workflow';
31
32			/**
33			* Workflow name.
34			*
35			* @var string
36			*/
37			protected $name;
38
39			/**
40			* Endpoint.
41			*
42			* @var EndpointInterface
43			*/
44			protected $endpoint;
45
46			/**
47			* Logger.
48			*
49			* @var LoggerInterface
50			*/
51			protected $logger;
52
53			/**
54			* Attribute map.
55			*
56			* @var AttributeMap
57			*/
58			protected $attribute_map;
59
60			/**
61			* Condition.
62			*
63			* @var string
64			*/
65			protected $ensure = WorkflowInterface::ENSURE_EXISTS;
66
67			/**
68			* Condiditon.
69			*/
70			protected $condition;
71
72			/**
73			* V8 engine.
74			*
75			* @var V8Engine
76			*/
77			protected $v8;
78
79			/**
80			* Initialize.
81			*/
82			public function __construct(string $name, string $ensure, V8Engine $v8, AttributeMapInterface $attribute_map, EndpointInterface $endpoint, LoggerInterface $logger, array $resource = [])
83			{
84			$this->name = $name;
85			$this->ensure = $ensure;
86			$this->v8 = $v8;
87			$this->attribute_map = $attribute_map;
			0 ignored issues – show Documentation Bug introduced 2018-04-16 09:00 UTC by Report Bug Copy Issue Report `$attribute_map` is of type `object<Tubee\AttributeMap\AttributeMapInterface>`, but the property `$attribute_map` was declared to be of type `object<Tubee\AttributeMap>`. Are you sure that you always receive this specific sub-class here, or does it make sense to add an `instanceof` check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a given class or a super-class is assigned to a property that is type hinted more strictly. Either this assignment is in error or an instanceof check should be added for that assignment. class Alien {} class Dalek extends Alien {} class Plot { /** @var Dalek */ public $villain; } $alien = new Alien(); $plot = new Plot(); if ($alien instanceof Dalek) { $plot->villain = $alien; } Loading history...
88			$this->endpoint = $endpoint;
89			$this->logger = $logger;
90			$this->resource = $resource;
91			$this->condition = $resource['data']['condition'];
92			}
93
94			/**
95			* {@inheritdoc}
96			*/
97			public function getIdentifier(): string
98			{
99			return $this->endpoint->getIdentifier().'::'.$this->name;
100			}
101
102			/**
103			* Get ensure.
104			*/
105			public function getEnsure(): string
106			{
107			return $this->ensure;
108			}
109
110			/**
111			* {@inheritdoc}
112			*/
113			public function decorate(ServerRequestInterface $request): array
114			{
115			$namespace = $this->endpoint->getCollection()->getResourceNamespace()->getName();
116			$collection = $this->endpoint->getCollection()->getName();
117			$endpoint = $this->endpoint->getName();
118
119			$resource = [
120			'_links' => [
121			'namespace' => ['href' => (string) $request->getUri()->withPath('/api/v1/namespaces/'.$namespace)],
122			'collection' => ['href' => (string) $request->getUri()->withPath('/api/v1/namespaces/'.$namespace.'/collections/'.$collection)],
123			'endpoint' => ['href' => (string) $request->getUri()->withPath('/api/v1/namespaces/'.$namespace.'/collections/'.$collection.'/endpoints/'.$endpoint)],
124			],
125			'namespace' => $namespace,
126			'collection' => $collection,
127			'endpoint' => $endpoint,
128			'data' => $this->getData(),
129			];
130
131			return AttributeResolver::resolve($request, $this, $resource);
132			}
133
134			/**
135			* {@inheritdoc}
136			*/
137			public function getEndpoint(): EndpointInterface
138			{
139			return $this->endpoint;
140			}
141
142			/**
143			* {@inheritdoc}
144			*/
145			public function getAttributeMap(): AttributeMapInterface
146			{
147			return $this->attribute_map;
148			}
149
150			/**
151			* check condition.
152			*/
153			protected function checkCondition(array $object): bool
154			{
155			if ($this->condition === null) {
156			$this->logger->debug('no workflow condition set for workflow ['.$this->getIdentifier().']', [
157			'category' => get_class($this),
158			]);
159
160			return true;
161			}
162
163			$this->logger->debug('execute workflow condiditon ['.$this->condition.'] for workflow ['.$this->getIdentifier().']', [
164			'category' => get_class($this),
165			]);
166
167			try {
168			$this->v8->object = $object;
169			$this->v8->executeString($this->condition, '', V8Js::FLAG_FORCE_ARRAY);
170
171			return (bool) $this->v8->getLastResult();
172			} catch (\Exception $e) {
173			$this->logger->error('failed execute workflow condition ['.$this->condition.']', [
174			'category' => get_class($this),
175			'exception' => $e,
176			]);
177
178			return false;
179			}
180			}
181			}
182

gyselroth / tubee

Push — master ( e50616...a5acb0 )

Workflow::import() C

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like