Tubee\Rest\Helper::stream()

Complexity

Conditions	5
Paths	2

Size

Total Lines

44

Duplication

Lines	15
Ratio	34.09 %

Code Coverage

Tests	0
CRAP Score	30

Importance

Changes

0

<?php
    public static function stream(ServerRequestInterface $request, Identity $identity, Acl $acl, iterable $cursor): ResponseInterface

The parameter $identity is not used and could be removed.

The parameter $acl is not used and could be removed.

    {
        //Stream is valid for 5min, after a new requests needs to be sent
        ini_set('max_execution_time', '300');

        $query = $request->getQueryParams();
        $options = isset($query['pretty']) ? JSON_PRETTY_PRINT : 0;
        $error = null;

$error is not used, you could remove the assignment.

        $stream = new StreamIterator($cursor, function ($resource) use ($request, $options) {
            if ($this->tell() === 0) {

The method tell() does not seem to exist on object<Tubee\Rest\Helper>.

                echo  '[';
            } else {
                echo  ',';
            }

            echo json_encode($resource->decorate($request), $options);

            if ($this->eof()) {

The method eof() does not seem to exist on object<Tubee\Rest\Helper>.

                echo ']';
            }

            flush();
        }, function (\Throwable $e) {

The call to StreamIterator::__construct() has too many arguments starting with function (\Throwable $e) { if ($this->tell() === 0) { echo '['; } else { echo ','; } echo json_encode(array('kind' => 'StreamError', 'error' => $e->getMessage(), 'class' => get_class($e))) . ']'; flush(); }.

This code seems to be duplicated across your project.

            if ($this->tell() === 0) {

The method tell() does not seem to exist on object<Tubee\Rest\Helper>.

                echo  '[';
            } else {
                echo  ',';
            }

            echo json_encode([
                'kind' => 'StreamError',
                'error' => $e->getMessage(),
                'class' => get_class($e),
            ]).']';

            flush();
        });

        return (new Response($stream))
            ->withHeader('X-Accel-Buffering', 'no')
            ->withHeader('Content-Type', 'application/json;stream')
            ->withStatus(StatusCodeInterface::STATUS_OK);
    }