Tubee\Rest\Middlewares\QueryDecoder

Complexity

Total Complexity

15

Size/Duplication

Total Lines	60
Duplicated Lines	20 %

Coupling/Cohesion

Components	0
Dependencies	3

Test Coverage

Coverage

0%

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
D	process()	12	54	15

<?php

declare(strict_types=1);

/**
 * tubee
 *
 * @copyright   Copryright (c) 2017-2019 gyselroth GmbH (https://gyselroth.com)
 * @license     GPL-3.0 https://opensource.org/licenses/GPL-3.0
 */

namespace Tubee\Rest\Middlewares;

use function MongoDB\BSON\fromJSON;
use function MongoDB\BSON\toPHP;
use Psr\Http\Message\ResponseInterface;
use Psr\Http\Message\ServerRequestInterface;
use Psr\Http\Server\MiddlewareInterface;
use Psr\Http\Server\RequestHandlerInterface;
use Tubee\Rest\Exception;
use Zend\Diactoros\Response;

class QueryDecoder implements MiddlewareInterface
{
    /**
     * Process a server request and return a response.
     */
    public function process(ServerRequestInterface $request, RequestHandlerInterface $handler): ResponseInterface
    {
        $query = $request->getQueryParams();

        if (isset($query['offset'])) {
            $query['offset'] = (int) $query['offset'];
        }

        if (isset($query['limit'])) {
            $query['limit'] = (int) $query['limit'];
        }

        if (isset($query['watch']) && !empty($query['watch']) && $query['watch'] !== 'false') {

This code seems to be duplicated across your project.

The strict comparison !== seems to always evaluate to true as the types of $query['watch'] (integer) and 'false' (string) can never be identical. Maybe you want to use a loose comparison != instead?

            $query['watch'] = true;
        } else {
            $query['watch'] = null;
        }

        if (!empty($query['query'])) {
            $query['query'] = toPHP(fromJSON($query['query']), [
                'root' => 'array',
                'document' => 'array',
                'array' => 'array',
            ]);
        } else {
            $query['query'] = [];
        }

        if (isset($query['stream']) && $query['stream'] !== 'false' && !empty($query['stream'])) {

This code seems to be duplicated across your project.

            if (!isset($query['limit'])) {
                $query['limit'] = null;
            }
        } else {
            $query['stream'] = null;
        }

        if (!empty($query['sort'])) {
            $query['sort'] = json_decode(htmlspecialchars_decode($query['sort']), true);

            if (json_last_error()) {
                throw new Exception\InvalidInput('failed to decode provided sort: '.json_last_error_msg().', sort needs to be valid json');
            }
        } else {
            $query['sort'] = [];
        }

        if ($query['stream'] === null && empty($query['sort'])) {
            $query['sort'] = ['created' => -1];
        }

        $request = $request->withQueryParams($query);

        return $handler->handle($request);
    }
}