Validator::validateRelation() - Code Metrics - Inspection of "Merge pull request #20 from gyselroth/dev" - gyselroth/tubee - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( abe227...316baf )

by Raffael

created 2019-01-14 11:22 UTC

Validator::validateRelation() A

↳ Parent: Validator

Complexity

Conditions	4
Paths	4

Size

Total Lines

Duplication

Lines	12
Ratio	100 %

Code Coverage

Tests	0
CRAP Score	20

Importance

Changes

Metric	Value
dl	12
loc	12
ccs	0
cts	11
cp	0
rs	9.8666
c	0
b	0
f	0
cc	4
nc	4
nop	1
crap	20

<?php

declare(strict_types=1);

/**
 * tubee.io
 *
 * @copyright   Copryright (c) 2017-2019 gyselroth GmbH (https://gyselroth.com)
 * @license     GPL-3.0 https://opensource.org/licenses/GPL-3.0
 */

namespace Tubee\DataObjectRelation;

use InvalidArgumentException;
use Tubee\Resource\Validator as ResourceValidator;

class Validator extends ResourceValidator
{
    /**
     * Validate resource.
     */
    public static function validate(array $resource): array
    {
        $resource = parent::validate($resource);

        $defaults = [
            'data' => [
                'relation' => [],
                'context' => [],
            ],
        ];

        $resource = array_replace_recursive($defaults, $resource);

        if (!is_array($resource['data']['relation']) || count($resource['data']['relation']) !== 2) {
            throw new InvalidArgumentException('relation requires data.relation with exactly two objects');
        }

        self::validateRelation($resource['data']['relation']);

        if (!is_array($resource['data']['context'])) {
            throw new InvalidArgumentException('relation requires data.context to be an array');
        }

        return $resource;
    }

    /**
     * Validate relation.
     */
    protected static function validateRelation(array $resource): void

    {
        foreach ($resource as $object) {
            if (['namespace', 'collection', 'object'] != array_keys($object)) {
                throw new InvalidArgumentException('relation in data.relation must contain namespace, collection and object as strings');
            }

            if (array_filter($object, 'is_string') != $object) {
                throw new InvalidArgumentException('relation in data.relation must contain namespace, collection and object as strings');
            }
        }
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		/**
6		* tubee.io
7		*
8		* @copyright Copryright (c) 2017-2019 gyselroth GmbH (https://gyselroth.com)
9		* @license GPL-3.0 https://opensource.org/licenses/GPL-3.0
10		*/
11
12		namespace Tubee\DataObjectRelation;
13
14		use InvalidArgumentException;
15		use Tubee\Resource\Validator as ResourceValidator;
16
17		class Validator extends ResourceValidator
18		{
19		/**
20		* Validate resource.
21		*/
22		public static function validate(array $resource): array
23		{
24		$resource = parent::validate($resource);
25
26		$defaults = [
27		'data' => [
28		'relation' => [],
29		'context' => [],
30		],
31		];
32
33		$resource = array_replace_recursive($defaults, $resource);
34
35		if (!is_array($resource['data']['relation']) \|\| count($resource['data']['relation']) !== 2) {
36		throw new InvalidArgumentException('relation requires data.relation with exactly two objects');
37		}
38
39		self::validateRelation($resource['data']['relation']);
40
41		if (!is_array($resource['data']['context'])) {
42		throw new InvalidArgumentException('relation requires data.context to be an array');
43		}
44
45		return $resource;
46		}
47
48		/**
49		* Validate relation.
50		*/
51	View Code Duplication	protected static function validateRelation(array $resource): void
		0 ignored issues – show Duplication introduced 2019-01-14 11:29 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
52		{
53		foreach ($resource as $object) {
54		if (['namespace', 'collection', 'object'] != array_keys($object)) {
55		throw new InvalidArgumentException('relation in data.relation must contain namespace, collection and object as strings');
56		}
57
58		if (array_filter($object, 'is_string') != $object) {
59		throw new InvalidArgumentException('relation in data.relation must contain namespace, collection and object as strings');
60		}
61		}
62		}
63		}
64

gyselroth / tubee

Push — master ( abe227...316baf )

Validator::validateRelation() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like