Issues in InjectTrait.php (master) - Issues in master - gyselroth/mongodb-php-task-scheduler - Measure and Improve Code Quality continuously with Scrutinizer

Issues (14)

src/InjectTrait.php (2 issues)

Labels

Best Practice 2
Bug 1

Severity

Major 2

<?php

declare(strict_types=1);

/**
 * TaskScheduler
 *
 * @author      Raffael Sahli <[email protected]>
 * @copyright   Copryright (c) 2017-2019 gyselroth GmbH (https://gyselroth.com)
 * @license     MIT https://opensource.org/licenses/MIT
 */

namespace TaskScheduler;

trait InjectTrait
{
    /**
     * This method may seem useless but is actually very useful to mock the loop.
     */
    protected function loop(): bool
    {
        return true;
    }

    /**
     * This method may seem useless but is actually very useful to mock exits.
     */
    protected function exit(): bool
    {
        exit();
interface ReturnsInt {
    public function returnsIntHinted(): int;
}

class MyClass implements ReturnsInt {
    public function returnsIntHinted(): int
    {
        if (foo()) {
            return 123;
        }
        // here: null is implicitly returned
    }
}
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			/**
6			* TaskScheduler
7			*
8			* @author Raffael Sahli <[email protected]>
9			* @copyright Copryright (c) 2017-2019 gyselroth GmbH (https://gyselroth.com)
10			* @license MIT https://opensource.org/licenses/MIT
11			*/
12
13			namespace TaskScheduler;
14
15			trait InjectTrait
16			{
17			/**
18			* This method may seem useless but is actually very useful to mock the loop.
19			*/
20			protected function loop(): bool
21			{
22			return true;
23			}
24
25			/**
26			* This method may seem useless but is actually very useful to mock exits.
27			*/
28			protected function exit(): bool
29			{
30			exit();
			0 ignored issues – show Best Practice introduced 2018-09-14 11:44 UTC by Report Bug Copy Issue Report Show Similar Issues like this Using `exit` here is not recommended. In general, usage of exit should be done with care and only when running in a scripting context like a CLI script. Loading history... Bug Best Practice introduced 2018-09-14 11:44 UTC by Report Bug Copy Issue Report Show Similar Issues like this In this branch, the function will implicitly return `null` which is incompatible with the type-hinted return `boolean`. Consider adding a return statement or allowing `null` as return value. For hinted functions/methods where all return statements with the correct type are only reachable via conditions, ?null? gets implicitly returned which may be incompatible with the hinted type. Let?s take a look at an example: interface ReturnsInt { public function returnsIntHinted(): int; } class MyClass implements ReturnsInt { public function returnsIntHinted(): int { if (foo()) { return 123; } // here: null is implicitly returned } } Loading history...
31			}
32			}
33

gyselroth / mongodb-php-task-scheduler

Issues (14)

src/InjectTrait.php (2 issues)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like