Issues in Ldap.php (master) - Issues in master - gyselroth/micro - Measure and Improve Code Quality continuously with Scrutinizer

Issues (69)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Auth/Adapter/Basic/Ldap.php (1 issue)

Labels

Coding Style 1

Severity

Informational 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
declare(strict_types = 1);

/**
 * Micro
 *
 * @author      Raffael Sahli <[email protected]>
 * @copyright   Copryright (c) 2017 gyselroth GmbH (https://gyselroth.com)
 * @license     MIT https://opensource.org/licenses/MIT
 */

namespace Micro\Auth\Adapter\Basic;

use \Micro\Auth\Exception;
use \Psr\Log\LoggerInterface;
use \Micro\Ldap as LdapServer;
use \Micro\Auth\Adapter\AdapterInterface;
use \Micro\Auth\Adapter\AbstractAdapter;

class Ldap extends AbstractBasic
{
    /**
     * Ldap
     *
     * @var LdapServer
     */
    protected $ldap;


    /**
     * LDAP DN
     *
     * @var string
     */
    protected $ldap_dn;


    /**
     * my account filter
     *
     * @var string
     */
    protected $account_filter = '(uid=%s)';


    public function __construct(LdapServer $ldap, LoggerInterface $logger, ?Iterable $config=null)
    {
        $this->logger = $logger;
        $this->ldap = $ldap;
        $this->setOptions($config);
    }


    /**
     * Set options
     *
     * @param   Iterable $config
     * @return  AdapterInterface
     */
    public function setOptions(? Iterable $config = null) : AdapterInterface
    {
        if ($config === null) {
            return $this;
        }

        foreach ($config as $option => $value) {
            switch ($option) {
                case 'account_filter':
switch ($expr) {
    case "A": { //wrong
        doSomething();
        break;
    }
    case "B"; //wrong
        doSomething();
        break;
    case "C": //right
        doSomething();
        break;
}
                    $this->account_filter = $value;
                    unset($config[$option]);
                break;
            }
        }

        parent::setOptions($config);

        return $this;
    }


    /**
     * LDAP Auth
     *
     * @param   string $username
     * @param   string $password
     * @return  bool
     */
    protected function plainAuth(string $username, string $password): bool
    {
        $this->ldap->connect();
        $resource = $this->ldap->getResource();

        $esc_username = ldap_escape($username);
        $filter       = htmlspecialchars_decode(sprintf($this->account_filter, $esc_username));
        $result       = ldap_search($resource, $this->ldap->getBase(), $filter, ['dn']);
        $entries      = ldap_get_entries($resource, $result);

        if ($entries['count'] === 0) {
            $this->logger->warning("user not found with ldap filter [{$filter}]", [
                'category' => get_class($this)
            ]);

            return false;
        } elseif ($entries['count'] > 1) {
            $this->logger->warning("more than one user found with ldap filter [{$filter}]", [
                'category' => get_class($this)
            ]);

            return false;
        }

        $dn = $entries[0]['dn'];
        $this->logger->info("found ldap user [{$dn}] with filter [{$filter}]", [
            'category' => get_class($this)
        ]);

        $result = ldap_bind($resource, $dn, $password);
        $this->logger->info("bind ldap user [{$dn}]", [
            'category' => get_class($this),
            'result'   => $result
        ]);

        if ($result === false) {
            return false;
        }

        $this->identifier  = $username;
        $this->ldap_dn     = $dn;

        return true;
    }


    /**
     * Get attributes
     *
     * @return array
     */
    public function getAttributes(): array
    {
        $search = [];
        foreach ($this->map as $attr => $value) {
            $search[] = $value['attr'];
        }

        $result     = ldap_read($this->ldap->getResource(), $this->ldap_dn, '(objectClass=*)', $search);
        $entries    = ldap_get_entries($this->ldap->getResource(), $result);
        $attributes = $entries[0];

        $this->logger->info("get ldap user [{$this->ldap_dn}] attributes", [
            'category' => get_class($this),
            'params'   => $attributes,
        ]);

        return $attributes;
    }
}


1			<?php
2			declare(strict_types = 1);
3
4			/**
5			* Micro
6			*
7			* @author Raffael Sahli <[email protected]>
8			* @copyright Copryright (c) 2017 gyselroth GmbH (https://gyselroth.com)
9			* @license MIT https://opensource.org/licenses/MIT
10			*/
11
12			namespace Micro\Auth\Adapter\Basic;
13
14			use \Micro\Auth\Exception;
15			use \Psr\Log\LoggerInterface;
16			use \Micro\Ldap as LdapServer;
17			use \Micro\Auth\Adapter\AdapterInterface;
18			use \Micro\Auth\Adapter\AbstractAdapter;
19
20			class Ldap extends AbstractBasic
21			{
22			/**
23			* Ldap
24			*
25			* @var LdapServer
26			*/
27			protected $ldap;
28
29
30			/**
31			* LDAP DN
32			*
33			* @var string
34			*/
35			protected $ldap_dn;
36
37
38			/**
39			* my account filter
40			*
41			* @var string
42			*/
43			protected $account_filter = '(uid=%s)';
44
45
46			public function __construct(LdapServer $ldap, LoggerInterface $logger, ?Iterable $config=null)
47			{
48			$this->logger = $logger;
49			$this->ldap = $ldap;
50			$this->setOptions($config);
51			}
52
53
54			/**
55			* Set options
56			*
57			* @param Iterable $config
58			* @return AdapterInterface
59			*/
60			public function setOptions(? Iterable $config = null) : AdapterInterface
61			{
62			if ($config === null) {
63			return $this;
64			}
65
66			foreach ($config as $option => $value) {
67			switch ($option) {
68			case 'account_filter':
			0 ignored issues – show Coding Style introduced 2017-11-03 15:49 UTC by Report Bug Copy Issue Report Show Similar Issues like this `case` statements should be defined using a colon. As per the PSR-2 coding standard, case statements should not be wrapped in curly braces. There is no need for braces, since each case is terminated by the next `break`. There is also the option to use a semicolon instead of a colon, this is discouraged because many programmers do not even know it works and the colon is universal between programming languages. switch ($expr) { case "A": { //wrong doSomething(); break; } case "B"; //wrong doSomething(); break; case "C": //right doSomething(); break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
69			$this->account_filter = $value;
70			unset($config[$option]);
71			break;
72			}
73			}
74
75			parent::setOptions($config);
76
77			return $this;
78			}
79
80
81			/**
82			* LDAP Auth
83			*
84			* @param string $username
85			* @param string $password
86			* @return bool
87			*/
88			protected function plainAuth(string $username, string $password): bool
89			{
90			$this->ldap->connect();
91			$resource = $this->ldap->getResource();
92
93			$esc_username = ldap_escape($username);
94			$filter = htmlspecialchars_decode(sprintf($this->account_filter, $esc_username));
95			$result = ldap_search($resource, $this->ldap->getBase(), $filter, ['dn']);
96			$entries = ldap_get_entries($resource, $result);
97
98			if ($entries['count'] === 0) {
99			$this->logger->warning("user not found with ldap filter [{$filter}]", [
100			'category' => get_class($this)
101			]);
102
103			return false;
104			} elseif ($entries['count'] > 1) {
105			$this->logger->warning("more than one user found with ldap filter [{$filter}]", [
106			'category' => get_class($this)
107			]);
108
109			return false;
110			}
111
112			$dn = $entries[0]['dn'];
113			$this->logger->info("found ldap user [{$dn}] with filter [{$filter}]", [
114			'category' => get_class($this)
115			]);
116
117			$result = ldap_bind($resource, $dn, $password);
118			$this->logger->info("bind ldap user [{$dn}]", [
119			'category' => get_class($this),
120			'result' => $result
121			]);
122
123			if ($result === false) {
124			return false;
125			}
126
127			$this->identifier = $username;
128			$this->ldap_dn = $dn;
129
130			return true;
131			}
132
133
134			/**
135			* Get attributes
136			*
137			* @return array
138			*/
139			public function getAttributes(): array
140			{
141			$search = [];
142			foreach ($this->map as $attr => $value) {
143			$search[] = $value['attr'];
144			}
145
146			$result = ldap_read($this->ldap->getResource(), $this->ldap_dn, '(objectClass=*)', $search);
147			$entries = ldap_get_entries($this->ldap->getResource(), $result);
148			$attributes = $entries[0];
149
150			$this->logger->info("get ldap user [{$this->ldap_dn}] attributes", [
151			'category' => get_class($this),
152			'params' => $attributes,
153			]);
154
155			return $attributes;
156			}
157			}
158

gyselroth / micro

Issues (69)

Security Analysis not enabled

src/Auth/Adapter/Basic/Ldap.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like