gyselroth / balloon

src/app/Balloon.App.Office/Api/Latest/Document.php

Unused Use Statements -1 removed lines

@@ -20,7 +20,6 @@
 use Balloon\Filesystem\Node\Collection;
 use Balloon\Filesystem\Node\File;
 use Balloon\Server;
-use Balloon\Server\User;
 use Micro\Http\Response;
 
 class Document extends Controller

Spacing +4 added lines, -4 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare(strict_types=1);
+declare(strict_types = 1);
 
 /**
  * balloon
@@ -94,10 +94,10 @@ 
 
         foreach ($document->getSessions() as $session) {
             $sessions[] = [
-                'id' => (string) $session['_id'],
+                'id' => (string)$session['_id'],
                 'created' => $session['_id']->getTimestamp(),
                 'user' => [
-                    'id' => (string) $session['user'],
+                    'id' => (string)$session['user'],
                     'name' => $this->server->getUserById($session['user'])->getUsername(),
                 ],
             ];
@@ -165,6 +165,6 @@ 
         $tpl = new Template($type);
         $result = $parent->addFile($name, $tpl->get(), $attributes);
 
-        return (new Response())->setCode(201)->setBody((string) $result->getId());
+        return (new Response())->setCode(201)->setBody((string)$result->getId());
     }
 }

src/app/Balloon.App.Office/Api/Latest/Wopi/Document.php

Doc Comments -1 removed lines

@@ -151,7 +151,6 @@
      * Get by access token.
      *
      * @param string $id
-     * @param string $access_token
      *
      * @return Session
      */

Spacing +1 added lines, -1 removed lines

@@ -1,6 +1,6 @@
 <?php
 
-declare(strict_types=1);
+declare(strict_types = 1);
 
 /**
  * balloon

src/lib/Console.php

Doc Comments +1 added lines, -2 removed lines

@@ -173,7 +173,7 @@ 
     /**
      * Configure cli logger.
      *
-     * @return Cli
+     * @return Console
      */
     protected function configureLogger(?int $level = null): self
     {
@@ -264,7 +264,6 @@ 
     /**
      * Start.
      *
-     * @param array $options
      *
      * @return bool
      */

Spacing +1 added lines, -1 removed lines

@@ -1,6 +1,6 @@
 <?php
 
-declare(strict_types=1);
+declare(strict_types = 1);
 
 /**
  * balloon

src/lib/Console/Jobs.php

Doc Comments -1 removed lines

@@ -50,7 +50,6 @@
     /**
      * Constructor.
      *
-     * @param App             $app
      * @param Async           $async
      * @param LoggerInterface $logger
      * @param GetOpt          $getopt

Spacing +1 added lines, -1 removed lines

@@ -1,6 +1,6 @@
 <?php
 
-declare(strict_types=1);
+declare(strict_types = 1);
 
 /**
  * balloon

src/lib/Filesystem/Delta.php

Doc Comments -2 removed lines

@@ -80,9 +80,7 @@
     /**
      * Add delta event.
      *
-     * @param string        $name
      * @param NodeInterface $node
-     * @param array         $options
      *
      * @return ObjectId
      */

Spacing +9 added lines, -9 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare(strict_types=1);
+declare(strict_types = 1);
 
 /**
  * balloon
@@ -282,13 +282,13 @@ 
             }
 
             $result = $this->db->delta->find($filter, [
-                'skip' => (int) $cursor[1],
-                'limit' => (int) $limit,
+                'skip' => (int)$cursor[1],
+                'limit' => (int)$limit,
                 'sort' => ['timestamp' => 1],
             ]);
 
             $left = $this->db->delta->count($filter, [
-                'skip' => (int) $cursor[1],
+                'skip' => (int)$cursor[1],
                 'sort' => ['timestamp' => 1],
             ]);
 
@@ -309,8 +309,8 @@ 
 
         foreach ($result as $log) {
             if (false === $has_more) {
-                $last_id = (string) $log['_id'];
-                $last_ts = (string) $log['timestamp'];
+                $last_id = (string)$log['_id'];
+                $last_ts = (string)$log['timestamp'];
             }
 
             try {
@@ -357,7 +357,7 @@ 
                     }
 
                     $deleted_node = [
-                        'id' => (string) $log['node'],
+                        'id' => (string)$log['node'],
                         'deleted' => true,
                         'created' => null,
                         'changed' => Helper::DateTimeToUnix($log['timestamp']),
@@ -382,7 +382,7 @@ 
                     }
 
                     $entry = [
-                        'id' => (string) $log['node'],
+                        'id' => (string)$log['node'],
                         'deleted' => true,
                         'created' => null,
                         'changed' => Helper::DateTimeToUnix($log['timestamp']),
@@ -536,7 +536,7 @@ 
         if (5 !== count($cursor)) {
             return null;
         }
-        $cursor[1] = (int) $cursor[1];
+        $cursor[1] = (int)$cursor[1];
 
         return $cursor;
     }

src/lib/Filesystem/Node/AttributeDecorator.php

Doc Comments +1 added lines, -1 removed lines

@@ -60,7 +60,7 @@
      *
      * @param Server    $server
      * @param Acl       $acl
-     * @param Decorator $role_decorator
+     * @param RoleAttributeDecorator $role_decorator
      */
     public function __construct(Server $server, Acl $acl, RoleAttributeDecorator $role_decorator)
     {

Spacing +20 added lines, -20 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare(strict_types=1);
+declare(strict_types = 1);
 
 /**
  * balloon
@@ -125,25 +125,25 @@ 
         $decorator = $this->role_decorator;
 
         return [
-            'id' => (string) $attributes['id'],
-            'name' => (string) $attributes['name'],
-            'mime' => (string) $attributes['mime'],
-            'readonly' => (bool) $attributes['readonly'],
+            'id' => (string)$attributes['id'],
+            'name' => (string)$attributes['name'],
+            'mime' => (string)$attributes['mime'],
+            'readonly' => (bool)$attributes['readonly'],
             'directory' => $node instanceof Collection,
-            'meta' => function ($node) {
-                return (object) $node->getMetaAttributes();
+            'meta' => function($node) {
+                return (object)$node->getMetaAttributes();
             },
-            'size' => function ($node) {
+            'size' => function($node) {
                 return $node->getSize();
             },
-            'path' => function ($node) {
+            'path' => function($node) {
                 try {
                     return $node->getPath();
                 } catch (\Exception $e) {
                     return null;
                 }
             },
-            'parent' => function ($node) {
+            'parent' => function($node) {
                 $parent = $node->getParent();
 
                 if (null === $parent || $parent->isRoot()) {
@@ -152,10 +152,10 @@ 
 
                 return $this->decorate($node->getParent(), ['id', 'name', '_links']);
             },
-            'access' => function ($node) use ($acl) {
+            'access' => function($node) use ($acl) {
                 return $acl->getAclPrivilege($node);
             },
-            'share' => function ($node) {
+            'share' => function($node) {
                 if ($node->isShared() || !$node->isSpecial()) {
                     return null;
                 }
@@ -166,7 +166,7 @@ 
                     return null;
                 }
             },
-            'sharename' => function ($node) {
+            'sharename' => function($node) {
                 if (!$node->isShared()) {
                     return null;
                 }
@@ -177,7 +177,7 @@ 
                     return null;
                 }
             },
-            'shareowner' => function ($node) use ($server, $fs, $decorator) {
+            'shareowner' => function($node) use ($server, $fs, $decorator) {
                 if (!$node->isSpecial()) {
                     return null;
                 }
@@ -191,7 +191,7 @@ 
                     return null;
                 }
             },
-            'owner' => function ($node) use ($server, $decorator) {
+            'owner' => function($node) use ($server, $decorator) {
                 try {
                     return $decorator->decorate(
                         $server->getUserById($node->getOwner()),
@@ -215,20 +215,20 @@ 
     protected function getTimeAttributes(NodeInterface $node, array $attributes): array
     {
         return [
-            'created' => function ($node) use ($attributes) {
+            'created' => function($node) use ($attributes) {
                 return $attributes['created']->toDateTime()->format('c');
             },
-            'changed' => function ($node) use ($attributes) {
+            'changed' => function($node) use ($attributes) {
                 return $attributes['changed']->toDateTime()->format('c');
             },
-            'deleted' => function ($node) use ($attributes) {
+            'deleted' => function($node) use ($attributes) {
                 if (false === $attributes['deleted']) {
                     return null;
                 }
 
                 return $attributes['deleted']->toDateTime()->format('c');
             },
-            'destroy' => function ($node) use ($attributes) {
+            'destroy' => function($node) use ($attributes) {
                 if (null === $attributes['destroy']) {
                     return null;
                 }
@@ -261,7 +261,7 @@ 
         return [
             'shared' => $node->isShared(),
             'reference' => $node->isReference(),
-            'filter' => function ($node) use ($attributes) {
+            'filter' => function($node) use ($attributes) {
                 if (null === $attributes['filter']) {
                     return null;
                 }

src/lib/Filesystem/Node/NodeInterface.php

Doc Comments +2 added lines, -2 removed lines

@@ -106,14 +106,13 @@ 
      *
      * @param bool $reference
      *
-     * @return ObjectId
+     * @return ObjectId|null
      */
     public function getShareId(bool $reference = false): ?ObjectId;
 
     /**
      * Get share node.
      *
-     * @param bool $reference
      *
      * @return Collection
      */
@@ -236,6 +235,7 @@ 
 
     /**
      * Download.
+     * @return resource
      */
     public function get();
 }

Spacing +1 added lines, -1 removed lines

@@ -1,6 +1,6 @@
 <?php
 
-declare(strict_types=1);
+declare(strict_types = 1);
 
 /**
  * balloon

src/app/Balloon.App.Office/Session/Member.php

Spacing +3 added lines, -3 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare(strict_types=1);
+declare(strict_types = 1);
 
 /**
  * balloon
@@ -140,8 +140,8 @@ 
             'BaseFileName' => $attrs['name'],
             'Size' => $doc->getSize(),
             'Version' => $attrs['version'],
-            'OwnerId' => (string) $doc->getNode()->getOwner(),
-            'UserId' => (string) $this->user->getId(),
+            'OwnerId' => (string)$doc->getNode()->getOwner(),
+            'UserId' => (string)$this->user->getId(),
             'UserFriendlyName' => $this->user->getUsername(),
             'UserCanWrite' => true,
             'PostMessageOrigin' => null,

src/app/Balloon.App.Office/Api/Latest/Session.php

Spacing +2 added lines, -2 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare(strict_types=1);
+declare(strict_types = 1);
 
 /**
  * balloon
@@ -100,7 +100,7 @@ 
                 ->store();
 
         return (new Response())->setCode(201)->setBody([
-            'id' => (string) $session->getId(),
+            'id' => (string)$session->getId(),
             'wopi_url' => $this->app->getWopiUrl(),
             'access_token' => $member->getAccessToken(),
             'access_token_ttl' => ($member->getTTL()->toDateTime()->format('U') * 1000),