gyselroth / balloon

src/lib/Hook/AutoCreateUser.php

Indentation +1 added lines, -1 removed lines

@@ -91,7 +91,7 @@
         }
 
         $this->logger->info('found first time username ['.$identity->getIdentifier().'], auto-create user in mongodb user collection', [
-             'category' => get_class($this),
+                'category' => get_class($this),
         ]);
 
         $attributes = [

Spacing +4 added lines, -4 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare(strict_types=1);
+declare(strict_types = 1);
 
 /**
  * balloon
@@ -110,15 +110,15 @@ 
 
             switch ($value['type']) {
                 case 'string':
-                     $attributes[$attr] = (string) $value['value'];
+                     $attributes[$attr] = (string)$value['value'];
 
                 break;
                 case 'int':
-                     $attributes[$attr] = (int) $value['value'];
+                     $attributes[$attr] = (int)$value['value'];
 
                 break;
                 case 'bool':
-                     $attributes[$attr] = (bool) $value['value'];
+                     $attributes[$attr] = (bool)$value['value'];
 
                 break;
                 case 'binary':

src/lib/Hook/HookInterface.php

Indentation +2 added lines, -2 removed lines

@@ -206,7 +206,7 @@ 
     public function preCopyFile(
         File $node,
         Collection $parent,
-       int $conflict,
+        int $conflict,
         ?string $recursion,
         bool $recursion_first
     ): void;
@@ -227,7 +227,7 @@ 
         File $node,
         Collection $parent,
         File $new_node,
-       int $conflict,
+        int $conflict,
         ?string $recursion,
         bool $recursion_first
     ): void;

Spacing +1 added lines, -1 removed lines

@@ -1,6 +1,6 @@
 <?php
 
-declare(strict_types=1);
+declare(strict_types = 1);
 
 /**
  * balloon

src/app/Balloon.App.Office/Template.php

Indentation +1 added lines, -1 removed lines

@@ -85,6 +85,6 @@
     protected function getTemplate(): string
     {
         return __DIR__.DIRECTORY_SEPARATOR.'assets'
-          .DIRECTORY_SEPARATOR.'template.'.$this->type;
+            .DIRECTORY_SEPARATOR.'template.'.$this->type;
     }
 }

Spacing +1 added lines, -1 removed lines

@@ -1,6 +1,6 @@
 <?php
 
-declare(strict_types=1);
+declare(strict_types = 1);
 
 /**
  * balloon

src/app/Balloon.App.Preview/Hook.php

Unused Use Statements -1 removed lines

@@ -12,7 +12,6 @@
 
 namespace Balloon\App\Preview;
 
-use Balloon\Exception;
 use Balloon\Filesystem\Node\File;
 use Balloon\Hook\AbstractHook;
 use MongoDB\GridFS\Exception\FileNotFoundException;

Spacing +1 added lines, -1 removed lines

@@ -1,6 +1,6 @@
 <?php
 
-declare(strict_types=1);
+declare(strict_types = 1);
 
 /**
  * balloon

src/lib/Filesystem.php

Doc Comments +2 added lines, -2 removed lines

@@ -291,7 +291,7 @@ 
      *
      * @param array  $id
      * @param string $class   Force check node type
-     * @param bool   $deleted
+     * @param integer   $deleted
      *
      * @return Generator
      */
@@ -411,7 +411,7 @@ 
      * @param string $class      Force set node type
      * @param bool   $multiple   Allow $id to be an array
      * @param bool   $allow_root Allow instance of root collection
-     * @param bool   $deleted    How to handle deleted node
+     * @param integer   $deleted    How to handle deleted node
      *
      * @return NodeInterface
      */

Spacing +6 added lines, -6 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare(strict_types=1);
+declare(strict_types = 1);
 
 /**
  * balloon
@@ -192,8 +192,8 @@ 
      */
     public function findRawNode(ObjectId $id): array
     {
-        if (isset($this->cache[(string) $id])) {
-            return $this->cache[(string) $id]->getRawAttributes();
+        if (isset($this->cache[(string)$id])) {
+            return $this->cache[(string)$id]->getRawAttributes();
         }
 
         $node = $this->db->storage->findOne(['_id' => $id]);
@@ -218,8 +218,8 @@ 
      */
     public function findNodeById($id, ?string $class = null, int $deleted = NodeInterface::DELETED_INCLUDE): NodeInterface
     {
-        if (isset($this->cache[(string) $id])) {
-            return $this->cache[(string) $id];
+        if (isset($this->cache[(string)$id])) {
+            return $this->cache[(string)$id];
         }
 
         if (!is_string($id) && !($id instanceof ObjectId)) {
@@ -597,7 +597,7 @@ 
             throw new Exception\Conflict('node is not available anymore');
         }
 
-        $this->cache[(string) $node['_id']] = $instance;
+        $this->cache[(string)$node['_id']] = $instance;
 
         return $instance;
     }

src/lib/Filesystem/Node/File.php

Doc Comments +2 added lines, -2 removed lines

@@ -694,7 +694,7 @@ 
      * @param string $path
      * @param bool   $new
      *
-     * @return bool
+     * @return string
      */
     protected function verifyFile(?string $path, bool $new = false): string
     {
@@ -827,7 +827,7 @@ 
     /**
      * Finalize put request.
      *
-     * @param resource|string $file
+     * @param string|null $file
      * @param bool            $new
      * @param array           $attributes
      *

Indentation +1 added lines, -1 removed lines

@@ -589,7 +589,7 @@
         ]);
 
         $this->addVersion($attributes)
-             ->postPutFile($file, $new, $attributes);
+                ->postPutFile($file, $new, $attributes);
 
         return $this->version;
     }

Unused Use Statements -1 removed lines

@@ -18,7 +18,6 @@
 use Balloon\Filesystem\Storage;
 use Balloon\Hook;
 use Balloon\Mime;
-use Balloon\Server\User;
 use MongoDB\BSON\UTCDateTime;
 use Psr\Log\LoggerInterface;
 

Spacing +13 added lines, -13 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare(strict_types=1);
+declare(strict_types = 1);
 
 /**
  * balloon
@@ -44,14 +44,14 @@ 
      * @param array
      **/
     protected $temp_files = [
-        '/^\._(.*)$/',     // OS/X resource forks
-        '/^.DS_Store$/',   // OS/X custom folder settings
+        '/^\._(.*)$/', // OS/X resource forks
+        '/^.DS_Store$/', // OS/X custom folder settings
         '/^desktop.ini$/', // Windows custom folder settings
-        '/^Thumbs.db$/',   // Windows thumbnail cache
-        '/^.(.*).swpx$/',  // ViM temporary files
-        '/^.(.*).swx$/',   // ViM temporary files
-        '/^.(.*).swp$/',   // ViM temporary files
-        '/^\.dat(.*)$/',   // Smultron seems to create these
+        '/^Thumbs.db$/', // Windows thumbnail cache
+        '/^.(.*).swpx$/', // ViM temporary files
+        '/^.(.*).swx$/', // ViM temporary files
+        '/^.(.*).swp$/', // ViM temporary files
+        '/^\.dat(.*)$/', // Smultron seems to create these
         '/^~lock.(.*)#$/', // Windows 7 lockfiles
     ];
 
@@ -543,7 +543,7 @@ 
         }
 
         $this->hash = $new_hash;
-        $max = (int) (string) $this->_fs->getServer()->getMaxFileVersion();
+        $max = (int)(string)$this->_fs->getServer()->getMaxFileVersion();
         if (count($this->history) >= $max) {
             $del = key($this->history);
             $this->_logger->debug('history limit ['.$max.'] reached, remove oldest version ['.$del.'] from file ['.$this->_id.']', [
@@ -637,8 +637,8 @@ 
     {
         assert(16 === strlen($data));
 
-        $data[6] = chr(ord($data[6]) & 0x0f | 0x40); // set version to 0100
-        $data[8] = chr(ord($data[8]) & 0x3f | 0x80); // set bits 6-7 to 10
+        $data[6] = chr(ord($data[6])&0x0f|0x40); // set version to 0100
+        $data[8] = chr(ord($data[8])&0x3f|0x80); // set bits 6-7 to 10
 
         return vsprintf('%s%s-%s-%s-%s-%s%s%s', str_split(bin2hex($data), 4));
     }
@@ -741,11 +741,11 @@ 
 
             $tmp_file = $tmp.DIRECTORY_SEPARATOR.$this->guidv4(openssl_random_pseudo_bytes(16));
             $stream = fopen($tmp_file, 'w+');
-            $size = stream_copy_to_stream($file, $stream, ((int) $this->_fs->getServer()->getMaxFileSize() + 1));
+            $size = stream_copy_to_stream($file, $stream, ((int)$this->_fs->getServer()->getMaxFileSize() + 1));
             rewind($stream);
             fclose($file);
 
-            if ($size > (int) $this->_fs->getServer()->getMaxFileSize()) {
+            if ($size > (int)$this->_fs->getServer()->getMaxFileSize()) {
                 unlink($tmp_file);
 
                 throw new Exception\InsufficientStorage(

src/app/Balloon.App.Api/Latest/File.php

Doc Comments +1 added lines, -1 removed lines

@@ -107,7 +107,7 @@
      *
      * @param string $id
      * @param string $p
-     * @param string $version
+     * @param integer $version
      *
      * @return Response
      */

Spacing +4 added lines, -4 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare(strict_types=1);
+declare(strict_types = 1);
 
 /**
  * balloon
@@ -310,7 +310,7 @@ 
             $wrote = fwrite($chunkgroup_handler, $data);
             $tmp_size += $wrote;
 
-            if ($tmp_size > (int) $this->server->getMaxFileSize()) {
+            if ($tmp_size > (int)$this->server->getMaxFileSize()) {
                 fclose($input_handler);
                 fclose($chunkgroup_handler);
                 unlink($file);
@@ -513,7 +513,7 @@ 
 
                 $result = $collection->addFile($name, $content, $attributes)->getId();
 
-                return (new Response())->setCode(201)->setBody((string) $result);
+                return (new Response())->setCode(201)->setBody((string)$result);
             }
         } catch (ForbiddenException $e) {
             throw new Exception\Conflict(
@@ -538,7 +538,7 @@ 
 
                     $result = $parent->addFile($name, $content, $attributes)->getId();
 
-                    return (new Response())->setCode(201)->setBody((string) $result);
+                    return (new Response())->setCode(201)->setBody((string)$result);
                 } catch (Exception\NotFound $e) {
                     throw new Exception('parent collection '.$parent_path.' was not found');
                 }

src/app/Balloon.App.Api/Latest/Node.php

Doc Comments +3 added lines, -3 removed lines

@@ -282,7 +282,7 @@ 
      * @param array|string $id
      * @param array|string $p
      * @param int          $offset
-     * @param int          $legnth
+     * @param int          $length
      * @param string       $encode
      * @param bool         $download
      * @param string       $name
@@ -1420,7 +1420,7 @@ 
      * @param string $class      Force set node type
      * @param bool   $multiple   Allow $id to be an array
      * @param bool   $allow_root Allow instance of root collection
-     * @param bool   $deleted    How to handle deleted node
+     * @param integer   $deleted    How to handle deleted node
      *
      * @return NodeInterface
      */
@@ -1454,7 +1454,7 @@ 
      * @param string $id
      * @param string $path
      * @param string $class   Force set node type
-     * @param bool   $deleted How to handle deleted node
+     * @param integer   $deleted How to handle deleted node
      *
      * @return Generator
      */

Indentation +44 added lines, -44 removed lines

@@ -320,50 +320,50 @@ 
         }
 
         return (new Response())
-          ->setOutputFormat(null)
-          ->setBody(function () use ($node, $encode, $offset, $length) {
-              $mime = $node->getContentType();
-              $stream = $node->get();
-              $name = $node->getName();
-
-              if (null === $stream) {
-                  return;
-              }
-
-              if (0 !== $offset) {
-                  if (fseek($stream, $offset) === -1) {
-                      throw new Exception\Conflict(
+            ->setOutputFormat(null)
+            ->setBody(function () use ($node, $encode, $offset, $length) {
+                $mime = $node->getContentType();
+                $stream = $node->get();
+                $name = $node->getName();
+
+                if (null === $stream) {
+                    return;
+                }
+
+                if (0 !== $offset) {
+                    if (fseek($stream, $offset) === -1) {
+                        throw new Exception\Conflict(
                         'invalid offset requested',
                         Exception\Conflict::INVALID_OFFSET
                     );
-                  }
-              }
-
-              $read = 0;
-              header('Content-Type: '.$mime.'');
-              if ('base64' === $encode) {
-                  header('Content-Encoding: base64');
-                  while (!feof($stream)) {
-                      if (0 !== $length && $read + 8192 > $length) {
-                          echo base64_encode(fread($stream, $length - $read));
-                          exit();
-                      }
-
-                      echo base64_encode(fread($stream, 8192));
-                      $read += 8192;
-                  }
-              } else {
-                  while (!feof($stream)) {
-                      if (0 !== $length && $read + 8192 > $length) {
-                          echo fread($stream, $length - $read);
-                          exit();
-                      }
-
-                      echo fread($stream, 8192);
-                      $read += 8192;
-                  }
-              }
-          });
+                    }
+                }
+
+                $read = 0;
+                header('Content-Type: '.$mime.'');
+                if ('base64' === $encode) {
+                    header('Content-Encoding: base64');
+                    while (!feof($stream)) {
+                        if (0 !== $length && $read + 8192 > $length) {
+                            echo base64_encode(fread($stream, $length - $read));
+                            exit();
+                        }
+
+                        echo base64_encode(fread($stream, 8192));
+                        $read += 8192;
+                    }
+                } else {
+                    while (!feof($stream)) {
+                        if (0 !== $length && $read + 8192 > $length) {
+                            echo fread($stream, $length - $read);
+                            exit();
+                        }
+
+                        echo fread($stream, 8192);
+                        $read += 8192;
+                    }
+                }
+            });
     }
 
     /**
@@ -1502,9 +1502,9 @@ 
                 $node->zip($archive);
             } catch (\Exception $e) {
                 $this->logger->debug('failed zip node in multi node request ['.$node->getId().']', [
-                   'category' => get_class($this),
-                   'exception' => $e,
-               ]);
+                    'category' => get_class($this),
+                    'exception' => $e,
+                ]);
             }
         }
 

Spacing +16 added lines, -16 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare(strict_types=1);
+declare(strict_types = 1);
 
 /**
  * balloon
@@ -139,7 +139,7 @@ 
             $result = $this->_getNode($id, $p, null, false, false, $deleted);
 
             $response = (new Response())
-                ->setHeader('Content-Length', (string) $result->getSize())
+                ->setHeader('Content-Length', (string)$result->getSize())
                 ->setHeader('Content-Type', $result->getContentType())
                 ->setCode(200);
 
@@ -208,7 +208,7 @@ 
             }
         }
 
-        return $this->bulk($id, $p, function ($node) use ($parent, $conflict, $move) {
+        return $this->bulk($id, $p, function($node) use ($parent, $conflict, $move) {
             if (true === $move) {
                 $node = $node->setParent($parent, $conflict);
             }
@@ -289,7 +289,7 @@ 
 
         $node = $this->_getNode($id, $p);
         if ($node instanceof Collection) {
-            return (new Response())->setBody(function () use ($node) {
+            return (new Response())->setBody(function() use ($node) {
                 $node->getZip();
             });
         }
@@ -300,7 +300,7 @@ 
             $response->setHeader('Content-Disposition', 'attachment; filename*=UTF-8\'\''.rawurlencode($name));
             $response->setHeader('Cache-Control', 'no-store, no-cache, must-revalidate, post-check=0, pre-check=0');
             $response->setHeader('Content-Type', 'application/octet-stream');
-            $response->setHeader('Content-Length', (string) $node->getSize());
+            $response->setHeader('Content-Length', (string)$node->getSize());
             $response->setHeader('Content-Transfer-Encoding', 'binary');
         } else {
             $response->setHeader('Content-Disposition', 'inline; filename*=UTF-8\'\''.rawurlencode($name));
@@ -308,7 +308,7 @@ 
 
         return (new Response())
           ->setOutputFormat(null)
-          ->setBody(function () use ($node, $encode, $offset, $length) {
+          ->setBody(function() use ($node, $encode, $offset, $length) {
               $mime = $node->getContentType();
               $stream = $node->get();
               $name = $node->getName();
@@ -381,7 +381,7 @@ 
      */
     public function postReadonly($id = null, $p = null, bool $readonly = true): Response
     {
-        return $this->bulk($id, $p, function ($node) use ($readonly) {
+        return $this->bulk($id, $p, function($node) use ($readonly) {
             $node->setReadonly($readonly);
 
             return ['code' => 204];
@@ -625,7 +625,7 @@ 
      */
     public function postMetaAttributes(array $attributes, ?string $id = null, ?string $p = null): Response
     {
-        return $this->bulk($id, $p, function ($node) use ($attributes) {
+        return $this->bulk($id, $p, function($node) use ($attributes) {
             $node->setMetaAttributes($attributes);
 
             return ['code' => 204];
@@ -713,7 +713,7 @@ 
             );
         }
 
-        return $this->bulk($id, $p, function ($node) use ($parent, $conflict) {
+        return $this->bulk($id, $p, function($node) use ($parent, $conflict) {
             $result = $node->copyTo($parent, $conflict);
 
             return [
@@ -777,7 +777,7 @@ 
             );
         }
 
-        return $this->bulk($id, $p, function ($node) use ($parent, $conflict) {
+        return $this->bulk($id, $p, function($node) use ($parent, $conflict) {
             $result = $node->setParent($parent, $conflict);
             if (NodeInterface::CONFLICT_RENAME === $conflict) {
                 return [
@@ -836,7 +836,7 @@ 
             $at = $this->_verifyAttributes(['destroy' => $at])['destroy'];
         }
 
-        return $this->bulk($id, $p, function ($node) use ($force, $ignore_flag, $at) {
+        return $this->bulk($id, $p, function($node) use ($force, $ignore_flag, $at) {
             if (null === $at) {
                 $node->delete($force && $node->isDeleted() || $force && $ignore_flag);
             } else {
@@ -1233,9 +1233,9 @@ 
             $body = [];
             foreach ($this->_getNodes($id, $p) as $node) {
                 try {
-                    $body[(string) $node->getId()] = $action->call($this, $node);
+                    $body[(string)$node->getId()] = $action->call($this, $node);
                 } catch (\Exception $e) {
-                    $body[(string) $node->getId()] = [
+                    $body[(string)$node->getId()] = [
                         'code' => 400,
                         'data' => [
                             'error' => get_class($e),
@@ -1391,7 +1391,7 @@ 
         foreach ($attributes as $attribute => $value) {
             switch ($attribute) {
                 case 'filter':
-                    $attributes['filter'] = json_encode((array) $attributes['filter']);
+                    $attributes['filter'] = json_encode((array)$attributes['filter']);
 
                 break;
                 case 'destroy':
@@ -1406,14 +1406,14 @@ 
                     if (!Helper::isValidTimestamp($value)) {
                         throw new Exception\InvalidArgument($attribute.' Changed timestamp must be valid unix timestamp');
                     }
-                    if ((int) $value > time()) {
+                    if ((int)$value > time()) {
                         throw new Exception\InvalidArgument($attribute.' timestamp can not be set greater than the server time');
                     }
                     $attributes[$attribute] = new UTCDateTime($value.'000');
 
                 break;
                 case 'readonly':
-                    $attributes['readonly'] = (bool) $attributes['readonly'];
+                    $attributes['readonly'] = (bool)$attributes['readonly'];
 
                 break;
             }

src/app/Balloon.App.Elasticsearch/Elasticsearch.php

Doc Comments +2 added lines, -2 removed lines

@@ -213,7 +213,7 @@ 
     /**
      * Get es client.
      *
-     * @return Elasticsearch
+     * @return Client
      */
     public function getEsClient(): Client
     {
@@ -230,7 +230,7 @@ 
      * Search.
      *
      * @param array $query
-     * @param array $share
+     * @param array $shares
      *
      * @return array
      */

Spacing +8 added lines, -8 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare(strict_types=1);
+declare(strict_types = 1);
 
 /**
  * balloon
@@ -93,11 +93,11 @@ 
         foreach ($config as $option => $value) {
             switch ($option) {
                 case 'server':
-                    $this->es_server = (array) $value;
+                    $this->es_server = (array)$value;
 
                 break;
                 case 'index':
-                    $this->es_index = (string) $value;
+                    $this->es_index = (string)$value;
 
                 break;
                 default:
@@ -147,7 +147,7 @@ 
             ],
         ]);
 
-        $user = (string) $this->user->getId();
+        $user = (string)$this->user->getId();
         foreach ($result['hits']['hits'] as $node) {
             $id = false;
 
@@ -158,8 +158,8 @@ 
                     $_node = $this->fs->findNodeById($id);
                     if ($_node->isDeleted() && (1 === $deleted || 2 === $deleted)
                      || !$_node->isDeleted() && (0 === $deleted || 2 === $deleted)) {
-                        if (!($_node->isShared() && !$_node->isOwnerRequest()) && !isset($list[(string) $_node->getId()])) {
-                            $list[(string) $_node->getId()] = $_node;
+                        if (!($_node->isShared() && !$_node->isOwnerRequest()) && !isset($list[(string)$_node->getId()])) {
+                            $list[(string)$_node->getId()] = $_node;
                         }
                     }
                 } catch (\Exception $e) {
@@ -239,8 +239,8 @@ 
         $bool = $query['body']['query'];
 
         $filter1 = [];
-        $filter1['bool']['should'][]['term']['owner'] = (string) $this->user->getId();
-        $filter1['bool']['should'][]['term']['metadata.ref.owner'] = (string) $this->user->getId();
+        $filter1['bool']['should'][]['term']['owner'] = (string)$this->user->getId();
+        $filter1['bool']['should'][]['term']['metadata.ref.owner'] = (string)$this->user->getId();
 
         $share_filter = [
             'bool' => [