gyselroth / balloon

src/lib/Balloon/Rest/v1/Collection.php

Spacing +15 added lines, -15 removed lines

@@ -1,5 +1,5 @@ 
 <?php
-declare(strict_types=1);
+declare(strict_types = 1);
 
 /**
  * Balloon
@@ -41,7 +41,7 @@ 
      * @param   string $p
      * @return  Response
      */
-    public function headChildren(?string $id=null, ?string $p=null): Response
+    public function headChildren(?string $id = null, ?string $p = null) : Response
     {
         $result   = $this->fs->getNode($id, $p, null, false, true);
         $children = $result->getSize();
@@ -97,11 +97,11 @@ 
      * @return Response
      */
     public function getChildren(
-        ?string $id=null,
-        ?string $p=null,
-        int $deleted=0,
-        array $filter=[],
-        array $attributes=[]): Response
+        ?string $id = null,
+        ?string $p = null,
+        int $deleted = 0,
+        array $filter = [],
+        array $attributes = []) : Response
     {
         $children = [];
         $nodes = $this->fs->getNode($id, $p, null, false, true)->getChildNodes($deleted, $filter);
@@ -152,7 +152,7 @@ 
      * @param  string $p
      * @return Response
      */
-    public function getShare(?string $id=null, ?string $p=null): Response
+    public function getShare(?string $id = null, ?string $p = null) : Response
     {
         $result = $this->fs->getNode($id, $p)->getShare();
         return (new Response())->setCode(200)->setBody($result);
@@ -200,7 +200,7 @@ 
      * @param  array $acl
      * @return Response
      */
-    public function postShare(array $acl, ?string $id=null, ?string $p=null): Response
+    public function postShare(array $acl, ?string $id = null, ?string $p = null) : Response
     {
         $node    = $this->fs->getNode($id, $p);
         $result  = $node->share($acl);
@@ -236,7 +236,7 @@ 
      * @param  string $p
      * @return Response
      */
-    public function deleteShare(?string $id=null, ?string $p=null): Response
+    public function deleteShare(?string $id = null, ?string $p = null) : Response
     {
         $node = $this->fs->getNode($id, $p);
         $result = $node->unshare();
@@ -291,11 +291,11 @@ 
      * @return Response
      */
     public function post(
-        ?string $id=null,
-        ?string $p=null,
-        ?string $name=null,
-        array $attributes=[],
-        int $conflict=0): Response
+        ?string $id = null,
+        ?string $p = null,
+        ?string $name = null,
+        array $attributes = [],
+        int $conflict = 0) : Response
     {
         if ($p !== null && $name !== null) {
             throw new Exception\InvalidArgument('p and name can not be used at the same time');

src/lib/Balloon/Rest/v1/Node.php

Spacing +61 added lines, -61 removed lines

@@ -1,5 +1,5 @@ 
 <?php
-declare(strict_types=1);
+declare(strict_types = 1);
 
 /**
  * Balloon
@@ -176,12 +176,12 @@ 
      * @return  INode
      */
     protected function _getNode(
-        ?string $id=null,
-        ?string $path=null,
-        ?string $class=null,
-        bool $multiple=false,
-        bool $allow_root=false,
-        int $deleted=2): INode
+        ?string $id = null,
+        ?string $path = null,
+        ?string $class = null,
+        bool $multiple = false,
+        bool $allow_root = false,
+        int $deleted = 2) : INode
     {
         if ($class === null) {
             $class = join('', array_slice(explode('\\', get_class($this)), -1));
@@ -226,7 +226,7 @@ 
      * @param   int $deleted
      * @return  Response
      */
-    public function head(?string $id=null, ?string $p=null, int $deleted=0): Response
+    public function head(?string $id = null, ?string $p = null, int $deleted = 0) : Response
     {
         try {
             $result = $this->_getNode($id, $p, null, false, false, $deleted);
@@ -283,12 +283,12 @@ 
      * @return  void
      */
     public function postUndelete(
-        $id=null,
-        ?string $p=null,
-        bool $move=false,
-        ?string $destid=null,
-        ?string $destp=null,
-        int $conflict=0): Response
+        $id = null,
+        ?string $p = null,
+        bool $move = false,
+        ?string $destid = null,
+        ?string $destp = null,
+        int $conflict = 0) : Response
     {
         if ($move == true) {
             try {
@@ -380,7 +380,7 @@ 
      * @param   array $options
      * @return  Response
      */
-    public function postShareLink(?string $id=null, ?string $p=null, array $options=[]): Response
+    public function postShareLink(?string $id = null, ?string $p = null, array $options = []) : Response
     {
         $node = $this->_getNode($id, $p);
         $options = Helper::filter($options);
@@ -411,7 +411,7 @@ 
      * @param   string $p
      * @return  Response
      */
-    public function deleteShareLink(?string $id=null, ?string $p=null): Response
+    public function deleteShareLink(?string $id = null, ?string $p = null) : Response
     {
         $node = $this->_getNode($id, $p);
         
@@ -454,7 +454,7 @@ 
      * @param   string $p
      * @return  Response
      */
-    public function getShareLink(?string $id=null, ?string $p=null): Response
+    public function getShareLink(?string $id = null, ?string $p = null) : Response
     {
         $result = Helper::escape(
             $this->_getNode($id, $p)->getShareLink()
@@ -510,13 +510,13 @@ 
      * @return  void
      */
     public function get(
-        $id=null,
-        ?string $p=null,
-        int $offset=0,
-        int $length=0,
-        ?string $encode=null,
-        bool $download=false,
-        string $name='selected'): void
+        $id = null,
+        ?string $p = null,
+        int $offset = 0,
+        int $length = 0,
+        ?string $encode = null,
+        bool $download = false,
+        string $name = 'selected') : void
     {
         if (is_array($id)) {
             $this->_combine($id, $p, $name);
@@ -533,13 +533,13 @@ 
         }
 
         if ($download == true) {
-            header('Content-Disposition: attachment; filename*=UTF-8\'\'' .rawurlencode($name));
+            header('Content-Disposition: attachment; filename*=UTF-8\'\''.rawurlencode($name));
             header('Cache-Control: no-store, no-cache, must-revalidate, post-check=0, pre-check=0');
             header('Content-Type: application/octet-stream');
             header('Content-Length: '.$node->getSize());
             header('Content-Transfer-Encoding: binary');
         } else {
-            header('Content-Disposition: inline; filename*=UTF-8\'\'' .rawurlencode($name));
+            header('Content-Disposition: inline; filename*=UTF-8\'\''.rawurlencode($name));
         }
 
         if ($stream === null) {
@@ -608,7 +608,7 @@ 
      * @param   string $p
      * @return  Response
      */
-    public function postReadonly($id=null, ?string $p=null, bool $readonly=true): Response
+    public function postReadonly($id = null, ?string $p = null, bool $readonly = true) : Response
     {
         if (is_array($id)) {
             $failures = [];
@@ -651,7 +651,7 @@ 
      * @param   string $name
      * @return  void
      */
-    protected function _combine($id=null, ?string $path=null, string $name='selected'): void
+    protected function _combine($id = null, ?string $path = null, string $name = 'selected') : void
     {
         $temp = $this->config->dir->temp.DIRECTORY_SEPARATOR.'zip';
         if (!file_exists($temp)) {
@@ -776,10 +776,10 @@ 
      * @param  array $attributes
      * @return Response
      */
-    public function getAttributes($id=null, ?string $p=null, array $attributes=[]): Response
+    public function getAttributes($id = null, ?string $p = null, array $attributes = []) : Response
     {
         if (is_array($id)) {
-            $nodes    = [];
+            $nodes = [];
             foreach ($this->fs->findNodes($id) as $node) {
                 $nodes[] = Helper::escape($node->getAttribute($attributes));
             }
@@ -905,7 +905,7 @@ 
      * @param  array $attributes
      * @return Response
      */
-    public function getParent(?string $id=null, ?string $p=null, array $attributes=[]): Response
+    public function getParent(?string $id = null, ?string $p = null, array $attributes = []) : Response
     {
         $result = Helper::escape(
             $this->_getNode($id, $p)
@@ -987,7 +987,7 @@ 
      * @param  array $attributes
      * @return Response
      */
-    public function getParents(?string $id=null, ?string $p=null, array $attributes=[], bool $self=false): Response
+    public function getParents(?string $id = null, ?string $p = null, array $attributes = [], bool $self = false) : Response
     {
         $request = $this->_getNode($id, $p);
         $parents = $request->getParents();
@@ -1035,7 +1035,7 @@ 
      * @param   string $p
      * @return  Response
      */
-    public function postMetaAttributes(?string $id=null, ?string $p=null): Response
+    public function postMetaAttributes(?string $id = null, ?string $p = null) : Response
     {
         $this->_getNode($id, $p)->setMetaAttribute(Helper::filter($_POST));
         return (new Response())->setCode(204);
@@ -1068,7 +1068,7 @@ 
      * @param   string $name
      * @return  Response
      */
-    public function postName(string $name, ?string $id=null, ?string $p=null): Response
+    public function postName(string $name, ?string $id = null, ?string $p = null) : Response
     {
         $this->_getNode($id, $p)->setName($name);
         return (new Response())->setCode(204);
@@ -1106,11 +1106,11 @@ 
      * @return  Response
      */
     public function postClone(
-        $id=null,
-        ?string $p=null,
-        ?string $destid=null,
-        ?string $destp=null,
-        int $conflict=0): Response
+        $id = null,
+        ?string $p = null,
+        ?string $destid = null,
+        ?string $destp = null,
+        int $conflict = 0) : Response
     {
         try {
             $parent = $this->_getNode($destid, $destp, 'Collection', false, true);
@@ -1192,11 +1192,11 @@ 
      * @return  Response
      */
     public function postMove(
-        $id=null,
-        ?string $p=null,
-        ?string $destid=null,
-        ?string $destp=null,
-        int $conflict=0): Response
+        $id = null,
+        ?string $p = null,
+        ?string $destid = null,
+        ?string $destp = null,
+        int $conflict = 0) : Response
     {
         try {
             $parent = $this->_getNode($destid, $destp, 'Collection', false, true);
@@ -1276,11 +1276,11 @@ 
      * @return  Response
      */
     public function delete(
-        $id=null,
-        ?string $p=null,
-        bool $force=false,
-        bool $ignore_flag=false,
-        ?string $at=null): Response
+        $id = null,
+        ?string $p = null,
+        bool $force = false,
+        bool $ignore_flag = false,
+        ?string $at = null) : Response
     {
         $failures = [];
             
@@ -1373,7 +1373,7 @@ 
      * @param  array $attributes
      * @return Response
      */
-    public function getQuery(int $deleted=0, array $filter=[], array $attributes=[]): Response
+    public function getQuery(int $deleted = 0, array $filter = [], array $attributes = []): Response
     {
         $children = [];
         $nodes = $this->fs->findNodesWithCustomFilterUser($deleted, $filter);
@@ -1414,7 +1414,7 @@ 
      * @param  array $attributes
      * @return Response
      */
-    public function getTrash(array $attributes=[]): Response
+    public function getTrash(array $attributes = []): Response
     {
         $children = [];
         $nodes = $this->fs->findNodesWithCustomFilterUser(INode::DELETED_ONLY, ['deleted' => ['$type' => 9]]);
@@ -1489,7 +1489,7 @@ 
      * @param  int $deleted
      * @return Response
      */
-    public function getSearch(array $query, array $attributes=[], int $deleted=0): Response
+    public function getSearch(array $query, array $attributes = [], int $deleted = 0): Response
     {
         $children = [];
         $nodes = $this->fs->search($query, $deleted);
@@ -1599,11 +1599,11 @@ 
      * @return  Response
      */
     public function getDelta(
-        ?string $id=null,
-        ?string $p=null,
-        ?string $cursor=null,
-        int $limit=250,
-        array $attributes=[]): Response
+        ?string $id = null,
+        ?string $p = null,
+        ?string $cursor = null,
+        int $limit = 250,
+        array $attributes = []) : Response
     {
         if ($id !== null || $p !== null) {
             $node = $this->_getNode($id, $p);
@@ -1611,7 +1611,7 @@ 
             $node = null;
         }
         
-        $result= $this->fs->getDelta()->getDeltaFeed($cursor, $limit, $attributes, $node);
+        $result = $this->fs->getDelta()->getDeltaFeed($cursor, $limit, $attributes, $node);
 
         return (new Response())->setCode(200)->setBody($result);
     }
@@ -1719,7 +1719,7 @@ 
      * @param  int $limit
      * @return Response
      */
-    public function getEventLog(?string $id=null, ?string $p=null, int $skip=0, int $limit=100): Response
+    public function getEventLog(?string $id = null, ?string $p = null, int $skip = 0, int $limit = 100) : Response
     {
         if ($id !== null || $p !== null) {
             $node = $this->_getNode($id, $p);
@@ -1759,7 +1759,7 @@ 
      * @param   string $p
      * @return  Response
      */
-    public function getLastCursor(?string $id=null, ?string $p=null): Response
+    public function getLastCursor(?string $id = null, ?string $p = null) : Response
     {
         if ($id !== null || $p !== null) {
             $node = $this->_getNode($id, $p);
@@ -1767,7 +1767,7 @@ 
             $node = null;
         }
 
-        $result= $this->fs->getDelta()->getLastCursor();
+        $result = $this->fs->getDelta()->getLastCursor();
         return (new Response())->setCode(200)->setBody($result);
     }
 }

src/lib/Balloon/Filesystem/Node/File.php

Spacing +23 added lines, -23 removed lines

@@ -1,5 +1,5 @@ 
 <?php
-declare(strict_types=1);
+declare(strict_types = 1);
 
 /**
  * Balloon
@@ -47,14 +47,14 @@ 
      * @param array
      **/
     protected $temp_files = [
-        '/^\._(.*)$/',     // OS/X resource forks
-        '/^.DS_Store$/',   // OS/X custom folder settings
+        '/^\._(.*)$/', // OS/X resource forks
+        '/^.DS_Store$/', // OS/X custom folder settings
         '/^desktop.ini$/', // Windows custom folder settings
-        '/^Thumbs.db$/',   // Windows thumbnail cache
-        '/^.(.*).swpx$/',  // ViM temporary files
-        '/^.(.*).swx$/',   // ViM temporary files
-        '/^.(.*).swp$/',   // ViM temporary files
-        '/^\.dat(.*)$/',   // Smultron seems to create these
+        '/^Thumbs.db$/', // Windows thumbnail cache
+        '/^.(.*).swpx$/', // ViM temporary files
+        '/^.(.*).swx$/', // ViM temporary files
+        '/^.(.*).swp$/', // ViM temporary files
+        '/^\.dat(.*)$/', // Smultron seems to create these
         '/^~lock.(.*)#$/', // Windows 7 lockfiles
     ];
 
@@ -123,11 +123,11 @@ 
      * @param   bool $force
      * @return  void
      */
-    public function __construct(BSONDocument $node, Filesystem $fs, bool $force=false)
+    public function __construct(BSONDocument $node, Filesystem $fs, bool $force = false)
     {
         parent::__construct($node, $fs);
 
-        if($force === false) {
+        if ($force === false) {
             $this->_verifyAccess();
         }
     }
@@ -163,7 +163,7 @@ 
      * @param  bool $recursion_first
      * @return INode
      */
-    public function copyTo(Collection $parent, int $conflict=INode::CONFLICT_NOACTION, ?string $recursion=null, bool $recursion_first=true): INode
+    public function copyTo(Collection $parent, int $conflict = INode::CONFLICT_NOACTION, ?string $recursion = null, bool $recursion_first = true) : INode
     {
         $this->_pluginmgr->run('preCopyFile',
             [$this, $parent, &$conflict, &$recursion, &$recursion_first]
@@ -320,7 +320,7 @@ 
      * @param   bool $recursion_first
      * @return  bool
      */
-    public function delete(bool $force=false, ?string $recursion=null, bool $recursion_first=true): bool
+    public function delete(bool $force = false, ?string $recursion = null, bool $recursion_first = true) : bool
     {
         if (!$this->isAllowed('w')) {
             throw new Exception\Forbidden('not allowed to delete node '.$this->name,
@@ -343,7 +343,7 @@ 
         }
 
         $ts = new UTCDateTime();
-        $this->deleted  = $ts;
+        $this->deleted = $ts;
         $this->increaseVersion();
         
         $this->history[] = [
@@ -438,7 +438,7 @@ 
                     return true;
                 }
 
-                $ref  = $file['metadata']['ref'];
+                $ref = $file['metadata']['ref'];
                 
                 $found = false;
                 foreach ($ref as $key => $node) {
@@ -577,7 +577,7 @@ 
      * @param  string|array $attribute
      * @return array|string
      */
-    public function getAttribute($attribute=[])
+    public function getAttribute($attribute = [])
     {
         if (empty($attribute)) {
             $attribute = [
@@ -896,8 +896,8 @@ 
     {
         assert(strlen($data) == 16);
 
-        $data[6] = chr(ord($data[6]) & 0x0f | 0x40); // set version to 0100
-        $data[8] = chr(ord($data[8]) & 0x3f | 0x80); // set bits 6-7 to 10
+        $data[6] = chr(ord($data[6])&0x0f|0x40); // set version to 0100
+        $data[8] = chr(ord($data[8])&0x3f|0x80); // set bits 6-7 to 10
 
         return vsprintf('%s%s-%s-%s-%s-%s%s%s', str_split(bin2hex($data), 4));
     }
@@ -921,7 +921,7 @@ 
      * @param   array $attributes
      * @return  int
      */
-    public function put($file, bool $new=false, array $attributes=[]): int
+    public function put($file, bool $new = false, array $attributes = []): int
     {
         $this->_logger->debug('PUT new content data for ['.$this->_id.']', [
             'category' => get_class($this),
@@ -972,7 +972,7 @@ 
                 );
             }
 
-            $file  = $tmp_file;
+            $file = $tmp_file;
         }
         
        
@@ -1040,10 +1040,10 @@ 
             $this->mime = $attributes['mime'];
         } elseif ($file !== null) {
             $finfo = finfo_open(FILEINFO_MIME_TYPE);
-            $this->mime  = finfo_file($finfo, $file);
+            $this->mime = finfo_file($finfo, $file);
             if ($this->mime == 'application/zip' || $this->mime == 'application/vnd.ms-office') {
                 $mime = $this->getMimeTypeFromExtension($this->name);
-                if($mime !== null) {
+                if ($mime !== null) {
                     $this->mime = $mime;
                 }
             }
@@ -1136,7 +1136,7 @@ 
      * @param  string $db mimetypes
      * @return string
      */
-    public function getMimeTypeFromExtension(string $filename, string $db='/etc/mime.types'): ?string
+    public function getMimeTypeFromExtension(string $filename, string $db = '/etc/mime.types'): ?string
     {
         if (!is_readable($db)) {
             throw new Exception('mime database '.$db.' was not found or is not readable');
@@ -1153,7 +1153,7 @@ 
             if (substr($line, 0, 1) == '#') {
                 continue;
             } // skip comments
-            $line = rtrim($line) . " ";
+            $line = rtrim($line)." ";
             if (!preg_match($regex, $line, $matches)) {
                 continue;
             } // no match to the extension

src/lib/Balloon/Rest/v1/File.php

Spacing +27 added lines, -27 removed lines

@@ -1,5 +1,5 @@ 
 <?php
-declare(strict_types=1);
+declare(strict_types = 1);
 
 /**
  * Balloon
@@ -55,7 +55,7 @@ 
      * @param  string $encode
      * @return void
      */
-    public function getPreview(?string $id=null, ?string $p=null, ?string $encode=null): void
+    public function getPreview(?string $id = null, ?string $p = null, ?string $encode = null) : void
     {
         $node = $this->_getNode($id, $p);
         $data = $node->getPreview();
@@ -128,7 +128,7 @@ 
      * @param  string $p
      * @return Response
      */
-    public function getHistory(?string $id=null, ?string $p=null): Response
+    public function getHistory(?string $id = null, ?string $p = null) : Response
     {
         $result = Helper::escape(
             $this->_getNode($id, $p)->getHistory()
@@ -161,7 +161,7 @@ 
      * @param   string $version
      * @return  Response
      */
-    public function postRestore(int $version, ?string $id=null, ?string $p=null): Response
+    public function postRestore(int $version, ?string $id = null, ?string $p = null) : Response
     {
         $result = $this->_getNode($id, $p)->restore($version);
         return (new Response())->setCode(204);
@@ -297,15 +297,15 @@ 
      */
     public function putChunk(
         string $chunkgroup,
-        ?string $id=null,
-        ?string $p=null,
-        ?string $collection=null,
-        ?string $name=null,
-        int $index=1,
-        int $chunks=0,
-        int $size=0,
-        array $attributes=[],
-        int $conflict=0)
+        ?string $id = null,
+        ?string $p = null,
+        ?string $collection = null,
+        ?string $name = null,
+        int $index = 1,
+        int $chunks = 0,
+        int $size = 0,
+        array $attributes = [],
+        int $conflict = 0)
     {
         ini_set('auto_detect_line_endings', '1');
         $input_handler = fopen('php://input', 'rb');
@@ -464,12 +464,12 @@ 
      * @return Response
      */
     public function put(
-        ?string $id=null,
-        ?string $p=null,
-        ?string $collection=null,
-        ?string $name=null,
-        array $attributes=[],
-        int $conflict=0): Response
+        ?string $id = null,
+        ?string $p = null,
+        ?string $collection = null,
+        ?string $name = null,
+        array $attributes = [],
+        int $conflict = 0) : Response
     {
         $attributes = $this->_verifyAttributes($attributes);
 
@@ -493,12 +493,12 @@ 
      */
     protected function _put(
         $content,
-        ?string $id=null,
-        ?string $p=null,
-        ?string $collection=null,
-        ?string $name=null,
-        array $attributes=[],
-        int $conflict=0): Response
+        ?string $id = null,
+        ?string $p = null,
+        ?string $collection = null,
+        ?string $name = null,
+        array $attributes = [],
+        int $conflict = 0) : Response
     {
         if ($id === null && $p === null && $name === null) {
             throw new Exception\InvalidArgument('neither id, p nor name was set');
@@ -518,7 +518,7 @@ 
                 $result = $node->put($content, false, $attributes);
                 return (new Response())->setCode(200)->setBody($result);
             } elseif ($p === null && $id === null && $name !== null) {
-                $collection =  $this->_getNode($collection, null, 'Collection', false, true);
+                $collection = $this->_getNode($collection, null, 'Collection', false, true);
 
                 if ($collection->childExists($name)) {
                     $child = $collection->getChild($name);
@@ -534,7 +534,7 @@ 
                     return (new Response())->setCode(201)->setBody($result);
                 }
             }
-        } catch(Exception\Forbidden $e) {
+        } catch (Exception\Forbidden $e) {
             throw new Exception\Conflict('a node called '.$name.' does already exists in this collection',
                 Exception\Conflict::NODE_WITH_SAME_NAME_ALREADY_EXISTS
             );

src/lib/Balloon/Filesystem/Node/Node.php

Spacing +28 added lines, -28 removed lines

@@ -1,5 +1,5 @@ 
 <?php
-declare(strict_types=1);
+declare(strict_types = 1);
 
 /**
  * Balloon
@@ -222,7 +222,7 @@ 
      * @param  bool $force
      * @return void
      */
-    public function __construct(?BSONDocument $node, Filesystem $fs, bool $force=false)
+    public function __construct(?BSONDocument $node, Filesystem $fs, bool $force = false)
     {
         $this->_fs         = $fs;
         $this->_db         = $fs->getDatabase();
@@ -270,7 +270,7 @@ 
      *
      * @return mixed
      */
-    public function __call(string $attribute, array $params=[])
+    public function __call(string $attribute, array $params = [])
     {
         $prefix = 'get';
         $attr = strtolower(substr($attribute, 3));
@@ -315,7 +315,7 @@ 
      * @param  int $conflict
      * @return INode
      */
-    public function setParent(Collection $parent, int $conflict=INode::CONFLICT_NOACTION): INode
+    public function setParent(Collection $parent, int $conflict = INode::CONFLICT_NOACTION): INode
     {
         if ($this->parent === $parent->getId()) {
             throw new Exception\Conflict('source node '.$this->name.' is already in the requested parent folder',
@@ -390,7 +390,7 @@ 
      * @param   bool $recursion_first
      * @return  INode
      */
-    abstract public function copyTo(Collection $parent, int $conflict=INode::CONFLICT_NOACTION, ?string $recursion=null, bool $recursion_first=true): INode;
+    abstract public function copyTo(Collection $parent, int $conflict = INode::CONFLICT_NOACTION, ?string $recursion = null, bool $recursion_first = true) : INode;
 
 
     /**
@@ -399,7 +399,7 @@ 
      * @param   bool $reference
      * @return  ObjectId
      */
-    public function getShareId(bool $reference=false): ?ObjectId
+    public function getShareId(bool $reference = false): ?ObjectId
     {
         if ($this->isReference() && $reference === true) {
             return $this->_id;
@@ -547,12 +547,12 @@ 
 
         try {
             $child = $this->getParent()->getChild($name);
-            if($child->getId() != $this->_id) {
+            if ($child->getId() != $this->_id) {
                 throw new Exception\Conflict('a node called '.$name.' does already exists in this collection',
                     Exception\Conflict::NODE_WITH_SAME_NAME_ALREADY_EXISTS
                 );
             }  
-        } catch(Exception\NotFound $e) {
+        } catch (Exception\NotFound $e) {
             //child does not exists, we can safely rename
         }   
           
@@ -600,7 +600,7 @@ 
      * @param   string $privilege
      * @return  bool
      */
-    public function isAllowed(string $privilege='r'): bool
+    public function isAllowed(string $privilege = 'r'): bool
     {
         $acl   = null;
         $share = null;
@@ -794,7 +794,7 @@ 
             $clean[] = 'meta';
         }
         
-        $attribute  = $clean;
+        $attribute = $clean;
 
         try {
             $sharenode  = $this->getShareNode();
@@ -924,7 +924,7 @@ 
      * @param   string $name
      * @return  string
      */
-    protected function _getDuplicateName(?string $name=null): string
+    protected function _getDuplicateName(?string $name = null) : string
     {
         if ($name === null) {
             $name = $this->name;
@@ -933,7 +933,7 @@ 
         if ($this instanceof Collection) {
             return $name.' ('.substr(uniqid('', true), -4).')';
         } else {
-            $ext  = substr(strrchr($name, '.'), 1);
+            $ext = substr(strrchr($name, '.'), 1);
 
             if ($ext === false) {
                 return $name.' ('.substr(uniqid('', true), -4).')';
@@ -953,7 +953,7 @@ 
      * @param   bool $recursion_first
      * @return  bool
      */
-    public function undelete(int $conflict=INode::CONFLICT_NOACTION, ?string $recursion=null, bool $recursion_first=true): bool
+    public function undelete(int $conflict = INode::CONFLICT_NOACTION, ?string $recursion = null, bool $recursion_first = true) : bool
     {
         if (!$this->isAllowed('w')) {
             throw new Exception\Forbidden('not allowed to restore node '.$this->name,
@@ -993,7 +993,7 @@ 
             $recursion_first = false;
         }
 
-        $this->deleted  = false;
+        $this->deleted = false;
         
         if ($this instanceof File) {
             $current = $this->version;
@@ -1021,7 +1021,7 @@ 
                 'deleted',
             ], [], $recursion, $recursion_first);
 
-            if($this->isReference()) {
+            if ($this->isReference()) {
                 return true;
             }            
 
@@ -1151,7 +1151,7 @@ 
      *
      * @return ObjectId|string
      */
-    public function getId(bool $string=false)
+    public function getId(bool $string = false)
     {
         if ($string === true) {
             return (string)$this->_id;
@@ -1201,7 +1201,7 @@ 
      * @param   array $parents
      * @return  array
      */
-    public function getParents(?INode $node=null, array $parents=[]): array
+    public function getParents(?INode $node = null, array $parents = []) : array
     {
         if ($node === null) {
             $node = $this;
@@ -1268,7 +1268,7 @@ 
      * @param   int $depth
      * @return  bool
      */
-    public function zip(ZipStream $archive, bool $self=true, ?INode $parent=null, string $path='', int $depth=0): bool
+    public function zip(ZipStream $archive, bool $self = true, ?INode $parent = null, string $path = '', int $depth = 0) : bool
     {
         if ($parent === null) {
             $parent = $this;
@@ -1330,7 +1330,7 @@ 
      * @param   mixed $value
      * @return  INode
      */
-    public function setMetaAttribute($attributes, $value=null): INode
+    public function setMetaAttribute($attributes, $value = null): INode
     {
         $this->meta = self::validateMetaAttribute($attributes, $value, $this->meta);
         $this->save('meta');
@@ -1346,7 +1346,7 @@ 
      * @param   array $set
      * @return  array
      */
-    public static function validateMetaAttribute($attributes, $value=null, array $set=[]): array
+    public static function validateMetaAttribute($attributes, $value = null, array $set = []): array
     {
         if (is_string($attributes)) {
             $attributes = [
@@ -1377,7 +1377,7 @@ 
      * @param  string|array $attribute Specify attributes to return
      * @return string|array
      */
-    public function getMetaAttribute($attribute=[])
+    public function getMetaAttribute($attribute = [])
     {
         if (is_string($attribute)) {
             if (isset($this->meta[$attribute])) {
@@ -1397,7 +1397,7 @@ 
      * @param   bool $readonly
      * @return  bool
      */
-    public function setReadonly(bool $readonly=true): bool
+    public function setReadonly(bool $readonly = true): bool
     {
         $this->readonly = $readonly;
         return $this->save('readonly');
@@ -1410,7 +1410,7 @@ 
      * @param   UTCDateTime $ts
      * @return  bool
      */
-    public function setDestroyable(?UTCDateTime $ts): bool
+    public function setDestroyable(?UTCDateTime $ts) : bool
     {
         $this->destroy = $ts;
         
@@ -1433,7 +1433,7 @@ 
      * @param   string $recursion
      * @return  bool
      */
-    abstract public function delete(bool $force=false, ?string $recursion=null, bool $recursion_first=true): bool;
+    abstract public function delete(bool $force = false, ?string $recursion = null, bool $recursion_first = true) : bool;
 
 
     /**
@@ -1503,7 +1503,7 @@ 
      * @param  bool $recursion_first
      * @return bool
      */
-    public function save($attributes=[], $remove=[], ?string $recursion=null, bool $recursion_first=true): bool
+    public function save($attributes = [], $remove = [], ?string $recursion = null, bool $recursion_first = true) : bool
     {
         if (!$this->isAllowed('w') && !$this->isReference()) {
             throw new Exception\Forbidden('not allowed to modify node '.$this->name,
@@ -1536,7 +1536,7 @@ 
             if (empty($update)) {
                 return false;
             } else {
-                $result =$this->_db->storage->updateOne([
+                $result = $this->_db->storage->updateOne([
                     '_id' => $this->_id,
                 ], $update);
             }
@@ -1572,7 +1572,7 @@ 
      * @return  array
      */
     public static function loadNodeAttributesWithCustomFilter(
-        ?array $filter = null,
+        ? array $filter = null,
         array $attributes = ['_id'],
         ?int $limit = null,
         ?int &$cursor = null,
@@ -1588,7 +1588,7 @@ 
 
         $search_attributes = array_merge($default, array_fill_keys($attributes, 1));
         $list   = [];
-        $result =$this->_db->storage->find($filter, [
+        $result = $this->_db->storage->find($filter, [
             'skip'      => $cursor,
             'limit'     => $limit,
             'projection'=> $search_attributes

src/lib/Balloon/Filesystem/Node/Collection.php

Spacing +23 added lines, -23 removed lines

@@ -1,5 +1,5 @@ 
 <?php
-declare(strict_types=1);
+declare(strict_types = 1);
 
 /**
  * Balloon
@@ -73,7 +73,7 @@ 
      * @param  bool $force
      * @return void
      */
-    public function __construct(?BSONDocument $node, Filesystem $fs, bool $force=false)
+    public function __construct(?BSONDocument $node, Filesystem $fs, bool $force = false)
     {
         parent::__construct($node, $fs);
         
@@ -81,11 +81,11 @@ 
             $this->_id = null;
 
             if ($this->_user instanceof User) {
-                $this->owner  = $this->_user->getId();
+                $this->owner = $this->_user->getId();
             }
         }
             
-        if($force === false) {
+        if ($force === false) {
             $this->_verifyAccess();
         }
     }
@@ -100,7 +100,7 @@ 
      * @param  bool $recursion_first
      * @return INode
      */
-    public function copyTo(Collection $parent, int $conflict=INode::CONFLICT_NOACTION, ?string $recursion=null, bool $recursion_first=true): INode
+    public function copyTo(Collection $parent, int $conflict = INode::CONFLICT_NOACTION, ?string $recursion = null, bool $recursion_first = true) : INode
     {
         if ($recursion === null) {
             $recursion_first = true;
@@ -200,7 +200,7 @@ 
      * @param  array|string $attribute
      * @return array|string
      */
-    public function getAttribute($attribute=[])
+    public function getAttribute($attribute = [])
     {
         if (empty($attribute)) {
             $attribute = [
@@ -246,7 +246,7 @@ 
      * @param   array $filter
      * @return  Generator
      */
-    public function getChildNodes(int $deleted=INode::DELETED_EXCLUDE, array $filter=[]): Generator
+    public function getChildNodes(int $deleted = INode::DELETED_EXCLUDE, array $filter = []): Generator
     {
         if ($this->_user instanceof User) {
             $this->_user->findNewShares();
@@ -298,7 +298,7 @@ 
         }
         
         if (!empty($this->filter)) {
-            if(is_string($this->filter)) {
+            if (is_string($this->filter)) {
                 $filter = json_decode($this->filter, true);
             } else {
                 $filter = $this->filter;
@@ -323,7 +323,7 @@ 
      * @param   array $filter
      * @return  Generator
      */
-    public function getChildren(int $deleted=INode::DELETED_EXCLUDE, array $filter=[]): array
+    public function getChildren(int $deleted = INode::DELETED_EXCLUDE, array $filter = []): array
     {
         return iterator_to_array($this->getChildNodes($deleted, $filter));
     }
@@ -394,7 +394,7 @@ 
      * @param  array $filter
      * @return INode
      */
-    public function getChild($node, int $deleted=INode::DELETED_EXCLUDE, array $filter=[]): INode
+    public function getChild($node, int $deleted = INode::DELETED_EXCLUDE, array $filter = []): INode
     {
         //if $node is string load the object from the backend based on the current parent (the name
         //is unique per depth, so we can load the object)
@@ -463,7 +463,7 @@ 
      * @param   int $deleted
      * @return  bool
      */
-    protected function doRecursiveAction(string $method, array $params=[], int $deleted=INode::DELETED_EXCLUDE): bool
+    protected function doRecursiveAction(string $method, array $params = [], int $deleted = INode::DELETED_EXCLUDE): bool
     {
         if (!is_callable([$this, $method])) {
             throw new Exception("method $method is not callable in ".__CLASS__);
@@ -490,7 +490,7 @@ 
      * @param   bool $recursion_first
      * @return  bool
      */
-    public function delete(bool $force=false, ?string $recursion=null, bool $recursion_first=true): bool
+    public function delete(bool $force = false, ?string $recursion = null, bool $recursion_first = true) : bool
     {
         if (!$this->isAllowed('w') && !$this->isReference()) {
             throw new Exception\Forbidden('not allowed to delete node '.$this->name,
@@ -553,7 +553,7 @@ 
      * @param   bool $recursion_first
      * @return  bool
      */
-    protected function _forceDelete(?string $recursion=null, bool $recursion_first=true): bool
+    protected function _forceDelete(?string $recursion = null, bool $recursion_first = true) : bool
     {
         if (!$this->isReference()) {
             $this->doRecursiveAction('delete', [
@@ -605,7 +605,7 @@ 
      * @param   array $filter
      * @return  bool
      */
-    public function childExists($name, $deleted=INode::DELETED_EXCLUDE, array $filter=[]): bool
+    public function childExists($name, $deleted = INode::DELETED_EXCLUDE, array $filter = []): bool
     {
         $find = [
             'parent'  => $this->getRealId(),
@@ -739,7 +739,7 @@ 
         }
 
         $this->shared = false;
-        $this->acl   = null;
+        $this->acl = null;
         $action = [
             '$unset' => [
                 'shared' => $this->_id
@@ -799,7 +799,7 @@ 
      * @param   arary $files
      * @return  array
      */
-    public function getChildrenRecursive(?ObjectId $id=null, ?array &$shares=[], ?array &$files=[]): array
+    public function getChildrenRecursive(?ObjectId $id = null, ? array &$shares = [], ? array &$files = []) : array
     {
         $list = [];
         $result = $this->_db->storage->find([
@@ -843,7 +843,7 @@ 
      * @param   bool $clone
      * @return  Collection
      */
-    public function addDirectory($name, array $attributes=[], int $conflict=INode::CONFLICT_NOACTION, bool $clone=false): Collection
+    public function addDirectory($name, array $attributes = [], int $conflict = INode::CONFLICT_NOACTION, bool $clone = false): Collection
     {
         if (!$this->isAllowed('w')) {
             throw new Exception\Forbidden('not allowed to create new node here',
@@ -890,7 +890,7 @@ 
                 'shared'    => ($this->shared === true ? $this->getRealId() : $this->shared)
             ];
 
-            $save  = array_merge($meta, $attributes);
+            $save = array_merge($meta, $attributes);
 
             $result = $this->_db->storage->insertOne($save);
             $save['_id'] = $result->getInsertedId();
@@ -899,7 +899,7 @@ 
                 'category' => get_class($this),
             ]);
             
-	    if(!$this->isRoot()) {
+	    if (!$this->isRoot()) {
                 $this->changed = $save['changed'];
                 $this->save('changed');
             }            
@@ -928,7 +928,7 @@ 
      * @param   bool $clone
      * @return  File
      */
-    public function addFile($name, $data=null, array $attributes=[], int $conflict=INode::CONFLICT_NOACTION, bool $clone=false): File
+    public function addFile($name, $data = null, array $attributes = [], int $conflict = INode::CONFLICT_NOACTION, bool $clone = false): File
     {
         if (!$this->isAllowed('w')) {
             throw new Exception\Forbidden('not allowed to create new node here',
@@ -978,7 +978,7 @@ 
                 'shared'    => ($this->shared === true ? $this->getRealId() : $this->shared),
             ];
 
-            $save  = array_merge($meta, $attributes);
+            $save = array_merge($meta, $attributes);
 
             $result = $this->_db->storage->insertOne($save);
             $save['_id'] = $result->getInsertedId();
@@ -987,7 +987,7 @@ 
                 'category' => get_class($this),
             ]);
 
-            if(!$this->isRoot()) {
+            if (!$this->isRoot()) {
                 $this->changed = $save['changed'];
                 $this->save('changed');
             }            
@@ -1033,7 +1033,7 @@ 
      * @param   string $data
      * @return  File
      */
-    public function createFile($name, $data=null): String
+    public function createFile($name, $data = null): String
     {
         return $this->addFile($name, $data)->getETag();
     }

src/lib/Balloon/Filesystem.php

Spacing +13 added lines, -13 removed lines

@@ -1,5 +1,5 @@ 
 <?php
-declare(strict_types=1);
+declare(strict_types = 1);
 
 /**
  * Balloon
@@ -295,7 +295,7 @@ 
      * @param   int $deleted
      * @return  INode
      */
-    public function findNodeWithId($id, ?string $class=null, int $deleted=INode::DELETED_INCLUDE): INode
+    public function findNodeWithId($id, ?string $class = null, int $deleted = INode::DELETED_INCLUDE) : INode
     {
         if (!is_string($id) && !($id instanceof ObjectID)) {
             throw new Exception\InvalidArgument($id.' node id has to be a string or instance of \MongoDB\BSON\ObjectID');
@@ -353,13 +353,13 @@ 
      * @param   string $class Fore check node type
      * @return  INode
      */
-    public function findNodeWithPath(string $path='', ?string $class=null): INode
+    public function findNodeWithPath(string $path = '', ?string $class = null) : INode
     {
         if (empty($path) || $path[0] != '/') {
             $path = '/'.$path;
         }
         
-        $last = strlen($path)-1;
+        $last = strlen($path) - 1;
         if ($path[$last] == '/') {
             $path = substr($path, 0, -1);
         }
@@ -390,7 +390,7 @@ 
      * @param   string $class Fore check node type
      * @return  INode
      */
-    public function findNodeWithShareToken(string $token, ?string $class=null): INode
+    public function findNodeWithShareToken(string $token, ?string $class = null) : INode
     {
         $node = $this->db->storage->findOne([
             'sharelink.token' => $token,
@@ -434,7 +434,7 @@ 
      * @param   bool $deleted
      * @return  Generator
      */
-    public function findNodes(array $id=[], ?string $class=null, int $deleted=INode::DELETED_INCLUDE): Generator
+    public function findNodes(array $id = [], ?string $class = null, int $deleted = INode::DELETED_INCLUDE) : Generator
     {
         $id = (array)$id;
 
@@ -488,7 +488,7 @@ 
      * @param   int $deleted
      * @return  array
      */
-    public function search(array $query, int $deleted=INode::DELETED_INCLUDE): array
+    public function search(array $query, int $deleted = INode::DELETED_INCLUDE): array
     {
         if ($this->user instanceof User) {
             $this->user->findNewShares();
@@ -582,7 +582,7 @@ 
                    ->setHosts((array)$this->config->search->hosts->server)
                    ->build();
 
-        $bool =  $query['body']['query'];
+        $bool = $query['body']['query'];
 
         $filter1 = [];
         $filter1['bool']['should'][]['term']['owner'] = (string)$this->user->getId();
@@ -650,7 +650,7 @@ 
      * @param   bool $deleted How to handle deleted node
      * @return  INode
      */
-    public function getNode($id=null, $path=null, $class=null, $multiple=false, $allow_root=false, $deleted=null)
+    public function getNode($id = null, $path = null, $class = null, $multiple = false, $allow_root = false, $deleted = null)
     {
         if (empty($id) && empty($path)) {
             if ($allow_root === true) {
@@ -766,21 +766,21 @@ 
      * @return  array
      */
     public function findNodeAttributesWithCustomFilter(
-        ?array $filter = null,
+        ? array $filter = null,
         array $attributes = ['_id'],
         ?int $limit = null,
         ?int &$cursor = null,
         ?bool &$has_more = null,
         ?INode $parent = null)
     {
-        $list   = [];
+        $list = [];
         
-	$result =$this->db->storage->find($filter, [
+	$result = $this->db->storage->find($filter, [
             'skip'      => $cursor,
             'limit'     => $limit,
         ]);
         
-        $left =$this->db->storage->count($filter, [
+        $left = $this->db->storage->count($filter, [
             'skip' => $cursor,
         ]);