gyselroth / balloon

src/lib/Filesystem/Delta.php

Doc Comments +2 added lines, -3 removed lines

@@ -70,9 +70,7 @@ 
     /**
      * Add delta event.
      *
-     * @param string        $name
      * @param NodeInterface $node
-     * @param array         $options
      *
      * @return ObjectId
      */
@@ -359,7 +357,8 @@ 
     /**
      * Get delta feed filter.
      *
-     * @param array $cursor
+     * @param integer[] $cursor
+     * @param NodeInterface|null $node
      *
      * @return array
      */

src/lib/Hook/AutoCreateUser.php

Indentation +1 added lines, -1 removed lines

@@ -90,7 +90,7 @@
         }
 
         $this->logger->info('found first time username ['.$identity->getIdentifier().'], auto-create user', [
-             'category' => get_class($this),
+                'category' => get_class($this),
         ]);
 
         $attributes = [];

src/app/Balloon.App.Api/Controller.php

Doc Comments +2 added lines, -2 removed lines

@@ -214,7 +214,7 @@ 
      * @param string $class      Force set node type
      * @param bool   $multiple   Allow $id to be an array
      * @param bool   $allow_root Allow instance of root collection
-     * @param bool   $deleted    How to handle deleted node
+     * @param integer   $deleted    How to handle deleted node
      *
      * @return NodeInterface
      */
@@ -248,7 +248,7 @@ 
      * @param string $id
      * @param string $path
      * @param string $class   Force set node type
-     * @param bool   $deleted How to handle deleted node
+     * @param integer   $deleted How to handle deleted node
      *
      * @return Generator
      */

src/app/Balloon.App.Api/v2/Groups.php

Doc Comments -1 removed lines

@@ -302,7 +302,6 @@
      * HTTP/1.1 200 OK
      *
      * @param string $id
-     * @param array  $attributes
      *
      * @return Response
      */

Spacing +2 added lines, -2 removed lines

@@ -270,7 +270,7 @@ 
         }
 
         $attributes = compact('namespace', 'optional');
-        $attributes = array_filter($attributes, function ($attribute) {return !is_null($attribute); });
+        $attributes = array_filter($attributes, function($attribute) {return !is_null($attribute); });
 
         $id = $this->server->addGroup($name, $member, $attributes);
         $result = $this->decorator->decorate($this->server->getGroupById($id));
@@ -309,7 +309,7 @@ 
     public function patch(string $id, ?array $member = null, ?string $namespace = null, ?array $optional = null): Response
     {
         $attributes = compact('namespace', 'optional', 'name', 'member');
-        $attributes = array_filter($attributes, function ($attribute) {return !is_null($attribute); });
+        $attributes = array_filter($attributes, function($attribute) {return !is_null($attribute); });
 
         $group = $this->_getGroup($id, true);
         $group->setAttributes($attributes);

src/app/Balloon.App.Api/v2/Users.php

Doc Comments -3 removed lines

@@ -158,8 +158,6 @@ 
      *     "name": "peter.meier"
      * }
      *
-     * @param string $id
-     * @param string $uname
      *
      * @return Response
      */
@@ -429,7 +427,6 @@ 
      *
      * @param string $uname
      * @param string $id
-     * @param array  $attributes
      *
      * @return Response
      */

Spacing +2 added lines, -2 removed lines

@@ -388,7 +388,7 @@ 
         }
 
         $attributes = compact('password', 'soft_quota', 'hard_quota', 'avatar', 'mail', 'admin', 'namespace', 'locale', 'optional');
-        $attributes = array_filter($attributes, function ($attribute) {return !is_null($attribute); });
+        $attributes = array_filter($attributes, function($attribute) {return !is_null($attribute); });
 
         if (isset($attributes['avatar'])) {
             $attributes['avatar'] = new Binary(base64_decode($attributes['avatar']), Binary::TYPE_GENERIC);
@@ -436,7 +436,7 @@ 
     public function patch(?string $id = null, ?string $uname = null, ?string $username = null, ?string $password = null, ?int $soft_quota = null, ?int $hard_quota = null, ?string $avatar = null, ?string $mail = null, ?bool $admin = false, ?string $namespace = null, ?string $locale = null, ?array $optional = null): Response
     {
         $attributes = compact('username', 'password', 'soft_quota', 'hard_quota', 'avatar', 'mail', 'admin', 'namespace', 'locale', 'optional');
-        $attributes = array_filter($attributes, function ($attribute) {return !is_null($attribute); });
+        $attributes = array_filter($attributes, function($attribute) {return !is_null($attribute); });
 
         if (isset($attributes['avatar'])) {
             $attributes['avatar'] = new Binary(base64_decode($attributes['avatar']), Binary::TYPE_GENERIC);

src/app/Balloon.App.Elasticsearch/Api/v2/Search.php

Doc Comments +1 added lines, -1 removed lines

@@ -107,7 +107,7 @@
      * @param array $query
      * @param array $attributes
      * @param int   $deleted
-     * @param mixed $limit
+     * @param integer $limit
      *
      * @return Response
      */

src/app/Balloon.App.Sharelink/Constructor/Http.php

Doc Comments -1 removed lines

@@ -50,7 +50,6 @@
      * @param Router             $router
      * @param Hook               $hook
      * @param Share              $sharelink
-     * @param AttributeDecorator $decorator
      * @param LoggerInterface    $logger
      */
     public function __construct(Router $router, Hook $hook, Share $sharelink, NodeAttributeDecorator $node_decorator_v2, NodeAttributeDecoratorv1 $node_decorator_v1, LoggerInterface $logger)

Spacing +3 added lines, -3 removed lines

@@ -72,7 +72,7 @@ 
             }
         });
 
-        $node_decorator_v2->addDecorator('sharelink_token', function ($node) use ($sharelink) {
+        $node_decorator_v2->addDecorator('sharelink_token', function($node) use ($sharelink) {
             $attributes = $sharelink->getSharelink($node);
 
             if (isset($attributes['token'])) {
@@ -80,7 +80,7 @@ 
             }
         });
 
-        $node_decorator_v2->addDecorator('sharelink_expire', function ($node) use ($sharelink) {
+        $node_decorator_v2->addDecorator('sharelink_expire', function($node) use ($sharelink) {
             $attributes = $sharelink->getSharelink($node);
 
             if (isset($attributes['expiration'])) {
@@ -90,7 +90,7 @@ 
             }
         });
 
-        $node_decorator_v1->addDecorator('sharelink', function ($node) use ($sharelink) {
+        $node_decorator_v1->addDecorator('sharelink', function($node) use ($sharelink) {
             return isset($sharelink->getSharelink($node)['token']);
         });
 

src/lib/Filesystem.php

Doc Comments +3 added lines, -4 removed lines

@@ -181,7 +181,7 @@ 
     /**
      * Find raw node.
      *
-     * @param ObjectId $id
+     * @param ObjectId|null $id
      *
      * @return array
      */
@@ -302,7 +302,7 @@ 
      *
      * @param array  $id
      * @param string $class   Force check node type
-     * @param bool   $deleted
+     * @param integer   $deleted
      *
      * @return Generator
      */
@@ -431,7 +431,7 @@ 
      * @param string $class      Force set node type
      * @param bool   $multiple   Allow $id to be an array
      * @param bool   $allow_root Allow instance of root collection
-     * @param bool   $deleted    How to handle deleted node
+     * @param integer   $deleted    How to handle deleted node
      *
      * @return NodeInterface
      */
@@ -493,7 +493,6 @@ 
      * @param array $filter
      * @param int   $offset
      * @param int   $limit
-     * @param int   $total
      *
      * @return Generator
      */

src/lib/Filesystem/Node/Collection.php

Doc Comments +2 added lines, -4 removed lines

@@ -269,7 +269,7 @@ 
     /**
      * Get real id (reference).
      *
-     * @return ObjectId
+     * @return ObjectId|null
      */
     public function getRealId(): ?ObjectId
     {
@@ -298,7 +298,6 @@ 
     /**
      * Fetch children items of this collection.
      *
-     * @param string $node
      * @param int    $deleted
      * @param array  $filter
      * @param mixed  $name
@@ -860,7 +859,7 @@ 
      * @param string $name
      * @param string $data
      *
-     * @return File
+     * @return string
      */
     public function createFile($name, $data = null): String
     {
@@ -885,7 +884,6 @@ 
      *
      * @param callable $callable
      * @param int      $deleted
-     * @param bool     $ignore_exception
      *
      * @return bool
      */

Unused Use Statements -1 removed lines

@@ -16,7 +16,6 @@
 use Balloon\Filesystem\Acl\Exception\Forbidden as ForbiddenException;
 use Balloon\Filesystem\Exception;
 use Balloon\Hook;
-use Balloon\Server\User;
 use Generator;
 use MongoDB\BSON\ObjectId;
 use MongoDB\BSON\Regex;

Spacing +2 added lines, -2 removed lines

@@ -386,7 +386,7 @@ 
         $this->deleted = new UTCDateTime();
 
         if (!$this->isReference()) {
-            $this->doRecursiveAction(function ($node) use ($recursion) {
+            $this->doRecursiveAction(function($node) use ($recursion) {
                 $node->delete(false, $recursion, false);
             }, NodeInterface::DELETED_EXCLUDE);
         }
@@ -936,7 +936,7 @@ 
     protected function _forceDelete(?string $recursion = null, bool $recursion_first = true): bool
     {
         if (!$this->isReference()) {
-            $this->doRecursiveAction(function ($node) use ($recursion) {
+            $this->doRecursiveAction(function($node) use ($recursion) {
                 $node->delete(true, $recursion, false);
             }, NodeInterface::DELETED_INCLUDE);
         }