gyselroth / balloon

src/app/Balloon.App.Api/v1/Node.php

Doc Comments +3 added lines, -3 removed lines

@@ -282,7 +282,7 @@ 
      * @param array|string $id
      * @param array|string $p
      * @param int          $offset
-     * @param int          $legnth
+     * @param int          $length
      * @param string       $encode
      * @param bool         $download
      * @param string       $name
@@ -1420,7 +1420,7 @@ 
      * @param string $class      Force set node type
      * @param bool   $multiple   Allow $id to be an array
      * @param bool   $allow_root Allow instance of root collection
-     * @param bool   $deleted    How to handle deleted node
+     * @param integer   $deleted    How to handle deleted node
      *
      * @return NodeInterface
      */
@@ -1454,7 +1454,7 @@ 
      * @param string $id
      * @param string $path
      * @param string $class   Force set node type
-     * @param bool   $deleted How to handle deleted node
+     * @param integer   $deleted How to handle deleted node
      *
      * @return Generator
      */

Indentation +44 added lines, -44 removed lines

@@ -320,50 +320,50 @@ 
         }
 
         return (new Response())
-          ->setOutputFormat(null)
-          ->setBody(function () use ($node, $encode, $offset, $length) {
-              $mime = $node->getContentType();
-              $stream = $node->get();
-              $name = $node->getName();
-
-              if (null === $stream) {
-                  return;
-              }
-
-              if (0 !== $offset) {
-                  if (fseek($stream, $offset) === -1) {
-                      throw new Exception\Conflict(
+            ->setOutputFormat(null)
+            ->setBody(function () use ($node, $encode, $offset, $length) {
+                $mime = $node->getContentType();
+                $stream = $node->get();
+                $name = $node->getName();
+
+                if (null === $stream) {
+                    return;
+                }
+
+                if (0 !== $offset) {
+                    if (fseek($stream, $offset) === -1) {
+                        throw new Exception\Conflict(
                         'invalid offset requested',
                         Exception\Conflict::INVALID_OFFSET
                     );
-                  }
-              }
-
-              $read = 0;
-              header('Content-Type: '.$mime.'');
-              if ('base64' === $encode) {
-                  header('Content-Encoding: base64');
-                  while (!feof($stream)) {
-                      if (0 !== $length && $read + 8192 > $length) {
-                          echo base64_encode(fread($stream, $length - $read));
-                          exit();
-                      }
-
-                      echo base64_encode(fread($stream, 8192));
-                      $read += 8192;
-                  }
-              } else {
-                  while (!feof($stream)) {
-                      if (0 !== $length && $read + 8192 > $length) {
-                          echo fread($stream, $length - $read);
-                          exit();
-                      }
-
-                      echo fread($stream, 8192);
-                      $read += 8192;
-                  }
-              }
-          });
+                    }
+                }
+
+                $read = 0;
+                header('Content-Type: '.$mime.'');
+                if ('base64' === $encode) {
+                    header('Content-Encoding: base64');
+                    while (!feof($stream)) {
+                        if (0 !== $length && $read + 8192 > $length) {
+                            echo base64_encode(fread($stream, $length - $read));
+                            exit();
+                        }
+
+                        echo base64_encode(fread($stream, 8192));
+                        $read += 8192;
+                    }
+                } else {
+                    while (!feof($stream)) {
+                        if (0 !== $length && $read + 8192 > $length) {
+                            echo fread($stream, $length - $read);
+                            exit();
+                        }
+
+                        echo fread($stream, 8192);
+                        $read += 8192;
+                    }
+                }
+            });
     }
 
     /**
@@ -1502,9 +1502,9 @@ 
                 $node->zip($archive);
             } catch (\Exception $e) {
                 $this->logger->debug('failed zip node in multi node request ['.$node->getId().']', [
-                   'category' => get_class($this),
-                   'exception' => $e,
-               ]);
+                    'category' => get_class($this),
+                    'exception' => $e,
+                ]);
             }
         }
 

Spacing +14 added lines, -14 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare(strict_types=1);
+declare(strict_types = 1);
 
 /**
  * balloon
@@ -123,7 +123,7 @@ 
             $result = $this->_getNode($id, $p, null, false, false, $deleted);
 
             $response = (new Response())
-                ->setHeader('Content-Length', (string) $result->getSize())
+                ->setHeader('Content-Length', (string)$result->getSize())
                 ->setHeader('Content-Type', $result->getContentType())
                 ->setCode(200);
 
@@ -192,7 +192,7 @@ 
             }
         }
 
-        return $this->bulk($id, $p, function ($node) use ($parent, $conflict, $move) {
+        return $this->bulk($id, $p, function($node) use ($parent, $conflict, $move) {
             if (true === $move) {
                 $node = $node->setParent($parent, $conflict);
             }
@@ -273,7 +273,7 @@ 
 
         $node = $this->_getNode($id, $p);
         if ($node instanceof Collection) {
-            return (new Response())->setBody(function () use ($node) {
+            return (new Response())->setBody(function() use ($node) {
                 $node->getZip();
             });
         }
@@ -284,7 +284,7 @@ 
             $response->setHeader('Content-Disposition', 'attachment; filename*=UTF-8\'\''.rawurlencode($name));
             $response->setHeader('Cache-Control', 'no-store, no-cache, must-revalidate, post-check=0, pre-check=0');
             $response->setHeader('Content-Type', 'application/octet-stream');
-            $response->setHeader('Content-Length', (string) $node->getSize());
+            $response->setHeader('Content-Length', (string)$node->getSize());
             $response->setHeader('Content-Transfer-Encoding', 'binary');
         } else {
             $response->setHeader('Content-Disposition', 'inline; filename*=UTF-8\'\''.rawurlencode($name));
@@ -292,7 +292,7 @@ 
 
         return (new Response())
           ->setOutputFormat(null)
-          ->setBody(function () use ($node, $encode, $offset, $length) {
+          ->setBody(function() use ($node, $encode, $offset, $length) {
               $mime = $node->getContentType();
               $stream = $node->get();
               $name = $node->getName();
@@ -365,7 +365,7 @@ 
      */
     public function postReadonly($id = null, $p = null, bool $readonly = true): Response
     {
-        return $this->bulk($id, $p, function ($node) use ($readonly) {
+        return $this->bulk($id, $p, function($node) use ($readonly) {
             $node->setReadonly($readonly);
 
             return ['code' => 204];
@@ -618,7 +618,7 @@ 
      */
     public function postMetaAttributes(array $attributes, ?string $id = null, ?string $p = null): Response
     {
-        return $this->bulk($id, $p, function ($node) use ($attributes) {
+        return $this->bulk($id, $p, function($node) use ($attributes) {
             $node->setMetaAttributes($attributes);
 
             return ['code' => 204];
@@ -706,7 +706,7 @@ 
             );
         }
 
-        return $this->bulk($id, $p, function ($node) use ($parent, $conflict) {
+        return $this->bulk($id, $p, function($node) use ($parent, $conflict) {
             $result = $node->copyTo($parent, $conflict);
 
             return [
@@ -770,7 +770,7 @@ 
             );
         }
 
-        return $this->bulk($id, $p, function ($node) use ($parent, $conflict) {
+        return $this->bulk($id, $p, function($node) use ($parent, $conflict) {
             $result = $node->setParent($parent, $conflict);
             if (NodeInterface::CONFLICT_RENAME === $conflict) {
                 return [
@@ -829,7 +829,7 @@ 
             $at = $this->_verifyAttributes(['destroy' => $at])['destroy'];
         }
 
-        return $this->bulk($id, $p, function ($node) use ($force, $ignore_flag, $at) {
+        return $this->bulk($id, $p, function($node) use ($force, $ignore_flag, $at) {
             if (null === $at) {
                 $node->delete($force && $node->isDeleted() || $force && $ignore_flag);
             } else {
@@ -1425,7 +1425,7 @@ 
         foreach ($attributes as $attribute => $value) {
             switch ($attribute) {
                 case 'filter':
-                    $attributes['filter'] = json_encode((array) $attributes['filter']);
+                    $attributes['filter'] = json_encode((array)$attributes['filter']);
 
                 break;
                 case 'destroy':
@@ -1440,14 +1440,14 @@ 
                     if (!Helper::isValidTimestamp($value)) {
                         throw new Exception\InvalidArgument($attribute.' Changed timestamp must be valid unix timestamp');
                     }
-                    if ((int) $value > time()) {
+                    if ((int)$value > time()) {
                         throw new Exception\InvalidArgument($attribute.' timestamp can not be set greater than the server time');
                     }
                     $attributes[$attribute] = new UTCDateTime($value.'000');
 
                 break;
                 case 'readonly':
-                    $attributes['readonly'] = (bool) $attributes['readonly'];
+                    $attributes['readonly'] = (bool)$attributes['readonly'];
 
                 break;
             }

src/app/Balloon.App.Notification/Hook/NewShareAdded.php

Doc Comments +2 added lines, -2 removed lines

@@ -55,7 +55,7 @@ 
     /**
      * Constructor.
      *
-     * @param Notification $notifier
+     * @param Notifier $notifier
      * @param Server       $server
      */
     public function __construct(Notifier $notifier, Server $server, LoggerInterface $logger, TemplateHandler $template)
@@ -129,7 +129,7 @@ 
      * @param NodeInterface $node
      * @param User          $user
      *
-     * @return string
+     * @return boolean
      */
     protected function checkNotify(NodeInterface $node, User $user): bool
     {

Unused Use Statements -1 removed lines

@@ -14,7 +14,6 @@
 use Balloon\App\Notification\NodeMessage;
 use Balloon\App\Notification\Notifier;
 use Balloon\App\Notification\TemplateHandler;
-use Balloon\Async\Mail;
 use Balloon\Filesystem\Node\Collection;
 use Balloon\Filesystem\Node\NodeInterface;
 use Balloon\Hook\AbstractHook;

Spacing +5 added lines, -5 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare(strict_types=1);
+declare(strict_types = 1);
 
 /**
  * balloon
@@ -105,13 +105,13 @@ 
         $receiver = [];
         foreach ($node->getAcl() as $rule) {
             if ('user' === $rule['type']) {
-                if (!isset($receiver[(string) $rule['role']->getId()]) && $this->checkNotify($node, $rule['role'])) {
-                    $receiver[(string) $rule['role']->getId()] = $rule['role'];
+                if (!isset($receiver[(string)$rule['role']->getId()]) && $this->checkNotify($node, $rule['role'])) {
+                    $receiver[(string)$rule['role']->getId()] = $rule['role'];
                 }
             } elseif ('group' === $rule['type']) {
                 foreach ($rule['role']->getResolvedMember() as $user) {
-                    if (!isset($receiver[(string) $user->getId()]) && $this->checkNotify($node, $user)) {
-                        $receiver[(string) $user->getId()] = $user;
+                    if (!isset($receiver[(string)$user->getId()]) && $this->checkNotify($node, $user)) {
+                        $receiver[(string)$user->getId()] = $user;
                     }
                 }
             }

src/app/Balloon.App.Notification/Hook/Subscription.php

Doc Comments +1 added lines, -1 removed lines

@@ -64,7 +64,7 @@
     /**
      * Constructor.
      *
-     * @param Notification $notifier
+     * @param Notifier $notifier
      * @param Server       $server
      */
     public function __construct(Notifier $notifier, Server $server, TemplateHandler $template, LoggerInterface $logger, ?Iterable $config = null)

Unused Use Statements -1 removed lines

@@ -20,7 +20,6 @@
 use Balloon\Filesystem\Node\NodeInterface;
 use Balloon\Hook\AbstractHook;
 use Balloon\Server;
-use Balloon\Server\User;
 use MongoDB\BSON\UTCDateTime;
 use Psr\Log\LoggerInterface;
 

Spacing +5 added lines, -5 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare(strict_types=1);
+declare(strict_types = 1);
 
 /**
  * balloon
@@ -92,7 +92,7 @@ 
         foreach ($config as $option => $value) {
             switch ($option) {
                 case 'notification_throttle':
-                    $this->{$option} = (int) $value;
+                    $this->{$option} = (int)$value;
 
                 break;
                 default:
@@ -109,7 +109,7 @@ 
     public function postCreateCollection(Collection $parent, Collection $node, bool $clone): void
     {
         $this->notify($node);
-        $user_id = (string) $this->server->getIdentity()->getId();
+        $user_id = (string)$this->server->getIdentity()->getId();
         $subs = $parent->getAppAttribute('Balloon\\App\\Notification', 'subscription');
 
         if (isset($subs[$user_id]) && $subs[$user_id]['recursive'] === true) {
@@ -171,7 +171,7 @@ 
         $parent = $node->getParent();
 
         if ($parent !== null) {
-            $subs = array_keys((array) $parent->getAppAttribute('Balloon\\App\\Notification', 'subscription'));
+            $subs = array_keys((array)$parent->getAppAttribute('Balloon\\App\\Notification', 'subscription'));
             $parents = $this->getReceiver($parent);
 
             $blacklist = array_diff($subs, $parents);
@@ -223,7 +223,7 @@ 
         $node->setAppAttribute('Balloon\\App\\Notification', 'subscription', $update);
 
         if ($this->server->getIdentity() !== null) {
-            $user_id = (string) $this->server->getIdentity()->getId();
+            $user_id = (string)$this->server->getIdentity()->getId();
             if (isset($subs[$user_id]) && $subs[$user_id]['exclude_me'] === true) {
                 $this->logger->debug('skip message for user ['.$user_id.'], user excludes own actions in node ['.$node->getId().']', [
                     'category' => get_class($this),

src/app/Balloon.App.Notification/Notifier.php

Doc Comments +5 added lines, -7 removed lines

@@ -71,7 +71,7 @@ 
      *
      * @param Database       $db
      * @param Server         $server
-     * @param LoggerInterace $logger
+     * @param LoggerInterface $logger
      * @param iterable       $config
      */
     public function __construct(Database $db, Server $server, LoggerInterface $logger, ?Iterable $config = null)
@@ -116,9 +116,7 @@ 
      *
      * @param iterable $receiver
      * @param User     $sender
-     * @param string   $subject
-     * @param string   $body
-     * @param array    $context
+     * @param string    $context
      *
      * @return bool
      */
@@ -226,10 +224,10 @@ 
     /**
      * Add notification.
      *
-     * @param array            $receiver
-     * @param User             $user
+     * @param User            $receiver
      * @param MessageInterface $message
      * @param array            $context
+     * @param User $sender
      *
      * @return ObjectId
      */
@@ -266,7 +264,7 @@ 
     /**
      * Get notifications.
      *
-     * @param ObjectId $id
+     * @param User $id
      *
      * @return bool
      */

Spacing +4 added lines, -4 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare(strict_types=1);
+declare(strict_types = 1);
 
 /**
  * balloon
@@ -301,7 +301,7 @@ 
     public function subscribeNode(NodeInterface $node, bool $subscribe = true, bool $exclude_me = true, bool $recursive = false): bool
     {
         $subs = $node->getAppAttribute(__NAMESPACE__, 'subscription');
-        $user_id = (string) $this->server->getIdentity()->getId();
+        $user_id = (string)$this->server->getIdentity()->getId();
 
         if (true === $subscribe) {
             $this->logger->debug('user ['.$this->server->getIdentity()->getId().'] subribes node ['.$node->getId().']', [
@@ -317,7 +317,7 @@ 
             $subs[$user_id] = $subscription;
             $node->setAppAttribute(__NAMESPACE__, 'subscription', $subs);
             if ($node instanceof Collection && $recursive === true) {
-                $node->doRecursiveAction(function ($child) use ($subscription, $user_id) {
+                $node->doRecursiveAction(function($child) use ($subscription, $user_id) {
                     $subs = $child->getAppAttribute(__NAMESPACE__, 'subscription');
                     $subs[$user_id] = $subscription;
                     $child->setAppAttribute(__NAMESPACE__, 'subscription', $subs);
@@ -335,7 +335,7 @@ 
             $node->setAppAttribute(__NAMESPACE__, 'subscription', $subs);
 
             if ($node instanceof Collection && $recursive === true) {
-                $node->doRecursiveAction(function ($child) use ($user_id) {
+                $node->doRecursiveAction(function($child) use ($user_id) {
                     $subs = $child->getAppAttribute(__NAMESPACE__, 'subscription');
 
                     if (isset($subs[$user_id])) {

src/app/Balloon.App.Notification/TemplateHandler.php

Doc Comments +2 added lines, -7 removed lines

@@ -218,8 +218,6 @@ 
     /**
      * Replace variables.
      *
-     * @param string $type
-     * @param User   $user
      */
     protected function decorate(string $template): string
     {
@@ -229,8 +227,6 @@ 
     /**
      * Replace variables.
      *
-     * @param string $type
-     * @param User   $user
      */
     protected function decorateNode(string $template, NodeInterface $node): string
     {
@@ -248,7 +244,6 @@ 
     /**
      * Replace variables.
      *
-     * @param string $type
      * @param User   $user
      */
     protected function decorateUser(string $template, User $user): string
@@ -267,9 +262,9 @@ 
     /**
      * Get array value via string path.
      *
-     * @param iterable $arr
+     * @param iterable $array
      * @param string   $path
-     * @param string   $seperator
+     * @param string   $separator
      *
      * @return mixed
      */

Spacing +4 added lines, -4 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare(strict_types=1);
+declare(strict_types = 1);
 
 /**
  * balloon
@@ -120,7 +120,7 @@ 
             switch ($option) {
                 case 'asset_dir':
                 case 'fallback_locale':
-                    $this->{$option} = (string) $value;
+                    $this->{$option} = (string)$value;
 
                 break;
                 default:
@@ -236,7 +236,7 @@ 
     {
         $decorator = $this->decorator;
 
-        return preg_replace_callback('/(\{node\.(([a-z]\.*)+)\})/', function ($match) use ($node, $decorator) {
+        return preg_replace_callback('/(\{node\.(([a-z]\.*)+)\})/', function($match) use ($node, $decorator) {
             $key = explode('.', $match[2]);
             $key = array_shift($key);
             $attrs = $decorator->decorate($node, [$key]);
@@ -255,7 +255,7 @@ 
     {
         $role_decorator = $this->role_decorator;
 
-        return preg_replace_callback('/(\{user\.(([a-z]\.*)+)\})/', function ($match) use ($user, $role_decorator) {
+        return preg_replace_callback('/(\{user\.(([a-z]\.*)+)\})/', function($match) use ($user, $role_decorator) {
             $key = explode('.', $match[2]);
             $key = array_shift($key);
             $attrs = $role_decorator->decorate($user, [$key]);

src/lib/Bootstrap/AbstractBootstrap.php

Unused Use Statements -1 removed lines

@@ -11,7 +11,6 @@
 
 namespace Balloon\Bootstrap;
 
-use Balloon\App;
 use Composer\Autoload\ClassLoader as Composer;
 use ErrorException;
 use Micro\Container\Container;

Spacing +4 added lines, -4 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare(strict_types=1);
+declare(strict_types = 1);
 
 /**
  * balloon
@@ -65,7 +65,7 @@ 
     protected function registerAppConstructors(array $apps): self
     {
         $context = $this->getContext();
-        $app_config = (array) $this->config['apps'];
+        $app_config = (array)$this->config['apps'];
 
         foreach ($apps as $app) {
             if (isset($app_config[$app])) {
@@ -102,7 +102,7 @@ 
     protected function loadAppConfigs(array $apps, Config $config)
     {
         $root = new Config(__DIR__.DIRECTORY_SEPARATOR.'..'.DIRECTORY_SEPARATOR.'..'.DIRECTORY_SEPARATOR.'.container.config.php');
-        $app_config = (array) $config['apps'];
+        $app_config = (array)$config['apps'];
         $configs = [];
 
         foreach ($apps as $name => $config_path) {
@@ -182,7 +182,7 @@ 
      */
     protected function setErrorHandler(): self
     {
-        set_error_handler(function ($severity, $message, $file, $line) {
+        set_error_handler(function($severity, $message, $file, $line) {
             $log = $message.' in '.$file.':'.$line;
 
             if (null === $this->container) {

src/lib/Filesystem/EventAttributeDecorator.php

Doc Comments +1 added lines, -1 removed lines

@@ -100,7 +100,7 @@
      * @param string  $attribute
      * @param Closure $decorator
      *
-     * @return AttributeDecorator
+     * @return EventAttributeDecorator
      */
     public function addDecorator(string $attribute, Closure $decorator): self
     {

Spacing +2 added lines, -2 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare(strict_types=1);
+declare(strict_types = 1);
 
 /**
  * balloon
@@ -119,7 +119,7 @@ 
     protected function getAttributes(array $event): array
     {
         return [
-            'event' => (string) $event['_id'],
+            'event' => (string)$event['_id'],
             'timestamp' => $event['timestamp']->toDateTime()->format('c'),
             'operation' => $event['operation'],
             'name' => $event['name'],

src/lib/Filesystem/Storage.php

Unused Use Statements -1 removed lines

@@ -13,7 +13,6 @@
 
 use Balloon\Filesystem\Node\File;
 use Balloon\Filesystem\Storage\Adapter\AdapterInterface;
-use Balloon\Filesystem\Storage\Adapter\Gridfs;
 use Psr\Log\LoggerInterface;
 
 class Storage

Spacing +1 added lines, -1 removed lines

@@ -1,6 +1,6 @@
 <?php
 
-declare(strict_types=1);
+declare(strict_types = 1);
 
 /**
  * balloon

src/lib/Hook.php

Doc Comments -1 removed lines

@@ -44,7 +44,6 @@
     /**
      * Inject hook.
      *
-     * @param HookInterface $adapter
      *
      * @return Hook
      */

Spacing +1 added lines, -1 removed lines

@@ -1,6 +1,6 @@
 <?php
 
-declare(strict_types=1);
+declare(strict_types = 1);
 
 /**
  * balloon