Job - Code Metrics - Inspection of "v2 fixes regarding delta attribute decorator" - gyselroth/balloon - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Branch — dev (d5d70c)

by Raffael

created 2018-02-16 14:20 UTC

Job A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	61
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	5

Importance

Changes

Metric	Value
wmc	4
lcom	1
dl	0
loc	61
rs	10
c	0
b	0
f	0
cbo	5

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	6	1
A	start()	0	17	3

<?php

declare(strict_types=1);

/**
 * balloon
 *
 * @copyright   Copryright (c) 2012-2018 gyselroth GmbH (https://gyselroth.com)
 * @license     GPL-3.0 https://opensource.org/licenses/GPL-3.0
 */

namespace Balloon\App\Convert;

use Balloon\Server;
use TaskScheduler\AbstractJob;
use TaskScheduler\Async;

class Job extends AbstractJob
{
    /**
     * Converter.
     *
     * @var Converter
     */
    protected $converter;

    /**
     * Server.
     *
     * @var Server
     */
    protected $server;

    /**
     * Async.
     *
     * @var Async
     */
    protected $async;

    /**
     * Constructor.
     *
     * @param Async $async
     */
    public function __construct(Server $server, Async $async, Converter $converter)
    {
        $this->server = $server;
        $this->async = $async;
        $this->converter = $converter;
    }

    /**
     * Start job.
     *
     * @param Server          $server
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @param LoggerInterface $logger
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     *
     * @return bool
     */
    public function start(): bool
    {
        $master = $this->server->getFilesystem()->findNodeById($this->data['master']);

        if (isset($this->data['id'])) {
            $this->converter->convert($this->data['id'], $master);

        } else {
            foreach ($this->converter->getSlaves($master) as $slave) {

                $this->async->addJob(self::class, [
                    'master' => $this->data['master'],
                    'id' => $slave['_id'],
                ]);
            }
        }

        return true;
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			/**
6			* balloon
7			*
8			* @copyright Copryright (c) 2012-2018 gyselroth GmbH (https://gyselroth.com)
9			* @license GPL-3.0 https://opensource.org/licenses/GPL-3.0
10			*/
11
12			namespace Balloon\App\Convert;
13
14			use Balloon\Server;
15			use TaskScheduler\AbstractJob;
16			use TaskScheduler\Async;
17
18			class Job extends AbstractJob
19			{
20			/**
21			* Converter.
22			*
23			* @var Converter
24			*/
25			protected $converter;
26
27			/**
28			* Server.
29			*
30			* @var Server
31			*/
32			protected $server;
33
34			/**
35			* Async.
36			*
37			* @var Async
38			*/
39			protected $async;
40
41			/**
42			* Constructor.
43			*
44			* @param Async $async
45			*/
46			public function __construct(Server $server, Async $async, Converter $converter)
47			{
48			$this->server = $server;
49			$this->async = $async;
50			$this->converter = $converter;
51			}
52
53			/**
54			* Start job.
55			*
56			* @param Server $server
			0 ignored issues – show Bug introduced 2017-11-24 09:08 UTC by Report Bug Copy Issue Report There is no parameter named `$server`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
57			* @param LoggerInterface $logger
			0 ignored issues – show Bug introduced 2017-11-24 09:08 UTC by Report Bug Copy Issue Report There is no parameter named `$logger`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
58			*
59			* @return bool
60			*/
61			public function start(): bool
62			{
63			$master = $this->server->getFilesystem()->findNodeById($this->data['master']);
64
65			if (isset($this->data['id'])) {
66			$this->converter->convert($this->data['id'], $master);
			0 ignored issues – show Compatibility introduced 2018-02-16 14:31 UTC by Report Bug Copy Issue Report `$master` of type `object<Balloon\Filesystem\Node\NodeInterface>` is not a sub-type of `object<Balloon\Filesystem\Node\File>`. It seems like you assume a concrete implementation of the interface `Balloon\Filesystem\Node\NodeInterface` to be always present. This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass. Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type. Loading history...
67			} else {
68			foreach ($this->converter->getSlaves($master) as $slave) {
			0 ignored issues – show Compatibility introduced 2018-02-16 14:31 UTC by Report Bug Copy Issue Report `$master` of type `object<Balloon\Filesystem\Node\NodeInterface>` is not a sub-type of `object<Balloon\Filesystem\Node\File>`. It seems like you assume a concrete implementation of the interface `Balloon\Filesystem\Node\NodeInterface` to be always present. This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass. Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type. Loading history...
69			$this->async->addJob(self::class, [
70			'master' => $this->data['master'],
71			'id' => $slave['_id'],
72			]);
73			}
74			}
75
76			return true;
77			}
78			}
79

gyselroth / balloon

Branch — dev (d5d70c)

Job A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

2 Methods

Duplication Side-by-Side

Filter issues like