gyselroth / balloon

src/app/Balloon.App.Office/Api/v2/Documents.php

Unused Use Statements -1 removed lines

@@ -20,7 +20,6 @@
 use Balloon\Filesystem\Node\Collection;
 use Balloon\Filesystem\Node\File;
 use Balloon\Server;
-use Balloon\Server\User;
 use Micro\Http\Response;
 
 class Documents extends Controller

Spacing +1 added lines, -1 removed lines

@@ -173,7 +173,7 @@
         $tpl = new Template($type);
 
         $attributes = compact('readonly', 'meta');
-        $attributes = array_filter($attributes, function ($attribute) {return !is_null($attribute); });
+        $attributes = array_filter($attributes, function($attribute) {return !is_null($attribute); });
 
         $result = $parent->addFile($name, $tpl->get(), $attributes);
         $result = $this->decorator->decorate($result);

src/lib/Filesystem/Delta.php

Doc Comments +2 added lines, -3 removed lines

@@ -70,9 +70,7 @@ 
     /**
      * Add delta event.
      *
-     * @param string        $name
      * @param NodeInterface $node
-     * @param array         $options
      *
      * @return ObjectId
      */
@@ -359,7 +357,8 @@ 
     /**
      * Get delta feed filter.
      *
-     * @param array $cursor
+     * @param integer[] $cursor
+     * @param NodeInterface|null $node
      *
      * @return array
      */

src/lib/Filesystem/Node/AbstractNode.php

Doc Comments +3 added lines, -9 removed lines

@@ -816,7 +816,6 @@ 
     /**
      * Set app attributes.
      *
-     * @param AppInterface $app
      * @param array        $attributes
      *
      * @return NodeInterface
@@ -832,7 +831,6 @@ 
     /**
      * Set app attribute.
      *
-     * @param AppInterface $app
      * @param string       $attribute
      * @param mixed        $value
      *
@@ -853,7 +851,6 @@ 
     /**
      * Remove app attribute.
      *
-     * @param AppInterface $app
      *
      * @return NodeInterface
      */
@@ -870,7 +867,6 @@ 
     /**
      * Remove app attribute.
      *
-     * @param AppInterface $app
      * @param string       $attribute
      *
      * @return NodeInterface
@@ -888,7 +884,6 @@ 
     /**
      * Get app attribute.
      *
-     * @param AppInterface $app
      * @param string       $attribute
      *
      * @return mixed
@@ -905,7 +900,6 @@ 
     /**
      * Get app attributes.
      *
-     * @param AppInterface $app
      *
      * @return array
      */
@@ -944,7 +938,7 @@ 
     /**
      * Get meta attributes as array.
      *
-     * @param array $attribute Specify attributes to return
+     * @param array $attributes Specify attributes to return
      *
      * @return array
      */
@@ -1115,9 +1109,9 @@ 
     /**
      * Get array value via string path.
      *
-     * @param iterable $arr
+     * @param iterable $array
      * @param string   $path
-     * @param string   $seperator
+     * @param string   $separator
      *
      * @return mixed
      */

Spacing +1 added lines, -1 removed lines

@@ -629,7 +629,7 @@
             return true;
         }
 
-        return $this->doRecursiveAction(function ($node) use ($conflict, $recursion) {
+        return $this->doRecursiveAction(function($node) use ($conflict, $recursion) {
             $node->undelete($conflict, $recursion, false);
         }, NodeInterface::DELETED_ONLY);
     }

src/lib/Hook/AutoCreateUser.php

Indentation +1 added lines, -1 removed lines

@@ -90,7 +90,7 @@
         }
 
         $this->logger->info('found first time username ['.$identity->getIdentifier().'], auto-create user', [
-             'category' => get_class($this),
+                'category' => get_class($this),
         ]);
 
         $attributes = [];

src/app/Balloon.App.Api/Controller.php

Doc Comments +2 added lines, -2 removed lines

@@ -214,7 +214,7 @@ 
      * @param string $class      Force set node type
      * @param bool   $multiple   Allow $id to be an array
      * @param bool   $allow_root Allow instance of root collection
-     * @param bool   $deleted    How to handle deleted node
+     * @param integer   $deleted    How to handle deleted node
      *
      * @return NodeInterface
      */
@@ -248,7 +248,7 @@ 
      * @param string $id
      * @param string $path
      * @param string $class   Force set node type
-     * @param bool   $deleted How to handle deleted node
+     * @param integer   $deleted How to handle deleted node
      *
      * @return Generator
      */

src/app/Balloon.App.Api/v2/Groups.php

Doc Comments -1 removed lines

@@ -302,7 +302,6 @@
      * HTTP/1.1 200 OK
      *
      * @param string $id
-     * @param array  $attributes
      *
      * @return Response
      */

Spacing +2 added lines, -2 removed lines

@@ -270,7 +270,7 @@ 
         }
 
         $attributes = compact('namespace', 'optional');
-        $attributes = array_filter($attributes, function ($attribute) {return !is_null($attribute); });
+        $attributes = array_filter($attributes, function($attribute) {return !is_null($attribute); });
 
         $id = $this->server->addGroup($name, $member, $attributes);
         $result = $this->decorator->decorate($this->server->getGroupById($id));
@@ -309,7 +309,7 @@ 
     public function patch(string $id, ?array $member = null, ?string $namespace = null, ?array $optional = null): Response
     {
         $attributes = compact('namespace', 'optional', 'name', 'member');
-        $attributes = array_filter($attributes, function ($attribute) {return !is_null($attribute); });
+        $attributes = array_filter($attributes, function($attribute) {return !is_null($attribute); });
 
         $group = $this->_getGroup($id, true);
         $group->setAttributes($attributes);

src/app/Balloon.App.Api/v2/Users.php

Doc Comments -3 removed lines

@@ -158,8 +158,6 @@ 
      *     "name": "peter.meier"
      * }
      *
-     * @param string $id
-     * @param string $uname
      *
      * @return Response
      */
@@ -429,7 +427,6 @@ 
      *
      * @param string $uname
      * @param string $id
-     * @param array  $attributes
      *
      * @return Response
      */

Spacing +2 added lines, -2 removed lines

@@ -388,7 +388,7 @@ 
         }
 
         $attributes = compact('password', 'soft_quota', 'hard_quota', 'avatar', 'mail', 'admin', 'namespace', 'locale', 'optional');
-        $attributes = array_filter($attributes, function ($attribute) {return !is_null($attribute); });
+        $attributes = array_filter($attributes, function($attribute) {return !is_null($attribute); });
 
         if (isset($attributes['avatar'])) {
             $attributes['avatar'] = new Binary(base64_decode($attributes['avatar']), Binary::TYPE_GENERIC);
@@ -436,7 +436,7 @@ 
     public function patch(?string $id = null, ?string $uname = null, ?string $username = null, ?string $password = null, ?int $soft_quota = null, ?int $hard_quota = null, ?string $avatar = null, ?string $mail = null, ?bool $admin = false, ?string $namespace = null, ?string $locale = null, ?array $optional = null): Response
     {
         $attributes = compact('username', 'password', 'soft_quota', 'hard_quota', 'avatar', 'mail', 'admin', 'namespace', 'locale', 'optional');
-        $attributes = array_filter($attributes, function ($attribute) {return !is_null($attribute); });
+        $attributes = array_filter($attributes, function($attribute) {return !is_null($attribute); });
 
         if (isset($attributes['avatar'])) {
             $attributes['avatar'] = new Binary(base64_decode($attributes['avatar']), Binary::TYPE_GENERIC);

src/app/Balloon.App.Elasticsearch/Api/v2/Search.php

Doc Comments +1 added lines, -1 removed lines

@@ -107,7 +107,7 @@
      * @param array $query
      * @param array $attributes
      * @param int   $deleted
-     * @param mixed $limit
+     * @param integer $limit
      *
      * @return Response
      */

src/app/Balloon.App.Notification/Notifier.php

Doc Comments +4 added lines, -6 removed lines

@@ -71,7 +71,7 @@ 
      *
      * @param Database       $db
      * @param Server         $server
-     * @param LoggerInterace $logger
+     * @param LoggerInterface $logger
      * @param iterable       $config
      */
     public function __construct(Database $db, Server $server, LoggerInterface $logger, ?Iterable $config = null)
@@ -116,9 +116,7 @@ 
      *
      * @param iterable $receiver
      * @param User     $sender
-     * @param string   $subject
-     * @param string   $body
-     * @param array    $context
+     * @param string    $context
      *
      * @return bool
      */
@@ -226,10 +224,10 @@ 
     /**
      * Add notification.
      *
-     * @param array            $receiver
-     * @param User             $user
+     * @param User            $receiver
      * @param MessageInterface $message
      * @param array            $context
+     * @param User $sender
      *
      * @return ObjectId
      */

Spacing +2 added lines, -2 removed lines

@@ -404,7 +404,7 @@ 
 
             if ($node instanceof Collection && $recursive === true) {
                 $db = $this->db;
-                $node->doRecursiveAction(function ($child) use ($db, $subscription) {
+                $node->doRecursiveAction(function($child) use ($db, $subscription) {
                     $subscription['node_id'] = $child->getId();
                     $db->subscription->replaceOne(
                         [
@@ -430,7 +430,7 @@ 
 
             if ($node instanceof Collection && $recursive === true) {
                 $db = $this->db;
-                $node->doRecursiveAction(function ($child) use ($db, $node_id, $user_id) {
+                $node->doRecursiveAction(function($child) use ($db, $node_id, $user_id) {
                     $db->subscription->deleteOne([
                         'user' => $user_id,
                         'node' => $node_id,