gyselroth / balloon

src/app/Balloon.App.Api/v2/Groups.php

Spacing +2 added lines, -2 removed lines

@@ -270,7 +270,7 @@ 
         }
 
         $attributes = compact('namespace', 'optional');
-        $attributes = array_filter($attributes, function ($attribute) {return !is_null($attribute); });
+        $attributes = array_filter($attributes, function($attribute) {return !is_null($attribute); });
 
         $id = $this->server->addGroup($name, $member, $attributes);
         $result = $this->decorator->decorate($this->server->getGroupById($id));
@@ -309,7 +309,7 @@ 
     public function patch(string $id, ?array $member = null, ?string $namespace = null, ?array $optional = null): Response
     {
         $attributes = compact('namespace', 'optional', 'name', 'member');
-        $attributes = array_filter($attributes, function ($attribute) {return !is_null($attribute); });
+        $attributes = array_filter($attributes, function($attribute) {return !is_null($attribute); });
 
         $group = $this->_getGroup($id, true);
         $group->setAttributes($attributes);

src/app/Balloon.App.Api/v1/AttributeDecorator/RoleDecorator.php

Spacing +6 added lines, -6 removed lines

@@ -105,13 +105,13 @@ 
         }
 
         return [
-            'created' => function ($role, $requested) use ($attributes) {
+            'created' => function($role, $requested) use ($attributes) {
                 return $attributes['created']->toDateTime()->format('c');
             },
-            'changed' => function ($role, $requested) use ($attributes) {
+            'changed' => function($role, $requested) use ($attributes) {
                 return $attributes['changed']->toDateTime()->format('c');
             },
-            'deleted' => function ($role, $requested) use ($attributes) {
+            'deleted' => function($role, $requested) use ($attributes) {
                 if (false === $attributes['deleted']) {
                     return null;
                 }
@@ -164,14 +164,14 @@ 
             'name' => (string) $attributes['username'],
             'namespace' => (string) $attributes['namespace'],
             'mail' => (string) $attributes['mail'],
-            'avatar' => function ($role, $requested) use ($attributes) {
+            'avatar' => function($role, $requested) use ($attributes) {
                 if ($attributes['avatar'] instanceof Binary) {
                     return base64_encode($attributes['avatar']->getData());
                 }
 
                 return null;
             },
-            'soft_quota' => function ($role, $requested) use ($attributes, $user) {
+            'soft_quota' => function($role, $requested) use ($attributes, $user) {
                 if ($user === null) {
                     return null;
                 }
@@ -182,7 +182,7 @@ 
 
                 return null;
             },
-            'hard_quota' => function ($role, $requested) use ($attributes, $user) {
+            'hard_quota' => function($role, $requested) use ($attributes, $user) {
                 if ($user === null) {
                     return null;
                 }

Doc Comments +1 added lines, -1 removed lines

@@ -73,7 +73,7 @@
      * Add decorator.
      *
      *
-     * @return AttributeDecorator
+     * @return RoleDecorator
      */
     public function addDecorator(string $attribute, Closure $decorator): self
     {

src/app/Balloon.App.Api/v2/Nodes.php

Indentation +31 added lines, -31 removed lines

@@ -273,37 +273,37 @@ 
         }
 
         return $response
-          ->setOutputFormat(null)
-          ->setBody(function () use ($node, $offset, $limit) {
-              $stream = $node->get();
-              $name = $node->getName();
-
-              if (null === $stream) {
-                  return;
-              }
-
-              if (0 !== $offset) {
-                  if (fseek($stream, $offset) === -1) {
-                      throw new Exception\Conflict(
+            ->setOutputFormat(null)
+            ->setBody(function () use ($node, $offset, $limit) {
+                $stream = $node->get();
+                $name = $node->getName();
+
+                if (null === $stream) {
+                    return;
+                }
+
+                if (0 !== $offset) {
+                    if (fseek($stream, $offset) === -1) {
+                        throw new Exception\Conflict(
                         'invalid offset requested',
                         Exception\Conflict::INVALID_OFFSET
                     );
-                  }
-              }
-
-              $read = 0;
-              while (!feof($stream)) {
-                  if (0 !== $limit && $read + 8192 > $limit) {
-                      echo fread($stream, $limit - $read);
-                      exit();
-                  }
-
-                  echo fread($stream, 8192);
-                  $read += 8192;
-              }
-
-              exit();
-          });
+                    }
+                }
+
+                $read = 0;
+                while (!feof($stream)) {
+                    if (0 !== $limit && $read + 8192 > $limit) {
+                        echo fread($stream, $limit - $read);
+                        exit();
+                    }
+
+                    echo fread($stream, 8192);
+                    $read += 8192;
+                }
+
+                exit();
+            });
     }
 
     /**
@@ -1053,9 +1053,9 @@ 
                 $node->zip($archive);
             } catch (\Exception $e) {
                 $this->logger->debug('failed zip node in multi node request ['.$node->getId().']', [
-                   'category' => get_class($this),
-                   'exception' => $e,
-               ]);
+                    'category' => get_class($this),
+                    'exception' => $e,
+                ]);
             }
         }
 

Spacing +8 added lines, -8 removed lines

@@ -187,7 +187,7 @@ 
             }
         }
 
-        return $this->bulk($id, $p, function ($node) use ($parent, $conflict, $move) {
+        return $this->bulk($id, $p, function($node) use ($parent, $conflict, $move) {
             if (true === $move) {
                 $node = $node->setParent($parent, $conflict);
             }
@@ -274,7 +274,7 @@ 
 
         return $response
           ->setOutputFormat(null)
-          ->setBody(function () use ($node, $offset, $limit) {
+          ->setBody(function() use ($node, $offset, $limit) {
               $stream = $node->get();
               $name = $node->getName();
 
@@ -410,7 +410,7 @@ 
             return (new Response())->setCode(200)->setBody($result);
         }
 
-        return $this->bulk($id, $p, function ($node) use ($attributes) {
+        return $this->bulk($id, $p, function($node) use ($attributes) {
             return [
                 'code' => 200,
                 'data' => $this->node_decorator->decorate($node, $attributes),
@@ -524,9 +524,9 @@ 
     public function patch(?string $name = null, ?array $meta = null, ?bool $readonly = null, ?array $filter = null, ?string $id = null, ?string $p = null): Response
     {
         $attributes = compact('name', 'meta', 'readonly', 'filter');
-        $attributes = array_filter($attributes, function ($attribute) {return !is_null($attribute); });
+        $attributes = array_filter($attributes, function($attribute) {return !is_null($attribute); });
 
-        return $this->bulk($id, $p, function ($node) use ($attributes) {
+        return $this->bulk($id, $p, function($node) use ($attributes) {
             foreach ($attributes as $attribute => $value) {
                 switch ($attribute) {
                     case 'name':
@@ -608,7 +608,7 @@ 
             );
         }
 
-        return $this->bulk($id, $p, function ($node) use ($parent, $conflict) {
+        return $this->bulk($id, $p, function($node) use ($parent, $conflict) {
             $result = $node->copyTo($parent, $conflict);
 
             return [
@@ -672,7 +672,7 @@ 
             );
         }
 
-        return $this->bulk($id, $p, function ($node) use ($parent, $conflict) {
+        return $this->bulk($id, $p, function($node) use ($parent, $conflict) {
             $result = $node->setParent($parent, $conflict);
 
             return [
@@ -726,7 +726,7 @@ 
             $at = $this->_verifyAttributes(['destroy' => $at])['destroy'];
         }
 
-        return $this->bulk($id, $p, function ($node) use ($force, $ignore_flag, $at) {
+        return $this->bulk($id, $p, function($node) use ($force, $ignore_flag, $at) {
             if (null === $at) {
                 $node->delete($force && $node->isDeleted() || $force && $ignore_flag);
             } else {

src/app/Balloon.App.Api/Controller.php

Doc Comments +2 added lines, -2 removed lines

@@ -210,7 +210,7 @@ 
      * @param string $class      Force set node type
      * @param bool   $multiple   Allow $id to be an array
      * @param bool   $allow_root Allow instance of root collection
-     * @param bool   $deleted    How to handle deleted node
+     * @param integer   $deleted    How to handle deleted node
      */
     protected function _getNode(
         ?string $id = null,
@@ -242,7 +242,7 @@ 
      * @param string $id
      * @param string $path
      * @param string $class   Force set node type
-     * @param bool   $deleted How to handle deleted node
+     * @param integer   $deleted How to handle deleted node
      */
     protected function _getNodes(
         $id = null,

src/app/Balloon.App.Api/v1/AttributeDecorator/NodeDecorator.php

Doc Comments +1 added lines, -1 removed lines

@@ -86,7 +86,7 @@
      * Add decorator.
      *
      *
-     * @return AttributeDecorator
+     * @return NodeDecorator
      */
     public function addDecorator(string $attribute, Closure $decorator): self
     {

Spacing +11 added lines, -11 removed lines

@@ -127,20 +127,20 @@ 
             'mime' => (string) $attributes['mime'],
             'readonly' => (bool) $attributes['readonly'],
             'directory' => $node instanceof Collection,
-            'meta' => function ($node) {
+            'meta' => function($node) {
                 return (object) $node->getMetaAttributes();
             },
-            'size' => function ($node) {
+            'size' => function($node) {
                 return $node->getSize();
             },
-            'path' => function ($node) {
+            'path' => function($node) {
                 try {
                     return $node->getPath();
                 } catch (\Exception $e) {
                     return null;
                 }
             },
-            'parent' => function ($node) {
+            'parent' => function($node) {
                 $id = $node->getAttributes()['parent'];
 
                 if (null === $id) {
@@ -149,10 +149,10 @@ 
 
                 return (string) $id;
             },
-            'access' => function ($node) use ($acl) {
+            'access' => function($node) use ($acl) {
                 return $acl->getAclPrivilege($node);
             },
-            'share' => function ($node) {
+            'share' => function($node) {
                 if (!$node->isShared() && !$node->isSpecial()) {
                     return false;
                 }
@@ -163,7 +163,7 @@ 
                     return false;
                 }
             },
-            'shareowner' => function ($node) use ($server, $fs) {
+            'shareowner' => function($node) use ($server, $fs) {
                 if (!$node->isSpecial()) {
                     return null;
                 }
@@ -206,20 +206,20 @@ 
     protected function getTimeAttributes(NodeInterface $node, array $attributes): array
     {
         return [
-            'created' => function ($node) use ($attributes) {
+            'created' => function($node) use ($attributes) {
                 return $this->dateTimeToUnix($attributes['created']);
             },
-            'changed' => function ($node) use ($attributes) {
+            'changed' => function($node) use ($attributes) {
                 return $this->dateTimeToUnix($attributes['changed']);
             },
-            'deleted' => function ($node) use ($attributes) {
+            'deleted' => function($node) use ($attributes) {
                 if (false === $attributes['deleted']) {
                     return false;
                 }
 
                 return $this->dateTimeToUnix($attributes['deleted']);
             },
-            'destroy' => function ($node) use ($attributes) {
+            'destroy' => function($node) use ($attributes) {
                 if (null === $attributes['destroy']) {
                     return null;
                 }

src/app/Balloon.App.Api/v1/File.php

Doc Comments +1 added lines, -1 removed lines

@@ -115,7 +115,7 @@
      *
      * @param string $id
      * @param string $p
-     * @param string $version
+     * @param integer $version
      */
     public function postRestore(int $version, ?string $id = null, ?string $p = null): Response
     {

src/app/Balloon.App.Notification/Hook/NewShareAdded.php

Doc Comments +2 added lines, -2 removed lines

@@ -46,7 +46,7 @@ 
     /**
      * Constructor.
      *
-     * @param Notification $notifier
+     * @param Notifier $notifier
      */
     public function __construct(Notifier $notifier, Server $server, LoggerInterface $logger)
     {
@@ -106,7 +106,7 @@ 
      * Check if users needs a notification and checks if mail adress is available.
      *
      *
-     * @return string
+     * @return boolean
      */
     protected function checkNotify(NodeInterface $node, User $user): bool
     {

Unused Use Statements -1 removed lines

@@ -12,7 +12,6 @@
 namespace Balloon\App\Notification\Hook;
 
 use Balloon\App\Notification\Notifier;
-use Balloon\Async\Mail;
 use Balloon\Filesystem\Node\Collection;
 use Balloon\Filesystem\Node\NodeInterface;
 use Balloon\Hook\AbstractHook;

src/lib/Filesystem.php

Doc Comments +2 added lines, -2 removed lines

@@ -281,7 +281,7 @@ 
      * Load nodes by id.
      *
      * @param string $class   Force check node type
-     * @param bool   $deleted
+     * @param integer   $deleted
      */
     public function findNodesById(array $id = [], ?string $class = null, int $deleted = NodeInterface::DELETED_INCLUDE): Generator
     {
@@ -402,7 +402,7 @@ 
      * @param string $class      Force set node type
      * @param bool   $multiple   Allow $id to be an array
      * @param bool   $allow_root Allow instance of root collection
-     * @param bool   $deleted    How to handle deleted node
+     * @param integer   $deleted    How to handle deleted node
      */
     public function getNode($id = null, $path = null, $class = null, bool $multiple = false, bool $allow_root = false, int $deleted = NodeInterface::DELETED_EXCLUDE): NodeInterface
     {

src/lib/Filesystem/Delta.php

Doc Comments +1 added lines

@@ -344,6 +344,7 @@
 
     /**
      * Get delta feed filter.
+     * @param NodeInterface|null $node
      */
     protected function buildDeltaFeedFilter(array $cursor, int $limit, ?NodeInterface $node): array
     {