Completed
Pull Request — master (#141)
by Raffael
15:37 queued 10:36
created
src/lib/Server/Group.php 1 patch
Doc Comments   +2 added lines patch added patch discarded remove patch
@@ -265,6 +265,8 @@
 block discarded – undo
265 265
     /**
266 266
      * Get resolved member.
267 267
      *
268
+     * @param integer $offset
269
+     * @param integer $limit
268 270
      * @return Generator
269 271
      */
270 272
     public function getResolvedMembers(?int $offset = null, ?int $limit = null): ?Generator
Please login to merge, or discard this patch.
src/lib/Server/User.php 1 patch
Doc Comments   +2 added lines patch added patch discarded remove patch
@@ -722,6 +722,8 @@
 block discarded – undo
722 722
     /**
723 723
      * Get resolved groups.
724 724
      *
725
+     * @param integer $offset
726
+     * @param integer $limit
725 727
      * @return Generator
726 728
      */
727 729
     public function getResolvedGroups(?int $offset = null, ?int $limit = null): ?Generator
Please login to merge, or discard this patch.
src/lib/Filesystem/Node/AbstractNode.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -629,7 +629,7 @@
 block discarded – undo
629 629
             return true;
630 630
         }
631 631
 
632
-        return $this->doRecursiveAction(function ($node) use ($conflict, $recursion) {
632
+        return $this->doRecursiveAction(function($node) use ($conflict, $recursion) {
633 633
             $node->undelete($conflict, $recursion, false);
634 634
         }, NodeInterface::DELETED_ONLY);
635 635
     }
Please login to merge, or discard this patch.
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -1044,6 +1044,7 @@
 block discarded – undo
1044 1044
 
1045 1045
     /**
1046 1046
      * Duplicate name with a uniqid within name.
1047
+     * @param string $name
1047 1048
      */
1048 1049
     protected function getDuplicateName(?string $name = null, ?string $class = null): string
1049 1050
     {
Please login to merge, or discard this patch.
src/lib/Filesystem/Node/File.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -45,14 +45,14 @@
 block discarded – undo
45 45
      * @param array
46 46
      **/
47 47
     protected $temp_files = [
48
-        '/^\._(.*)$/',     // OS/X resource forks
49
-        '/^.DS_Store$/',   // OS/X custom folder settings
48
+        '/^\._(.*)$/', // OS/X resource forks
49
+        '/^.DS_Store$/', // OS/X custom folder settings
50 50
         '/^desktop.ini$/', // Windows custom folder settings
51
-        '/^Thumbs.db$/',   // Windows thumbnail cache
52
-        '/^.(.*).swpx$/',  // ViM temporary files
53
-        '/^.(.*).swx$/',   // ViM temporary files
54
-        '/^.(.*).swp$/',   // ViM temporary files
55
-        '/^\.dat(.*)$/',   // Smultron seems to create these
51
+        '/^Thumbs.db$/', // Windows thumbnail cache
52
+        '/^.(.*).swpx$/', // ViM temporary files
53
+        '/^.(.*).swx$/', // ViM temporary files
54
+        '/^.(.*).swp$/', // ViM temporary files
55
+        '/^\.dat(.*)$/', // Smultron seems to create these
56 56
         '/^~lock.(.*)#$/', // Windows 7 lockfiles
57 57
     ];
58 58
 
Please login to merge, or discard this patch.
src/lib/Filesystem/Node/Collection.php 2 patches
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -386,7 +386,7 @@  discard block
 block discarded – undo
386 386
         $this->deleted = new UTCDateTime();
387 387
 
388 388
         if (!$this->isReference()) {
389
-            $this->doRecursiveAction(function ($node) use ($recursion) {
389
+            $this->doRecursiveAction(function($node) use ($recursion) {
390 390
                 $node->delete(false, $recursion, false);
391 391
             }, NodeInterface::DELETED_EXCLUDE);
392 392
         }
@@ -936,7 +936,7 @@  discard block
 block discarded – undo
936 936
     protected function _forceDelete(?string $recursion = null, bool $recursion_first = true): bool
937 937
     {
938 938
         if (!$this->isReference()) {
939
-            $this->doRecursiveAction(function ($node) use ($recursion) {
939
+            $this->doRecursiveAction(function($node) use ($recursion) {
940 940
                 $node->delete(true, $recursion, false);
941 941
             }, NodeInterface::DELETED_INCLUDE);
942 942
         }
Please login to merge, or discard this patch.
Doc Comments   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -257,7 +257,7 @@  discard block
 block discarded – undo
257 257
     /**
258 258
      * Get real id (reference).
259 259
      *
260
-     * @return ObjectId
260
+     * @return ObjectId|null
261 261
      */
262 262
     public function getRealId(): ?ObjectId
263 263
     {
@@ -639,6 +639,7 @@  discard block
 block discarded – undo
639 639
 
640 640
     /**
641 641
      * Create new file as a child from this collection.
642
+     * @param string $name
642 643
      */
643 644
     public function addFile($name, ?ObjectId $session = null, array $attributes = [], int $conflict = NodeInterface::CONFLICT_NOACTION, bool $clone = false): File
644 645
     {
Please login to merge, or discard this patch.
src/lib/Filesystem/Node/AttributeDecorator.php 2 patches
Spacing   +14 added lines, -14 removed lines patch added patch discarded remove patch
@@ -131,20 +131,20 @@  discard block
 block discarded – undo
131 131
             'mime' => (string) $attributes['mime'],
132 132
             'readonly' => (bool) $attributes['readonly'],
133 133
             'directory' => $node instanceof Collection,
134
-            'meta' => function ($node) {
134
+            'meta' => function($node) {
135 135
                 return (object) $node->getMetaAttributes();
136 136
             },
137
-            'size' => function ($node) {
137
+            'size' => function($node) {
138 138
                 return $node->getSize();
139 139
             },
140
-            'path' => function ($node) {
140
+            'path' => function($node) {
141 141
                 try {
142 142
                     return $node->getPath();
143 143
                 } catch (\Exception $e) {
144 144
                     return null;
145 145
                 }
146 146
             },
147
-            'parent' => function ($node) {
147
+            'parent' => function($node) {
148 148
                 $parent = $node->getParent();
149 149
 
150 150
                 if (null === $parent || $parent->isRoot()) {
@@ -153,10 +153,10 @@  discard block
 block discarded – undo
153 153
 
154 154
                 return $this->decorate($node->getParent(), ['id', 'name', '_links']);
155 155
             },
156
-            'access' => function ($node) use ($acl) {
156
+            'access' => function($node) use ($acl) {
157 157
                 return $acl->getAclPrivilege($node);
158 158
             },
159
-            'share' => function ($node) {
159
+            'share' => function($node) {
160 160
                 if ($node->isShared() || !$node->isSpecial()) {
161 161
                     return null;
162 162
                 }
@@ -167,7 +167,7 @@  discard block
 block discarded – undo
167 167
                     return null;
168 168
                 }
169 169
             },
170
-            'sharename' => function ($node) {
170
+            'sharename' => function($node) {
171 171
                 if (!$node->isShared()) {
172 172
                     return null;
173 173
                 }
@@ -178,7 +178,7 @@  discard block
 block discarded – undo
178 178
                     return null;
179 179
                 }
180 180
             },
181
-            'shareowner' => function ($node) use ($server, $fs, $decorator) {
181
+            'shareowner' => function($node) use ($server, $fs, $decorator) {
182 182
                 if (!$node->isSpecial()) {
183 183
                     return null;
184 184
                 }
@@ -192,7 +192,7 @@  discard block
 block discarded – undo
192 192
                     return null;
193 193
                 }
194 194
             },
195
-            'owner' => function ($node) use ($server, $decorator) {
195
+            'owner' => function($node) use ($server, $decorator) {
196 196
                 try {
197 197
                     return $decorator->decorate(
198 198
                         $server->getUserById($node->getOwner()),
@@ -216,20 +216,20 @@  discard block
 block discarded – undo
216 216
     protected function getTimeAttributes(NodeInterface $node, array $attributes): array
217 217
     {
218 218
         return [
219
-            'created' => function ($node) use ($attributes) {
219
+            'created' => function($node) use ($attributes) {
220 220
                 return $attributes['created']->toDateTime()->format('c');
221 221
             },
222
-            'changed' => function ($node) use ($attributes) {
222
+            'changed' => function($node) use ($attributes) {
223 223
                 return $attributes['changed']->toDateTime()->format('c');
224 224
             },
225
-            'deleted' => function ($node) use ($attributes) {
225
+            'deleted' => function($node) use ($attributes) {
226 226
                 if (false === $attributes['deleted']) {
227 227
                     return null;
228 228
                 }
229 229
 
230 230
                 return $attributes['deleted']->toDateTime()->format('c');
231 231
             },
232
-            'destroy' => function ($node) use ($attributes) {
232
+            'destroy' => function($node) use ($attributes) {
233 233
                 if (null === $attributes['destroy']) {
234 234
                     return null;
235 235
                 }
@@ -262,7 +262,7 @@  discard block
 block discarded – undo
262 262
         return [
263 263
             'shared' => $node->isShared(),
264 264
             'reference' => $node->isReference(),
265
-            'filter' => function ($node) use ($attributes) {
265
+            'filter' => function($node) use ($attributes) {
266 266
                 if (null === $attributes['filter']) {
267 267
                     return null;
268 268
                 }
Please login to merge, or discard this patch.
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -58,7 +58,7 @@
 block discarded – undo
58 58
     /**
59 59
      * Init.
60 60
      *
61
-     * @param Decorator $role_decorator
61
+     * @param RoleAttributeDecorator $role_decorator
62 62
      */
63 63
     public function __construct(Server $server, Acl $acl, RoleAttributeDecorator $role_decorator)
64 64
     {
Please login to merge, or discard this patch.
src/lib/Bootstrap/Cli.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -171,7 +171,7 @@
 block discarded – undo
171 171
      */
172 172
     protected function setExceptionHandler(): self
173 173
     {
174
-        set_exception_handler(function ($e) {
174
+        set_exception_handler(function($e) {
175 175
             $this->logger->emergency('uncaught exception: '.$e->getMessage(), [
176 176
                 'category' => get_class($this),
177 177
                 'exception' => $e,
Please login to merge, or discard this patch.
src/lib/Bootstrap/Http.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -85,7 +85,7 @@  discard block
 block discarded – undo
85 85
 
86 86
         if ($this->auth->requireOne()) {
87 87
             if (!($this->auth->getIdentity()->getAdapter() instanceof AuthNone)) {
88
-                $this->auth->getIdentity()->getAttributeMap()->addMapper('binary', function ($value) {
88
+                $this->auth->getIdentity()->getAttributeMap()->addMapper('binary', function($value) {
89 89
                     return new Binary($value, Binary::TYPE_GENERIC);
90 90
                 });
91 91
 
@@ -138,7 +138,7 @@  discard block
 block discarded – undo
138 138
      */
139 139
     protected function setExceptionHandler(): self
140 140
     {
141
-        set_exception_handler(function ($e) {
141
+        set_exception_handler(function($e) {
142 142
             $this->logger->emergency('uncaught exception: '.$e->getMessage(), [
143 143
                 'category' => get_class($this),
144 144
                 'exception' => $e,
Please login to merge, or discard this patch.
src/lib/Bootstrap/AbstractBootstrap.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -42,7 +42,7 @@
 block discarded – undo
42 42
      */
43 43
     protected function setErrorHandler(): self
44 44
     {
45
-        set_error_handler(function ($severity, $message, $file, $line) {
45
+        set_error_handler(function($severity, $message, $file, $line) {
46 46
             $log = $message.' in '.$file.':'.$line;
47 47
 
48 48
             switch ($severity) {
Please login to merge, or discard this patch.