gyselroth / balloon

src/app/Balloon.App.Sharelink/Constructor/Http.php

Spacing +4 added lines, -4 removed lines

@@ -65,13 +65,13 @@ 
             }
         });
 
-        $node_decorator_v2->addDecorator('sharelink_has_password', function ($node) use ($sharelink) {
+        $node_decorator_v2->addDecorator('sharelink_has_password', function($node) use ($sharelink) {
             $attributes = $sharelink->getSharelink($node);
 
             return isset($attributes['password']);
         });
 
-        $node_decorator_v2->addDecorator('sharelink_token', function ($node) use ($sharelink) {
+        $node_decorator_v2->addDecorator('sharelink_token', function($node) use ($sharelink) {
             $attributes = $sharelink->getSharelink($node);
 
             if (isset($attributes['token'])) {
@@ -79,7 +79,7 @@ 
             }
         });
 
-        $node_decorator_v2->addDecorator('sharelink_expire', function ($node) use ($sharelink) {
+        $node_decorator_v2->addDecorator('sharelink_expire', function($node) use ($sharelink) {
             $attributes = $sharelink->getSharelink($node);
 
             if (isset($attributes['expiration'])) {
@@ -89,7 +89,7 @@ 
             }
         });
 
-        $node_decorator_v1->addDecorator('sharelink', function ($node) use ($sharelink) {
+        $node_decorator_v1->addDecorator('sharelink', function($node) use ($sharelink) {
             return isset($sharelink->getSharelink($node)['token']);
         });
 

src/app/Balloon.App.Api/v1/Node.php

Doc Comments +2 added lines, -2 removed lines

@@ -210,7 +210,7 @@ 
      * @param string $class      Force set node type
      * @param bool   $multiple   Allow $id to be an array
      * @param bool   $allow_root Allow instance of root collection
-     * @param bool   $deleted    How to handle deleted node
+     * @param integer   $deleted    How to handle deleted node
      */
     protected function _getNode(
         ?string $id = null,
@@ -242,7 +242,7 @@ 
      * @param string $id
      * @param string $path
      * @param string $class   Force set node type
-     * @param bool   $deleted How to handle deleted node
+     * @param integer   $deleted How to handle deleted node
      */
     protected function _getNodes(
         $id = null,

Spacing +8 added lines, -8 removed lines

@@ -183,7 +183,7 @@ 
             }
         }
 
-        return $this->bulk($id, $p, function ($node) use ($parent, $conflict, $move) {
+        return $this->bulk($id, $p, function($node) use ($parent, $conflict, $move) {
             if (true === $move) {
                 $node = $node->setParent($parent, $conflict);
             }
@@ -260,7 +260,7 @@ 
 
         $node = $this->_getNode($id, $p);
         if ($node instanceof Collection) {
-            return (new Response())->setBody(function () use ($node) {
+            return (new Response())->setBody(function() use ($node) {
                 $node->getZip();
             });
         }
@@ -278,7 +278,7 @@ 
         }
 
         return $response->setOutputFormat(null)
-          ->setBody(function () use ($node, $encode, $offset, $length) {
+          ->setBody(function() use ($node, $encode, $offset, $length) {
               $mime = $node->getContentType();
               $stream = $node->get();
               $name = $node->getName();
@@ -349,7 +349,7 @@ 
      */
     public function postReadonly($id = null, $p = null, bool $readonly = true): Response
     {
-        return $this->bulk($id, $p, function ($node) use ($readonly) {
+        return $this->bulk($id, $p, function($node) use ($readonly) {
             $node->setReadonly($readonly);
 
             return ['status' => 204];
@@ -594,7 +594,7 @@ 
      */
     public function postMetaAttributes(?string $id = null, ?string $p = null): Response
     {
-        return $this->bulk($id, $p, function ($node) {
+        return $this->bulk($id, $p, function($node) {
             $node->setMetaAttributes($_POST);
 
             return ['status' => 204];
@@ -676,7 +676,7 @@ 
             );
         }
 
-        return $this->bulk($id, $p, function ($node) use ($parent, $conflict) {
+        return $this->bulk($id, $p, function($node) use ($parent, $conflict) {
             $result = $node->copyTo($parent, $conflict);
 
             return [
@@ -737,7 +737,7 @@ 
             );
         }
 
-        return $this->bulk($id, $p, function ($node) use ($parent, $conflict) {
+        return $this->bulk($id, $p, function($node) use ($parent, $conflict) {
             $result = $node->setParent($parent, $conflict);
             if (NodeInterface::CONFLICT_RENAME === $conflict) {
                 return [
@@ -792,7 +792,7 @@ 
             $at = $this->_verifyAttributes(['destroy' => $at])['destroy'];
         }
 
-        return $this->bulk($id, $p, function ($node) use ($force, $ignore_flag, $at) {
+        return $this->bulk($id, $p, function($node) use ($force, $ignore_flag, $at) {
             if (null === $at) {
                 $node->delete($force && $node->isDeleted() || $force && $ignore_flag);
             } else {

Indentation +45 added lines, -45 removed lines

@@ -287,49 +287,49 @@ 
         }
 
         return $response->setOutputFormat(null)
-          ->setBody(function () use ($node, $encode, $offset, $length) {
-              $mime = $node->getContentType();
-              $stream = $node->get();
-              $name = $node->getName();
-
-              if (null === $stream) {
-                  return;
-              }
-
-              if (0 !== $offset) {
-                  if (fseek($stream, $offset) === -1) {
-                      throw new Exception\Conflict(
-                          'invalid offset requested',
-                          Exception\Conflict::INVALID_OFFSET
+            ->setBody(function () use ($node, $encode, $offset, $length) {
+                $mime = $node->getContentType();
+                $stream = $node->get();
+                $name = $node->getName();
+
+                if (null === $stream) {
+                    return;
+                }
+
+                if (0 !== $offset) {
+                    if (fseek($stream, $offset) === -1) {
+                        throw new Exception\Conflict(
+                            'invalid offset requested',
+                            Exception\Conflict::INVALID_OFFSET
                     );
-                  }
-              }
-
-              $read = 0;
-              header('Content-Type: '.$mime.'');
-              if ('base64' === $encode) {
-                  header('Content-Encoding: base64');
-                  while (!feof($stream)) {
-                      if (0 !== $length && $read + 8192 > $length) {
-                          echo base64_encode(fread($stream, $length - $read));
-                          exit();
-                      }
-
-                      echo base64_encode(fread($stream, 8192));
-                      $read += 8192;
-                  }
-              } else {
-                  while (!feof($stream)) {
-                      if (0 !== $length && $read + 8192 > $length) {
-                          echo fread($stream, $length - $read);
-                          exit();
-                      }
-
-                      echo fread($stream, 8192);
-                      $read += 8192;
-                  }
-              }
-          });
+                    }
+                }
+
+                $read = 0;
+                header('Content-Type: '.$mime.'');
+                if ('base64' === $encode) {
+                    header('Content-Encoding: base64');
+                    while (!feof($stream)) {
+                        if (0 !== $length && $read + 8192 > $length) {
+                            echo base64_encode(fread($stream, $length - $read));
+                            exit();
+                        }
+
+                        echo base64_encode(fread($stream, 8192));
+                        $read += 8192;
+                    }
+                } else {
+                    while (!feof($stream)) {
+                        if (0 !== $length && $read + 8192 > $length) {
+                            echo fread($stream, $length - $read);
+                            exit();
+                        }
+
+                        echo fread($stream, 8192);
+                        $read += 8192;
+                    }
+                }
+            });
     }
 
     /**
@@ -1330,9 +1330,9 @@ 
                 $node->zip($archive);
             } catch (\Exception $e) {
                 $this->logger->debug('failed zip node in multi node request ['.$node->getId().']', [
-                   'category' => get_class($this),
-                   'exception' => $e,
-               ]);
+                    'category' => get_class($this),
+                    'exception' => $e,
+                ]);
             }
         }
 

src/app/Balloon.App.Notification/Api/v2/Notifications.php

Indentation +3 added lines, -3 removed lines

@@ -256,9 +256,9 @@
         $body->setParts([$html, $plain]);
 
         $mail = (new Message())
-          ->setSubject($message->getSubject())
-          ->setBody($body)
-          ->setEncoding('UTF-8');
+            ->setSubject($message->getSubject())
+            ->setBody($body)
+            ->setEncoding('UTF-8');
 
         $type = $mail->getHeaders()->get('Content-Type');
         $type->setType('multipart/alternative');

src/app/Balloon.App.Api/v2/Users.php

Spacing +2 added lines, -2 removed lines

@@ -370,7 +370,7 @@ 
         }
 
         $attributes = compact('password', 'soft_quota', 'hard_quota', 'avatar', 'mail', 'admin', 'namespace', 'locale', 'optional');
-        $attributes = array_filter($attributes, function ($attribute) {return !is_null($attribute); });
+        $attributes = array_filter($attributes, function($attribute) {return !is_null($attribute); });
 
         if (isset($attributes['avatar'])) {
             $attributes['avatar'] = new Binary(base64_decode($attributes['avatar']), Binary::TYPE_GENERIC);
@@ -415,7 +415,7 @@ 
     public function patch(?string $id = null, ?string $uname = null, ?string $username = null, ?string $password = null, ?int $soft_quota = null, ?int $hard_quota = null, ?string $avatar = null, ?string $mail = null, ?bool $admin = null, ?string $namespace = null, ?string $locale = null, ?array $optional = null): Response
     {
         $attributes = compact('username', 'password', 'soft_quota', 'hard_quota', 'avatar', 'mail', 'admin', 'namespace', 'locale', 'optional');
-        $attributes = array_filter($attributes, function ($attribute) {return !is_null($attribute); });
+        $attributes = array_filter($attributes, function($attribute) {return !is_null($attribute); });
 
         if (isset($attributes['avatar'])) {
             $attributes['avatar'] = new Binary(base64_decode($attributes['avatar']), Binary::TYPE_GENERIC);

src/app/Balloon.App.Office/Session.php

Doc Comments +1 added lines, -1 removed lines

@@ -137,7 +137,7 @@
      * Get Session.
      *
      *
-     * @return Session
+     * @return Session|null
      */
     public static function getByAccessToken(Server $server, ObjectId $session_id, string $access_token): self
     {

src/lib/Migration/Delta/Md5BlobIgnoreNull.php

Unused Use Statements -1 removed lines

@@ -12,7 +12,6 @@
 namespace Balloon\Migration\Delta;
 
 use MongoDB\Database;
-use MongoDB\Driver\Exception\CommandException;
 use MongoDB\Driver\Exception\RuntimeException;
 
 class Md5BlobIgnoreNull implements DeltaInterface

src/lib/Filesystem/Acl.php

Indentation +3 added lines, -3 removed lines

@@ -236,8 +236,8 @@ 
             $share = $node->getFilesystem()->findRawNode($node->getShareId());
         } catch (\Exception $e) {
             $this->logger->error('could not find share node ['.$node->getShareId().'] for reference ['.$node->getId().'], dead reference?', [
-                 'category' => get_class($this),
-                 'exception' => $e,
+                    'category' => get_class($this),
+                    'exception' => $e,
             ]);
 
             return self::PRIVILEGE_DENY;
@@ -245,7 +245,7 @@ 
 
         if ($share['deleted'] instanceof UTCDateTime || true !== $share['shared']) {
             $this->logger->error('share node ['.$share['_id'].'] has been deleted, dead reference?', [
-                 'category' => get_class($this),
+                    'category' => get_class($this),
             ]);
 
             return self::PRIVILEGE_DENY;

src/lib/Server/AttributeDecorator.php

Spacing +6 added lines, -6 removed lines

@@ -92,13 +92,13 @@ 
         }
 
         return [
-            'created' => function ($role) use ($attributes) {
+            'created' => function($role) use ($attributes) {
                 return $attributes['created']->toDateTime()->format('c');
             },
-            'changed' => function ($role) use ($attributes) {
+            'changed' => function($role) use ($attributes) {
                 return $attributes['changed']->toDateTime()->format('c');
             },
-            'deleted' => function ($role) use ($attributes) {
+            'deleted' => function($role) use ($attributes) {
                 if (false === $attributes['deleted']) {
                     return null;
                 }
@@ -146,7 +146,7 @@ 
             'name' => (string) $attributes['username'],
             'admin' => (bool) $attributes['admin'],
             'namespace' => isset($attributes['namespace']) ? (string) $attributes['namespace'] : null,
-            'mail' => function ($role) use ($attributes, $user) {
+            'mail' => function($role) use ($attributes, $user) {
                 if (!isset($attributes['mail'])) {
                     return null;
                 }
@@ -160,7 +160,7 @@ 
             'locale' => isset($attributes['locale']) ? (string) $attributes['locale'] : null,
             'hard_quota' => isset($attributes['hard_quota']) ? (int) $attributes['hard_quota'] : null,
             'soft_quota' => isset($attributes['soft_quota']) ? (int) $attributes['soft_quota'] : null,
-            'available' => function ($role) use (&$quota, $attributes, $user) {
+            'available' => function($role) use (&$quota, $attributes, $user) {
                 $quota === null ? $quota = $role->getQuotaUsage() : null;
                 if ($attributes['_id'] == $user->getId() || $user->isAdmin()) {
                     return $quota['available'];
@@ -168,7 +168,7 @@ 
 
                 return null;
             },
-            'used' => function ($role) use (&$quota, $attributes, $user) {
+            'used' => function($role) use (&$quota, $attributes, $user) {
                 $quota === null ? $quota = $role->getQuotaUsage() : null;
                 if ($attributes['_id'] == $user->getId() || $user->isAdmin()) {
                     return $quota['used'];

src/app/Balloon.App.Notification/Notifier.php

Spacing +2 added lines, -2 removed lines

@@ -348,7 +348,7 @@ 
 
             if ($node instanceof Collection && $recursive === true) {
                 $db = $this->db;
-                $node->doRecursiveAction(function ($child) use ($db, $subscription) {
+                $node->doRecursiveAction(function($child) use ($db, $subscription) {
                     $subscription['node'] = $child->getId();
                     $db->subscription->replaceOne(
                         [
@@ -374,7 +374,7 @@ 
 
             if ($node instanceof Collection && $recursive === true) {
                 $db = $this->db;
-                $node->doRecursiveAction(function ($child) use ($db, $node_id, $user_id) {
+                $node->doRecursiveAction(function($child) use ($db, $node_id, $user_id) {
                     $db->subscription->deleteOne([
                         'user' => $user_id,
                         'node' => $node_id,

Doc Comments +5 added lines

@@ -93,6 +93,7 @@ 
 
     /**
      * Send notification.
+     * @param User $sender
      */
     public function notify(Iterable $receiver, ?User $sender, MessageInterface $message): bool
     {
@@ -180,6 +181,7 @@ 
 
     /**
      * Add notification.
+     * @param User $sender
      */
     public function postNotification(User $receiver, ?User $sender, MessageInterface $message): ObjectId
     {
@@ -206,6 +208,8 @@ 
 
     /**
      * Get notifications.
+     * @param integer $offset
+     * @param integer $limit
      */
     public function getNotifications(User $user, ?int $offset = null, ?int $limit = null, ?int &$total = null): Iterable
     {
@@ -278,6 +282,7 @@ 
 
     /**
      * Get subscription.
+     * @return NodeInterface
      */
     public function getSubscription(NodeInterface $node, User $user): ?array
     {