gyselroth / balloon

src/app/Balloon.App.Preview/Hook.php

Unused Use Statements -1 removed lines

@@ -12,7 +12,6 @@
 
 namespace Balloon\App\Preview;
 
-use Balloon\Exception;
 use Balloon\Filesystem\Node\File;
 use Balloon\Hook\AbstractHook;
 use MongoDB\GridFS\Exception\FileNotFoundException;

Spacing +1 added lines, -1 removed lines

@@ -1,6 +1,6 @@
 <?php
 
-declare(strict_types=1);
+declare(strict_types = 1);
 
 /**
  * balloon

src/lib/Filesystem/Node/File.php

Doc Comments +2 added lines, -2 removed lines

@@ -694,7 +694,7 @@ 
      * @param string $path
      * @param bool   $new
      *
-     * @return bool
+     * @return string
      */
     protected function verifyFile(?string $path, bool $new = false): string
     {
@@ -827,7 +827,7 @@ 
     /**
      * Finalize put request.
      *
-     * @param resource|string $file
+     * @param string|null $file
      * @param bool            $new
      * @param array           $attributes
      *

Indentation +1 added lines, -1 removed lines

@@ -589,7 +589,7 @@
         ]);
 
         $this->addVersion($attributes)
-             ->postPutFile($file, $new, $attributes);
+                ->postPutFile($file, $new, $attributes);
 
         return $this->version;
     }

Spacing +13 added lines, -13 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare(strict_types=1);
+declare(strict_types = 1);
 
 /**
  * balloon
@@ -44,14 +44,14 @@ 
      * @param array
      **/
     protected $temp_files = [
-        '/^\._(.*)$/',     // OS/X resource forks
-        '/^.DS_Store$/',   // OS/X custom folder settings
+        '/^\._(.*)$/', // OS/X resource forks
+        '/^.DS_Store$/', // OS/X custom folder settings
         '/^desktop.ini$/', // Windows custom folder settings
-        '/^Thumbs.db$/',   // Windows thumbnail cache
-        '/^.(.*).swpx$/',  // ViM temporary files
-        '/^.(.*).swx$/',   // ViM temporary files
-        '/^.(.*).swp$/',   // ViM temporary files
-        '/^\.dat(.*)$/',   // Smultron seems to create these
+        '/^Thumbs.db$/', // Windows thumbnail cache
+        '/^.(.*).swpx$/', // ViM temporary files
+        '/^.(.*).swx$/', // ViM temporary files
+        '/^.(.*).swp$/', // ViM temporary files
+        '/^\.dat(.*)$/', // Smultron seems to create these
         '/^~lock.(.*)#$/', // Windows 7 lockfiles
     ];
 
@@ -543,7 +543,7 @@ 
         }
 
         $this->hash = $new_hash;
-        $max = (int) (string) $this->_fs->getServer()->getMaxFileVersion();
+        $max = (int)(string)$this->_fs->getServer()->getMaxFileVersion();
         if (count($this->history) >= $max) {
             $del = key($this->history);
             $this->_logger->debug('history limit ['.$max.'] reached, remove oldest version ['.$del.'] from file ['.$this->_id.']', [
@@ -637,8 +637,8 @@ 
     {
         assert(16 === strlen($data));
 
-        $data[6] = chr(ord($data[6]) & 0x0f | 0x40); // set version to 0100
-        $data[8] = chr(ord($data[8]) & 0x3f | 0x80); // set bits 6-7 to 10
+        $data[6] = chr(ord($data[6])&0x0f|0x40); // set version to 0100
+        $data[8] = chr(ord($data[8])&0x3f|0x80); // set bits 6-7 to 10
 
         return vsprintf('%s%s-%s-%s-%s-%s%s%s', str_split(bin2hex($data), 4));
     }
@@ -741,11 +741,11 @@ 
 
             $tmp_file = $tmp.DIRECTORY_SEPARATOR.$this->guidv4(openssl_random_pseudo_bytes(16));
             $stream = fopen($tmp_file, 'w+');
-            $size = stream_copy_to_stream($file, $stream, ((int) $this->_fs->getServer()->getMaxFileSize() + 1));
+            $size = stream_copy_to_stream($file, $stream, ((int)$this->_fs->getServer()->getMaxFileSize() + 1));
             rewind($stream);
             fclose($file);
 
-            if ($size > (int) $this->_fs->getServer()->getMaxFileSize()) {
+            if ($size > (int)$this->_fs->getServer()->getMaxFileSize()) {
                 unlink($tmp_file);
 
                 throw new Exception\InsufficientStorage(

Unused Use Statements -1 removed lines

@@ -18,7 +18,6 @@
 use Balloon\Filesystem\Storage;
 use Balloon\Hook;
 use Balloon\Mime;
-use Balloon\Server\User;
 use MongoDB\BSON\UTCDateTime;
 use Psr\Log\LoggerInterface;
 use Sabre\DAV\IFile;

src/lib/Filesystem/Node/NodeInterface.php

Doc Comments +1 added lines, -2 removed lines

@@ -108,14 +108,13 @@
      *
      * @param bool $reference
      *
-     * @return ObjectId
+     * @return ObjectId|null
      */
     public function getShareId(bool $reference = false): ?ObjectId;
 
     /**
      * Get share node.
      *
-     * @param bool $reference
      *
      * @return Collection
      */

Spacing +1 added lines, -1 removed lines

@@ -1,6 +1,6 @@
 <?php
 
-declare(strict_types=1);
+declare(strict_types = 1);
 
 /**
  * balloon

src/lib/Console.php

Doc Comments +1 added lines, -2 removed lines

@@ -173,7 +173,7 @@ 
     /**
      * Configure cli logger.
      *
-     * @return Cli
+     * @return Console
      */
     protected function configureLogger(?int $level = null): self
     {
@@ -264,7 +264,6 @@ 
     /**
      * Start.
      *
-     * @param array $options
      *
      * @return bool
      */

Spacing +1 added lines, -1 removed lines

@@ -1,6 +1,6 @@
 <?php
 
-declare(strict_types=1);
+declare(strict_types = 1);
 
 /**
  * balloon

src/lib/Console/Jobs.php

Doc Comments -1 removed lines

@@ -50,7 +50,6 @@
     /**
      * Constructor.
      *
-     * @param App             $app
      * @param Async           $async
      * @param LoggerInterface $logger
      * @param GetOpt          $getopt

Spacing +1 added lines, -1 removed lines

@@ -1,6 +1,6 @@
 <?php
 
-declare(strict_types=1);
+declare(strict_types = 1);
 
 /**
  * balloon

src/lib/Filesystem/Node/AttributeDecorator.php

Doc Comments +1 added lines, -1 removed lines

@@ -60,7 +60,7 @@
      *
      * @param Server    $server
      * @param Acl       $acl
-     * @param Decorator $role_decorator
+     * @param RoleAttributeDecorator $role_decorator
      */
     public function __construct(Server $server, Acl $acl, RoleAttributeDecorator $role_decorator)
     {

Spacing +20 added lines, -20 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare(strict_types=1);
+declare(strict_types = 1);
 
 /**
  * balloon
@@ -125,25 +125,25 @@ 
         $decorator = $this->role_decorator;
 
         return [
-            'id' => (string) $attributes['_id'],
-            'name' => (string) $attributes['name'],
-            'mime' => (string) $attributes['mime'],
-            'readonly' => (bool) $attributes['readonly'],
+            'id' => (string)$attributes['_id'],
+            'name' => (string)$attributes['name'],
+            'mime' => (string)$attributes['mime'],
+            'readonly' => (bool)$attributes['readonly'],
             'directory' => $node instanceof Collection,
-            'meta' => function ($node) {
-                return (object) $node->getMetaAttributes();
+            'meta' => function($node) {
+                return (object)$node->getMetaAttributes();
             },
-            'size' => function ($node) {
+            'size' => function($node) {
                 return $node->getSize();
             },
-            'path' => function ($node) {
+            'path' => function($node) {
                 try {
                     return $node->getPath();
                 } catch (\Exception $e) {
                     return null;
                 }
             },
-            'parent' => function ($node) {
+            'parent' => function($node) {
                 $parent = $node->getParent();
 
                 if (null === $parent || $parent->isRoot()) {
@@ -152,10 +152,10 @@ 
 
                 return $this->decorate($node->getParent(), ['id', 'name', '_links']);
             },
-            'access' => function ($node) use ($acl) {
+            'access' => function($node) use ($acl) {
                 return $acl->getAclPrivilege($node);
             },
-            'share' => function ($node) {
+            'share' => function($node) {
                 if ($node->isShared() || !$node->isSpecial()) {
                     return null;
                 }
@@ -166,7 +166,7 @@ 
                     return null;
                 }
             },
-            'sharename' => function ($node) {
+            'sharename' => function($node) {
                 if (!$node->isShared()) {
                     return null;
                 }
@@ -177,7 +177,7 @@ 
                     return null;
                 }
             },
-            'shareowner' => function ($node) use ($server, $fs, $decorator) {
+            'shareowner' => function($node) use ($server, $fs, $decorator) {
                 if (!$node->isSpecial()) {
                     return null;
                 }
@@ -191,7 +191,7 @@ 
                     return null;
                 }
             },
-            'owner' => function ($node) use ($server, $decorator) {
+            'owner' => function($node) use ($server, $decorator) {
                 try {
                     return $decorator->decorate(
                         $server->getUserById($node->getOwner()),
@@ -215,20 +215,20 @@ 
     protected function getTimeAttributes(NodeInterface $node, array $attributes): array
     {
         return [
-            'created' => function ($node) use ($attributes) {
+            'created' => function($node) use ($attributes) {
                 return $attributes['created']->toDateTime()->format('c');
             },
-            'changed' => function ($node) use ($attributes) {
+            'changed' => function($node) use ($attributes) {
                 return $attributes['changed']->toDateTime()->format('c');
             },
-            'deleted' => function ($node) use ($attributes) {
+            'deleted' => function($node) use ($attributes) {
                 if (false === $attributes['deleted']) {
                     return null;
                 }
 
                 return $attributes['deleted']->toDateTime()->format('c');
             },
-            'destroy' => function ($node) use ($attributes) {
+            'destroy' => function($node) use ($attributes) {
                 if (null === $attributes['destroy']) {
                     return null;
                 }
@@ -261,7 +261,7 @@ 
         return [
             'shared' => $node->isShared(),
             'reference' => $node->isReference(),
-            'filter' => function ($node) use ($attributes) {
+            'filter' => function($node) use ($attributes) {
                 if (null === $attributes['filter']) {
                     return null;
                 }

src/app/Balloon.App.Office/Session/Member.php

Spacing +3 added lines, -3 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare(strict_types=1);
+declare(strict_types = 1);
 
 /**
  * balloon
@@ -140,8 +140,8 @@ 
             'BaseFileName' => $attrs['name'],
             'Size' => $doc->getSize(),
             'Version' => $attrs['version'],
-            'OwnerId' => (string) $doc->getNode()->getOwner(),
-            'UserId' => (string) $this->user->getId(),
+            'OwnerId' => (string)$doc->getNode()->getOwner(),
+            'UserId' => (string)$this->user->getId(),
             'UserFriendlyName' => $this->user->getUsername(),
             'UserCanWrite' => true,
             'PostMessageOrigin' => null,

src/app/Balloon.App.Elasticsearch/Migration/Delta/Installation.php

Spacing +2 added lines, -2 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare(strict_types=1);
+declare(strict_types = 1);
 
 /**
  * balloon
@@ -68,7 +68,7 @@ 
         foreach ($config as $key => $value) {
             switch ($key) {
                 case 'index_configuration':
-                    $this->{$key} = (string) $value;
+                    $this->{$key} = (string)$value;
 
                 break;
                 default:

src/app/Balloon.App.Notification/UserMessage.php

Spacing +2 added lines, -2 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare(strict_types=1);
+declare(strict_types = 1);
 
 /**
  * balloon
@@ -77,7 +77,7 @@ 
     {
         $role_decorator = $this->role_decorator;
 
-        $string = preg_replace_callback('/(\{user\.(([a-z]\.*)+)\})/', function ($match) use ($user, $role_decorator) {
+        $string = preg_replace_callback('/(\{user\.(([a-z]\.*)+)\})/', function($match) use ($user, $role_decorator) {
             return $role_decorator->decorate($user, [$match[2]])[$match[2]];
         }, $this->{$type});