gyselroth / balloon

src/lib/Balloon/Auth/Adapter/Basic/Db.php

Doc Comments +1 added lines, -1 removed lines

@@ -68,7 +68,7 @@
      * Set options
      *
      * @param   Iterable
-     * @return  Ldap
+     * @return  Db
      */
     public function setOptions(?Iterable $config): Db
     {

Unused Use Statements -1 removed lines

@@ -12,7 +12,6 @@
 namespace Balloon\Auth\Adapter\Basic;
 
 use \Psr\Log\LoggerInterface as Logger;
-use Balloon\Config;
 use Balloon\Auth\Adapter\AdapterInterface;
 use \MongoDB\Database;
 

Spacing +5 added lines, -5 removed lines

@@ -1,5 +1,5 @@ 
 <?php
-declare(strict_types=1);
+declare(strict_types = 1);
 
 /**
  * Balloon
@@ -57,9 +57,9 @@ 
      * @param   Logger $logger
      * @return  void
      */
-    public function __construct(?Iterable $config, Logger $logger)
+    public function __construct(? Iterable $config, Logger $logger)
     {
-        $this->logger  = $logger;
+        $this->logger = $logger;
         $this->setOptions($config);
     }
 
@@ -70,7 +70,7 @@ 
      * @param   Iterable
      * @return  Ldap
      */
-    public function setOptions(?Iterable $config): Db
+    public function setOptions(? Iterable $config) : Db
     {
         if ($config === null) {
             return $this;
@@ -197,7 +197,7 @@ 
             return false;
         }
 
-        $this->identity  = $username;
+        $this->identity = $username;
         return true;
     }
 

src/lib/Balloon/Auth/Adapter/Basic/Ldap.php

Unused Use Statements -2 removed lines

@@ -11,9 +11,7 @@
 
 namespace Balloon\Auth\Adapter\Basic;
 
-use Balloon\Auth\Exception;
 use \Psr\Log\LoggerInterface as Logger;
-use Balloon\Config;
 use Balloon\Ldap as LdapServer;
 use Balloon\Auth\Adapter\AdapterInterface;
 

Spacing +3 added lines, -3 removed lines

@@ -1,5 +1,5 @@ 
 <?php
-declare(strict_types=1);
+declare(strict_types = 1);
 
 /**
  * Balloon
@@ -74,7 +74,7 @@ 
      * @param   Logger $logger
      * @return  void
      */
-    public function __construct(?Iterable $config, Logger $logger)
+    public function __construct(? Iterable $config, Logger $logger)
     {
         $this->logger = $logger;
         $this->setOptions($config);
@@ -109,7 +109,7 @@ 
      * @param   Iterable
      * @return  Ldap
      */
-    public function setOptions(?Iterable $config): LdapServer
+    public function setOptions(? Iterable $config) : LdapServer
     {
         if ($config === null) {
             return $this;

src/lib/Balloon/Auth/Adapter/None.php

Doc Comments +1 added lines, -1 removed lines

@@ -27,7 +27,7 @@
     /**
      * Initialize
      *
-     * @param  Iterable $config
+     * @param  Config $config
      * @param  Logger $logger
      * @return void
      */

Spacing +3 added lines, -3 removed lines

@@ -1,5 +1,5 @@ 
 <?php
-declare(strict_types=1);
+declare(strict_types = 1);
 
 /**
  * Balloon
@@ -31,7 +31,7 @@ 
      * @param  Logger $logger
      * @return void
      */
-    public function __construct(?Iterable $config, Logger $logger)
+    public function __construct(? Iterable $config, Logger $logger)
     {
     }
 
@@ -41,7 +41,7 @@ 
      *
      * @return int
      */
-    public function getAttributeSyncCache(): int
+    public function getAttributeSyncCache() : int
     {
         return -1;
     }

src/lib/Balloon/Auth/Adapter/Preauth.php

Unused Use Statements -1 removed lines

@@ -14,7 +14,6 @@
 use Balloon\Auth\Exception;
 use Balloon\Auth\Adapter\Basic\Ldap;
 use Balloon\Ldap as LdapServer;
-use Balloon\Config;
 
 class Preauth extends Ldap implements AdapterInterface
 {

Spacing +5 added lines, -5 removed lines

@@ -1,5 +1,5 @@ 
 <?php
-declare(strict_types=1);
+declare(strict_types = 1);
 
 /**
  * Balloon
@@ -40,7 +40,7 @@ 
      * @param   Iterable $config
      * @return  LdapServer
      */
-    public function setOptions(?Iterable $config): LdapServer
+    public function setOptions(? Iterable $config) : LdapServer
     {
         if ($config === null) {
             return $this;
@@ -108,7 +108,7 @@ 
      */
     public function preauth(string $value): bool
     {
-        $parts   = explode('|', $value);
+        $parts = explode('|', $value);
 
         if (count($parts) !== 2) {
             $this->logger->warning('invalid header x-preauth value, parts != 2', [
@@ -195,7 +195,7 @@ 
             'category' => get_class($this)
         ]);
 
-        $this->ldap_dn   = $dn;
+        $this->ldap_dn = $dn;
 
         return true;
     }
@@ -220,6 +220,6 @@ 
         $ip_decimal = ip2long($ip);
         $wildcard_decimal = pow(2, (32 - $netmask)) - 1;
         $netmask_decimal = ~ $wildcard_decimal;
-        return (($ip_decimal & $netmask_decimal) == ($range_decimal & $netmask_decimal));
+        return (($ip_decimal&$netmask_decimal) == ($range_decimal&$netmask_decimal));
     }
 }

src/lib/Balloon/Bootstrap/AbstractBootstrap.php

Doc Comments -1 removed lines

@@ -93,7 +93,6 @@
      * Init bootstrap
      *
      * @param   Composer $composer
-     * @param   Config $router
      * @return  void
      */
     public function __construct(Composer $composer, Config $config)

Spacing +1 added lines, -1 removed lines

@@ -1,5 +1,5 @@
 <?php
-declare(strict_types=1);
+declare(strict_types = 1);
 
 /**
  * Balloon

src/lib/Balloon/Bootstrap/AbstractCore.php

Doc Comments +1 added lines, -1 removed lines

@@ -138,7 +138,7 @@
     /**
      * Set error handler
      *
-     * @return Core
+     * @return AbstractCore
      */
     protected function setErrorHandler()
     {

Unused Use Statements -3 removed lines

@@ -11,7 +11,6 @@ 
 
 namespace Balloon\Bootstrap;
 
-use Balloon\Http\Router;
 use Balloon\Exception;
 use Balloon\Config;
 use Balloon\Logger;
@@ -19,8 +18,6 @@ 
 use Balloon\Queue;
 use Balloon\Filesystem;
 use \Composer\Autoload\ClassLoader as Composer;
-use Balloon\Http\Router\Route;
-use Balloon\Http\Response;
 
 abstract class AbstractCore extends AbstractBootstrap
 {

Spacing +3 added lines, -3 removed lines

@@ -1,5 +1,5 @@ 
 <?php
-declare(strict_types=1);
+declare(strict_types = 1);
 
 /**
  * Balloon
@@ -45,7 +45,7 @@ 
      *
      * @var Config
      */
-    protected $option_log ;
+    protected $option_log;
 
 
     /**
@@ -142,7 +142,7 @@ 
      */
     protected function setErrorHandler()
     {
-        set_error_handler(function ($errno, $errstr, $errfile, $errline) {
+        set_error_handler(function($errno, $errstr, $errfile, $errline) {
             $msg = $errstr." in ".$errfile.":".$errline;
             switch ($errno) {
                 case E_ERROR:

src/lib/Balloon/Config/ConfigInterface.php

Doc Comments +2 added lines, -3 removed lines

@@ -29,7 +29,7 @@ 
     /**
      * Get entire simplexml
      *
-     * @return mixed
+     * @return \SimpleXMLElement
      */
     public function getRaw();
 
@@ -38,7 +38,7 @@ 
      * Get from config
      *
      * @param   string $name
-     * @return  mixed
+     * @return  \SimpleXMLElement
      */
     public function __get(string $name);
 
@@ -55,7 +55,6 @@ 
     /**
      * Get native config format as config instance
      *
-     * @param   mixed $config
      * @return  Config
      */
     public function map($native=null): Config;

Spacing +2 added lines, -2 removed lines

@@ -1,5 +1,5 @@ 
 <?php
-declare(strict_types=1);
+declare(strict_types = 1);
 
 /**
  * Balloon
@@ -58,5 +58,5 @@ 
      * @param   mixed $config
      * @return  Config
      */
-    public function map($native=null): Config;
+    public function map($native = null): Config;
 }

src/lib/Balloon/Config/Xml.php

Doc Comments +1 added lines, -1 removed lines

@@ -81,7 +81,7 @@
     /**
      * Merge xml tree's
      *
-     * @param   SimpleXMLElement $simmplexml_to
+     * @param   SimpleXMLElement $simplexml_to
      * @param   SimpleXMLElement $simplexml_from
      * @param   bool $replace
      * @return  bool

Spacing +11 added lines, -11 removed lines

@@ -1,5 +1,5 @@ 
 <?php
-declare(strict_types=1);
+declare(strict_types = 1);
 
 /**
  * Balloon
@@ -31,7 +31,7 @@ 
      * @param   string $env
      * @return  void
      */
-    public function __construct(string $config, string $env='production')
+    public function __construct(string $config, string $env = 'production')
     {
         $config = simplexml_load_file($config);
         if ($this->store === false) {
@@ -86,7 +86,7 @@ 
      * @param   bool $replace
      * @return  bool
      */
-    protected function appendSimplexml(SimpleXMLElement &$simplexml_to, SimpleXMLElement &$simplexml_from, bool $replace=true): bool
+    protected function appendSimplexml(SimpleXMLElement&$simplexml_to, SimpleXMLElement&$simplexml_from, bool $replace = true): bool
     {
         if (count($simplexml_from->children()) === 0) {
             if ($replace === true && count($simplexml_to->children()) === 0) {
@@ -98,7 +98,7 @@ 
         foreach ($simplexml_from->attributes() as $attr_key => $attr_value) {
             if (!isset($attrs[$attr_key])) {
                 $simplexml_to->addAttribute($attr_key, (string)$attr_value);
-            } elseif ($replace===true) {
+            } elseif ($replace === true) {
                 $simplexml_to->attributes()->{$attr_key} = (string)$attr_value;
             }
         }
@@ -118,7 +118,7 @@ 
             foreach ($simplexml_child->attributes() as $attr_key => $attr_value) {
                 if (!isset($attrs[$attr_key])) {
                     $simplexml_to->{$simplexml_child->getName()}->addAttribute($attr_key, (string)$attr_value);
-                } elseif ($replace===true) {
+                } elseif ($replace === true) {
                     $simplexml_to->{$simplexml_child->getName()}->attributes()->{$attr_key} = (string)$attr_value;
                 }
             }
@@ -190,7 +190,7 @@ 
      * @param   SimpleXMLElement $xml
      * @return  Config
      */
-    public function map($xml=null): Config
+    public function map($xml = null): Config
     {
         if ($xml === null) {
             $xml = $this->store;
@@ -200,7 +200,7 @@ 
         foreach ($xml->getNamespaces() + array(null) as $prefix => $namespace) {
             foreach ($xml->attributes($namespace) as $key => $value) {
                 if (is_string($prefix)) {
-                    $key = $prefix . '.' . $key;
+                    $key = $prefix.'.'.$key;
                 }
 
                 if ($key === 'inherits') {
@@ -217,13 +217,13 @@ 
                 if (!isset($arr[$name])) {
                     $config[$name] = $value;
                 } else {
-                    foreach ((array) $value as $k => $v) {
+                    foreach ((array)$value as $k => $v) {
                         if (is_numeric($k)) {
                             $config[$name][] = $v;
                         } else {
                             $config[$name][$k] = array_merge(
-                                (array) $config[$name][$k],
-                                (array) $v
+                                (array)$config[$name][$k],
+                                (array)$v
                             );
                         }
                     }
@@ -232,7 +232,7 @@ 
                 $config[$name] = new Config();
             }
         }
-        if ($content = trim((string) $xml)) {
+        if ($content = trim((string)$xml)) {
             $config[] = $content;
         }
 

src/lib/Balloon/Filesystem.php

Doc Comments +2 added lines, -2 removed lines

@@ -431,7 +431,7 @@ 
      *
      * @param   array $id
      * @param   string $class Fore check node type
-     * @param   bool $deleted
+     * @param   integer $deleted
      * @return  Generator
      */
     public function findNodes(array $id=[], ?string $class=null, int $deleted=INode::DELETED_INCLUDE): Generator
@@ -573,7 +573,7 @@ 
      * Search
      *
      * @param   array $query
-     * @param   array $share
+     * @param   array $shares
      * @return  array
      */
     protected function _searchElastic(array $query, array $shares): array

Indentation +9 added lines, -9 removed lines

@@ -204,14 +204,14 @@ 
      *
      * @return Delta
      */
-     public function getDelta(): Delta
-     {
-         if ($this->delta instanceof Delta) {
-             return $this->delta;
-         }
+        public function getDelta(): Delta
+        {
+            if ($this->delta instanceof Delta) {
+                return $this->delta;
+            }
  
-         return $this->delta = new Delta($this);
-     }
+            return $this->delta = new Delta($this);
+        }
 
     
     /**
@@ -579,8 +579,8 @@ 
     protected function _searchElastic(array $query, array $shares): array
     {
         $client = \Elasticsearch\ClientBuilder::create()
-                   ->setHosts((array)$this->config->search->hosts->server)
-                   ->build();
+                    ->setHosts((array)$this->config->search->hosts->server)
+                    ->build();
 
         $bool =  $query['body']['query'];
 

Spacing +16 added lines, -16 removed lines

@@ -1,5 +1,5 @@ 
 <?php
-declare(strict_types=1);
+declare(strict_types = 1);
 
 /**
  * Balloon
@@ -295,7 +295,7 @@ 
      * @param   int $deleted
      * @return  INode
      */
-    public function findNodeWithId($id, ?string $class=null, int $deleted=INode::DELETED_INCLUDE): INode
+    public function findNodeWithId($id, ? string $class = null, int $deleted = INode::DELETED_INCLUDE) : INode
     {
         if (!is_string($id) && !($id instanceof ObjectID)) {
             throw new Exception\InvalidArgument($id.' node id has to be a string or instance of \MongoDB\BSON\ObjectID');
@@ -353,13 +353,13 @@ 
      * @param   string $class Fore check node type
      * @return  INode
      */
-    public function findNodeWithPath(string $path='', ?string $class=null): INode
+    public function findNodeWithPath(string $path = '', ? string $class = null) : INode
     {
         if (empty($path) || $path[0] != '/') {
             $path = '/'.$path;
         }
         
-        $last = strlen($path)-1;
+        $last = strlen($path) - 1;
         if ($path[$last] == '/') {
             $path = substr($path, 0, -1);
         }
@@ -390,7 +390,7 @@ 
      * @param   string $class Fore check node type
      * @return  INode
      */
-    public function findNodeWithShareToken(string $token, ?string $class=null): INode
+    public function findNodeWithShareToken(string $token, ? string $class = null) : INode
     {
         $node = $this->db->storage->findOne([
             'sharelink.token' => $token,
@@ -434,7 +434,7 @@ 
      * @param   bool $deleted
      * @return  Generator
      */
-    public function findNodes(array $id=[], ?string $class=null, int $deleted=INode::DELETED_INCLUDE): Generator
+    public function findNodes(array $id = [], ? string $class = null, int $deleted = INode::DELETED_INCLUDE) : Generator
     {
         $id = (array)$id;
 
@@ -488,7 +488,7 @@ 
      * @param   int $deleted
      * @return  array
      */
-    public function search(array $query, int $deleted=INode::DELETED_INCLUDE): array
+    public function search(array $query, int $deleted = INode::DELETED_INCLUDE): array
     {
         if ($this->user instanceof User) {
             $this->user->findNewShares();
@@ -582,7 +582,7 @@ 
                    ->setHosts((array)$this->config->search->hosts->server)
                    ->build();
 
-        $bool =  $query['body']['query'];
+        $bool = $query['body']['query'];
 
         $filter1 = [];
         $filter1['bool']['should'][]['term']['owner'] = (string)$this->user->getId();
@@ -650,7 +650,7 @@ 
      * @param   bool $deleted How to handle deleted node
      * @return  INode
      */
-    public function getNode($id=null, $path=null, $class=null, $multiple=false, $allow_root=false, $deleted=null)
+    public function getNode($id = null, $path = null, $class = null, $multiple = false, $allow_root = false, $deleted = null)
     {
         if (empty($id) && empty($path)) {
             if ($allow_root === true) {
@@ -766,12 +766,12 @@ 
      * @return  array
      */
     public function findNodeAttributesWithCustomFilter(
-        ?array $filter = null,
+        ? array $filter = null,
         array $attributes = ['_id'],
-        ?int $limit = null,
-        ?int &$cursor = null,
-        ?bool &$has_more = null,
-        ?INode $parent = null)
+        ? int $limit = null,
+        ? int&$cursor = null,
+        ? bool&$has_more = null,
+        ? INode $parent = null)
     {
         $default = [
             '_id'       => 1,
@@ -783,13 +783,13 @@ 
 
         $search_attributes = array_merge($default, array_fill_keys($attributes, 1));
         $list   = [];
-        $result =$this->db->storage->find($filter, [
+        $result = $this->db->storage->find($filter, [
             'skip'      => $cursor,
             'limit'     => $limit,
             'projection'=> $search_attributes
         ]);
         
-        $left =$this->db->storage->count($filter, [
+        $left = $this->db->storage->count($filter, [
             'skip' => $cursor,
         ]);