gyselroth / balloon

src/lib/Balloon/Filesystem/Node/Collection.php

Unused Use Statements -2 removed lines

@@ -13,11 +13,9 @@
 
 use \Sabre\DAV;
 use Balloon\Exception;
-use Balloon\Helper;
 use Balloon\User;
 use Balloon\Resource;
 use \Psr\Log\LoggerInterface as Logger;
-use Balloon\Plugin;
 use Balloon\Filesystem;
 use \MongoDB\BSON\ObjectId;
 use \MongoDB\BSON\UTCDateTime;

Doc Comments +2 added lines, -2 removed lines

@@ -348,7 +348,7 @@ 
     /**
      * Get real id (reference)
      *
-     * @return ObjectId
+     * @return ObjectId|null
      */
     public function getRealId(): ?ObjectId
     {
@@ -1011,7 +1011,7 @@ 
      *
      * @param   string $name
      * @param   string $data
-     * @return  File
+     * @return  string
      */
     public function createFile($name, $data=null): String
     {

Spacing +20 added lines, -20 removed lines

@@ -1,5 +1,5 @@ 
 <?php
-declare(strict_types=1);
+declare(strict_types = 1);
 
 /**
  * Balloon
@@ -72,7 +72,7 @@ 
      * @param  Filesystem $fs
      * @return void
      */
-    public function __construct(?BSONDocument $node, Filesystem $fs)
+    public function __construct(? BSONDocument $node, Filesystem $fs)
     {
         parent::__construct($node, $fs);
         
@@ -80,7 +80,7 @@ 
             $this->_id = null;
 
             if ($this->_user instanceof User) {
-                $this->owner  = $this->_user->getId();
+                $this->owner = $this->_user->getId();
             }
         }
             
@@ -97,7 +97,7 @@ 
      * @param  bool $recursion_first
      * @return INode
      */
-    public function copyTo(Collection $parent, int $conflict=INode::CONFLICT_NOACTION, ?string $recursion=null, bool $recursion_first=true): INode
+    public function copyTo(Collection $parent, int $conflict = INode::CONFLICT_NOACTION, ? string $recursion = null, bool $recursion_first = true) : INode
     {
         if ($recursion === null) {
             $recursion_first = true;
@@ -196,7 +196,7 @@ 
      * @param  array|string $attribute
      * @return array|string
      */
-    public function getAttribute($attribute=[])
+    public function getAttribute($attribute = [])
     {
         if (empty($attribute)) {
             $attribute = [
@@ -242,7 +242,7 @@ 
      * @param   array $filter
      * @return  Generator
      */
-    public function getChildNodes(int $deleted=INode::DELETED_EXCLUDE, array $filter=[]): Generator
+    public function getChildNodes(int $deleted = INode::DELETED_EXCLUDE, array $filter = []): Generator
     {
         if ($this->_user instanceof User) {
             $this->_user->findNewShares();
@@ -313,7 +313,7 @@ 
      * @param   array $filter
      * @return  Generator
      */
-    public function getChildren(int $deleted=INode::DELETED_EXCLUDE, array $filter=[]): array
+    public function getChildren(int $deleted = INode::DELETED_EXCLUDE, array $filter = []): array
     {
         return iterator_to_array($this->getChildNodes($deleted, $filter));
     }
@@ -350,7 +350,7 @@ 
      *
      * @return ObjectId
      */
-    public function getRealId(): ?ObjectId
+    public function getRealId(): ? ObjectId
     {
         if ($this->shared == true && $this->isReference()) {
             return $this->reference;
@@ -384,7 +384,7 @@ 
      * @param  array $filter
      * @return INode
      */
-    public function getChild($node, int $deleted=INode::DELETED_EXCLUDE, array $filter=[]): INode
+    public function getChild($node, int $deleted = INode::DELETED_EXCLUDE, array $filter = []): INode
     {
         //if $node is string load the object from the backend based on the current parent (the name
         //is unique per depth, so we can load the object)
@@ -453,7 +453,7 @@ 
      * @param   int $deleted
      * @return  bool
      */
-    protected function doRecursiveAction(string $method, array $params=[], int $deleted=INode::DELETED_EXCLUDE): bool
+    protected function doRecursiveAction(string $method, array $params = [], int $deleted = INode::DELETED_EXCLUDE): bool
     {
         if (!is_callable([$this, $method])) {
             throw new Exception("method $method is not callable in ".__CLASS__);
@@ -480,7 +480,7 @@ 
      * @param   bool $recursion_first
      * @return  bool
      */
-    public function delete(bool $force=false, ?string $recursion=null, bool $recursion_first=true): bool
+    public function delete(bool $force = false, ? string $recursion = null, bool $recursion_first = true) : bool
     {
         if (!$this->isAllowed('w') && !$this->isReference()) {
             throw new Exception\Forbidden('not allowed to delete node '.$this->name,
@@ -543,7 +543,7 @@ 
      * @param   bool $recursion_first
      * @return  bool
      */
-    protected function _forceDelete(?string $recursion=null, bool $recursion_first=true): bool
+    protected function _forceDelete(? string $recursion = null, bool $recursion_first = true) : bool
     {
         if (!$this->isReference()) {
             $this->doRecursiveAction('delete', [
@@ -595,7 +595,7 @@ 
      * @param   array $filter
      * @return  bool
      */
-    public function childExists($name, $deleted=INode::DELETED_EXCLUDE, array $filter=[]): bool
+    public function childExists($name, $deleted = INode::DELETED_EXCLUDE, array $filter = []): bool
     {
         $find = [
             'parent'  => $this->getRealId(),
@@ -729,7 +729,7 @@ 
         }
 
         $this->shared = false;
-        $this->acl   = null;
+        $this->acl = null;
         $action = [
             '$unset' => [
                 'shared' => $this->_id
@@ -789,7 +789,7 @@ 
      * @param   arary $files
      * @return  array
      */
-    public function getChildrenRecursive(?ObjectId $id=null, ?array &$shares=[], ?array &$files=[]): array
+    public function getChildrenRecursive(? ObjectId $id = null, ? array &$shares = [], ? array &$files = []) : array
     {
         $list = [];
         $result = $this->_db->storage->find([
@@ -833,7 +833,7 @@ 
      * @param   bool $clone
      * @return  Collection
      */
-    public function addDirectory($name, array $attributes=[], int $conflict=INode::CONFLICT_NOACTION, bool $clone=false): Collection
+    public function addDirectory($name, array $attributes = [], int $conflict = INode::CONFLICT_NOACTION, bool $clone = false): Collection
     {
         if (!$this->isAllowed('w')) {
             throw new Exception\Forbidden('not allowed to create new node here',
@@ -880,7 +880,7 @@ 
                 'shared'    => ($this->shared === true ? $this->getRealId() : $this->shared)
             ];
 
-            $save  = array_merge($meta, $attributes);
+            $save = array_merge($meta, $attributes);
 
             $result = $this->_db->storage->insertOne($save);
             $save['_id'] = $result->getInsertedId();
@@ -913,7 +913,7 @@ 
      * @param   bool $clone
      * @return  File
      */
-    public function addFile($name, $data=null, array $attributes=[], int $conflict=INode::CONFLICT_NOACTION, bool $clone=false): File
+    public function addFile($name, $data = null, array $attributes = [], int $conflict = INode::CONFLICT_NOACTION, bool $clone = false): File
     {
         if (!$this->isAllowed('w')) {
             throw new Exception\Forbidden('not allowed to create new node here',
@@ -963,7 +963,7 @@ 
                 'shared'    => ($this->shared === true ? $this->getRealId() : $this->shared),
             ];
 
-            $save  = array_merge($meta, $attributes);
+            $save = array_merge($meta, $attributes);
 
             $result = $this->_db->storage->insertOne($save);
             $save['_id'] = $result->getInsertedId();
@@ -1013,7 +1013,7 @@ 
      * @param   string $data
      * @return  File
      */
-    public function createFile($name, $data=null): String
+    public function createFile($name, $data = null): String
     {
         return $this->addFile($name, $data)->getETag();
     }

src/lib/Balloon/Filesystem/Node/File.php

Doc Comments -1 removed lines

@@ -655,7 +655,6 @@
     /**
      * Set thumbnail
      *
-     * @param  resource $thumbnail
      * @return ObjectId
      */
     protected function storePreview(string $content): ObjectId

Unused Use Statements -2 removed lines

@@ -14,10 +14,8 @@
 use \Sabre\DAV;
 use Balloon\Exception;
 use Balloon\Helper;
-use Balloon\Queue;
 use Balloon\User;
 use \Psr\Log\LoggerInterface as Logger;
-use Balloon\Plugin;
 use Balloon\Filesystem;
 use \MongoDB\BSON\ObjectId;
 use \MongoDB\BSON\UTCDateTime;

Indentation +6 added lines, -6 removed lines

@@ -205,7 +205,7 @@ 
             $v = (array)$version;
 
             $v['user'] = (new User($version['user'], $this->_logger, $this->_fs))
-              ->getUsername();
+                ->getUsername();
             $v['changed'] = Helper::DateTimeToUnix($version['changed']);
             $filtered[] = $v;
         }
@@ -597,15 +597,15 @@ 
         $build = [];
         foreach ($requested as $key => $attr) {
             switch ($attr) {
-               case 'hash':
+                case 'hash':
                case 'version':
                case 'thumbnail':
                    $build[$attr] = $this->{$attr};
-               break;
+                break;
             
-               case 'history':
+                case 'history':
                    $build['history'] = $this->getHistory();
-               break;
+                break;
             }
         }
 
@@ -870,7 +870,7 @@ 
             //somehow mongo-connector does not catch metadata when set during uploadFromStream()
             $stream = $bucket->uploadFromStream($id, $contents, ['_id' => $id/*, 'metadata' => $file*/]);
             $this->_db->{'fs.files'}->updateOne(['_id' => $id], [
-              '$set' => ['metadata'=> $file]
+                '$set' => ['metadata'=> $file]
             ]);
             
             $this->_logger->info('added new gridfs content node ['.$id.'] for file ['.$this->_id.']', [

Spacing +20 added lines, -20 removed lines

@@ -1,5 +1,5 @@ 
 <?php
-declare(strict_types=1);
+declare(strict_types = 1);
 
 /**
  * Balloon
@@ -47,14 +47,14 @@ 
      * @param array
      **/
     protected $temp_files = [
-        '/^\._(.*)$/',     // OS/X resource forks
-        '/^.DS_Store$/',   // OS/X custom folder settings
+        '/^\._(.*)$/', // OS/X resource forks
+        '/^.DS_Store$/', // OS/X custom folder settings
         '/^desktop.ini$/', // Windows custom folder settings
-        '/^Thumbs.db$/',   // Windows thumbnail cache
-        '/^.(.*).swpx$/',  // ViM temporary files
-        '/^.(.*).swx$/',   // ViM temporary files
-        '/^.(.*).swp$/',   // ViM temporary files
-        '/^\.dat(.*)$/',   // Smultron seems to create these
+        '/^Thumbs.db$/', // Windows thumbnail cache
+        '/^.(.*).swpx$/', // ViM temporary files
+        '/^.(.*).swx$/', // ViM temporary files
+        '/^.(.*).swp$/', // ViM temporary files
+        '/^\.dat(.*)$/', // Smultron seems to create these
         '/^~lock.(.*)#$/', // Windows 7 lockfiles
     ];
 
@@ -159,7 +159,7 @@ 
      * @param  bool $recursion_first
      * @return INode
      */
-    public function copyTo(Collection $parent, int $conflict=INode::CONFLICT_NOACTION, ?string $recursion=null, bool $recursion_first=true): INode
+    public function copyTo(Collection $parent, int $conflict = INode::CONFLICT_NOACTION, ? string $recursion = null, bool $recursion_first = true) : INode
     {
         $this->_pluginmgr->run('preCopyFile',
             [$this, $parent, &$conflict, &$recursion, &$recursion_first]
@@ -316,7 +316,7 @@ 
      * @param   bool $recursion_first
      * @return  bool
      */
-    public function delete(bool $force=false, ?string $recursion=null, bool $recursion_first=true): bool
+    public function delete(bool $force = false, ? string $recursion = null, bool $recursion_first = true) : bool
     {
         if (!$this->isAllowed('w')) {
             throw new Exception\Forbidden('not allowed to delete node '.$this->name,
@@ -339,7 +339,7 @@ 
         }
 
         $ts = new UTCDateTime();
-        $this->deleted  = $ts;
+        $this->deleted = $ts;
         $this->increaseVersion();
         
         $this->history[] = [
@@ -434,7 +434,7 @@ 
                     return true;
                 }
 
-                $ref  = $file['metadata']['ref'];
+                $ref = $file['metadata']['ref'];
                 
                 $found = false;
                 foreach ($ref as $key => $node) {
@@ -573,7 +573,7 @@ 
      * @param  string|array $attribute
      * @return array|string
      */
-    public function getAttribute($attribute=[])
+    public function getAttribute($attribute = [])
     {
         if (empty($attribute)) {
             $attribute = [
@@ -892,8 +892,8 @@ 
     {
         assert(strlen($data) == 16);
 
-        $data[6] = chr(ord($data[6]) & 0x0f | 0x40); // set version to 0100
-        $data[8] = chr(ord($data[8]) & 0x3f | 0x80); // set bits 6-7 to 10
+        $data[6] = chr(ord($data[6])&0x0f|0x40); // set version to 0100
+        $data[8] = chr(ord($data[8])&0x3f|0x80); // set bits 6-7 to 10
 
         return vsprintf('%s%s-%s-%s-%s-%s%s%s', str_split(bin2hex($data), 4));
     }
@@ -917,7 +917,7 @@ 
      * @param   array $attributes
      * @return  int
      */
-    public function put($file, bool $new=false, array $attributes=[]): int
+    public function put($file, bool $new = false, array $attributes = []): int
     {
         $this->_logger->debug('PUT new content data for ['.$this->_id.']', [
             'category' => get_class($this),
@@ -968,7 +968,7 @@ 
                 );
             }
 
-            $file  = $tmp_file;
+            $file = $tmp_file;
         }
         
        
@@ -1036,7 +1036,7 @@ 
             $this->mime = $attributes['mime'];
         } elseif ($file !== null) {
             $finfo = finfo_open(FILEINFO_MIME_TYPE);
-            $this->mime  = finfo_file($finfo, $file);
+            $this->mime = finfo_file($finfo, $file);
             if ($this->mime == 'application/zip' || $this->mime == 'application/vnd.ms-office') {
                 $this->mime = $this->getMimeTypeFromExtension($this->name);
             }
@@ -1129,7 +1129,7 @@ 
      * @param  string $db mimetypes
      * @return string
      */
-    public function getMimeTypeFromExtension(string $filename, string $db='/etc/mime.types'): string
+    public function getMimeTypeFromExtension(string $filename, string $db = '/etc/mime.types'): string
     {
         if (!is_readable($db)) {
             throw new Exception('mime database '.$db.' was not found or is not readable');
@@ -1146,7 +1146,7 @@ 
             if (substr($line, 0, 1) == '#') {
                 continue;
             } // skip comments
-            $line = rtrim($line) . " ";
+            $line = rtrim($line)." ";
             if (!preg_match($regex, $line, $matches)) {
                 continue;
             } // no match to the extension

src/lib/Balloon/Filesystem/Node/Node.php

Doc Comments +1 added lines, -2 removed lines

@@ -443,7 +443,6 @@ 
     /**
      * Get share node
      *
-     * @param   bool $reference
      * @return  Collection
      */
     public function getShareNode(): ?Collection
@@ -1231,7 +1230,7 @@ 
     /**
      * Get as zip
      *
-     * @return void
+     * @return resource
      */
     public function getZip(): void
     {

Indentation +1 added lines, -1 removed lines

@@ -893,7 +893,7 @@
                 case 'shareowner':
                     if ($this->isSpecial() && $sharenode !== null) {
                         $build['shareowner'] = (new User($this->_fs->findRawNode($this->getShareId())['owner'],
-                          $this->_logger, $this->_fs)
+                            $this->_logger, $this->_fs)
                         )->getUsername();
                     }
                 break;

Spacing +30 added lines, -30 removed lines

@@ -1,5 +1,5 @@ 
 <?php
-declare(strict_types=1);
+declare(strict_types = 1);
 
 /**
  * Balloon
@@ -221,7 +221,7 @@ 
      * @param  Filesystem $fs
      * @return void
      */
-    public function __construct(?BSONDocument $node, Filesystem $fs)
+    public function __construct(? BSONDocument $node, Filesystem $fs)
     {
         $this->_fs         = $fs;
         $this->_db         = $fs->getDatabase();
@@ -269,7 +269,7 @@ 
      *
      * @return mixed
      */
-    public function __call(string $attribute, array $params=[])
+    public function __call(string $attribute, array $params = [])
     {
         $prefix = 'get';
         $attr = strtolower(substr($attribute, 3));
@@ -314,7 +314,7 @@ 
      * @param  int $conflict
      * @return INode
      */
-    public function setParent(Collection $parent, int $conflict=INode::CONFLICT_NOACTION): INode
+    public function setParent(Collection $parent, int $conflict = INode::CONFLICT_NOACTION): INode
     {
         if ($this->parent === $parent->getId()) {
             throw new Exception\Conflict('source node '.$this->name.' is already in the requested parent folder',
@@ -389,7 +389,7 @@ 
      * @param   bool $recursion_first
      * @return  INode
      */
-    abstract public function copyTo(Collection $parent, int $conflict=INode::CONFLICT_NOACTION, ?string $recursion=null, bool $recursion_first=true): INode;
+    abstract public function copyTo(Collection $parent, int $conflict = INode::CONFLICT_NOACTION, ? string $recursion = null, bool $recursion_first = true) : INode;
 
 
     /**
@@ -398,7 +398,7 @@ 
      * @param   bool $reference
      * @return  ObjectId
      */
-    public function getShareId(bool $reference=false): ?ObjectId
+    public function getShareId(bool $reference = false): ? ObjectId
     {
         if ($this->isReference() && $reference === true) {
             return $this->_id;
@@ -446,7 +446,7 @@ 
      * @param   bool $reference
      * @return  Collection
      */
-    public function getShareNode(): ?Collection
+    public function getShareNode(): ? Collection
     {
         if ($this->isSpecial()) {
             return $this->_fs->findNodeWithId($this->getShareId(true));
@@ -594,7 +594,7 @@ 
      * @param   string $privilege
      * @return  bool
      */
-    public function isAllowed(string $privilege='r'): bool
+    public function isAllowed(string $privilege = 'r'): bool
     {
         $acl   = null;
         $share = null;
@@ -788,7 +788,7 @@ 
             $clean[] = 'meta';
         }
         
-        $attribute  = $clean;
+        $attribute = $clean;
 
         try {
             $sharenode  = $this->getShareNode();
@@ -918,7 +918,7 @@ 
      * @param   string $name
      * @return  string
      */
-    protected function _getDuplicateName(?string $name=null): string
+    protected function _getDuplicateName(? string $name = null) : string
     {
         if ($name === null) {
             $name = $this->name;
@@ -927,7 +927,7 @@ 
         if ($this instanceof Collection) {
             return $name.' ('.substr(uniqid('', true), -4).')';
         } else {
-            $ext  = substr(strrchr($name, '.'), 1);
+            $ext = substr(strrchr($name, '.'), 1);
 
             if ($ext === false) {
                 return $name.' ('.substr(uniqid('', true), -4).')';
@@ -947,7 +947,7 @@ 
      * @param   bool $recursion_first
      * @return  bool
      */
-    public function undelete(int $conflict=INode::CONFLICT_NOACTION, ?string $recursion=null, bool $recursion_first=true): bool
+    public function undelete(int $conflict = INode::CONFLICT_NOACTION, ? string $recursion = null, bool $recursion_first = true) : bool
     {
         if (!$this->isAllowed('w')) {
             throw new Exception\Forbidden('not allowed to restore node '.$this->name,
@@ -987,7 +987,7 @@ 
             $recursion_first = false;
         }
 
-        $this->deleted  = false;
+        $this->deleted = false;
         
         if ($this instanceof File) {
             $current = $this->version;
@@ -1141,7 +1141,7 @@ 
      *
      * @return ObjectId|string
      */
-    public function getId(bool $string=false)
+    public function getId(bool $string = false)
     {
         if ($string === true) {
             return (string)$this->_id;
@@ -1156,7 +1156,7 @@ 
      *
      * @return Collection
      */
-    public function getParent(): ?Collection
+    public function getParent(): ? Collection
     {
         try {
             if ($this->isRoot()) {
@@ -1191,7 +1191,7 @@ 
      * @param   array $parents
      * @return  array
      */
-    public function getParents(?INode $node=null, array $parents=[]): array
+    public function getParents(? INode $node = null, array $parents = []) : array
     {
         if ($node === null) {
             $node = $this;
@@ -1258,7 +1258,7 @@ 
      * @param   int $depth
      * @return  bool
      */
-    public function zip(ZipStream $archive, bool $self=true, ?INode $parent=null, string $path='', int $depth=0): bool
+    public function zip(ZipStream $archive, bool $self = true, ? INode $parent = null, string $path = '', int $depth = 0) : bool
     {
         if ($parent === null) {
             $parent = $this;
@@ -1320,7 +1320,7 @@ 
      * @param   mixed $value
      * @return  INode
      */
-    public function setMetaAttribute($attributes, $value=null): INode
+    public function setMetaAttribute($attributes, $value = null): INode
     {
         $this->meta = self::validateMetaAttribute($attributes, $value, $this->meta);
         $this->save('meta');
@@ -1336,7 +1336,7 @@ 
      * @param   array $set
      * @return  array
      */
-    public static function validateMetaAttribute($attributes, $value=null, array $set=[]): array
+    public static function validateMetaAttribute($attributes, $value = null, array $set = []): array
     {
         if (is_string($attributes)) {
             $attributes = [
@@ -1367,7 +1367,7 @@ 
      * @param  string|array $attribute Specify attributes to return
      * @return string|array
      */
-    public function getMetaAttribute($attribute=[])
+    public function getMetaAttribute($attribute = [])
     {
         if (is_string($attribute)) {
             if (isset($this->meta[$attribute])) {
@@ -1387,7 +1387,7 @@ 
      * @param   bool $readonly
      * @return  bool
      */
-    public function setReadonly(bool $readonly=true): bool
+    public function setReadonly(bool $readonly = true): bool
     {
         $this->readonly = $readonly;
         return $this->save('readonly');
@@ -1400,7 +1400,7 @@ 
      * @param   UTCDateTime $ts
      * @return  bool
      */
-    public function setDestroyable(?UTCDateTime $ts): bool
+    public function setDestroyable(? UTCDateTime $ts) : bool
     {
         $this->destroy = $ts;
         
@@ -1423,7 +1423,7 @@ 
      * @param   string $recursion
      * @return  bool
      */
-    abstract public function delete(bool $force=false, ?string $recursion=null, bool $recursion_first=true): bool;
+    abstract public function delete(bool $force = false, ? string $recursion = null, bool $recursion_first = true) : bool;
 
 
     /**
@@ -1493,7 +1493,7 @@ 
      * @param  bool $recursion_first
      * @return bool
      */
-    public function save($attributes=[], $remove=[], ?string $recursion=null, bool $recursion_first=true): bool
+    public function save($attributes = [], $remove = [], ? string $recursion = null, bool $recursion_first = true) : bool
     {
         if (!$this->isAllowed('w') && !$this->isReference()) {
             throw new Exception\Forbidden('not allowed to modify node '.$this->name,
@@ -1526,7 +1526,7 @@ 
             if (empty($update)) {
                 return false;
             } else {
-                $result =$this->_db->storage->updateOne([
+                $result = $this->_db->storage->updateOne([
                     '_id' => $this->_id,
                 ], $update);
             }
@@ -1562,11 +1562,11 @@ 
      * @return  array
      */
     public static function loadNodeAttributesWithCustomFilter(
-        ?array $filter = null,
+        ? array $filter = null,
         array $attributes = ['_id'],
-        ?int $limit = null,
-        ?int &$cursor = null,
-        ?bool &$has_more = null)
+        ? int $limit = null,
+        ? int&$cursor = null,
+        ? bool&$has_more = null)
     {
         $default = [
             '_id'       => 1,
@@ -1578,7 +1578,7 @@ 
 
         $search_attributes = array_merge($default, array_fill_keys($attributes, 1));
         $list   = [];
-        $result =$this->_db->storage->find($filter, [
+        $result = $this->_db->storage->find($filter, [
             'skip'      => $cursor,
             'limit'     => $limit,
             'projection'=> $search_attributes

src/lib/Balloon/Helper.php

Doc Comments +5 added lines, -5 removed lines

@@ -47,7 +47,7 @@ 
      * Convert UTCDateTime to unix ts
      *
      * @param  UTCDateTime $date
-     * @return StdClass
+     * @return null|\stdClass
      */
     public static function DateTimeToUnix(?UTCDateTime $date): ?Stdclass
     {
@@ -66,10 +66,10 @@ 
     /**
      * Search array element
      *
-     * @param   mixed $values
-     * @param   mixed $key
+     * @param   integer $value
+     * @param   string $key
      * @param   array $array
-     * @return  void
+     * @return  integer
      */
     public static function searchArray($value, $key, array $array)
     {
@@ -87,7 +87,7 @@ 
      * Filter data
      *
      * @param  mixed $data
-     * @return mixed
+     * @return string
      */
     public static function filter($data)
     {

Spacing +3 added lines, -3 removed lines

@@ -1,5 +1,5 @@ 
 <?php
-declare(strict_types=1);
+declare(strict_types = 1);
 
 /**
  * Balloon
@@ -49,7 +49,7 @@ 
      * @param  UTCDateTime $date
      * @return StdClass
      */
-    public static function DateTimeToUnix(?UTCDateTime $date): ?Stdclass
+    public static function DateTimeToUnix(? UTCDateTime $date) : ? Stdclass
     {
         if ($date === null) {
             return null;
@@ -147,7 +147,7 @@ 
      */
     public static function isValidTimeStamp(string $timestamp): bool
     {
-        return ((string) (int) $timestamp === $timestamp)
+        return ((string)(int)$timestamp === $timestamp)
             && ($timestamp <= PHP_INT_MAX)
             && ($timestamp >= ~PHP_INT_MAX);
     }

src/lib/Balloon/Http/Response.php

Doc Comments +3 added lines, -3 removed lines

@@ -169,7 +169,7 @@ 
     /**
      * Get body
      *
-     * @return mixed
+     * @return string
      */
     public function getBody()
     {
@@ -286,7 +286,7 @@ 
     *
     * @param    mixed $data
     * @param    SimpleXMLElement $xml
-    * @param    string|int $child_name
+    * @param    string $child_name
     * @return   string
     */
     public function toXML($data, SimpleXMLElement $xml, $child_name): string
@@ -353,7 +353,7 @@ 
     /**
      * Set the current output format.
      *
-     * @param  string $foramt a key of $outputForms
+     * @param  string $format a key of $outputForms
      * @return Response
      */
     public function setOutputFormat(string $format): Response

Unused Use Statements -1 removed lines

@@ -13,7 +13,6 @@
 
 use Balloon\Http;
 use Balloon\Exception;
-use Balloon\Config\Xml;
 use \SimpleXMLElement;
 
 class Response

Indentation +7 added lines, -7 removed lines

@@ -282,13 +282,13 @@
 
 
     /**
-    * Converts mixed data to XML
-    *
-    * @param    mixed $data
-    * @param    SimpleXMLElement $xml
-    * @param    string|int $child_name
-    * @return   string
-    */
+     * Converts mixed data to XML
+     *
+     * @param    mixed $data
+     * @param    SimpleXMLElement $xml
+     * @param    string|int $child_name
+     * @return   string
+     */
     public function toXML($data, SimpleXMLElement $xml, $child_name): string
     {
         if (is_object($data)) {

Spacing +3 added lines, -3 removed lines

@@ -1,5 +1,5 @@ 
 <?php
-declare(strict_types=1);
+declare(strict_types = 1);
 
 /**
  * Balloon
@@ -158,7 +158,7 @@ 
      * @param  bool $body_only
      * @return Response
      */
-    public function setBody($body, bool $body_only=false): Response
+    public function setBody($body, bool $body_only = false): Response
     {
         $this->body = $body;
         $this->body_only = $body_only;
@@ -186,7 +186,7 @@ 
     {
         $this->sendHeaders();
         $status = Http::STATUS_CODES[$this->code];
-        header('HTTP/1.0 ' . $this->code . ' ' . $status, true, $this->code);
+        header('HTTP/1.0 '.$this->code.' '.$status, true, $this->code);
 
         if ($this->body === null && $this->code == 204) {
             $this->terminate();

src/lib/Balloon/Http/Router.php

Doc Comments +1 added lines, -1 removed lines

@@ -304,7 +304,7 @@
      * @param   string $class
      * @param   string $method
      * @param   array $parsed_params
-     * @return  array
+     * @return  callable
      */
     protected function getParams(string $class, string $method, array $parsed_params): array
     {

Indentation +11 added lines, -11 removed lines

@@ -223,7 +223,7 @@ 
                     }
                 } else {
                     $this->logger->debug('requested path ['.$this->path.'] does not match route ['.$route->getPath().']', [
-                         'category' => get_class($this),
+                            'category' => get_class($this),
                     ]);
                 }
             }
@@ -267,22 +267,22 @@ 
         ];
 
         switch (get_class($exception)) {
-           case 'Balloon\\Exception\\InvalidArgument':
+            case 'Balloon\\Exception\\InvalidArgument':
            case 'Balloon\\Exception\\Conflict':
                $code = 400;
-           break;
-           case 'Balloon\\Exception\\NotFound':
+            break;
+            case 'Balloon\\Exception\\NotFound':
                $code = 404;
-           break;
-           case 'Balloon\\Exception\\Forbidden':
+            break;
+            case 'Balloon\\Exception\\Forbidden':
                $code = 403;
-           break;
-           case 'Balloon\\Exception\\InsufficientStorage':
+            break;
+            case 'Balloon\\Exception\\InsufficientStorage':
                $code = 507;
-           break;
-           default:
+            break;
+            default:
               $code = 500;
-           break;
+            break;
         }
         
         $this->logger->error('uncaught exception '.$message.']', [

Spacing +3 added lines, -3 removed lines

@@ -1,5 +1,5 @@ 
 <?php
-declare(strict_types=1);
+declare(strict_types = 1);
 
 /**
  * Balloon
@@ -196,7 +196,7 @@ 
      * @param  array $constructor
      * @return bool
      */
-    public function run(array $constructor=[]): bool
+    public function run(array $constructor = []): bool
     {
         $this->logger->info('execute requested route ['.$this->path.']', [
             'category' => get_class($this),
@@ -319,7 +319,7 @@ 
                 if (!empty($body)) {
                     $json_params = json_decode($body, true);
                 } else {
-                    $parts  = explode('&', $_SERVER['QUERY_STRING']);
+                    $parts = explode('&', $_SERVER['QUERY_STRING']);
                     if (!empty($parts)) {
                         $json_params = json_decode(urldecode($parts[0]), true);
                     }

src/lib/Balloon/Http/Router/Route.php

Doc Comments +1 added lines, -1 removed lines

@@ -71,7 +71,7 @@
      * @param   string|object $class
      * @param   string $method
      * @param   array $params
-     * @return  void
+     * @return  Route
      */
     public function __construct(string $path, $class, ?string $method=null, array $params=[])
     {

Unused Use Statements -1 removed lines

@@ -11,7 +11,6 @@
 
 namespace Balloon\Http\Router;
 
-use Balloon\Exception;
 use Balloon\Http\Router;
 
 class Route

Spacing +7 added lines, -7 removed lines

@@ -1,5 +1,5 @@ 
 <?php
-declare(strict_types=1);
+declare(strict_types = 1);
 
 /**
  * Balloon
@@ -73,7 +73,7 @@ 
      * @param   array $params
      * @return  void
      */
-    public function __construct(string $path, $class, ?string $method=null, array $params=[])
+    public function __construct(string $path, $class, ? string $method = null, array $params = [])
     {
         $this->setPath($path);
         $this->setClass($class);
@@ -89,7 +89,7 @@ 
      */
     public function match(): bool
     {
-        $regex = preg_replace_callback('#({([A-Z0-9a-z]+)\:\#(.+?)\#})|\{(.+?)\}#', function ($match) {
+        $regex = preg_replace_callback('#({([A-Z0-9a-z]+)\:\#(.+?)\#})|\{(.+?)\}#', function($match) {
             if (count($match) === 4) {
                 return '(?<'.$match[2].'>'.$match[3].'+)';
             } else {
@@ -118,7 +118,7 @@ 
      * @param  array $constructor
      * @return array
      */
-    public function getCallable($constructor=[]): array
+    public function getCallable($constructor = []): array
     {
         if (is_object($this->class)) {
             $instance = $this->class;
@@ -140,7 +140,7 @@ 
      * @param   string $name
      * @return  string
      */
-    protected function _buildMethodName(?string $name): string
+    protected function _buildMethodName(? string $name) : string
     {
         $result = $this->router->getVerb();
         
@@ -265,7 +265,7 @@ 
      * @param   string $method
      * @return  Route
      */
-    public function setMethod(?string $method): Route
+    public function setMethod(? string $method) : Route
     {
         $this->method = $method;
         return $this;
@@ -313,7 +313,7 @@ 
      * @param  bool $next
      * @return Route
      */
-    public function continuePropagation($next=true): Route
+    public function continuePropagation($next = true): Route
     {
         $this->continue_propagation = (bool)$next;
         return $this;

src/lib/Balloon/Log/Adapter/AbstractAdapter.php

Doc Comments -2 removed lines

@@ -49,7 +49,6 @@ 
     /**
      * Create adapter
      *
-     * @param Iterable $options
      * @return void
      */
     public function __construct(?Iterable $config=null)
@@ -92,7 +91,6 @@ 
     /**
      * Set options
      *
-     * @param   Iterable $options
      * @return  AdapterInterface
      */
     public function setOptions(?Iterable $config=null): AdapterInterface

Spacing +3 added lines, -3 removed lines

@@ -1,5 +1,5 @@ 
 <?php
-declare(strict_types=1);
+declare(strict_types = 1);
 
 /**
  * Balloon
@@ -52,7 +52,7 @@ 
      * @param Iterable $options
      * @return void
      */
-    public function __construct(?Iterable $config=null)
+    public function __construct(? Iterable $config = null)
     {
         $this->setOptions($config);
     }
@@ -95,7 +95,7 @@ 
      * @param   Iterable $options
      * @return  AdapterInterface
      */
-    public function setOptions(?Iterable $config=null): AdapterInterface
+    public function setOptions(? Iterable $config = null) : AdapterInterface
     {
         if ($config === null) {
             return $this;

src/lib/Balloon/Log/Adapter/AdapterInterface.php

Doc Comments -2 removed lines

@@ -27,7 +27,6 @@ 
     /**
      * Create adapter
      *
-     * @param Iterable $options
      * @return void
      */
     public function __construct(?Iterable $config=null);
@@ -58,7 +57,6 @@ 
     /**
      * Set options
      *
-     * @param   Iterable $options
      * @return  AdapterInterface
      */
     public function setOptions(?Iterable $config=null): AdapterInterface;

Unused Use Statements -2 removed lines

@@ -11,8 +11,6 @@
 
 namespace Balloon\Log\Adapter;
 
-use Balloon\Exception;
-
 interface AdapterInterface
 {
     /**

Spacing +3 added lines, -3 removed lines

@@ -1,5 +1,5 @@ 
 <?php
-declare(strict_types=1);
+declare(strict_types = 1);
 
 /**
  * Balloon
@@ -30,7 +30,7 @@ 
      * @param Iterable $options
      * @return void
      */
-    public function __construct(?Iterable $config=null);
+    public function __construct(? Iterable $config = null);
     
 
     /**
@@ -61,5 +61,5 @@ 
      * @param   Iterable $options
      * @return  AdapterInterface
      */
-    public function setOptions(?Iterable $config=null): AdapterInterface;
+    public function setOptions(? Iterable $config = null) : AdapterInterface;
 }