Completed
Pull Request — master (#429)
by Raffael
03:46
created
src/lib/Server.php 2 patches
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -195,6 +195,7 @@
 block discarded – undo
195 195
 
196 196
     /**
197 197
      * Filesystem factory.
198
+     * @param User $user
198 199
      */
199 200
     public function getFilesystem(?User $user = null): Filesystem
200 201
     {
Please login to merge, or discard this patch.
Indentation   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -533,7 +533,7 @@  discard block
 block discarded – undo
533 533
 
534 534
         $this->identity = $user;
535 535
         $user->updateIdentity($identity)
536
-             ->updateShares();
536
+                ->updateShares();
537 537
         $this->hook->run('postServerIdentity', [$user]);
538 538
 
539 539
         return true;
@@ -642,7 +642,7 @@  discard block
 block discarded – undo
642 642
     public function getGroupByName(string $name): Group
643 643
     {
644 644
         $group = $this->db->group->findOne([
645
-           'name' => $name,
645
+            'name' => $name,
646 646
         ]);
647 647
 
648 648
         if (null === $group) {
@@ -664,7 +664,7 @@  discard block
 block discarded – undo
664 664
         }
665 665
 
666 666
         $group = $this->db->group->findOne([
667
-           '_id' => $id,
667
+            '_id' => $id,
668 668
         ]);
669 669
 
670 670
         if (null === $group) {
Please login to merge, or discard this patch.
src/app/Balloon.App.Notification/TemplateHandler.php 2 patches
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -101,7 +101,7 @@
 block discarded – undo
101 101
                 break;
102 102
                 default:
103 103
                     throw new InvalidArgumentException('invalid option '.$option.' given');
104
-             }
104
+                }
105 105
         }
106 106
 
107 107
         return $this;
Please login to merge, or discard this patch.
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -218,7 +218,7 @@  discard block
 block discarded – undo
218 218
      */
219 219
     protected function decorate(string $template, array $context): string
220 220
     {
221
-        return preg_replace_callback('/\{([^}\.]*)\}/', function ($match) use ($context) {
221
+        return preg_replace_callback('/\{([^}\.]*)\}/', function($match) use ($context) {
222 222
             $key = $match[1];
223 223
 
224 224
             if (isset($context[$key])) {
@@ -232,7 +232,7 @@  discard block
 block discarded – undo
232 232
      */
233 233
     protected function decorateResource(string $template, $resource, string $prefix, $decorator): string
234 234
     {
235
-        return preg_replace_callback('/(\{'.$prefix.'\.(([a-z]\.*)+)\})/', function ($match) use ($resource, $decorator) {
235
+        return preg_replace_callback('/(\{'.$prefix.'\.(([a-z]\.*)+)\})/', function($match) use ($resource, $decorator) {
236 236
             $key = explode('.', $match[2]);
237 237
             $key = array_shift($key);
238 238
             $attrs = $decorator->decorate($resource, [$key]);
Please login to merge, or discard this patch.
src/app/Balloon.App.Notification/Adapter/Mail.php 1 patch
Indentation   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -114,10 +114,10 @@
 block discarded – undo
114 114
         $body->setParts([$html, $plain]);
115 115
 
116 116
         $mail = (new Message())
117
-          ->setSubject($message->getSubject($receiver))
118
-          ->setBody($body)
119
-          ->setTo($address)
120
-          ->setEncoding('UTF-8');
117
+            ->setSubject($message->getSubject($receiver))
118
+            ->setBody($body)
119
+            ->setTo($address)
120
+            ->setEncoding('UTF-8');
121 121
 
122 122
         $type = $mail->getHeaders()->get('Content-Type');
123 123
         $type->setType('multipart/alternative');
Please login to merge, or discard this patch.
src/app/Balloon.App.Elasticsearch/NodeAttributeDecorator.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -56,7 +56,7 @@  discard block
 block discarded – undo
56 56
             'directory' => $node instanceof Collection,
57 57
             'meta' => $node->getMetaAttributes(),
58 58
             'size' => $node->getSize(),
59
-            'parent' => function ($node, $requested) use ($attributes) {
59
+            'parent' => function($node, $requested) use ($attributes) {
60 60
                 $parent = $node->getParent();
61 61
 
62 62
                 if (null === $parent || $parent->isRoot()) {
@@ -69,14 +69,14 @@  discard block
 block discarded – undo
69 69
             'shared' => (string) $attributes['shared'],
70 70
             'created' => $attributes['created']->toDateTime()->format('c'),
71 71
             'changed' => $attributes['changed']->toDateTime()->format('c'),
72
-            'deleted' => function ($node, $requested) use ($attributes) {
72
+            'deleted' => function($node, $requested) use ($attributes) {
73 73
                 if (!$attributes['deleted']) {
74 74
                     return null;
75 75
                 }
76 76
 
77 77
                 return $attributes['deleted']->toDateTime()->format('c');
78 78
             },
79
-            'destroy' => function ($node, $requested) use ($attributes) {
79
+            'destroy' => function($node, $requested) use ($attributes) {
80 80
                 if (!$attributes['destroy']) {
81 81
                     return null;
82 82
                 }
Please login to merge, or discard this patch.
src/app/Balloon.App.Sharelink/Constructor/Http.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -65,13 +65,13 @@  discard block
 block discarded – undo
65 65
             }
66 66
         });
67 67
 
68
-        $node_decorator_v2->addDecorator('sharelink_has_password', function ($node) use ($sharelink) {
68
+        $node_decorator_v2->addDecorator('sharelink_has_password', function($node) use ($sharelink) {
69 69
             $attributes = $sharelink->getSharelink($node);
70 70
 
71 71
             return isset($attributes['password']);
72 72
         });
73 73
 
74
-        $node_decorator_v2->addDecorator('sharelink_token', function ($node) use ($sharelink) {
74
+        $node_decorator_v2->addDecorator('sharelink_token', function($node) use ($sharelink) {
75 75
             $attributes = $sharelink->getSharelink($node);
76 76
 
77 77
             if (isset($attributes['token'])) {
@@ -79,7 +79,7 @@  discard block
 block discarded – undo
79 79
             }
80 80
         });
81 81
 
82
-        $node_decorator_v2->addDecorator('sharelink_expire', function ($node) use ($sharelink) {
82
+        $node_decorator_v2->addDecorator('sharelink_expire', function($node) use ($sharelink) {
83 83
             $attributes = $sharelink->getSharelink($node);
84 84
 
85 85
             if (isset($attributes['expiration'])) {
@@ -89,7 +89,7 @@  discard block
 block discarded – undo
89 89
             }
90 90
         });
91 91
 
92
-        $node_decorator_v1->addDecorator('sharelink', function ($node) use ($sharelink) {
92
+        $node_decorator_v1->addDecorator('sharelink', function($node) use ($sharelink) {
93 93
             return isset($sharelink->getSharelink($node)['token']);
94 94
         });
95 95
 
Please login to merge, or discard this patch.
src/app/Balloon.App.Api/v1/Node.php 3 patches
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -210,7 +210,7 @@  discard block
 block discarded – undo
210 210
      * @param string $class      Force set node type
211 211
      * @param bool   $multiple   Allow $id to be an array
212 212
      * @param bool   $allow_root Allow instance of root collection
213
-     * @param bool   $deleted    How to handle deleted node
213
+     * @param integer   $deleted    How to handle deleted node
214 214
      */
215 215
     protected function _getNode(
216 216
         ?string $id = null,
@@ -242,7 +242,7 @@  discard block
 block discarded – undo
242 242
      * @param string $id
243 243
      * @param string $path
244 244
      * @param string $class   Force set node type
245
-     * @param bool   $deleted How to handle deleted node
245
+     * @param integer   $deleted How to handle deleted node
246 246
      */
247 247
     protected function _getNodes(
248 248
         $id = null,
Please login to merge, or discard this patch.
Indentation   +43 added lines, -43 removed lines patch added patch discarded remove patch
@@ -284,46 +284,46 @@  discard block
 block discarded – undo
284 284
         }
285 285
 
286 286
         return $response->setOutputFormat(null)
287
-          ->setBody(function () use ($node, $encode, $offset, $length) {
288
-              $mime = $node->getContentType();
289
-              $stream = $node->get();
290
-              $name = $node->getName();
291
-
292
-              if (null === $stream) {
293
-                  return;
294
-              }
295
-
296
-              if (0 !== $offset) {
297
-                  if (fseek($stream, $offset) === -1) {
298
-                      throw new Exception\Conflict('invalid offset requested', Exception\Conflict::INVALID_OFFSET);
299
-                  }
300
-              }
301
-
302
-              $read = 0;
303
-              header('Content-Type: '.$mime.'');
304
-              if ('base64' === $encode) {
305
-                  header('Content-Encoding: base64');
306
-                  while (!feof($stream)) {
307
-                      if (0 !== $length && $read + 8192 > $length) {
308
-                          echo base64_encode(fread($stream, $length - $read));
309
-                          exit();
310
-                      }
311
-
312
-                      echo base64_encode(fread($stream, 8192));
313
-                      $read += 8192;
314
-                  }
315
-              } else {
316
-                  while (!feof($stream)) {
317
-                      if (0 !== $length && $read + 8192 > $length) {
318
-                          echo fread($stream, $length - $read);
319
-                          exit();
320
-                      }
321
-
322
-                      echo fread($stream, 8192);
323
-                      $read += 8192;
324
-                  }
325
-              }
326
-          });
287
+            ->setBody(function () use ($node, $encode, $offset, $length) {
288
+                $mime = $node->getContentType();
289
+                $stream = $node->get();
290
+                $name = $node->getName();
291
+
292
+                if (null === $stream) {
293
+                    return;
294
+                }
295
+
296
+                if (0 !== $offset) {
297
+                    if (fseek($stream, $offset) === -1) {
298
+                        throw new Exception\Conflict('invalid offset requested', Exception\Conflict::INVALID_OFFSET);
299
+                    }
300
+                }
301
+
302
+                $read = 0;
303
+                header('Content-Type: '.$mime.'');
304
+                if ('base64' === $encode) {
305
+                    header('Content-Encoding: base64');
306
+                    while (!feof($stream)) {
307
+                        if (0 !== $length && $read + 8192 > $length) {
308
+                            echo base64_encode(fread($stream, $length - $read));
309
+                            exit();
310
+                        }
311
+
312
+                        echo base64_encode(fread($stream, 8192));
313
+                        $read += 8192;
314
+                    }
315
+                } else {
316
+                    while (!feof($stream)) {
317
+                        if (0 !== $length && $read + 8192 > $length) {
318
+                            echo fread($stream, $length - $read);
319
+                            exit();
320
+                        }
321
+
322
+                        echo fread($stream, 8192);
323
+                        $read += 8192;
324
+                    }
325
+                }
326
+            });
327 327
     }
328 328
 
329 329
     /**
@@ -1318,9 +1318,9 @@  discard block
 block discarded – undo
1318 1318
                 $node->zip($archive);
1319 1319
             } catch (\Exception $e) {
1320 1320
                 $this->logger->debug('failed zip node in multi node request ['.$node->getId().']', [
1321
-                   'category' => get_class($this),
1322
-                   'exception' => $e,
1323
-               ]);
1321
+                    'category' => get_class($this),
1322
+                    'exception' => $e,
1323
+                ]);
1324 1324
             }
1325 1325
         }
1326 1326
 
Please login to merge, or discard this patch.
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -188,7 +188,7 @@  discard block
 block discarded – undo
188 188
             }
189 189
         }
190 190
 
191
-        return $this->bulk($id, $p, function ($node) use ($parent, $conflict, $move) {
191
+        return $this->bulk($id, $p, function($node) use ($parent, $conflict, $move) {
192 192
             if (true === $move) {
193 193
                 $node = $node->setParent($parent, $conflict);
194 194
             }
@@ -265,7 +265,7 @@  discard block
 block discarded – undo
265 265
 
266 266
         $node = $this->_getNode($id, $p);
267 267
         if ($node instanceof Collection) {
268
-            return (new Response())->setBody(function () use ($node) {
268
+            return (new Response())->setBody(function() use ($node) {
269 269
                 $node->getZip();
270 270
             });
271 271
         }
@@ -284,7 +284,7 @@  discard block
 block discarded – undo
284 284
         }
285 285
 
286 286
         return $response->setOutputFormat(null)
287
-          ->setBody(function () use ($node, $encode, $offset, $length) {
287
+          ->setBody(function() use ($node, $encode, $offset, $length) {
288 288
               $mime = $node->getContentType();
289 289
               $stream = $node->get();
290 290
               $name = $node->getName();
@@ -352,7 +352,7 @@  discard block
 block discarded – undo
352 352
      */
353 353
     public function postReadonly($id = null, $p = null, bool $readonly = true): Response
354 354
     {
355
-        return $this->bulk($id, $p, function ($node) use ($readonly) {
355
+        return $this->bulk($id, $p, function($node) use ($readonly) {
356 356
             $node->setReadonly($readonly);
357 357
 
358 358
             return ['status' => 204];
@@ -597,7 +597,7 @@  discard block
 block discarded – undo
597 597
      */
598 598
     public function postMetaAttributes(?string $id = null, ?string $p = null): Response
599 599
     {
600
-        return $this->bulk($id, $p, function ($node) {
600
+        return $this->bulk($id, $p, function($node) {
601 601
             $node->setMetaAttributes($_POST);
602 602
 
603 603
             return ['status' => 204];
@@ -676,7 +676,7 @@  discard block
 block discarded – undo
676 676
             throw new Exception\NotFound('destination collection was not found or is not a collection', Exception\NotFound::DESTINATION_NOT_FOUND);
677 677
         }
678 678
 
679
-        return $this->bulk($id, $p, function ($node) use ($parent, $conflict) {
679
+        return $this->bulk($id, $p, function($node) use ($parent, $conflict) {
680 680
             $result = $node->copyTo($parent, $conflict);
681 681
 
682 682
             return [
@@ -734,7 +734,7 @@  discard block
 block discarded – undo
734 734
             throw new Exception\NotFound('destination collection was not found or is not a collection', Exception\NotFound::DESTINATION_NOT_FOUND);
735 735
         }
736 736
 
737
-        return $this->bulk($id, $p, function ($node) use ($parent, $conflict) {
737
+        return $this->bulk($id, $p, function($node) use ($parent, $conflict) {
738 738
             $result = $node->setParent($parent, $conflict);
739 739
             if (NodeInterface::CONFLICT_RENAME === $conflict) {
740 740
                 return [
@@ -789,7 +789,7 @@  discard block
 block discarded – undo
789 789
             $at = $this->_verifyAttributes(['destroy' => $at])['destroy'];
790 790
         }
791 791
 
792
-        return $this->bulk($id, $p, function ($node) use ($force, $ignore_flag, $at) {
792
+        return $this->bulk($id, $p, function($node) use ($force, $ignore_flag, $at) {
793 793
             if (null === $at) {
794 794
                 $node->delete($force && $node->isDeleted() || $force && $ignore_flag);
795 795
             } else {
Please login to merge, or discard this patch.
src/app/Balloon.App.Notification/Api/v2/Notifications.php 1 patch
Indentation   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -256,9 +256,9 @@
 block discarded – undo
256 256
         $body->setParts([$html, $plain]);
257 257
 
258 258
         $mail = (new Message())
259
-          ->setSubject($message->getSubject())
260
-          ->setBody($body)
261
-          ->setEncoding('UTF-8');
259
+            ->setSubject($message->getSubject())
260
+            ->setBody($body)
261
+            ->setEncoding('UTF-8');
262 262
 
263 263
         $type = $mail->getHeaders()->get('Content-Type');
264 264
         $type->setType('multipart/alternative');
Please login to merge, or discard this patch.
src/lib/Migration/Delta/Md5BlobIgnoreNull.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -12,7 +12,6 @@
 block discarded – undo
12 12
 namespace Balloon\Migration\Delta;
13 13
 
14 14
 use MongoDB\Database;
15
-use MongoDB\Driver\Exception\CommandException;
16 15
 use MongoDB\Driver\Exception\RuntimeException;
17 16
 
18 17
 class Md5BlobIgnoreNull implements DeltaInterface
Please login to merge, or discard this patch.
src/app/Balloon.App.Notification/Notifier.php 2 patches
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -348,7 +348,7 @@  discard block
 block discarded – undo
348 348
 
349 349
             if ($node instanceof Collection && $recursive === true) {
350 350
                 $db = $this->db;
351
-                $node->doRecursiveAction(function ($child) use ($db, $subscription) {
351
+                $node->doRecursiveAction(function($child) use ($db, $subscription) {
352 352
                     $subscription['node'] = $child->getId();
353 353
                     $db->subscription->replaceOne(
354 354
                         [
@@ -374,7 +374,7 @@  discard block
 block discarded – undo
374 374
 
375 375
             if ($node instanceof Collection && $recursive === true) {
376 376
                 $db = $this->db;
377
-                $node->doRecursiveAction(function ($child) use ($db, $node_id, $user_id) {
377
+                $node->doRecursiveAction(function($child) use ($db, $node_id, $user_id) {
378 378
                     $db->subscription->deleteOne([
379 379
                         'user' => $user_id,
380 380
                         'node' => $node_id,
Please login to merge, or discard this patch.
Doc Comments   +5 added lines patch added patch discarded remove patch
@@ -93,6 +93,7 @@  discard block
 block discarded – undo
93 93
 
94 94
     /**
95 95
      * Send notification.
96
+     * @param User $sender
96 97
      */
97 98
     public function notify(iterable $receiver, ?User $sender, MessageInterface $message): bool
98 99
     {
@@ -180,6 +181,7 @@  discard block
 block discarded – undo
180 181
 
181 182
     /**
182 183
      * Add notification.
184
+     * @param User $sender
183 185
      */
184 186
     public function postNotification(User $receiver, ?User $sender, MessageInterface $message): ObjectId
185 187
     {
@@ -206,6 +208,8 @@  discard block
 block discarded – undo
206 208
 
207 209
     /**
208 210
      * Get notifications.
211
+     * @param integer $offset
212
+     * @param integer $limit
209 213
      */
210 214
     public function getNotifications(User $user, array $query = [], ?int $offset = null, ?int $limit = null, ?int &$total = null): iterable
211 215
     {
@@ -288,6 +292,7 @@  discard block
 block discarded – undo
288 292
 
289 293
     /**
290 294
      * Get subscription.
295
+     * @return NodeInterface
291 296
      */
292 297
     public function getSubscription(NodeInterface $node, User $user): ?array
293 298
     {
Please login to merge, or discard this patch.