gyselroth / balloon

src/lib/Filesystem/Node/Collection.php

Unused Use Statements -1 removed lines

@@ -16,7 +16,6 @@
 use Balloon\Filesystem\Acl\Exception\Forbidden as ForbiddenException;
 use Balloon\Filesystem\Exception;
 use Balloon\Hook;
-use Balloon\Server\User;
 use Generator;
 use MongoDB\BSON\ObjectId;
 use MongoDB\BSON\Regex;

Spacing +2 added lines, -2 removed lines

@@ -386,7 +386,7 @@ 
         $this->deleted = new UTCDateTime();
 
         if (!$this->isReference()) {
-            $this->doRecursiveAction(function ($node) use ($recursion) {
+            $this->doRecursiveAction(function($node) use ($recursion) {
                 $node->delete(false, $recursion, false);
             }, NodeInterface::DELETED_EXCLUDE);
         }
@@ -936,7 +936,7 @@ 
     protected function _forceDelete(?string $recursion = null, bool $recursion_first = true): bool
     {
         if (!$this->isReference()) {
-            $this->doRecursiveAction(function ($node) use ($recursion) {
+            $this->doRecursiveAction(function($node) use ($recursion) {
                 $node->delete(true, $recursion, false);
             }, NodeInterface::DELETED_INCLUDE);
         }

Doc Comments +2 added lines, -2 removed lines

@@ -255,7 +255,7 @@ 
     /**
      * Get real id (reference).
      *
-     * @return ObjectId
+     * @return ObjectId|null
      */
     public function getRealId(): ?ObjectId
     {
@@ -752,7 +752,7 @@ 
      * @param string $name
      * @param string $data
      *
-     * @return File
+     * @return string
      */
     public function createFile($name, $data = null): String
     {

src/lib/Server/Group.php

Doc Comments +2 added lines

@@ -265,6 +265,8 @@
     /**
      * Get resolved member.
      *
+     * @param integer $offset
+     * @param integer $limit
      * @return Generator
      */
     public function getResolvedMembers(?int $offset = null, ?int $limit = null): ?Generator

src/lib/Server.php

Indentation +3 added lines, -3 removed lines

@@ -531,7 +531,7 @@ 
 
         $this->identity = $user;
         $user->updateIdentity($identity)
-             ->updateShares();
+                ->updateShares();
         $this->hook->run('postServerIdentity', [$user]);
 
         return true;
@@ -662,7 +662,7 @@ 
     public function getGroupByName(string $name): Group
     {
         $group = $this->db->group->findOne([
-           'name' => $name,
+            'name' => $name,
         ]);
 
         if (null === $group) {
@@ -682,7 +682,7 @@ 
     public function getGroupById(ObjectId $id): Group
     {
         $group = $this->db->group->findOne([
-           '_id' => $id,
+            '_id' => $id,
         ]);
 
         if (null === $group) {

Doc Comments +1 added lines

@@ -195,6 +195,7 @@
 
     /**
      * Filesystem factory.
+     * @param User $user
      */
     public function getFilesystem(?User $user = null): Filesystem
     {

src/app/Balloon.App.Sharelink/Migration/Delta/SharelinkIntoApp.php

Indentation +2 added lines, -2 removed lines

@@ -49,8 +49,8 @@
             $this->db->storage->updateOne(
                 ['_id' => $object['_id']],
                 [
-                  '$unset' => ['sharelink' => 1],
-                  '$set' => ['app.Balloon\App\Sharelink' => $object['sharelink']],
+                    '$unset' => ['sharelink' => 1],
+                    '$set' => ['app.Balloon\App\Sharelink' => $object['sharelink']],
                 ]
             );
         }

src/app/Balloon.App.Elasticsearch/Job.php

Indentation +1 added lines, -1 removed lines

@@ -341,7 +341,7 @@
         }
 
         $this->logger->debug('elasticsarch blob document ['.$result['_id'].'] has no references left, remove completely', [
-         'category' => get_class($this),
+            'category' => get_class($this),
         ]);
 
         return $this->deleteBlob($result['_id']);

Spacing +2 added lines, -2 removed lines

@@ -271,7 +271,7 @@ 
     protected function addShare(Collection $collection): bool
     {
         $that = $this;
-        $collection->doRecursiveAction(function ($node) use ($that) {
+        $collection->doRecursiveAction(function($node) use ($that) {
             if ($node instanceof Collection) {
                 $that->addShare($node);
             } else {
@@ -292,7 +292,7 @@ 
     protected function deleteShare(Collection $collection): bool
     {
         $that = $this;
-        $collection->doRecursiveAction(function ($node) use ($that) {
+        $collection->doRecursiveAction(function($node) use ($that) {
             if ($node instanceof Collection) {
                 $that->deleteShare($node);
             } else {

src/app/Balloon.App.Cli/Console/Group.php

Indentation +1 added lines, -1 removed lines

@@ -75,7 +75,7 @@
 
         $this->logger->info('new group ['.$result.'] created', [
             'category' => get_class($this),
-       ]);
+        ]);
 
         return true;
     }

src/lib/Migration/Delta/AddHashToHistory.php

Indentation +1 added lines, -1 removed lines

@@ -49,7 +49,7 @@
                 'foreignField' => '_id',
                 'localField' => 'history.storage._id',
                 'as' => 'blob',
-           ]],
+            ]],
         ]);
 
         foreach ($cursor as $object) {

src/lib/Filesystem/Node/AbstractNode.php

Spacing +1 added lines, -1 removed lines

@@ -629,7 +629,7 @@
             return true;
         }
 
-        return $this->doRecursiveAction(function ($node) use ($conflict, $recursion) {
+        return $this->doRecursiveAction(function($node) use ($conflict, $recursion) {
             $node->undelete($conflict, $recursion, false);
         }, NodeInterface::DELETED_ONLY);
     }

Doc Comments +1 added lines

@@ -1044,6 +1044,7 @@
 
     /**
      * Duplicate name with a uniqid within name.
+     * @param string $name
      */
     protected function getDuplicateName(?string $name = null, ?string $class = null): string
     {

src/lib/Filesystem/Node/AttributeDecorator.php

Spacing +14 added lines, -14 removed lines

@@ -131,20 +131,20 @@ 
             'mime' => (string) $attributes['mime'],
             'readonly' => (bool) $attributes['readonly'],
             'directory' => $node instanceof Collection,
-            'meta' => function ($node) {
+            'meta' => function($node) {
                 return (object) $node->getMetaAttributes();
             },
-            'size' => function ($node) {
+            'size' => function($node) {
                 return $node->getSize();
             },
-            'path' => function ($node) {
+            'path' => function($node) {
                 try {
                     return $node->getPath();
                 } catch (\Exception $e) {
                     return null;
                 }
             },
-            'parent' => function ($node) {
+            'parent' => function($node) {
                 $parent = $node->getParent();
 
                 if (null === $parent || $parent->isRoot()) {
@@ -153,10 +153,10 @@ 
 
                 return $this->decorate($node->getParent(), ['id', 'name', '_links']);
             },
-            'access' => function ($node) use ($acl) {
+            'access' => function($node) use ($acl) {
                 return $acl->getAclPrivilege($node);
             },
-            'share' => function ($node) {
+            'share' => function($node) {
                 if ($node->isShared() || !$node->isSpecial()) {
                     return null;
                 }
@@ -167,7 +167,7 @@ 
                     return null;
                 }
             },
-            'sharename' => function ($node) {
+            'sharename' => function($node) {
                 if (!$node->isShared()) {
                     return null;
                 }
@@ -178,7 +178,7 @@ 
                     return null;
                 }
             },
-            'shareowner' => function ($node) use ($server, $fs, $decorator) {
+            'shareowner' => function($node) use ($server, $fs, $decorator) {
                 if (!$node->isSpecial()) {
                     return null;
                 }
@@ -192,7 +192,7 @@ 
                     return null;
                 }
             },
-            'owner' => function ($node) use ($server, $decorator) {
+            'owner' => function($node) use ($server, $decorator) {
                 try {
                     return $decorator->decorate(
                         $server->getUserById($node->getOwner()),
@@ -216,20 +216,20 @@ 
     protected function getTimeAttributes(NodeInterface $node, array $attributes): array
     {
         return [
-            'created' => function ($node) use ($attributes) {
+            'created' => function($node) use ($attributes) {
                 return $attributes['created']->toDateTime()->format('c');
             },
-            'changed' => function ($node) use ($attributes) {
+            'changed' => function($node) use ($attributes) {
                 return $attributes['changed']->toDateTime()->format('c');
             },
-            'deleted' => function ($node) use ($attributes) {
+            'deleted' => function($node) use ($attributes) {
                 if (false === $attributes['deleted']) {
                     return null;
                 }
 
                 return $attributes['deleted']->toDateTime()->format('c');
             },
-            'destroy' => function ($node) use ($attributes) {
+            'destroy' => function($node) use ($attributes) {
                 if (null === $attributes['destroy']) {
                     return null;
                 }
@@ -262,7 +262,7 @@ 
         return [
             'shared' => $node->isShared(),
             'reference' => $node->isReference(),
-            'filter' => function ($node) use ($attributes) {
+            'filter' => function($node) use ($attributes) {
                 if (null === $attributes['filter']) {
                     return null;
                 }

Doc Comments +1 added lines, -1 removed lines

@@ -58,7 +58,7 @@
     /**
      * Init.
      *
-     * @param Decorator $role_decorator
+     * @param RoleAttributeDecorator $role_decorator
      */
     public function __construct(Server $server, Acl $acl, RoleAttributeDecorator $role_decorator)
     {