gyselroth / balloon

src/lib/Server.php

Doc Comments +2 added lines, -1 removed lines

@@ -173,6 +173,7 @@ 
     /**
      * Filesystem factory.
      *
+     * @param User $user
      * @return Filesystem
      */
     public function getFilesystem(?User $user = null): Filesystem
@@ -376,7 +377,7 @@ 
      *
      * @param string $id
      *
-     * @return User
+     * @return Group
      */
     public function getGroupById(ObjectId $id): Group
     {

Indentation +2 added lines, -2 removed lines

@@ -543,7 +543,7 @@ 
     public function getGroupByName(string $name): Group
     {
         $attributes = $this->db->group->findOne([
-           'name' => $name,
+            'name' => $name,
         ]);
 
         if (null === $attributes) {
@@ -563,7 +563,7 @@ 
     public function getGroupById(ObjectId $id): Group
     {
         $attributes = $this->db->group->findOne([
-           '_id' => $id,
+            '_id' => $id,
         ]);
 
         if (null === $attributes) {

Spacing +4 added lines, -4 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare(strict_types=1);
+declare(strict_types = 1);
 
 /**
  * balloon
@@ -143,13 +143,13 @@ 
             switch ($name) {
                 case 'temp_dir':
                 case 'password_policy':
-                    $this->{$name} = (string) $value;
+                    $this->{$name} = (string)$value;
 
                 break;
                 case 'max_file_version':
                 case 'max_file_size':
                 case 'password_hash':
-                    $this->{$name} = (int) $value;
+                    $this->{$name} = (int)$value;
 
                 break;
                 default:
@@ -318,7 +318,7 @@ 
 
                 break;
                 case 'admin':
-                    $value = (bool) $value;
+                    $value = (bool)$value;
 
                 break;
                 case 'namespace':

src/lib/Hook/Delta.php

Indentation +2 added lines, -2 removed lines

@@ -424,8 +424,8 @@
         ];
 
         $node->getFilesystem()->getDatabase()->delta->updateMany([
-             'node' => [
-                 '$in' => $toset,
+                'node' => [
+                    '$in' => $toset,
             ],
         ], $action);
 

Spacing +1 added lines, -1 removed lines

@@ -1,6 +1,6 @@
 <?php
 
-declare(strict_types=1);
+declare(strict_types = 1);
 
 /**
  * balloon

src/lib/Hook/AbstractHook.php

Indentation +2 added lines, -2 removed lines

@@ -116,7 +116,7 @@ 
     public function preCopyFile(
         File $node,
         Collection $parent,
-       int $conflict,
+        int $conflict,
         ?string $recursion,
         bool $recursion_first
     ): void {
@@ -129,7 +129,7 @@ 
         File $node,
         Collection $parent,
         File $new_node,
-       int $conflict,
+        int $conflict,
         ?string $recursion,
         bool $recursion_first
     ): void {

Spacing +1 added lines, -1 removed lines

@@ -1,6 +1,6 @@
 <?php
 
-declare(strict_types=1);
+declare(strict_types = 1);
 
 /**
  * balloon

src/lib/Hook/AutoCreateUser.php

Indentation +1 added lines, -1 removed lines

@@ -91,7 +91,7 @@
         }
 
         $this->logger->info('found first time username ['.$identity->getIdentifier().'], auto-create user in mongodb user collection', [
-             'category' => get_class($this),
+                'category' => get_class($this),
         ]);
 
         $attributes = [

Spacing +4 added lines, -4 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare(strict_types=1);
+declare(strict_types = 1);
 
 /**
  * balloon
@@ -110,15 +110,15 @@ 
 
             switch ($value['type']) {
                 case 'string':
-                     $attributes[$attr] = (string) $value['value'];
+                     $attributes[$attr] = (string)$value['value'];
 
                 break;
                 case 'int':
-                     $attributes[$attr] = (int) $value['value'];
+                     $attributes[$attr] = (int)$value['value'];
 
                 break;
                 case 'bool':
-                     $attributes[$attr] = (bool) $value['value'];
+                     $attributes[$attr] = (bool)$value['value'];
 
                 break;
                 case 'binary':

src/app/Balloon.App.Office/Template.php

Indentation +1 added lines, -1 removed lines

@@ -85,6 +85,6 @@
     protected function getTemplate(): string
     {
         return __DIR__.DIRECTORY_SEPARATOR.'assets'
-          .DIRECTORY_SEPARATOR.'template.'.$this->type;
+            .DIRECTORY_SEPARATOR.'template.'.$this->type;
     }
 }

Spacing +1 added lines, -1 removed lines

@@ -1,6 +1,6 @@
 <?php
 
-declare(strict_types=1);
+declare(strict_types = 1);
 
 /**
  * balloon

src/app/Balloon.App.Preview/Hook.php

Unused Use Statements -1 removed lines

@@ -12,7 +12,6 @@
 
 namespace Balloon\App\Preview;
 
-use Balloon\Exception;
 use Balloon\Filesystem\Node\File;
 use Balloon\Hook\AbstractHook;
 use MongoDB\GridFS\Exception\FileNotFoundException;

Spacing +1 added lines, -1 removed lines

@@ -1,6 +1,6 @@
 <?php
 
-declare(strict_types=1);
+declare(strict_types = 1);
 
 /**
  * balloon

src/lib/Filesystem.php

Doc Comments +2 added lines, -2 removed lines

@@ -291,7 +291,7 @@ 
      *
      * @param array  $id
      * @param string $class   Force check node type
-     * @param bool   $deleted
+     * @param integer   $deleted
      *
      * @return Generator
      */
@@ -411,7 +411,7 @@ 
      * @param string $class      Force set node type
      * @param bool   $multiple   Allow $id to be an array
      * @param bool   $allow_root Allow instance of root collection
-     * @param bool   $deleted    How to handle deleted node
+     * @param integer   $deleted    How to handle deleted node
      *
      * @return NodeInterface
      */

Spacing +1 added lines, -1 removed lines

@@ -1,6 +1,6 @@
 <?php
 
-declare(strict_types=1);
+declare(strict_types = 1);
 
 /**
  * balloon

src/lib/Filesystem/Node/File.php

Doc Comments +2 added lines, -2 removed lines

@@ -694,7 +694,7 @@ 
      * @param string $path
      * @param bool   $new
      *
-     * @return bool
+     * @return string
      */
     protected function verifyFile(?string $path, bool $new = false): string
     {
@@ -827,7 +827,7 @@ 
     /**
      * Finalize put request.
      *
-     * @param resource|string $file
+     * @param string|null $file
      * @param bool            $new
      * @param array           $attributes
      *

Unused Use Statements -1 removed lines

@@ -20,7 +20,6 @@
 use Balloon\Helper;
 use Balloon\Hook;
 use Balloon\Mime;
-use Balloon\Server\User;
 use MongoDB\BSON\UTCDateTime;
 use Psr\Log\LoggerInterface;
 

Indentation +1 added lines, -1 removed lines

@@ -589,7 +589,7 @@
         ]);
 
         $this->addVersion($attributes)
-             ->postPutFile($file, $new, $attributes);
+                ->postPutFile($file, $new, $attributes);
 
         return $this->version;
     }

Spacing +14 added lines, -14 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare(strict_types=1);
+declare(strict_types = 1);
 
 /**
  * balloon
@@ -45,14 +45,14 @@ 
      * @param array
      **/
     protected $temp_files = [
-        '/^\._(.*)$/',     // OS/X resource forks
-        '/^.DS_Store$/',   // OS/X custom folder settings
+        '/^\._(.*)$/', // OS/X resource forks
+        '/^.DS_Store$/', // OS/X custom folder settings
         '/^desktop.ini$/', // Windows custom folder settings
-        '/^Thumbs.db$/',   // Windows thumbnail cache
-        '/^.(.*).swpx$/',  // ViM temporary files
-        '/^.(.*).swx$/',   // ViM temporary files
-        '/^.(.*).swp$/',   // ViM temporary files
-        '/^\.dat(.*)$/',   // Smultron seems to create these
+        '/^Thumbs.db$/', // Windows thumbnail cache
+        '/^.(.*).swpx$/', // ViM temporary files
+        '/^.(.*).swx$/', // ViM temporary files
+        '/^.(.*).swp$/', // ViM temporary files
+        '/^\.dat(.*)$/', // Smultron seems to create these
         '/^~lock.(.*)#$/', // Windows 7 lockfiles
     ];
 
@@ -197,7 +197,7 @@ 
         $filtered = [];
 
         foreach ($history as $version) {
-            $v = (array) $version;
+            $v = (array)$version;
 
             $v['user'] = $this->_fs->getServer()->getUserById($version['user'])->getUsername();
             $v['changed'] = Helper::DateTimeToUnix($version['changed']);
@@ -554,7 +554,7 @@ 
         }
 
         $this->hash = $new_hash;
-        $max = (int) (string) $this->_fs->getServer()->getMaxFileVersion();
+        $max = (int)(string)$this->_fs->getServer()->getMaxFileVersion();
         if (count($this->history) >= $max) {
             $del = key($this->history);
             $this->_logger->debug('history limit ['.$max.'] reached, remove oldest version ['.$del.'] from file ['.$this->_id.']', [
@@ -648,8 +648,8 @@ 
     {
         assert(16 === strlen($data));
 
-        $data[6] = chr(ord($data[6]) & 0x0f | 0x40); // set version to 0100
-        $data[8] = chr(ord($data[8]) & 0x3f | 0x80); // set bits 6-7 to 10
+        $data[6] = chr(ord($data[6])&0x0f|0x40); // set version to 0100
+        $data[8] = chr(ord($data[8])&0x3f|0x80); // set bits 6-7 to 10
 
         return vsprintf('%s%s-%s-%s-%s-%s%s%s', str_split(bin2hex($data), 4));
     }
@@ -752,11 +752,11 @@ 
 
             $tmp_file = $tmp.DIRECTORY_SEPARATOR.$this->guidv4(openssl_random_pseudo_bytes(16));
             $stream = fopen($tmp_file, 'w+');
-            $size = stream_copy_to_stream($file, $stream, ((int) $this->_fs->getServer()->getMaxFileSize() + 1));
+            $size = stream_copy_to_stream($file, $stream, ((int)$this->_fs->getServer()->getMaxFileSize() + 1));
             rewind($stream);
             fclose($file);
 
-            if ($size > (int) $this->_fs->getServer()->getMaxFileSize()) {
+            if ($size > (int)$this->_fs->getServer()->getMaxFileSize()) {
                 unlink($tmp_file);
 
                 throw new Exception\InsufficientStorage(

src/app/Balloon.App.Api/Latest/File.php

Doc Comments +1 added lines, -1 removed lines

@@ -107,7 +107,7 @@
      *
      * @param string $id
      * @param string $p
-     * @param string $version
+     * @param integer $version
      *
      * @return Response
      */

Spacing +4 added lines, -4 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare(strict_types=1);
+declare(strict_types = 1);
 
 /**
  * balloon
@@ -293,7 +293,7 @@ 
             $wrote = fwrite($chunkgroup_handler, $data);
             $tmp_size += $wrote;
 
-            if ($tmp_size > (int) $this->server->getMaxFileSize()) {
+            if ($tmp_size > (int)$this->server->getMaxFileSize()) {
                 fclose($input_handler);
                 fclose($chunkgroup_handler);
                 unlink($file);
@@ -497,7 +497,7 @@ 
                 $name = Helper::filter($name);
                 $result = $collection->addFile($name, $content, $attributes)->getId();
 
-                return (new Response())->setCode(201)->setBody((string) $result);
+                return (new Response())->setCode(201)->setBody((string)$result);
             }
         } catch (ForbiddenException $e) {
             throw new Exception\Conflict(
@@ -523,7 +523,7 @@ 
 
                     $result = $parent->addFile($name, $content, $attributes)->getId();
 
-                    return (new Response())->setCode(201)->setBody((string) $result);
+                    return (new Response())->setCode(201)->setBody((string)$result);
                 } catch (Exception\NotFound $e) {
                     throw new Exception('parent collection '.$parent_path.' was not found');
                 }