Balloon\Rest\v1\Parameter\JSON

Complexity

Total Complexity

4

Size/Duplication

Total Lines	27
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	1

Importance

Changes	2
Bugs	0	Features	0

1 Method

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	18	4

<?php
declare(strict_types=1);

/**
 * Balloon
 *
 * @author      Stefan Aebischer <aebischer@pixtron.ch>
 * @copyright   Copryright (c) 2012-2017 gyselroth GmbH (https://gyselroth.com)
 * @license     GPLv3 https://opensource.org/licenses/GPL-3.0
 */

namespace Balloon\Rest\v1\Parameter;

use Balloon\Exception;

class JSON extends \ArrayObject {
    /**
     * Initialize
     *
     * @param  ReflectionParameter $param
     * @param  string $value
     * @return void

Adding a @return annotation to constructors is generally not recommended as a constructor does not have a meaningful return value.

     */
    public function __construct(\ReflectionParameter $param, $value)
    {
        if(is_array($value)) {
          $data = $value;
        } else {
          if(!is_string($value)) {
            throw new Exception\InvalidArgument('Parameter '.$param->name.' expects a json string. ' . gettype($value).' given.');
          }

          $data = json_decode($value);

          if($data === null) {
              throw new Exception\InvalidArgument('Parameter '.$param->name.' expects a valid json string. ' . json_last_error_msg());
          }
        }

        return call_user_func_array(array('parent', __FUNCTION__), [$data]);

Constructors do not have meaningful return values, anything that is returned from here is discarded. Are you sure this is correct?

    }
}