gyselroth / balloon

src/app/Balloon.App.Preview/Hook.php

Unused Use Statements -1 removed lines

@@ -12,7 +12,6 @@
 
 namespace Balloon\App\Preview;
 
-use Balloon\Exception;
 use Balloon\Filesystem\Node\File;
 use Balloon\Hook\AbstractHook;
 use MongoDB\GridFS\Exception\FileNotFoundException;

Spacing +1 added lines, -1 removed lines

@@ -1,6 +1,6 @@
 <?php
 
-declare(strict_types=1);
+declare(strict_types = 1);
 
 /**
  * balloon

src/lib/Filesystem/Node/File.php

Doc Comments +2 added lines, -2 removed lines

@@ -694,7 +694,7 @@ 
      * @param string $path
      * @param bool   $new
      *
-     * @return bool
+     * @return string
      */
     protected function verifyFile(?string $path, bool $new = false): string
     {
@@ -827,7 +827,7 @@ 
     /**
      * Finalize put request.
      *
-     * @param resource|string $file
+     * @param string|null $file
      * @param bool            $new
      * @param array           $attributes
      *

Indentation +1 added lines, -1 removed lines

@@ -589,7 +589,7 @@
         ]);
 
         $this->addVersion($attributes)
-             ->postPutFile($file, $new, $attributes);
+                ->postPutFile($file, $new, $attributes);
 
         return $this->version;
     }

Unused Use Statements -1 removed lines

@@ -18,7 +18,6 @@
 use Balloon\Filesystem\Storage;
 use Balloon\Hook;
 use Balloon\Mime;
-use Balloon\Server\User;
 use MongoDB\BSON\UTCDateTime;
 use Psr\Log\LoggerInterface;
 use Sabre\DAV\IFile;

Spacing +8 added lines, -8 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare(strict_types=1);
+declare(strict_types = 1);
 
 /**
  * balloon
@@ -45,14 +45,14 @@ 
      * @param array
      **/
     protected $temp_files = [
-        '/^\._(.*)$/',     // OS/X resource forks
-        '/^.DS_Store$/',   // OS/X custom folder settings
+        '/^\._(.*)$/', // OS/X resource forks
+        '/^.DS_Store$/', // OS/X custom folder settings
         '/^desktop.ini$/', // Windows custom folder settings
-        '/^Thumbs.db$/',   // Windows thumbnail cache
-        '/^.(.*).swpx$/',  // ViM temporary files
-        '/^.(.*).swx$/',   // ViM temporary files
-        '/^.(.*).swp$/',   // ViM temporary files
-        '/^\.dat(.*)$/',   // Smultron seems to create these
+        '/^Thumbs.db$/', // Windows thumbnail cache
+        '/^.(.*).swpx$/', // ViM temporary files
+        '/^.(.*).swx$/', // ViM temporary files
+        '/^.(.*).swp$/', // ViM temporary files
+        '/^\.dat(.*)$/', // Smultron seems to create these
         '/^~lock.(.*)#$/', // Windows 7 lockfiles
     ];
 

src/lib/Filesystem/Node/NodeInterface.php

Doc Comments +1 added lines, -2 removed lines

@@ -108,14 +108,13 @@
      *
      * @param bool $reference
      *
-     * @return ObjectId
+     * @return ObjectId|null
      */
     public function getShareId(bool $reference = false): ?ObjectId;
 
     /**
      * Get share node.
      *
-     * @param bool $reference
      *
      * @return Collection
      */

Spacing +1 added lines, -1 removed lines

@@ -1,6 +1,6 @@
 <?php
 
-declare(strict_types=1);
+declare(strict_types = 1);
 
 /**
  * balloon

src/lib/Filesystem/Node/AttributeDecorator.php

Doc Comments +1 added lines, -1 removed lines

@@ -60,7 +60,7 @@
      *
      * @param Server    $server
      * @param Acl       $acl
-     * @param Decorator $role_decorator
+     * @param RoleAttributeDecorator $role_decorator
      */
     public function __construct(Server $server, Acl $acl, RoleAttributeDecorator $role_decorator)
     {

Spacing +15 added lines, -15 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare(strict_types=1);
+declare(strict_types = 1);
 
 /**
  * balloon
@@ -131,20 +131,20 @@ 
             'mime' => (string) $attributes['mime'],
             'readonly' => (bool) $attributes['readonly'],
             'directory' => $node instanceof Collection,
-            'meta' => function ($node) {
+            'meta' => function($node) {
                 return (object) $node->getMetaAttributes();
             },
-            'size' => function ($node) {
+            'size' => function($node) {
                 return $node->getSize();
             },
-            'path' => function ($node) {
+            'path' => function($node) {
                 try {
                     return $node->getPath();
                 } catch (\Exception $e) {
                     return null;
                 }
             },
-            'parent' => function ($node) {
+            'parent' => function($node) {
                 $parent = $node->getParent();
 
                 if (null === $parent || $parent->isRoot()) {
@@ -153,10 +153,10 @@ 
 
                 return $this->decorate($node->getParent(), ['id', 'name', '_links']);
             },
-            'access' => function ($node) use ($acl) {
+            'access' => function($node) use ($acl) {
                 return $acl->getAclPrivilege($node);
             },
-            'share' => function ($node) {
+            'share' => function($node) {
                 if ($node->isShared() || !$node->isSpecial()) {
                     return null;
                 }
@@ -167,7 +167,7 @@ 
                     return null;
                 }
             },
-            'sharename' => function ($node) {
+            'sharename' => function($node) {
                 if (!$node->isShared()) {
                     return null;
                 }
@@ -178,7 +178,7 @@ 
                     return null;
                 }
             },
-            'shareowner' => function ($node) use ($server, $fs, $decorator) {
+            'shareowner' => function($node) use ($server, $fs, $decorator) {
                 if (!$node->isSpecial()) {
                     return null;
                 }
@@ -192,7 +192,7 @@ 
                     return null;
                 }
             },
-            'owner' => function ($node) use ($server, $decorator) {
+            'owner' => function($node) use ($server, $decorator) {
                 try {
                     return $decorator->decorate(
                         $server->getUserById($node->getOwner()),
@@ -216,20 +216,20 @@ 
     protected function getTimeAttributes(NodeInterface $node, array $attributes): array
     {
         return [
-            'created' => function ($node) use ($attributes) {
+            'created' => function($node) use ($attributes) {
                 return $attributes['created']->toDateTime()->format('c');
             },
-            'changed' => function ($node) use ($attributes) {
+            'changed' => function($node) use ($attributes) {
                 return $attributes['changed']->toDateTime()->format('c');
             },
-            'deleted' => function ($node) use ($attributes) {
+            'deleted' => function($node) use ($attributes) {
                 if (false === $attributes['deleted']) {
                     return null;
                 }
 
                 return $attributes['deleted']->toDateTime()->format('c');
             },
-            'destroy' => function ($node) use ($attributes) {
+            'destroy' => function($node) use ($attributes) {
                 if (null === $attributes['destroy']) {
                     return null;
                 }
@@ -262,7 +262,7 @@ 
         return [
             'shared' => $node->isShared(),
             'reference' => $node->isReference(),
-            'filter' => function ($node) use ($attributes) {
+            'filter' => function($node) use ($attributes) {
                 if (null === $attributes['filter']) {
                     return null;
                 }

src/app/Balloon.App.Notification/UserMessage.php

Spacing +2 added lines, -2 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare(strict_types=1);
+declare(strict_types = 1);
 
 /**
  * balloon
@@ -77,7 +77,7 @@ 
     {
         $role_decorator = $this->role_decorator;
 
-        $string = preg_replace_callback('/(\{user\.(([a-z]\.*)+)\})/', function ($match) use ($user, $role_decorator) {
+        $string = preg_replace_callback('/(\{user\.(([a-z]\.*)+)\})/', function($match) use ($user, $role_decorator) {
             return $role_decorator->decorate($user, [$match[2]])[$match[2]];
         }, $this->{$type});
 

src/lib/Server/User.php

Indentation +2 added lines, -2 removed lines

@@ -734,8 +734,8 @@
 
         $ops[] = [
             '$sort' => [
-               'sum' => -1,
-               '_id' => 1,
+                'sum' => -1,
+                '_id' => 1,
             ],
         ];
 

Doc Comments +2 added lines

@@ -722,6 +722,8 @@
     /**
      * Get resolved groups.
      *
+     * @param integer $offset
+     * @param integer $limit
      * @return Generator
      */
     public function getResolvedGroups(?int $offset = null, ?int $limit = null): ?Generator

Spacing +1 added lines, -1 removed lines

@@ -1,6 +1,6 @@
 <?php
 
-declare(strict_types=1);
+declare(strict_types = 1);
 
 /**
  * balloon

src/lib/Migration/Delta/JsonEncodeFilteredCollection.php

Indentation +1 added lines, -1 removed lines

@@ -50,7 +50,7 @@
             $this->db->storage->updateOne(
                 ['_id' => $object['_id']],
                 [
-                   '$set' => ['filter' => $filter],
+                    '$set' => ['filter' => $filter],
                 ]
             );
         }

Spacing +1 added lines, -1 removed lines

@@ -1,6 +1,6 @@
 <?php
 
-declare(strict_types=1);
+declare(strict_types = 1);
 
 /**
  * balloon

src/app/Balloon.App.Api/v1/File.php

Doc Comments +1 added lines, -1 removed lines

@@ -107,7 +107,7 @@
      *
      * @param string $id
      * @param string $p
-     * @param string $version
+     * @param integer $version
      *
      * @return Response
      */

Spacing +1 added lines, -1 removed lines

@@ -1,6 +1,6 @@
 <?php
 
-declare(strict_types=1);
+declare(strict_types = 1);
 
 /**
  * balloon

src/app/Balloon.App.Api/v1/Node.php

Doc Comments +3 added lines, -3 removed lines

@@ -282,7 +282,7 @@ 
      * @param array|string $id
      * @param array|string $p
      * @param int          $offset
-     * @param int          $legnth
+     * @param int          $length
      * @param string       $encode
      * @param bool         $download
      * @param string       $name
@@ -1420,7 +1420,7 @@ 
      * @param string $class      Force set node type
      * @param bool   $multiple   Allow $id to be an array
      * @param bool   $allow_root Allow instance of root collection
-     * @param bool   $deleted    How to handle deleted node
+     * @param integer   $deleted    How to handle deleted node
      *
      * @return NodeInterface
      */
@@ -1454,7 +1454,7 @@ 
      * @param string $id
      * @param string $path
      * @param string $class   Force set node type
-     * @param bool   $deleted How to handle deleted node
+     * @param integer   $deleted How to handle deleted node
      *
      * @return Generator
      */

Indentation +44 added lines, -44 removed lines

@@ -320,50 +320,50 @@ 
         }
 
         return (new Response())
-          ->setOutputFormat(null)
-          ->setBody(function () use ($node, $encode, $offset, $length) {
-              $mime = $node->getContentType();
-              $stream = $node->get();
-              $name = $node->getName();
-
-              if (null === $stream) {
-                  return;
-              }
-
-              if (0 !== $offset) {
-                  if (fseek($stream, $offset) === -1) {
-                      throw new Exception\Conflict(
+            ->setOutputFormat(null)
+            ->setBody(function () use ($node, $encode, $offset, $length) {
+                $mime = $node->getContentType();
+                $stream = $node->get();
+                $name = $node->getName();
+
+                if (null === $stream) {
+                    return;
+                }
+
+                if (0 !== $offset) {
+                    if (fseek($stream, $offset) === -1) {
+                        throw new Exception\Conflict(
                         'invalid offset requested',
                         Exception\Conflict::INVALID_OFFSET
                     );
-                  }
-              }
-
-              $read = 0;
-              header('Content-Type: '.$mime.'');
-              if ('base64' === $encode) {
-                  header('Content-Encoding: base64');
-                  while (!feof($stream)) {
-                      if (0 !== $length && $read + 8192 > $length) {
-                          echo base64_encode(fread($stream, $length - $read));
-                          exit();
-                      }
-
-                      echo base64_encode(fread($stream, 8192));
-                      $read += 8192;
-                  }
-              } else {
-                  while (!feof($stream)) {
-                      if (0 !== $length && $read + 8192 > $length) {
-                          echo fread($stream, $length - $read);
-                          exit();
-                      }
-
-                      echo fread($stream, 8192);
-                      $read += 8192;
-                  }
-              }
-          });
+                    }
+                }
+
+                $read = 0;
+                header('Content-Type: '.$mime.'');
+                if ('base64' === $encode) {
+                    header('Content-Encoding: base64');
+                    while (!feof($stream)) {
+                        if (0 !== $length && $read + 8192 > $length) {
+                            echo base64_encode(fread($stream, $length - $read));
+                            exit();
+                        }
+
+                        echo base64_encode(fread($stream, 8192));
+                        $read += 8192;
+                    }
+                } else {
+                    while (!feof($stream)) {
+                        if (0 !== $length && $read + 8192 > $length) {
+                            echo fread($stream, $length - $read);
+                            exit();
+                        }
+
+                        echo fread($stream, 8192);
+                        $read += 8192;
+                    }
+                }
+            });
     }
 
     /**
@@ -1502,9 +1502,9 @@ 
                 $node->zip($archive);
             } catch (\Exception $e) {
                 $this->logger->debug('failed zip node in multi node request ['.$node->getId().']', [
-                   'category' => get_class($this),
-                   'exception' => $e,
-               ]);
+                    'category' => get_class($this),
+                    'exception' => $e,
+                ]);
             }
         }
 

Spacing +9 added lines, -9 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare(strict_types=1);
+declare(strict_types = 1);
 
 /**
  * balloon
@@ -192,7 +192,7 @@ 
             }
         }
 
-        return $this->bulk($id, $p, function ($node) use ($parent, $conflict, $move) {
+        return $this->bulk($id, $p, function($node) use ($parent, $conflict, $move) {
             if (true === $move) {
                 $node = $node->setParent($parent, $conflict);
             }
@@ -273,7 +273,7 @@ 
 
         $node = $this->_getNode($id, $p);
         if ($node instanceof Collection) {
-            return (new Response())->setBody(function () use ($node) {
+            return (new Response())->setBody(function() use ($node) {
                 $node->getZip();
             });
         }
@@ -292,7 +292,7 @@ 
 
         return (new Response())
           ->setOutputFormat(null)
-          ->setBody(function () use ($node, $encode, $offset, $length) {
+          ->setBody(function() use ($node, $encode, $offset, $length) {
               $mime = $node->getContentType();
               $stream = $node->get();
               $name = $node->getName();
@@ -365,7 +365,7 @@ 
      */
     public function postReadonly($id = null, $p = null, bool $readonly = true): Response
     {
-        return $this->bulk($id, $p, function ($node) use ($readonly) {
+        return $this->bulk($id, $p, function($node) use ($readonly) {
             $node->setReadonly($readonly);
 
             return ['code' => 204];
@@ -618,7 +618,7 @@ 
      */
     public function postMetaAttributes(?string $id = null, ?string $p = null): Response
     {
-        return $this->bulk($id, $p, function ($node) {
+        return $this->bulk($id, $p, function($node) {
             $node->setMetaAttributes($_POST);
 
             return ['code' => 204];
@@ -706,7 +706,7 @@ 
             );
         }
 
-        return $this->bulk($id, $p, function ($node) use ($parent, $conflict) {
+        return $this->bulk($id, $p, function($node) use ($parent, $conflict) {
             $result = $node->copyTo($parent, $conflict);
 
             return [
@@ -770,7 +770,7 @@ 
             );
         }
 
-        return $this->bulk($id, $p, function ($node) use ($parent, $conflict) {
+        return $this->bulk($id, $p, function($node) use ($parent, $conflict) {
             $result = $node->setParent($parent, $conflict);
             if (NodeInterface::CONFLICT_RENAME === $conflict) {
                 return [
@@ -829,7 +829,7 @@ 
             $at = $this->_verifyAttributes(['destroy' => $at])['destroy'];
         }
 
-        return $this->bulk($id, $p, function ($node) use ($force, $ignore_flag, $at) {
+        return $this->bulk($id, $p, function($node) use ($force, $ignore_flag, $at) {
             if (null === $at) {
                 $node->delete($force && $node->isDeleted() || $force && $ignore_flag);
             } else {