Gwa\Image\Dimensions

Complexity

Total Complexity

15

Size/Duplication

Total Lines	117
Duplicated Lines	25.64 %

Coupling/Cohesion

Components	0
Dependencies	0

Importance

Changes	3
Bugs	1	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	resizeToWithin()	0	19	4
C	resizeTo()	0	38	7
A	resizeToWidth()	15	15	2
A	resizeToHeight()	15	15	2

<?php
namespace Gwa\Image;

/**
 * Calculates new image dimensions
 */
class Dimensions
{
    /**
     * @param int $maxwidth
     * @param int $maxheight
     * @return \stdClass
     */
    public function resizeToWithin($width, $height, $maxwidth, $maxheight)
    {
        if ($width <= $maxwidth && $height <= $maxheight) {
            return null;
        }

        // calculate ratio based on widths
        $ratio = $maxwidth / $width;
        if ($height * $ratio > $maxheight) {
            // new height greater than maximum
            $ratio = $maxheight / $height;
        }

        $dimensions = new \stdClass;
        $dimensions->width = max(1, round($width * $ratio));
        $dimensions->height = max(1, round($height * $ratio));

        return $dimensions;
    }

    /**
     * @param int $width
     * @param int $height
     * @param int|null $newwidth
     * @param int|null $newheight
     * @return \stdClass|null
     */
    public function resizeTo($width, $height, $newwidth, $newheight)
    {
        if ($width === $newwidth && $height === $newheight) {
            return null;
        }

        if (!$newheight) {

The expression $newheight of type integer|null is loosely compared to false; this is ambiguous if the integer can be zero. You might want to explicitly use === null instead.

            return $this->resizeToWidth($width, $height, $newwidth);
        }

        if (!$newwidth) {

The expression $newwidth of type integer|null is loosely compared to false; this is ambiguous if the integer can be zero. You might want to explicitly use === null instead.

            return $this->resizeToHeight($width, $height, $newheight);
        }

        $ratio = $newwidth / $width;

        $dimensions = new \stdClass;
        $dimensions->overhang = false;
        $dimensions->width = $newwidth;
        $dimensions->height = $newheight;

        if ($height * $ratio < $newheight) {
            // - height is too small
            // - resize to height, and crop horizontal overhang
            $ratio = $newheight / $height;
            $dimensions->width = max(1, round($width * $ratio));
            $dimensions->height = $newheight;
            $dimensions->overhang = true;
        } elseif ($height * $ratio > $newheight) {
            // - height is too large
            // - resize to width, and crop vertical overhang
            $dimensions->width = $newwidth;
            $dimensions->height = max(1, round($height * $ratio));
            $dimensions->overhang = true;
        }

        return $dimensions;
    }

    /**
     * @param int $width
     * @param int $height
     * @param int $newwidth
     * @return \stdClass|null
     */
    private function resizeToWidth($width, $height, $newwidth)

This method seems to be duplicated in your project.

    {
        if ($width === $newwidth) {
            return null;
        }

        $ratio = $newwidth / $width;

        $dimensions = new \stdClass;
        $dimensions->width = $newwidth;
        $dimensions->height = max(1, round($height * $ratio));
        $dimensions->overhang = false;

        return $dimensions;
    }

    /**
     * @param int $width
     * @param int $height
     * @param int $newheight
     * @return \stdClass
     */
    private function resizeToHeight($width, $height, $newheight)

This method seems to be duplicated in your project.

    {
        if ($height === $newheight) {
            return null;
        }

        $ratio = $newheight / $height;

        $dimensions = new \stdClass;
        $dimensions->width = max(1, round($width * $ratio));
        $dimensions->height = $newheight;
        $dimensions->overhang = false;

        return $dimensions;
    }
}