Issues in RequestException.php (master) - Issues in master - guzzle/guzzle - Measure and Improve Code Quality continuously with Scrutinizer

Issues (56)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Exception/RequestException.php (1 issue)

Labels

Bug 1

Severity

Major 1

Maksim Naumov 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace GuzzleHttp\Exception;

use GuzzleHttp\BodySummarizer;
use GuzzleHttp\BodySummarizerInterface;
use Psr\Http\Client\RequestExceptionInterface;
use Psr\Http\Message\RequestInterface;
use Psr\Http\Message\ResponseInterface;
use Psr\Http\Message\UriInterface;

/**
 * HTTP Request exception
 */
class RequestException extends TransferException implements RequestExceptionInterface
{
    /**
     * @var RequestInterface
     */
    private $request;

    /**
     * @var ResponseInterface|null
     */
    private $response;

    /**
     * @var array
     */
    private $handlerContext;

    public function __construct(
        string $message,
        RequestInterface $request,
        ResponseInterface $response = null,
        \Throwable $previous = null,
        array $handlerContext = []
    ) {
        // Set the code of the exception if the response is set and not future.
        $code = $response ? $response->getStatusCode() : 0;
        parent::__construct($message, $code, $previous);
        $this->request = $request;
        $this->response = $response;
        $this->handlerContext = $handlerContext;
    }

    /**
     * Wrap non-RequestExceptions with a RequestException
     */
    public static function wrapException(RequestInterface $request, \Throwable $e): RequestException
    {
        return $e instanceof RequestException ? $e : new RequestException($e->getMessage(), $request, null, $e);
    }

    /**
     * Factory method to create a new exception with a normalized error message
     *
     * @param RequestInterface             $request        Request sent
     * @param ResponseInterface            $response       Response received
     * @param \Throwable|null              $previous       Previous exception
     * @param array                        $handlerContext Optional handler context
     * @param BodySummarizerInterface|null $bodySummarizer Optional body summarizer
     */
    public static function create(
        RequestInterface $request,
        ResponseInterface $response = null,
        \Throwable $previous = null,
        array $handlerContext = [],
        BodySummarizerInterface $bodySummarizer = null
    ): self {
        if (!$response) {
            return new self(
                'Error completing request',
                $request,
                null,
                $previous,
                $handlerContext
            );
        }

        $level = (int) \floor($response->getStatusCode() / 100);
        if ($level === 4) {
            $label = 'Client error';
            $className = ClientException::class;
        } elseif ($level === 5) {
            $label = 'Server error';
            $className = ServerException::class;
        } else {
            $label = 'Unsuccessful request';
            $className = __CLASS__;
        }

        $uri = $request->getUri();
        $uri = static::obfuscateUri($uri);
class YourClass
{
    private static function getTemperature() {
        return "3422 °C";
}

public static function getSomeVariable()
{
    return static::getTemperature();
}

        // Client Error: `GET /` resulted in a `404 Not Found` response:
        // <html> ... (truncated)
        $message = \sprintf(
            '%s: `%s %s` resulted in a `%s %s` response',
            $label,
            $request->getMethod(),
            $uri,
            $response->getStatusCode(),
            $response->getReasonPhrase()
        );

        $summary = ($bodySummarizer ?? new BodySummarizer())->summarize($response);

        if ($summary !== null) {
            $message .= ":\n{$summary}\n";
        }

        return new $className($message, $request, $response, $previous, $handlerContext);
    }

    /**
     * Obfuscates URI if there is a username and a password present
     */
    private static function obfuscateUri(UriInterface $uri): UriInterface
    {
        $userInfo = $uri->getUserInfo();

        if (false !== ($pos = \strpos($userInfo, ':'))) {
            return $uri->withUserInfo(\substr($userInfo, 0, $pos), '***');
        }

        return $uri;
    }

    /**
     * Get the request that caused the exception
     */
    public function getRequest(): RequestInterface
    {
        return $this->request;
    }

    /**
     * Get the associated response
     */
    public function getResponse(): ?ResponseInterface
    {
        return $this->response;
    }

    /**
     * Check if a response was received
     */
    public function hasResponse(): bool
    {
        return $this->response !== null;
    }

    /**
     * Get contextual information about the error from the underlying handler.
     *
     * The contents of this array will vary depending on which handler you are
     * using. It may also be just an empty array. Relying on this data will
     * couple you to a specific handler, but can give more debug information
     * when needed.
     */
    public function getHandlerContext(): array
    {
        return $this->handlerContext;
    }
}


1			<?php
2
3			namespace GuzzleHttp\Exception;
4
5			use GuzzleHttp\BodySummarizer;
6			use GuzzleHttp\BodySummarizerInterface;
7			use Psr\Http\Client\RequestExceptionInterface;
8			use Psr\Http\Message\RequestInterface;
9			use Psr\Http\Message\ResponseInterface;
10			use Psr\Http\Message\UriInterface;
11
12			/**
13			* HTTP Request exception
14			*/
15			class RequestException extends TransferException implements RequestExceptionInterface
16			{
17			/**
18			* @var RequestInterface
19			*/
20			private $request;
21
22			/**
23			* @var ResponseInterface\|null
24			*/
25			private $response;
26
27			/**
28			* @var array
29			*/
30			private $handlerContext;
31
32			public function __construct(
33			string $message,
34			RequestInterface $request,
35			ResponseInterface $response = null,
36			\Throwable $previous = null,
37			array $handlerContext = []
38			) {
39			// Set the code of the exception if the response is set and not future.
40			$code = $response ? $response->getStatusCode() : 0;
41			parent::__construct($message, $code, $previous);
42			$this->request = $request;
43			$this->response = $response;
44			$this->handlerContext = $handlerContext;
45			}
46
47			/**
48			* Wrap non-RequestExceptions with a RequestException
49			*/
50			public static function wrapException(RequestInterface $request, \Throwable $e): RequestException
51			{
52			return $e instanceof RequestException ? $e : new RequestException($e->getMessage(), $request, null, $e);
53			}
54
55			/**
56			* Factory method to create a new exception with a normalized error message
57			*
58			* @param RequestInterface $request Request sent
59			* @param ResponseInterface $response Response received
60			* @param \Throwable\|null $previous Previous exception
61			* @param array $handlerContext Optional handler context
62			* @param BodySummarizerInterface\|null $bodySummarizer Optional body summarizer
63			*/
64			public static function create(
65			RequestInterface $request,
66			ResponseInterface $response = null,
67			\Throwable $previous = null,
68			array $handlerContext = [],
69			BodySummarizerInterface $bodySummarizer = null
70			): self {
71			if (!$response) {
72			return new self(
73			'Error completing request',
74			$request,
75			null,
76			$previous,
77			$handlerContext
78			);
79			}
80
81			$level = (int) \floor($response->getStatusCode() / 100);
82			if ($level === 4) {
83			$label = 'Client error';
84			$className = ClientException::class;
85			} elseif ($level === 5) {
86			$label = 'Server error';
87			$className = ServerException::class;
88			} else {
89			$label = 'Unsuccessful request';
90			$className = __CLASS__;
91			}
92
93			$uri = $request->getUri();
94			$uri = static::obfuscateUri($uri);
			0 ignored issues – show Bug introduced 2016-09-06 09:07 UTC by Report Bug Copy Issue Report Show Similar Issues like this Since `obfuscateUri()` is declared private, calling it with `static` will lead to errors in possible sub-classes. You can either use `self`, or increase the visibility of `obfuscateUri()` to at least protected. Let’s assume you have a class which uses late-static binding: class YourClass { private static function getTemperature() { return "3422 °C"; } public static function getSomeVariable() { return static::getTemperature(); } } The code above will run fine in your PHP runtime. However, if you now create a sub-class and call the `getSomeVariable()` on that sub-class, you will receive a runtime error: class YourSubClass extends YourClass { private static function getTemperature() { return "-182 °C"; } } print YourSubClass::getSomeVariable(); // Will cause an access error. In the case above, it makes sense to update `SomeClass` to use `self` instead: class YourClass { private static function getTemperature() { return "3422 °C"; } public static function getSomeVariable() { return self::getTemperature(); } } Loading history...
95
96			// Client Error: `GET /` resulted in a `404 Not Found` response:
97			// <html> ... (truncated)
98			$message = \sprintf(
99			'%s: `%s %s` resulted in a `%s %s` response',
100			$label,
101			$request->getMethod(),
102			$uri,
103			$response->getStatusCode(),
104			$response->getReasonPhrase()
105			);
106
107			$summary = ($bodySummarizer ?? new BodySummarizer())->summarize($response);
108
109			if ($summary !== null) {
110			$message .= ":\n{$summary}\n";
111			}
112
113			return new $className($message, $request, $response, $previous, $handlerContext);
114			}
115
116			/**
117			* Obfuscates URI if there is a username and a password present
118			*/
119			private static function obfuscateUri(UriInterface $uri): UriInterface
120			{
121			$userInfo = $uri->getUserInfo();
122
123			if (false !== ($pos = \strpos($userInfo, ':'))) {
124			return $uri->withUserInfo(\substr($userInfo, 0, $pos), '***');
125			}
126
127			return $uri;
128			}
129
130			/**
131			* Get the request that caused the exception
132			*/
133			public function getRequest(): RequestInterface
134			{
135			return $this->request;
136			}
137
138			/**
139			* Get the associated response
140			*/
141			public function getResponse(): ?ResponseInterface
142			{
143			return $this->response;
144			}
145
146			/**
147			* Check if a response was received
148			*/
149			public function hasResponse(): bool
150			{
151			return $this->response !== null;
152			}
153
154			/**
155			* Get contextual information about the error from the underlying handler.
156			*
157			* The contents of this array will vary depending on which handler you are
158			* using. It may also be just an empty array. Relying on this data will
159			* couple you to a specific handler, but can give more debug information
160			* when needed.
161			*/
162			public function getHandlerContext(): array
163			{
164			return $this->handlerContext;
165			}
166			}
167

guzzle / guzzle

Issues (56)

Security Analysis not enabled

src/Exception/RequestException.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like