Anax\Ip2\IpStack::getInfo()

Complexity

Conditions	2
Paths	2

Size

Total Lines	32
Code Lines	23

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	23
CRAP Score	2

Importance

Changes	1
Bugs	0	Features	0

<?php
    public function getInfo($ipAd)
    {
        $ipVal = new IpValidate();

        if ($ipVal->validate($ipAd)) {
            $key = "299a8efa45108d9ed496c061839b0232";

            $cHan = curl_init();

            curl_setopt($cHan, CURLOPT_URL, "http://api.ipstack.com/{$ipAd}?access_key={$key}");

It seems like $cHan can also be of type false; however, parameter $ch of curl_setopt() does only seem to accept resource, maybe add an additional type check?

            curl_setopt($cHan, CURLOPT_RETURNTRANSFER, true);
            curl_setopt($cHan, CURLOPT_HEADER, false);

            $res = json_decode(curl_exec($cHan), true);

It seems like $cHan can also be of type false; however, parameter $ch of curl_exec() does only seem to accept resource, maybe add an additional type check?

            $data["ip"] = $res["ip"];

$data was never initialized. Although not strictly required by PHP, it is generally a good practice to add $data = array(); before regardless.

            $data["type"] = $res["type"];
            $data["country"] = $res["country_name"];
            $data["city"] = $res["city"];
            $data["lat"] = $res["latitude"];
            $data["long"] = $res["longitude"];

            curl_close($cHan);

It seems like $cHan can also be of type false; however, parameter $ch of curl_close() does only seem to accept resource, maybe add an additional type check?

        } else {
            $data["ip"] = $ipAd;
            $data["type"] = "Ogiltig";
            $data["country"] = "Inget";
            $data["city"] = "Ingen";
            $data["lat"] = "";
            $data["long"] = "";
        }
        return $data;
    }