ShowAllService::getValHtml() - Code Metrics - Inspection of "Testing codeclimate" - guni12/comment - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 66b618...d2e9dc )

by Gunvor

created 2017-10-20 11:25 UTC

ShowAllService::getValHtml() A

↳ Parent: ShowAllService

Complexity

Conditions	2
Paths	2

Size

Total Lines	12
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	6

Importance

Changes

Metric	Value
dl	0
loc	12
ccs	0
cts	10
cp	0
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	9
nc	2
nop	3
crap	6

<?php

namespace Anax\Comments;

use \Anax\DI\DIInterface;
use \Anax\Comments\Comm;

/**
 * Form to update an item.
 */
class ShowAllService
{
    /**
    * @var array $comments, all comments.
    */
    protected $comments;
    protected $sess;
    protected $users;
    protected $user;

    /**
     * Constructor injects with DI container and the id to update.
     *
     * @param Anax\DI\DIInterface $di a service container
     */
    public function __construct(DIInterface $di)
    {
        $this->di = $di;
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->comments = $this->getAll();
        $session = $this->di->get("session");
        $this->sess = $session->get("user");
        $addsess = isset($this->sess) ? $this->sess : null;
        $this->sess = $addsess;
        $userController = $this->di->get("userController");
        $this->users = $userController->getAllUsers();
        $this->user = $userController->getOne($this->sess['id']);
    }

    /**
     * Get details on all comments.
     *
     * @return Comm
     */
    public function getAll()
    {
        $comm = new Comm();
        $comm->setDb($this->di->get("db"));
        return $comm->findAll();
    }


    /**
     * Sets the callable to use for creating routes.
     *
     * @param callable $urlCreate to create framework urls.
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     *
     * @return void
     */
    public function setUrlCreator($route)
    {
        $url = $this->di->get("url");
        return call_user_func([$url, "create"], $route);
    }


    /**
     * Returns link for gravatar img
     *
     * @param object $item
     *
     * @return string htmlcode
     */
    public function getGravatar($item)
    {
        $comm = new Comm();
        $gravatar = $comm->getGravatar($item);
        return '<img src="' . $gravatar . '" alt=""/>';
    }


    /**
     * Returns text if updated
     *
     * @param object $item
     * @return string htmlcode
     */
    public function getExtra($item)
    {
        $extra = "";
        if ($item) {
            $extra .= '<br />Uppdaterades: ' . $item;
        }
        return $extra;
    }


    /**
     * Returns correct loginlink
     *
     * @param boolean $isadmin
     * @param string $create
     * @param string $del
     *
     * @return string htmlcode
     */
    public function getLoginLink($isadmin, $create, $del)
    {
        $loggedin = '<a href="user/login">Logga in om du vill kommentera</a>';
        if ($this->sess['id']) {
            $loggedin = ' <a href="' . $create .'">Skriv ett inlägg</a>';
            if ($isadmin === true) {
                $loggedin .= ' | <a href="' . $del . '">Ta bort ett inlägg</a>';
            }
        }
        return $loggedin;
    }


    /**
     * Returns html for each item
     *
     * @param object $item
     * @param boolean $isadmin
     * @param string $viewone
     *
     * @return string htmlcode
     */
    public function getValHtml($item, $isadmin, $viewone)
    {
        $gravatar = $this->getGravatar($item->email);
        $extra = $this->getExtra($item->updated);
        if ($isadmin === true) {
            $showid = '(' . $item->id . '): ';
        }
        $html = '<h4><a href="' . $viewone . '/' . $item->id . '">';
        $html .= $showid . ' ' . $item->title . '</a></h4><p>';
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
        $html .= $item->created . ' ' . $item->email . ' ' . $gravatar . ' ' . $extra . '</p><hr />';
        return $html;
    }


    /**
     * Returns all text for the view
     *
     * @return string htmlcode
     */
    public function getHTML()
    {
        $loggedin = "";
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        $showid = "";
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        $gravatar = "";
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        $extra = "";
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        $html = "";

        $isadmin = $this->sess['isadmin'] === 1 ? true : false;

        $create = $this->setUrlCreator("comm/create");
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();
        $del = $this->setUrlCreator("comm/admindelete");
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();
        $viewone = $this->setUrlCreator("comm/view-one");
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();

        $loggedin = $this->getLoginLink($isadmin, $create, $del);

        $html .= '<div class="col-sm-12 col-xs-12">
        <div class="col-lg-6 col-sm-7 col-xs-7">
        <h3>Gruppinlägg <span class="small">' . $loggedin . '</span></h3>
        <hr />';

        foreach ($this->comments as $value) {
            if ((int)$value->parentid > 0) {
                continue;
            }
            $html .= $this->getValHtml($value, $isadmin, $viewone);
        }
        
        $html .= '</div></div>';
        return $html;
    }
}


1			<?php
2
3			namespace Anax\Comments;
4
5			use \Anax\DI\DIInterface;
6			use \Anax\Comments\Comm;
7
8			/**
9			* Form to update an item.
10			*/
11			class ShowAllService
12			{
13			/**
14			* @var array $comments, all comments.
15			*/
16			protected $comments;
17			protected $sess;
18			protected $users;
19			protected $user;
20
21			/**
22			* Constructor injects with DI container and the id to update.
23			*
24			* @param Anax\DI\DIInterface $di a service container
25			*/
26			public function __construct(DIInterface $di)
27			{
28			$this->di = $di;
			0 ignored issues – show Bug introduced 2017-10-18 14:28 UTC by Report Bug Copy Issue Report The property `di` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
29			$this->comments = $this->getAll();
30			$session = $this->di->get("session");
31			$this->sess = $session->get("user");
32			$addsess = isset($this->sess) ? $this->sess : null;
33			$this->sess = $addsess;
34			$userController = $this->di->get("userController");
35			$this->users = $userController->getAllUsers();
36			$this->user = $userController->getOne($this->sess['id']);
37			}
38
39			/**
40			* Get details on all comments.
41			*
42			* @return Comm
43			*/
44			public function getAll()
45			{
46			$comm = new Comm();
47			$comm->setDb($this->di->get("db"));
48			return $comm->findAll();
49			}
50
51
52			/**
53			* Sets the callable to use for creating routes.
54			*
55			* @param callable $urlCreate to create framework urls.
			0 ignored issues – show Bug introduced 2017-10-18 14:28 UTC by Report Bug Copy Issue Report There is no parameter named `$urlCreate`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
56			*
57			* @return void
58			*/
59			public function setUrlCreator($route)
60			{
61			$url = $this->di->get("url");
62			return call_user_func([$url, "create"], $route);
63			}
64
65
66			/**
67			* Returns link for gravatar img
68			*
69			* @param object $item
70			*
71			* @return string htmlcode
72			*/
73			public function getGravatar($item)
74			{
75			$comm = new Comm();
76			$gravatar = $comm->getGravatar($item);
77			return '<img src="' . $gravatar . '" alt=""/>';
78			}
79
80
81			/**
82			* Returns text if updated
83			*
84			* @param object $item
85			* @return string htmlcode
86			*/
87			public function getExtra($item)
88			{
89			$extra = "";
90			if ($item) {
91			$extra .= '<br />Uppdaterades: ' . $item;
92			}
93			return $extra;
94			}
95
96
97			/**
98			* Returns correct loginlink
99			*
100			* @param boolean $isadmin
101			* @param string $create
102			* @param string $del
103			*
104			* @return string htmlcode
105			*/
106			public function getLoginLink($isadmin, $create, $del)
107			{
108			$loggedin = '<a href="user/login">Logga in om du vill kommentera</a>';
109			if ($this->sess['id']) {
110			$loggedin = ' <a href="' . $create .'">Skriv ett inlägg</a>';
111			if ($isadmin === true) {
112			$loggedin .= ' \| <a href="' . $del . '">Ta bort ett inlägg</a>';
113			}
114			}
115			return $loggedin;
116			}
117
118
119			/**
120			* Returns html for each item
121			*
122			* @param object $item
123			* @param boolean $isadmin
124			* @param string $viewone
125			*
126			* @return string htmlcode
127			*/
128			public function getValHtml($item, $isadmin, $viewone)
129			{
130			$gravatar = $this->getGravatar($item->email);
131			$extra = $this->getExtra($item->updated);
132			if ($isadmin === true) {
133			$showid = '(' . $item->id . '): ';
134			}
135			$html = '<h4><a href="' . $viewone . '/' . $item->id . '">';
136			$html .= $showid . ' ' . $item->title . '</a></h4><p>';
			0 ignored issues – show Bug introduced 2017-10-20 11:27 UTC by Report Bug Copy Issue Report The variable `$showid` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
137			$html .= $item->created . ' ' . $item->email . ' ' . $gravatar . ' ' . $extra . '</p><hr />';
138			return $html;
139			}
140
141
142			/**
143			* Returns all text for the view
144			*
145			* @return string htmlcode
146			*/
147			public function getHTML()
148			{
149			$loggedin = "";
			0 ignored issues – show Unused Code introduced 2017-10-18 14:28 UTC by Report Bug Copy Issue Report `$loggedin` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
150			$showid = "";
			0 ignored issues – show Unused Code introduced 2017-10-20 11:27 UTC by Report Bug Copy Issue Report `$showid` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
151			$gravatar = "";
			0 ignored issues – show Unused Code introduced 2017-10-18 14:28 UTC by Report Bug Copy Issue Report `$gravatar` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
152			$extra = "";
			0 ignored issues – show Unused Code introduced 2017-10-18 14:28 UTC by Report Bug Copy Issue Report `$extra` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
153			$html = "";
154
155			$isadmin = $this->sess['isadmin'] === 1 ? true : false;
156
157			$create = $this->setUrlCreator("comm/create");
			0 ignored issues – show Bug introduced 2017-10-18 14:28 UTC by Report Bug Copy Issue Report Are you sure the assignment to `$create` is correct as `$this->setUrlCreator('comm/create')` (which targets `Anax\Comments\ShowAllService::setUrlCreator()`) seems to always return null. This check looks for function or method calls that always return null and whose return value is assigned to a variable. class A { function getObject() { return null; } } $a = new A(); $object = $a->getObject(); The method `getObject()` can return nothing but null, so it makes no sense to assign that value to a variable. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
158			$del = $this->setUrlCreator("comm/admindelete");
			0 ignored issues – show Bug introduced 2017-10-18 14:28 UTC by Report Bug Copy Issue Report Are you sure the assignment to `$del` is correct as `$this->setUrlCreator('comm/admindelete')` (which targets `Anax\Comments\ShowAllService::setUrlCreator()`) seems to always return null. This check looks for function or method calls that always return null and whose return value is assigned to a variable. class A { function getObject() { return null; } } $a = new A(); $object = $a->getObject(); The method `getObject()` can return nothing but null, so it makes no sense to assign that value to a variable. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
159			$viewone = $this->setUrlCreator("comm/view-one");
			0 ignored issues – show Bug introduced 2017-10-18 14:28 UTC by Report Bug Copy Issue Report Are you sure the assignment to `$viewone` is correct as `$this->setUrlCreator('comm/view-one')` (which targets `Anax\Comments\ShowAllService::setUrlCreator()`) seems to always return null. This check looks for function or method calls that always return null and whose return value is assigned to a variable. class A { function getObject() { return null; } } $a = new A(); $object = $a->getObject(); The method `getObject()` can return nothing but null, so it makes no sense to assign that value to a variable. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
160
161			$loggedin = $this->getLoginLink($isadmin, $create, $del);
162
163			$html .= '<div class="col-sm-12 col-xs-12">
164			<div class="col-lg-6 col-sm-7 col-xs-7">
165			<h3>Gruppinlägg <span class="small">' . $loggedin . '</span></h3>
166			<hr />';
167
168			foreach ($this->comments as $value) {
169			if ((int)$value->parentid > 0) {
170			continue;
171			}
172			$html .= $this->getValHtml($value, $isadmin, $viewone);
173			}
174
175			$html .= '</div></div>';
176			return $html;
177			}
178			}
179

guni12 / comment

Push — master ( 66b618...d2e9dc )

ShowAllService::getValHtml() A

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like