GuillermoandraeTest\Highrise\Repositories\RepositoryTest

Complexity

Total Complexity

8

Size/Duplication

Total Lines	71
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

8 Methods

Rating	Name	Duplication	Size	Complexity
A	testFind()	0	8	1
A	testCreate()	0	7	1
A	testSearchWithCriteria()	0	8	1
A	getResource()	0	6	1
A	testDelete()	0	5	1
A	testSearchWithTerm()	0	8	1
A	testUpdate()	0	7	1
A	testFindAll()	0	6	1

<?php

namespace GuillermoandraeTest\Highrise\Repositories;

use Guillermoandrae\Highrise\Http\AdapterInterface;
use Guillermoandrae\Highrise\Repositories\AbstractRepository;
use Guillermoandrae\Highrise\Repositories\RepositoryInterface;
use GuillermoandraeTest\Highrise\Mocks\TestModel;
use GuillermoandraeTest\Highrise\TestCase;

class RepositoryTest extends TestCase
{
    public function testFind()
    {
        $id = '12345';
        $expectedBody = $this->getMockModelXml('test');
        $adapter = $this->getAdapter($this->getMockClient(200, [], $expectedBody));
        $repository = $this->getResource($adapter);
        $item = $repository->find($id);
        $this->assertEquals($id, $item->getId());

The method getId() does not exist on Guillermoandrae\Models\ModelInterface. It seems like you code against a sub-type of said class. However, the method does not exist in Guillermoandrae\Models\AbstractModel. Are you sure you never get one of those?

    }

    public function testFindAll()
    {
        $expectedBody = $this->getMockModelsXml('test');
        $adapter = $this->getAdapter($this->getMockClient(200, [], $expectedBody));
        $repository = $this->getResource($adapter);
        $this->assertCount(2, $repository->findAll());
    }

    public function testSearchWithTerm()
    {
        $expectedBody = $this->getMockModelsXml('test');
        $adapter = $this->getAdapter($this->getMockClient(200, [], $expectedBody));
        $repository = $this->getResource($adapter);
        $repository->search(['term' => 'test']);

The method search() does not exist on Guillermoandrae\Highrise\Repositories\RepositoryInterface. Since it exists in all sub-types, consider adding an abstract or default implementation to Guillermoandrae\Highrise\Repositories\RepositoryInterface.

        $actualQuery = $repository->getAdapter()->getLastRequest()->getUri()->getQuery();
        $this->assertSame(http_build_query(['term' => 'test']), $actualQuery);
    }

    public function testSearchWithCriteria()
    {
        $expectedBody = $this->getMockModelsXml('test');
        $adapter = $this->getAdapter($this->getMockClient(200, [], $expectedBody));
        $repository = $this->getResource($adapter);
        $repository->search(['test' => 'test']);
        $actualQuery = $repository->getAdapter()->getLastRequest()->getUri()->getQuery();
        $this->assertSame(http_build_query(['criteria[test]' => 'test']), $actualQuery);
    }

    public function testCreate()
    {
        $expectedBody = '<test><name>test</name></test>';
        $adapter = $this->getAdapter($this->getMockClient(201, [], $expectedBody));
        $repository = $this->getResource($adapter);
        $results = $repository->create(['name' => 'test']);

The assignment to $results is dead and can be removed.

        $this->assertSame($expectedBody, (string) $repository->getAdapter()->getLastRequest()->getBody());
    }

    public function testUpdate()
    {
        $expectedBody = '<test><name>test</name></test>';
        $adapter = $this->getAdapter($this->getMockClient(201, [], $expectedBody));
        $repository = $this->getResource($adapter);
        $results = $repository->update('123456', ['name' => 'test']);

The assignment to $results is dead and can be removed.

        $this->assertSame($expectedBody, (string) $repository->getAdapter()->getLastRequest()->getBody());
    }

    public function testDelete()
    {
        $adapter = $this->getAdapter($this->getMockClient(200));
        $repository = $this->getResource($adapter);
        $this->assertTrue($repository->delete('123456'));
    }

    private function getResource(AdapterInterface $adapter): RepositoryInterface
    {
        return $this->getMockForAbstractClass(

The expression return $this->getMockForAbstractClass(Guillermoandrae\Highrise\Repositories\AbstractRepository::class, array($adapter), 'Tests') returns the type PHPUnit\Framework\MockObject\MockObject which is incompatible with the type-hinted return Guillermoandrae\Highrise\Repositories\RepositoryInterface.

            AbstractRepository::class,
            [$adapter],
            'Tests'
        );
    }
}