guillermoandrae / php-dynamodb

src/DynamoDb/Operation/GetItemOperation.php

<?php

namespace Guillermoandrae\DynamoDb\Operation;

use Aws\DynamoDb\Exception\DynamoDbException;
use Guillermoandrae\DynamoDb\Contract\AbstractItemOperation;
use Guillermoandrae\DynamoDb\Factory\ExceptionFactory;

/**
 * GetItem operation.
 *
 * @author Guillermo A. Fisher <me@guillermoandraefisher.com>
 * @link https://docs.aws.amazon.com/aws-sdk-php/v3/api/api-dynamodb-2012-08-10.html#getitem
 */
final class GetItemOperation extends AbstractItemOperation
{
    public function execute(): array
    {
        try {
            $item = [];
            $results = $this->client->getItem($this->toArray());
            if (is_array($results['Item'])) {
                $item = $this->getMarshaler()->unmarshalItem($results['Item'], false);

It seems like $results['Item'] can also be of type null; however, parameter $data of Aws\DynamoDb\Marshaler::unmarshalItem() does only seem to accept array, maybe add an additional type check?

            }
            return $item;

The expression return $item could return the type stdClass which is incompatible with the type-hinted return array. Consider adding an additional type-check to rule them out.

        } catch (DynamoDbException $ex) {
            throw ExceptionFactory::factory($ex);
        }
    }
}