DeleteTableOperation::execute() - Code Metrics - Inspection of "Basically rewrote this entire thing." - guillermoandrae/php-dynamodb - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( a7a349...3fc402 )

by Guillermo A.

created 2020-01-08 05:52 UTC

DeleteTableOperation::execute() A

↳ Parent: DeleteTableOperation

Complexity

Conditions	4
Paths	4

Size

Total Lines	12
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	5
CRAP Score	5.4042

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
eloc	9
c	1
b	0
f	0
dl	0
loc	12
rs	9.9666
ccs	5
cts	9
cp	0.5556
cc	4
nc	4
nop	0
crap	5.4042

<?php

namespace Guillermoandrae\DynamoDb\Operation;

use Aws\DynamoDb\Exception\DynamoDbException;
use Guillermoandrae\DynamoDb\Contract\AbstractTableAwareOperation;
use Guillermoandrae\DynamoDb\Exception;
use InvalidArgumentException;

/**
 * @link https://docs.aws.amazon.com/aws-sdk-php/v3/api/api-dynamodb-2012-08-10.html#deletetable
 */
final class DeleteTableOperation extends AbstractTableAwareOperation
{
    /**
     * {@inheritDoc}
     */
    public function execute(): bool
    {
        try {
            $this->client->deleteTable($this->toArray());
            //$this->client->waitUntil('TableExists', ['TableName' => $this->tableName]);
            return true;
        } catch (DynamoDbException $ex) {
            throw new Exception($ex->getMessage());
        } catch (InvalidArgumentException $ex) {
            throw new Exception('Bad key schema: ' . $ex->getMessage());
        } catch (\Exception $ex) {
            die($ex->getMessage());
interface ReturnsInt {
    public function returnsIntHinted(): int;
}

class MyClass implements ReturnsInt {
    public function returnsIntHinted(): int
    {
        if (foo()) {
            return 123;
        }
        // here: null is implicitly returned
    }
}
        }
    }
}


1		<?php
2
3		namespace Guillermoandrae\DynamoDb\Operation;
4
5		use Aws\DynamoDb\Exception\DynamoDbException;
6		use Guillermoandrae\DynamoDb\Contract\AbstractTableAwareOperation;
7		use Guillermoandrae\DynamoDb\Exception;
8		use InvalidArgumentException;
9
10		/**
11		* @link https://docs.aws.amazon.com/aws-sdk-php/v3/api/api-dynamodb-2012-08-10.html#deletetable
12		*/
13		final class DeleteTableOperation extends AbstractTableAwareOperation
14		{
15		/**
16		* {@inheritDoc}
17		*/
18	8	public function execute(): bool
19		{
20		try {
21	8	$this->client->deleteTable($this->toArray());
22		//$this->client->waitUntil('TableExists', ['TableName' => $this->tableName]);
23	7	return true;
24	1	} catch (DynamoDbException $ex) {
25	1	throw new Exception($ex->getMessage());
26		} catch (InvalidArgumentException $ex) {
27		throw new Exception('Bad key schema: ' . $ex->getMessage());
28		} catch (\Exception $ex) {
29		die($ex->getMessage());
		0 ignored issues – show Bug Best Practice introduced 2020-01-08 05:55 UTC by Report Bug Copy Issue Report In this branch, the function will implicitly return `null` which is incompatible with the type-hinted return `boolean`. Consider adding a return statement or allowing `null` as return value. For hinted functions/methods where all return statements with the correct type are only reachable via conditions, ?null? gets implicitly returned which may be incompatible with the hinted type. Let?s take a look at an example: interface ReturnsInt { public function returnsIntHinted(): int; } class MyClass implements ReturnsInt { public function returnsIntHinted(): int { if (foo()) { return 123; } // here: null is implicitly returned } } Loading history... Best Practice introduced 2020-01-08 05:55 UTC by Report Bug Copy Issue Report Using `exit` here is not recommended. In general, usage of exit should be done with care and only when running in a scripting context like a CLI script. Loading history...
30		}
31		}
32		}
33

guillermoandrae / php-dynamodb

Push — master ( a7a349...3fc402 )

DeleteTableOperation::execute() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like