Rico\Slib\FilesystemUtils::listDirectory()

Complexity

Conditions	10
Paths	9

Size

Total Lines	37
Code Lines	24

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	0	Features	0

<?php
    public static function listDirectory(string $path, int $option = self::LIST_DIRECTORY_BOTH): ?array
    {
        if (!file_exists($path) || !is_dir($path)) {
            return null;
        }

        $aResult = [];

        $resourceDir = opendir($path);

        while (false !== ($strFile = readdir($resourceDir))) {

It seems like $resourceDir can also be of type false; however, parameter $dir_handle of readdir() does only seem to accept resource, maybe add an additional type check?

            if (in_array($strFile, ['.', '..'])) {
                continue;
            }

            $strCompleteFile = $path.'/'.$strFile;
            switch ($option) {
                case self::LIST_DIRECTORY_FILE_ONLY:
                    if (!is_dir($strCompleteFile)) {
                        $aResult[] = $strFile;
                    }
                    break;
                case self::LIST_DIRECTORY_DIR_ONLY:
                    if (is_dir($strCompleteFile)) {
                        $aResult[] = $strFile;
                    }
                    break;
                case self::LIST_DIRECTORY_BOTH:
                    $aResult[] = $strFile;
                    break;
                default:
                    return null;
            }
        }
        closedir($resourceDir);

It seems like $resourceDir can also be of type false; however, parameter $dir_handle of closedir() does only seem to accept resource, maybe add an additional type check?

        return $aResult;
    }