OAuth2Middleware::shouldSkipAuthorizationForUri() - Code Metrics - Inspection of "Refactor for a more flexible approach that allows..." - gsomoza/oauth2-middleware - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( f5d9cb...35a455 )

by Gabriel

created 2017-06-25 12:22 UTC

OAuth2Middleware::shouldSkipAuthorizationForUri() A

↳ Parent: OAuth2Middleware

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	2
CRAP Score	1

Importance

Changes

Metric	Value
dl	0
loc	4
ccs	2
cts	2
cp	1
rs	10
c	0
b	0
f	0
cc	1
eloc	2
nc	1
nop	1
crap	1

<?php

namespace Somoza\OAuth2Middleware;

use Assert\Assertion;
use Psr\Http\Message\RequestInterface;
use Somoza\OAuth2Middleware\TokenService\AuthorizesRequests;

/**
 * @author Gabriel Somoza <[email protected]>
 */
final class OAuth2Middleware
{
    /** @var AuthorizesRequests */
    private $tokenService;

    /** @var string[] */
    private $ignoredUris;

    /**
     * Middleware constructor.
     * @param AuthorizesRequests $tokenService
     * @param \string[] $ignoredUris
     */
    public function __construct(AuthorizesRequests $tokenService, array $ignoredUris = [])
    {
        Assertion::allString($ignoredUris);
        $this->ignoredUris = $ignoredUris;

        $this->tokenService = $tokenService;
    }


    /**
     * @param callable $handler
     * @return \Closure
     */
    public function __invoke(callable $handler): \Closure
    {
        return function (RequestInterface $request, array $options) use ($handler) {
            $uri = (string) $request->getUri();
            if (!$this->shouldSkipAuthorizationForUri($uri)) {
                $request = $this->tokenService->authorize($request);
            }

            return $handler($request, $options);
        };
    }

    /**
     * Returns whether a URL must NOT be authorized
     *
     * @param string $uri
     * @return bool
     */
    private function shouldSkipAuthorizationForUri(string $uri): bool
    {
        return in_array($uri, $this->ignoredUris);
    }
}


1		<?php
2
3		namespace Somoza\OAuth2Middleware;
4
5		use Assert\Assertion;
6		use Psr\Http\Message\RequestInterface;
7		use Somoza\OAuth2Middleware\TokenService\AuthorizesRequests;
8
9		/**
10		* @author Gabriel Somoza <[email protected]>
11		*/
12		final class OAuth2Middleware
13		{
14		/** @var AuthorizesRequests */
15		private $tokenService;
16
17		/** @var string[] */
18		private $ignoredUris;
19
20		/**
21		* Middleware constructor.
22		* @param AuthorizesRequests $tokenService
23		* @param \string[] $ignoredUris
24		*/
25	5	public function __construct(AuthorizesRequests $tokenService, array $ignoredUris = [])
26		{
27	5	Assertion::allString($ignoredUris);
28	4	$this->ignoredUris = $ignoredUris;
		0 ignored issues – show Documentation Bug introduced 2017-06-25 11:44 UTC by Report Bug Copy Issue Report It seems like `$ignoredUris` of type `array<integer,object<string>>` is incompatible with the declared type `array<integer,string>` of property `$ignoredUris`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
29	4	$this->tokenService = $tokenService;
30	4	}
31
32
33		/**
34		* @param callable $handler
35		* @return \Closure
36		*/
37		public function __invoke(callable $handler): \Closure
38		{
39	3	return function (RequestInterface $request, array $options) use ($handler) {
40	2	$uri = (string) $request->getUri();
41	2	if (!$this->shouldSkipAuthorizationForUri($uri)) {
42	1	$request = $this->tokenService->authorize($request);
43		}
44
45	2	return $handler($request, $options);
46	3	};
47		}
48
49		/**
50		* Returns whether a URL must NOT be authorized
51		*
52		* @param string $uri
53		* @return bool
54		*/
55	2	private function shouldSkipAuthorizationForUri(string $uri): bool
56		{
57	2	return in_array($uri, $this->ignoredUris);
58		}
59		}
60

gsomoza / oauth2-middleware

Push — master ( f5d9cb...35a455 )

OAuth2Middleware::shouldSkipAuthorizationForUri() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like