Gskema\TypeSniff\Sniffs\CodeElement\FqcnPropSniff::process()

Complexity

Conditions	12
Paths	24

Size

Total Lines	52
Code Lines	36

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	37
CRAP Score	12

Importance

Changes

0

<?php
    public function process(File $file, CodeElementInterface $prop): void
    {
        // @TODO Infer type from initial value?
        $docBlock = $prop->getDocBlock();

        /** @var VarTag|null $varTag */
        $varTag = $docBlock->getTagsByName('var')[0] ?? null;
        $docType = $varTag ? $varTag->getType() : null;

        $subject = 'property $'.$prop->getPropName();

The method getPropName() does not exist on Gskema\TypeSniff\Core\CodeElement\Element\CodeElementInterface. It seems like you code against a sub-type of Gskema\TypeSniff\Core\CodeElement\Element\CodeElementInterface such as Gskema\TypeSniff\Core\CodeElement\Element\AbstractFqcnPropElement.

        if ($docBlock instanceof UndefinedDocBlock) {
            $file->addWarningOnLine(
                'Add PHPDoc for '.$subject,
                $prop->getLine(),
                'FqcnPropSniff'
            );
        } elseif (null === $varTag) {
            $file->addWarningOnLine(
                'Add @var tag for '.$subject,
                $prop->getLine(),
                'FqcnPropSniff'
            );
        } elseif ($docType instanceof UndefinedType) {
            $file->addWarningOnLine(
                'Add type hint to @var tag for '.$subject,
                $prop->getLine(),
                'FqcnPropSniff'
            );
        } elseif ($docType instanceof ArrayType
              || ($docType instanceof CompoundType && $docType->containsType(ArrayType::class))
        ) {
            $file->addWarningOnLine(
                'Replace array type with typed array type in PHPDoc for '.$subject.'. Use mixed[] for generic arrays.',
                $prop->getLine(),
                'FqcnPropSniff'
            );
        } elseif (is_a($prop->getDefaultValueType(), ArrayType::class)

The method getDefaultValueType() does not exist on Gskema\TypeSniff\Core\CodeElement\Element\CodeElementInterface. It seems like you code against a sub-type of Gskema\TypeSniff\Core\CodeElement\Element\CodeElementInterface such as Gskema\TypeSniff\Core\CodeElement\Element\AbstractFqcnPropElement.

              && !is_a($docType, TypedArrayType::class)
        ) {
            $file->addWarningOnLine(
                'Add PHPDoc with typed array type hint for '.$subject.'. Use mixed[] for generic arrays.',
                $prop->getLine(),
                'FqcnPropSniff'
            );
        }

        if ($varTag && null !== $varTag->getParamName()) {
            $file->addWarningOnLine(
                'Remove property name $'.$varTag->getParamName().' from @var tag',
                $prop->getLine(),
                'FqcnPropSniff'
            );