RequestHandler::handle() - Code Metrics - Inspection of "Merge pull request #1 from gsdevme/feat/add-system..." - gsdevme/jumpcloud - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( 853650...6daea0 )

by Gavin

created 2016-06-22 23:11 UTC

RequestHandler::handle() B

↳ Parent: RequestHandler

Complexity

Conditions	3
Paths	3

Size

Total Lines	31
Code Lines	19

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
c	1
b	0
f	1
dl	0
loc	31
rs	8.8571
cc	3
eloc	19
nc	3
nop	2

<?php

namespace JumpCloud\Handler;

use GuzzleHttp\Client as GuzzleClient;
use GuzzleHttp\Exception\ClientException;
use GuzzleHttp\Psr7\Request as HttpRequest;
use GuzzleHttp\Psr7\Response;
use JumpCloud\Request\RequestInterface;
use JumpCloud\Response\ResponseInterface;
use Psr\Log\LoggerInterface;
use Psr\Log\NullLogger;
use Webmozart\Json\JsonEncoder;

/**
 * Class RequestHandler
 *
 * @package JumpCloud
 */
class RequestHandler
{
    /**
     * @var NullLogger
     */
    private $logger;

    /**
     * @var JsonEncoder
     */
    private $jsonEncoder;

    /**
     * RequestHandler constructor.
     *
     * @param LoggerInterface|null $logger
     */
    public function __construct(LoggerInterface $logger = null)
    {
        $this->logger = $logger ?: new NullLogger();
class Alien {}

class Dalek extends Alien {}

class Plot
{
    /** @var  Dalek */
    public $villain;
}

$alien = new Alien();
$plot = new Plot();
if ($alien instanceof Dalek) {
    $plot->villain = $alien;
}
        $this->jsonEncoder = new JsonEncoder();
    }

    /**
     * @param GuzzleClient $client
     * @param RequestInterface $request
     * @return ResponseInterface
     */
    public function handle(GuzzleClient $client, RequestInterface $request)
    {
        try {
            $response = $client->send(
                new HttpRequest(
                    $request->getMethod(),
                    $request->getUri(),
                    $request->getHeaders(),
                    $this->jsonEncoder->encode($request->getBody())
                )
            );
        } catch (\Exception $e) {
            $this->logger->debug(
                sprintf('Exception thrown during Guzzle request'),
                [
                    'message' => $e->getMessage(),
                    'line' => $e->getLine(),
                    'file' => $e->getFile(),
                    'trace' => $e->getTraceAsString()
                ]
            );

            $response = new Response(500);

            if ($e instanceof ClientException) {
                $response = new Response(401);
            }
        }

        return $request->getResponseFactory()->create($response);

    }
}


1			<?php
2
3			namespace JumpCloud\Handler;
4
5			use GuzzleHttp\Client as GuzzleClient;
6			use GuzzleHttp\Exception\ClientException;
7			use GuzzleHttp\Psr7\Request as HttpRequest;
8			use GuzzleHttp\Psr7\Response;
9			use JumpCloud\Request\RequestInterface;
10			use JumpCloud\Response\ResponseInterface;
11			use Psr\Log\LoggerInterface;
12			use Psr\Log\NullLogger;
13			use Webmozart\Json\JsonEncoder;
14
15			/**
16			* Class RequestHandler
17			*
18			* @package JumpCloud
19			*/
20			class RequestHandler
21			{
22			/**
23			* @var NullLogger
24			*/
25			private $logger;
26
27			/**
28			* @var JsonEncoder
29			*/
30			private $jsonEncoder;
31
32			/**
33			* RequestHandler constructor.
34			*
35			* @param LoggerInterface\|null $logger
36			*/
37			public function __construct(LoggerInterface $logger = null)
38			{
39			$this->logger = $logger ?: new NullLogger();
			0 ignored issues – show Documentation Bug introduced 2016-06-16 18:46 UTC by Report Bug Copy Issue Report `$logger ?: new \Psr\Log\NullLogger()` is of type `object<Psr\Log\LoggerInterface>`, but the property `$logger` was declared to be of type `object<Psr\Log\NullLogger>`. Are you sure that you always receive this specific sub-class here, or does it make sense to add an `instanceof` check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a given class or a super-class is assigned to a property that is type hinted more strictly. Either this assignment is in error or an instanceof check should be added for that assignment. class Alien {} class Dalek extends Alien {} class Plot { /** @var Dalek */ public $villain; } $alien = new Alien(); $plot = new Plot(); if ($alien instanceof Dalek) { $plot->villain = $alien; } Loading history...
40			$this->jsonEncoder = new JsonEncoder();
41			}
42
43			/**
44			* @param GuzzleClient $client
45			* @param RequestInterface $request
46			* @return ResponseInterface
47			*/
48			public function handle(GuzzleClient $client, RequestInterface $request)
49			{
50			try {
51			$response = $client->send(
52			new HttpRequest(
53			$request->getMethod(),
54			$request->getUri(),
55			$request->getHeaders(),
56			$this->jsonEncoder->encode($request->getBody())
57			)
58			);
59			} catch (\Exception $e) {
60			$this->logger->debug(
61			sprintf('Exception thrown during Guzzle request'),
62			[
63			'message' => $e->getMessage(),
64			'line' => $e->getLine(),
65			'file' => $e->getFile(),
66			'trace' => $e->getTraceAsString()
67			]
68			);
69
70			$response = new Response(500);
71
72			if ($e instanceof ClientException) {
73			$response = new Response(401);
74			}
75			}
76
77			return $request->getResponseFactory()->create($response);
			0 ignored issues – show Compatibility introduced 2016-06-15 20:24 UTC by Report Bug Copy Issue Report `$response` of type `object<Psr\Http\Message\ResponseInterface>` is not a sub-type of `object<GuzzleHttp\Psr7\Response>`. It seems like you assume a concrete implementation of the interface `Psr\Http\Message\ResponseInterface` to be always present. This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass. Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type. Loading history...
78			}
79			}
80

gsdevme / jumpcloud

GitHub Access Token became invalid

Push — develop ( 853650...6daea0 )

RequestHandler::handle() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like