groupby / api-php

src/API/AbstractBridge.php

Unused Use Statements -1 removed lines

@@ -4,7 +4,6 @@
 
 use Exception;
 use GroupByInc\API\Util\SerializerFactory;
-use GroupByInc\API\Util\UriBuilder;
 use Httpful\Mime;
 use Httpful\Request;
 use Httpful\Response;

Doc Comments +5 added lines, -1 removed lines

@@ -147,7 +147,7 @@ 
   /**
    * @param Response $response
    *
-   * @return bool|string
+   * @return string|false
    */
   private function getContentEncoding($response)
   {
@@ -161,6 +161,10 @@ 
     return false;
   }
 
+  /**
+   * @param string $json
+   * @param string $class
+   */
   private function deserialize($json, $class)
   {
     $object = null;

src/API/Query.php

Unused Use Statements -1 removed lines

@@ -16,7 +16,6 @@
 use GroupByInc\API\Request\RefinementsRequest;
 use GroupByInc\API\Request\Request;
 use GroupByInc\API\Request\RestrictNavigation;
-use GroupByInc\API\Request\SelectedRefinement;
 use GroupByInc\API\Request\SelectedRefinementRange;
 use GroupByInc\API\Request\SelectedRefinementValue;
 use GroupByInc\API\Request\Sort as RSort;

Doc Comments +4 added lines, -1 removed lines

@@ -428,6 +428,9 @@ 
     array_push($this->customUrlParams, $param);
   }
 
+  /**
+   * @param string|null $refinementString
+   */
   public function splitRefinements($refinementString)
   {
     if (StringUtils::isNotBlank($refinementString)) {
@@ -875,7 +878,7 @@ 
   /**
    * @param MBias $bias
    *
-   * @return Bias
+   * @return MBias
    */
   protected static function convertBias($bias)
   {

src/API/Url/UrlBeautifier.php

Unused Use Statements -1 removed lines

@@ -4,7 +4,6 @@
 
 use GroupByInc\API\Model\Navigation;
 use GroupByInc\API\Model\Refinement\Type;
-use GroupByInc\API\Model\SelectedRefinement;
 use GroupByInc\API\Model\SelectedRefinementValue;
 use GroupByInc\API\Query;
 use GroupByInc\API\Symbol;

Doc Comments +6 added lines

@@ -342,6 +342,9 @@ 
     return $lastSegment;
   }
 
+  /**
+   * @param string $pathSegmentLookup
+   */
   private function removeUnusedPathSegments(array &$pathSegments, $pathSegmentLookup)
   {
     while (count($pathSegments) > strlen($pathSegmentLookup)) {
@@ -389,6 +392,9 @@ 
     }
   }
 
+  /**
+   * @param string $token
+   */
   private function getFieldName($token)
   {
     $mapping = $this->tokenToName[$token];

src/API/Url/UrlReplacement.php

Doc Comments +1 added lines, -1 removed lines

@@ -149,7 +149,7 @@
 
   /**
    * @param UrlReplacement[] $replacements
-   * @return string
+   * @return StringBuilder
    */
   public static function buildQueryString(array $replacements)
   {

src/API/Util/StringBuilder.php

Doc Comments +4 added lines

@@ -71,6 +71,10 @@
     $this->string = $front . $back;
   }
 
+  /**
+   * @param integer $index
+   * @param integer $length
+   */
   public function delete($index, $length = null)
   {
     if ($length != null) {

src/API/Url/UrlReplacementRule.php

Unused Use Statements -1 removed lines

@@ -2,7 +2,6 @@
 
 namespace GroupByInc\API\Url;
 
-use GroupByInc\API\Model\SelectedRefinement;
 use GroupByInc\API\Util\StringBuilder;
 
 class UrlReplacementRule

tests/API/Expectation/Object.php

Unused Use Statements -1 removed lines

@@ -18,7 +18,6 @@
 use GroupByInc\API\Model\RichContentZone;
 use GroupByInc\API\Model\Sort;
 use GroupByInc\API\Model\Template;
-use GroupByInc\API\Model\Zone;
 use GroupByInc\API\Request\Bias;
 use GroupByInc\API\Request\Bias\Strength;
 use GroupByInc\API\Request\Biasing;

tests/API/Url/UrlBeautifierTest.php

Doc Comments +18 added lines

@@ -18,6 +18,9 @@ 
         $this->beautifier->clearSavedFields();
     }
 
+    /**
+     * @param string $identifier
+     */
     private function getBeautifier($identifier)
     {
         $beautifiers = UrlBeautifier::getUrlBeautifiers();
@@ -203,6 +206,10 @@ 
         $this->assertNavigation("height", "=20in", $navigations[1]);
     }
 
+    /**
+     * @param string $expectedNavName
+     * @param string $expectedValue
+     */
     public function assertNavigation($expectedNavName, $expectedValue, Navigation $navigation)
     {
         $this->assertEquals($expectedNavName, $navigation->getName());
@@ -284,6 +291,10 @@ 
         $this->assertFromUrl("/aoeu/laptop/MAGNOLIA+HOME+THEATRE/qd/index.html", null, "MAGNOLIA HOME THEATRE");
     }
 
+    /**
+     * @param string $url
+     * @param null|string $searchString
+     */
     private function assertFromUrl($url, $searchString)
     {
         $query = $this->beautifier->fromUrl($url);
@@ -324,6 +335,10 @@ 
             ->setAppend("/index.html");
     }
 
+    /**
+     * @param string|null $searchString
+     * @param null|string $refinementString
+     */
     private function assertToAndFromUrl($searchString, $refinementString)
     {
         $url = $this->beautifier->toUrl($searchString, $refinementString);
@@ -377,6 +392,9 @@ 
         $this->assertFailingQuery("/black+decker/q/index.html?z=2-B--");
     }
 
+    /**
+     * @param string $uri
+     */
     private function assertFailingQuery($uri)
     {
         try {

tests/API/Url/UrlReplacementTest.php

Doc Comments +10 added lines

@@ -121,6 +121,9 @@ 
         $this->assertBadApply("abc12", new UrlReplacement(6, "3", OperationType::Insert));
     }
 
+    /**
+     * @param string $input
+     */
     private function assertBadApply($input, UrlReplacement $replacement)
     {
         $builder = new StringBuilder($input);
@@ -128,6 +131,10 @@ 
         $this->assertEquals($input, $builder);
     }
 
+    /**
+     * @param string $input
+     * @param string $expected
+     */
     private function assertApply($input, $expected, UrlReplacement $replacement)
     {
         $builder = new StringBuilder($input);
@@ -156,6 +163,9 @@ 
         }
     }
 
+    /**
+     * @param string $replacementString
+     */
     private function assertToAndFromString($replacementString)
     {
         $replacement1 = UrlReplacement::fromString($replacementString);