Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
5 | View Code Duplication | class NumericBoost |
|
|
|||
6 | { |
||
7 | /** |
||
8 | * @var string |
||
9 | */ |
||
10 | private $name; |
||
11 | |||
12 | /** |
||
13 | * @var boolean |
||
14 | */ |
||
15 | private $inverted; |
||
16 | |||
17 | /** |
||
18 | * @var double |
||
19 | */ |
||
20 | private $strength = 1.0; |
||
21 | |||
22 | /** |
||
23 | * @return string The name of this Numeric Boost |
||
24 | */ |
||
25 | public function getName() |
||
29 | |||
30 | /** |
||
31 | * Set the name of this Numeric Boost |
||
32 | * |
||
33 | * @param name The string to be the name of this Numeric Boost |
||
34 | * @return This Numeric Boost |
||
35 | */ |
||
36 | public function setName($name) |
||
41 | |||
42 | /** |
||
43 | * @return boolean Whether this is an inverted Numeric Boost |
||
44 | */ |
||
45 | public function isInverted() |
||
46 | { |
||
47 | return $this->inverted; |
||
48 | } |
||
49 | |||
50 | /** |
||
51 | * Set this Numeric Boost to inverted |
||
52 | * |
||
53 | * @param inverted True if this is to be an iverted Numeric Boost, false otherwise |
||
54 | * @return This Numeric Boost |
||
55 | */ |
||
56 | public function setInverted($inverted) |
||
61 | |||
62 | /** |
||
63 | * @return double The strength of this Numeric Boost |
||
64 | */ |
||
65 | public function getStrength() |
||
69 | |||
70 | /** |
||
71 | * Set the strength of this Numeric Boost |
||
72 | * |
||
73 | * @param double The value to be the strength of this Numeric Boost |
||
74 | * @return This Numeric Boost |
||
75 | */ |
||
76 | public function setStrength($strength) |
||
81 | |||
82 | } |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.