CloudBridgeTest

Complexity

Total Complexity

11

Size/Duplication

Total Lines	138
Duplicated Lines	76.09 %

Coupling/Cohesion

Components	2
Dependencies	10

Importance

Changes

0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	testErroneousStatusCode()	18	18	3
A	testErrorOnReturnBinary()	15	15	2
A	testSearch()	12	12	1
A	testSearchCompressedResponse()	12	12	1
A	testSearchRefinements()	13	13	1
A	testMultipleFailingCalls()	19	19	2
A	testSomeFailingCalls()	16	16	1

<?php

use GroupByInc\API\AbstractBridge;
use GroupByInc\API\CloudBridge;
use GroupByInc\API\Model\RefinementsResult;
use GroupByInc\API\Model\Results;
use GroupByInc\API\Query;
use GroupByInc\API\Util\StringUtils;
use Httpful\Request;
use Httpful\Response;

class CloudBridgeTest extends PHPUnit_Framework_TestCase

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    const CLIENT_KEY = 'randomkey';
    const DOMAIN = 'testdomain';
    const SEARCH_URL = 'https://testdomain.groupbycloud.com:443/api/v1/search';
    const REFINEMENT_SEARCH_URL = 'https://testdomain.groupbycloud.com:443/api/v1/search/refinements';
    const HEADERS = "Status 200\r\nContent-Type:application/json\n";
    // Must match expected bridge json
    const TEST_QUERY = '{"clientKey":"randomkey","sort":[],"fields":[],"orFields":[],"refinements":[],"customUrlParams":[],"skip":0,"pageSize":10,"pruneRefinements":true,"wildcardSearchEnabled":false}';
    const TEST_RESPONSE = '{"query":"foobar","pageInfo":{"recordStart":14,"recordEnd":23}}';

    public function testErroneousStatusCode()

This method seems to be duplicated in your project.

    {
        $bridge = Phake::partialMock('GroupByInc\API\CloudBridge', self::CLIENT_KEY, self::DOMAIN);
        Phake::when($bridge)->execute(self::SEARCH_URL, self::TEST_QUERY, 0)
            ->thenReturn(new Response('{"foo":"bar"}', 'Status 400', Request::post('')));

        $query = new Query();
        try {
            /** @var CloudBridge $bridge */
            $bridge->search($query);
            $this->fail("Should have thrown exception here");
        } catch (RuntimeException $e) {
            if (strpos($e->getMessage(), '404 Not Found') !== false) {
                $this->fail("Expected status code 400, found 404");
            }
            // Should throw exception
        }
    }

    public function testErrorOnReturnBinary()

This method seems to be duplicated in your project.

    {
        $bridge = Phake::partialMock('GroupByInc\API\CloudBridge', self::CLIENT_KEY, self::DOMAIN);
        Phake::when($bridge)->execute(self::SEARCH_URL, self::TEST_QUERY, 0)
            ->thenReturn(new Response('{"foo":"bar"}', "Status 200\r\nContent-Type:application/bson\n", Request::post('')));

        $query = new Query();
        try {
            /** @var CloudBridge $bridge */
            $bridge->search($query);
            $this->fail("Should have thrown exception here");
        } catch (RuntimeException $e) {
            // Should throw exception
        }
    }

    public function testSearch()

This method seems to be duplicated in your project.

    {
        $bridge = Phake::partialMock('GroupByInc\API\CloudBridge', self::CLIENT_KEY, self::DOMAIN);
        Phake::when($bridge)->execute(self::SEARCH_URL, self::TEST_QUERY, 0)
            ->thenReturn(new Response(self::TEST_RESPONSE, self::HEADERS, Request::post('')));

        $query = new Query();
        /** @var CloudBridge $bridge */
        /** @var Results $results */
        $results = $bridge->search($query);

The method search() does not seem to exist on object<Phake_IMock>.

        $this->assertEquals('foobar', $results->getQuery());
    }

    public function testSearchCompressedResponse()

This method seems to be duplicated in your project.

    {
        $bridge = Phake::partialMock('GroupByInc\API\CloudBridge', self::CLIENT_KEY, self::DOMAIN);
        Phake::when($bridge)->execute(self::SEARCH_URL, self::TEST_QUERY, 0)
            ->thenReturn(new Response(self::TEST_RESPONSE, self::HEADERS . "Content-Encoding:gzip\n", Request::post('')));

        $query = new Query();
        /** @var CloudBridge $bridge */
        /** @var Results $results */
        $results = $bridge->search($query);

The method search() does not seem to exist on object<Phake_IMock>.

        $this->assertEquals('foobar', $results->getQuery());
    }

    public function testSearchRefinements()

This method seems to be duplicated in your project.

    {
        $refinementsQuery = '{"originalQuery":' . self::TEST_QUERY . ',"navigationName":"height"}';
        $bridge = Phake::partialMock('GroupByInc\API\CloudBridge', self::CLIENT_KEY, self::DOMAIN);
        Phake::when($bridge)->execute(self::REFINEMENT_SEARCH_URL, $refinementsQuery, 0)
            ->thenReturn(new Response('{"navigation":{"name":"foobar"}}', self::HEADERS, Request::post('')));

        $query = new Query();
        /** @var CloudBridge $bridge */
        /** @var RefinementsResult $results */
        $results = $bridge->refinements($query, "height");

The method refinements() does not seem to exist on object<Phake_IMock>.

        $this->assertEquals('foobar', $results->getNavigation()->getName());
    }

    public function testMultipleFailingCalls()

This method seems to be duplicated in your project.

    {
        $bridge = Phake::partialMock('GroupByInc\API\CloudBridge', self::CLIENT_KEY, self::DOMAIN);
        Phake::when($bridge)->execute(self::SEARCH_URL, self::TEST_QUERY, 0)
            ->thenThrow(new Exception('the request failed!'));
        Phake::when($bridge)->execute(self::SEARCH_URL, self::TEST_QUERY, 1)
            ->thenThrow(new Exception('the request failed!'));
        Phake::when($bridge)->execute(self::SEARCH_URL, self::TEST_QUERY, 2)
            ->thenThrow(new Exception('the request failed!'));

        $query = new Query();
        /** @var CloudBridge $bridge */
        try {
            $bridge->search($query);
            $this->fail('expected a "retry failed" exceptions but got none');
        } catch (Exception $e) {
            $this->assertTrue(StringUtils::endsWith($e->getMessage(), 'failed after ' . AbstractBridge::MAX_TRIES . ' tries'));
        }
    }

    public function testSomeFailingCalls()

This method seems to be duplicated in your project.

    {
        $bridge = Phake::partialMock('GroupByInc\API\CloudBridge', self::CLIENT_KEY, self::DOMAIN);
        Phake::when($bridge)->execute(self::SEARCH_URL, self::TEST_QUERY, 0)
            ->thenThrow(new Exception('the request failed!'));
        Phake::when($bridge)->execute(self::SEARCH_URL, self::TEST_QUERY, 1)
            ->thenThrow(new Exception('the request failed!'));
        Phake::when($bridge)->execute(self::SEARCH_URL, self::TEST_QUERY, 2)
            ->thenReturn(new Response(self::TEST_RESPONSE, self::HEADERS, Request::post('')));

        $query = new Query();
        /** @var CloudBridge $bridge */
        /** @var Results $results */
        $results = $bridge->search($query);

The method search() does not seem to exist on object<Phake_IMock>.

        $this->assertNotNull($results);
    }

//    public function testClusterSearch()

55% of this comment could be valid code. Did you maybe forget this after debugging?

//    {
//        $http = Mockery::mock('API\Util\AbstractRequest');
//        $http->shouldReceive('setOption');
//        $http->shouldReceive('getHttpStatusCode')->andReturn(200);
//        $http->shouldReceive('execute')->andReturn(true);
//        $http->shouldReceive('getHttpContentType')->andReturn('application/json');
//        //create fake bridge with empty query, assign the mock http session, try to search, should not get exception
//        $myBridge = new CloudBridge('randomkey', 'somewhere');
//        $myQuery = new Query();
//        /** @noinspection PhpParamsInspection */
//        $myBridge->setSessionCluster($http);
//        $myBridge->searchCluster($myQuery);
//    }
}