Files\Core\UploadHandler::doUpload()

Complexity

Conditions	15
Paths	49

Size

Total Lines	131
Code Lines	78

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

<?php
	public static function doUpload() {
		// parse account id.
		if (isset($_POST["parentID"])) { // will be set if a standard upload is used.
			$dstID = $_POST["parentID"];
		}
		else {
			if (isset($_SERVER['HTTP_X_FILE_DESTINATION'])) { // will be set if the upload is a ajax upload.
				$dstID = $_SERVER['HTTP_X_FILE_DESTINATION'];
			}
			else {
				Logger::error(self::LOG_CONTEXT, "upload failed: No destination given");
				echo json_encode(['success' => false, 'response' => 'No destination given', 'message' => 'No destination given']);

				exit();

Using exit here is not recommended.

			}
		}

		$accountID = substr($dstID, 3, (strpos($dstID, '/') - 3));

		// relative node ID. We need to trim off the #R# and account ID
		$relNodeId = substr($dstID, strpos($dstID, '/'));

		// Initialize the account and backendstore
		$accountStore = new \Files\Core\AccountStore();
		$backendStore = \Files\Backend\BackendStore::getInstance();

		$account = $accountStore->getAccount($accountID);

		// initialize the backend
		$initializedBackend = $backendStore->getInstanceOfBackend($account->getBackend());
		$initializedBackend->init_backend($account->getBackendConfig());

		try {
			$initializedBackend->open();
		}
		catch (\Files\Backend\Exception $e) {
			Logger::error(self::LOG_CONTEXT, "backend initialization failed: " . $e->getMessage());
			echo json_encode(['success' => false, 'response' => $e->getCode(), 'message' => $e->getMessage()]);

			exit();

Using exit here is not recommended.

		}

		// check if we are getting the file via the "new" method (ajax - XMLHttpRequest) or the standard way
		if (isset($_SERVER['HTTP_X_FILE_NAME'], $_SERVER['HTTP_X_FILE_SIZE'])) { // use the ajax method
			$targetPath = stringToUTF8Encode($relNodeId . $_SERVER['HTTP_X_FILE_NAME']);
			// check if backend supports streaming - this is the preferred way to upload files!
			if ($initializedBackend->supports(\Files\Backend\BackendStore::FEATURE_STREAMING)) {
				$fileReader = fopen('php://input', "r");
				$targetPath = UploadHandler::checkFilesNameConflict($targetPath, $initializedBackend, $relNodeId);
				$fileWriter = $initializedBackend->getStreamwriter($targetPath);

The method getStreamwriter() does not exist on Files\Backend\AbstractBackend.

				while (true) {
					set_time_limit(0);
					$buffer = fgets($fileReader, 4096);
					if (strlen($buffer) == 0) {
						fclose($fileReader);
						fclose($fileWriter);
						break;
					}

					fwrite($fileWriter, $buffer);
				}
			}
			else { // fallback to tmp files
				$targetPath = UploadHandler::checkFilesNameConflict($targetPath, $initializedBackend, $relNodeId);
				$targetPath = rawurldecode($targetPath);
				$temp_file = tempnam(TMP_PATH, "{$targetPath}");

The constant Files\Core\TMP_PATH was not found. Maybe you did not declare it correctly or list all dependencies?

				$fileReader = fopen('php://input', "r");
				$fileWriter = fopen($temp_file, "w");

				// store post data to tmp file
				while (true) {
					set_time_limit(0);
					$buffer = fgets($fileReader, 4096);
					if (strlen($buffer) == 0) {
						fclose($fileReader);
						fclose($fileWriter);
						break;
					}

					fwrite($fileWriter, $buffer);
				}

				// upload tmp file to backend
				$initializedBackend->put_file($targetPath, $temp_file);
				// clean up tmp file
				unlink($temp_file);
			}
			echo json_encode(['success' => true, 'parent' => $dstID, 'item' => $targetPath]);

			exit();

Using exit here is not recommended.

		}   // upload the standard way with $_FILES
		$items = [];

		try {
			for ($i = 0; $i < count($_FILES['attachments']['name']); ++$i) {

It seems like you are calling the size function count() as part of the test condition. You might want to compute the size beforehand, and not on each iteration.

				$targetPath = stringToUTF8Encode($relNodeId . $_FILES['attachments']['name'][$i]);

				// upload the file
				// check if backend supports streaming - this is the preferred way to upload files!
				if ($initializedBackend->supports(\Files\Backend\BackendStore::FEATURE_STREAMING)) {
					$fileReader = fopen($_FILES['attachments']['tmp_name'][$i], "r");
					$fileWriter = $initializedBackend->getStreamwriter($targetPath);

					while (true) {
						set_time_limit(0);
						$buffer = fgets($fileReader, 4096);
						if (strlen($buffer) == 0) {
							fclose($fileReader);
							fclose($fileWriter);
							break;
						}

						fwrite($fileWriter, $buffer);
					}
				}
				else { // use the normal way - might have a high memory footprint
					$initializedBackend->put_file($targetPath, $_FILES['attachments']['tmp_name'][$i]);
				}

				$items[] = ['tmp_name' => $_FILES['attachments']['tmp_name'][$i], 'name' => $_FILES['attachments']['name'][$i]];
			}
			echo json_encode(['success' => true, 'parent' => $dstID, 'items' => $items]);

			exit();

Using exit here is not recommended.

		}
		catch (\Files\Backend\Exception $e) {
			Logger::error(self::LOG_CONTEXT, "upload failed: " . $e->getMessage());
			echo json_encode(['success' => false, 'response' => $e->getCode(), 'message' => $e->getMessage()]);

			exit();

Using exit here is not recommended.

		}