@@ -2088,7 +2088,8 @@ discard block |
||
| 2088 | 2088 | if (!empty($action['props']['timezone_iana'])) { |
| 2089 | 2089 | try { |
| 2090 | 2090 | $tzdef = mapi_ianatz_to_tzdef($action['props']['timezone_iana']); |
| 2091 | - } catch (Exception $e) { |
|
| 2091 | + } |
|
| 2092 | + catch (Exception $e) { |
|
| 2092 | 2093 | } |
| 2093 | 2094 | if ($tzdef !== false) { |
| 2094 | 2095 | $action['props']['tzdefstart'] = $action['props']['tzdefend'] = bin2hex($tzdef); |
@@ -3056,8 +3057,9 @@ discard block |
||
| 3056 | 3057 | |
| 3057 | 3058 | if (array_search(strtolower($foldername), $folderNames) !== false) { |
| 3058 | 3059 | $i = 2; |
| 3059 | - while (array_search(strtolower($foldername)." ($i)", $folderNames) !== false) |
|
| 3060 | - ++$i; |
|
| 3060 | + while (array_search(strtolower($foldername)." ($i)", $folderNames) !== false) { |
|
| 3061 | + ++$i; |
|
| 3062 | + } |
|
| 3061 | 3063 | $foldername .= " ($i)"; |
| 3062 | 3064 | } |
| 3063 | 3065 | |
@@ -25,9 +25,11 @@ |
||
| 25 | 25 | * @return bool true on success or false on failure |
| 26 | 26 | */ |
| 27 | 27 | public function execute() { |
| 28 | - foreach ($this->data as $actionType => $actionData) try { |
|
| 28 | + foreach ($this->data as $actionType => $actionData) { |
|
| 29 | + try { |
|
| 29 | 30 | if (!isset($actionType)) |
| 30 | 31 | continue; |
| 32 | + } |
|
| 31 | 33 | switch ($actionType) { |
| 32 | 34 | case 'certificate': |
| 33 | 35 | $data = $this->verifyCertificate($actionData); |
@@ -165,8 +165,9 @@ discard block |
||
| 165 | 165 | if ($messageClass !== 'IPM.Note.SMIME' && |
| 166 | 166 | $messageClass !== 'IPM.Note.SMIME.SignedEncrypt' && |
| 167 | 167 | $messageClass !== 'IPM.Note.deferSMIME' && |
| 168 | - $messageClass !== 'IPM.Note.deferSMIME.SignedEncrypt') |
|
| 169 | - return; |
|
| 168 | + $messageClass !== 'IPM.Note.deferSMIME.SignedEncrypt') { |
|
| 169 | + return; |
|
| 170 | + } |
|
| 170 | 171 | |
| 171 | 172 | $recipients = $data['action']['props']['smime']; |
| 172 | 173 | $missingCerts = []; |
@@ -300,8 +301,9 @@ discard block |
||
| 300 | 301 | $importCert = file_get_contents($outcert); |
| 301 | 302 | $parsedImportCert = openssl_x509_parse($importCert); |
| 302 | 303 | $parsedUserCert = openssl_x509_parse($userCert); |
| 303 | - if (!$signed_ok || $openssl_error_code === OPENSSL_CA_VERIFY_FAIL) |
|
| 304 | - continue; |
|
| 304 | + if (!$signed_ok || $openssl_error_code === OPENSSL_CA_VERIFY_FAIL) { |
|
| 305 | + continue; |
|
| 306 | + } |
|
| 305 | 307 | |
| 306 | 308 | // CA Checks out |
| 307 | 309 | $caCerts = $this->extractCAs($tmpfname); |
@@ -528,8 +530,9 @@ discard block |
||
| 528 | 530 | * @param {mixed} $data |
| 529 | 531 | */ |
| 530 | 532 | public function onUploadCertificate($data) { |
| 531 | - if ($data['sourcetype'] !== 'certificate') |
|
| 532 | - return; |
|
| 533 | + if ($data['sourcetype'] !== 'certificate') { |
|
| 534 | + return; |
|
| 535 | + } |
|
| 533 | 536 | $passphrase = $_POST['passphrase']; |
| 534 | 537 | $saveCert = false; |
| 535 | 538 | $tmpname = $data['tmpname']; |
@@ -604,11 +607,13 @@ discard block |
||
| 604 | 607 | $props = mapi_getprops($message, [PR_MESSAGE_CLASS]); |
| 605 | 608 | $messageClass = $props[PR_MESSAGE_CLASS]; |
| 606 | 609 | |
| 607 | - if (!isset($messageClass)) |
|
| 608 | - return; |
|
| 610 | + if (!isset($messageClass)) { |
|
| 611 | + return; |
|
| 612 | + } |
|
| 609 | 613 | if (stripos($messageClass, 'IPM.Note.deferSMIME') === false && |
| 610 | - stripos($messageClass, 'IPM.Note.SMIME') === false) |
|
| 611 | - return; |
|
| 614 | + stripos($messageClass, 'IPM.Note.SMIME') === false) { |
|
| 615 | + return; |
|
| 616 | + } |
|
| 612 | 617 | |
| 613 | 618 | // FIXME: for now return when we are going to sign but we don't have the passphrase set |
| 614 | 619 | // This should never happen sign |
@@ -617,8 +622,9 @@ discard block |
||
| 617 | 622 | $messageClass === 'IPM.Note.deferSMIME.MultipartSigned' || |
| 618 | 623 | $messageClass === 'IPM.Note.SMIME.SignedEncrypt' || |
| 619 | 624 | $messageClass === 'IPM.Note.SMIME.MultipartSigned') && |
| 620 | - !$encryptionStore->get('smime')) |
|
| 621 | - return; |
|
| 625 | + !$encryptionStore->get('smime')) { |
|
| 626 | + return; |
|
| 627 | + } |
|
| 622 | 628 | // NOTE: setting message class to IPM.Note, so that mapi_inetmapi_imtoinet converts the message to plain email |
| 623 | 629 | // and doesn't fail when handling the attachments. |
| 624 | 630 | mapi_setprops($message, [PR_MESSAGE_CLASS => 'IPM.Note']); |
@@ -862,8 +868,9 @@ discard block |
||
| 862 | 868 | foreach ($certs as $cert) { |
| 863 | 869 | $pubkey = mapi_msgstore_openentry($this->getStore(), $cert[PR_ENTRYID]); |
| 864 | 870 | $certificate = ""; |
| 865 | - if ($pubkey == false) |
|
| 866 | - continue; |
|
| 871 | + if ($pubkey == false) { |
|
| 872 | + continue; |
|
| 873 | + } |
|
| 867 | 874 | // retrieve pkcs#11 certificate from body |
| 868 | 875 | $stream = mapi_openproperty($pubkey, PR_BODY, IID_IStream, 0, 0); |
| 869 | 876 | $stat = mapi_stream_stat($stream); |
@@ -985,8 +992,9 @@ discard block |
||
| 985 | 992 | */ |
| 986 | 993 | public function importCertificate($cert, $certData, $type = 'public', $force = false) { |
| 987 | 994 | $certEmail = getCertEmail($certData); |
| 988 | - if ($this->pubcertExists($certEmail) && !$force && $type !== 'private') |
|
| 989 | - return; |
|
| 995 | + if ($this->pubcertExists($certEmail) && !$force && $type !== 'private') { |
|
| 996 | + return; |
|
| 997 | + } |
|
| 990 | 998 | $issued_by = ""; |
| 991 | 999 | foreach (array_keys($certData['issuer']) as $key) { |
| 992 | 1000 | $issued_by .= $key . '=' . $certData['issuer'][$key] . "\n"; |
@@ -1110,8 +1118,9 @@ discard block |
||
| 1110 | 1118 | * @return array with properties |
| 1111 | 1119 | */ |
| 1112 | 1120 | public function getSenderAddress($mapiMessage) { |
| 1113 | - if (method_exists($GLOBALS['operations'], 'getSenderAddress')) |
|
| 1114 | - return $GLOBALS["operations"]->getSenderAddress($mapiMessage); |
|
| 1121 | + if (method_exists($GLOBALS['operations'], 'getSenderAddress')) { |
|
| 1122 | + return $GLOBALS["operations"]->getSenderAddress($mapiMessage); |
|
| 1123 | + } |
|
| 1115 | 1124 | |
| 1116 | 1125 | $messageProps = mapi_getprops($mapiMessage, [PR_SENT_REPRESENTING_ENTRYID, PR_SENDER_ENTRYID]); |
| 1117 | 1126 | $senderEntryID = isset($messageProps[PR_SENT_REPRESENTING_ENTRYID]) ? $messageProps[PR_SENT_REPRESENTING_ENTRYID] : $messageProps[PR_SENDER_ENTRYID]; |
@@ -98,8 +98,9 @@ |
||
| 98 | 98 | // Get messages from certificates |
| 99 | 99 | foreach ($privateCerts as $privateCert) { |
| 100 | 100 | $privateCertMessage = mapi_msgstore_openentry($store, $privateCert[PR_ENTRYID]); |
| 101 | - if ($privateCertMessage === false) |
|
| 102 | - continue; |
|
| 101 | + if ($privateCertMessage === false) { |
|
| 102 | + continue; |
|
| 103 | + } |
|
| 103 | 104 | $pkcs12 = ""; |
| 104 | 105 | $certs = []; |
| 105 | 106 | // Read pkcs12 cert from message |