Test Failed
Push — master ( c4f486...829997 )
by
unknown
35:45 queued 20:22
created
server/includes/modules/class.resolvenamesmodule.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -242,7 +242,7 @@  discard block
 block discarded – undo
242 242
 		$abHierarchyRows = mapi_table_queryallrows($hierarchyTable, [PR_AB_PROVIDER_ID, PR_ENTRYID]);
243 243
 
244 244
 		// Look for the 'Contacts Folders'
245
-		for ($i = 0,$len = count($abHierarchyRows); $i < $len; ++$i) {
245
+		for ($i = 0, $len = count($abHierarchyRows); $i < $len; ++$i) {
246 246
 			// Check if the folder matches the Contact Provider GUID
247 247
 			if ($abHierarchyRows[$i][PR_AB_PROVIDER_ID] == MUIDZCSAB) {
248 248
 				$abContactContainerEntryid = $abHierarchyRows[$i][PR_ENTRYID];
@@ -258,7 +258,7 @@  discard block
 block discarded – undo
258 258
 			$abContactContainerHierarchyRows = mapi_table_queryallrows($abContactContainerHierarchyTable, [PR_DISPLAY_NAME, PR_OBJECT_TYPE, PR_ENTRYID]);
259 259
 
260 260
 			// Loop through all the contact folders found under the 'Contacts Folders' hierarchy
261
-			for ($j = 0,$len = count($abContactContainerHierarchyRows); $j < $len; ++$j) {
261
+			for ($j = 0, $len = count($abContactContainerHierarchyRows); $j < $len; ++$j) {
262 262
 				// Open, get contents table, restrict, sort and then merge the result in the list of $rows
263 263
 				$abContactFolder = mapi_ab_openentry($ab, $abContactContainerHierarchyRows[$j][PR_ENTRYID]);
264 264
 				$abContactFolderTable = mapi_folder_getcontentstable($abContactFolder, MAPI_DEFERRED_ERRORS);
Please login to merge, or discard this patch.
server/includes/modules/class.addressbooklistmodule.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -851,7 +851,7 @@
 block discarded – undo
851 851
 								],
852 852
 								[
853 853
 									RES_OR,
854
-									$tempRestrictions,     // all group restrictions
854
+									$tempRestrictions, // all group restrictions
855 855
 								],
856 856
 							],
857 857
 						],
Please login to merge, or discard this patch.
server/includes/modules/class.listmodule.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -507,12 +507,12 @@
 block discarded – undo
507 507
 		$data["search_meta"]["searchfolder_entryid"] = $entryid;
508 508
 		$data["search_meta"]["search_store_entryid"] = $action["store_entryid"];
509 509
 		$data["search_meta"]["searchstate"] = $searchState;
510
-		$data["search_meta"]["results"] = $numberOfResults;		// actual number of items that we are sending to client
510
+		$data["search_meta"]["results"] = $numberOfResults; // actual number of items that we are sending to client
511 511
 
512 512
 		$data["page"] = [];
513 513
 		$data["page"]["start"] = 0;
514 514
 		$data["page"]["rowcount"] = $rowCount;
515
-		$data["page"]["totalrowcount"] = $totalRowCount;	// total number of items
515
+		$data["page"]["totalrowcount"] = $totalRowCount; // total number of items
516 516
 
517 517
 		if (!empty($listData)) {
518 518
 			$data["item"] = array_merge([], $listData);
Please login to merge, or discard this patch.
server/includes/modules/class.delegatesmodule.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -575,7 +575,7 @@
 block discarded – undo
575 575
 		];
576 576
 
577 577
 		$rule[PR_RULE_NAME] = '';
578
-		$rule[PR_RULE_PROVIDER_DATA] = '';		// 0 byte binary string
578
+		$rule[PR_RULE_PROVIDER_DATA] = ''; // 0 byte binary string
579 579
 		$rule[PR_RULE_STATE] = ST_ENABLED;
580 580
 		$rule[PR_RULE_LEVEL] = 0;
581 581
 		$rule[PR_RULE_SEQUENCE] = 0;
Please login to merge, or discard this patch.
server/includes/modules/class.hierarchymodule.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -315,7 +315,7 @@
 block discarded – undo
315 315
 								throw new MAPIException(null, MAPI_E_NO_ACCESS);
316 316
 							}
317 317
 
318
-							$noPermissionFolders = array_filter($data['item'][0]['folders']['item'], function ($item) {
318
+							$noPermissionFolders = array_filter($data['item'][0]['folders']['item'], function($item) {
319 319
 								return $item['props']['access'] === 0;
320 320
 							});
321 321
 							if (count($noPermissionFolders) >= $folders) {
Please login to merge, or discard this patch.
server/includes/core/class.mapisession.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -1101,7 +1101,7 @@  discard block
 block discarded – undo
1101 1101
 					// Postfix display name of every contact folder with respective owner name
1102 1102
 					// it is mandatory to keep display-name different
1103 1103
 					$userStoreProps = mapi_getprops($openedUserStore, [PR_MAILBOX_OWNER_NAME]);
1104
-					for ($i = 0,$len = count($userContactFolders); $i < $len; ++$i) {
1104
+					for ($i = 0, $len = count($userContactFolders); $i < $len; ++$i) {
1105 1105
 						$userContactFolders[$i][PR_DISPLAY_NAME] = $userContactFolders[$i][PR_DISPLAY_NAME] . " - " . $userStoreProps[PR_MAILBOX_OWNER_NAME];
1106 1106
 					}
1107 1107
 
@@ -1125,7 +1125,7 @@  discard block
 block discarded – undo
1125 1125
 
1126 1126
 			// Create the lists of store entryids, folder entryids and folder names to be added
1127 1127
 			// to the profile section
1128
-			for ($i = 0,$len = count($contactFolders); $i < $len; ++$i) {
1128
+			for ($i = 0, $len = count($contactFolders); $i < $len; ++$i) {
1129 1129
 				$contact_store_entryids[] = $contactFolders[$i][PR_STORE_ENTRYID];
1130 1130
 				$contact_folder_entryids[] = $contactFolders[$i][PR_ENTRYID];
1131 1131
 				$contact_folder_names[] = $contactFolders[$i][PR_DISPLAY_NAME];
Please login to merge, or discard this patch.
server/includes/core/class.language.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -384,7 +384,7 @@  discard block
 block discarded – undo
384 384
 			if ($data_orig_strs[$i]['length'] > 0) {	// fread does not accept length=0
385 385
 				$length = $data_orig_strs[$i]['length'];
386 386
 				$orig_str = unpack('a' . $length . 'str', fread($fp, $length));
387
-				$translation_data[$i]['msgid'] = $orig_str['str'];	// unpack converts to array :S
387
+				$translation_data[$i]['msgid'] = $orig_str['str']; // unpack converts to array :S
388 388
 
389 389
 				// Find context in the original string
390 390
 				if (strpos($translation_data[$i]['msgid'], "\004") !== false) {
@@ -411,7 +411,7 @@  discard block
 block discarded – undo
411 411
 			if ($data_transl_strs[$i]['length'] > 0) {	// fread does not accept length=0
412 412
 				$length = $data_transl_strs[$i]['length'];
413 413
 				$trans_str = unpack('a' . $length . 'str', fread($fp, $length));
414
-				$translation_data[$i]['msgstr'] = $trans_str['str'];	// unpack converts to array :S
414
+				$translation_data[$i]['msgstr'] = $trans_str['str']; // unpack converts to array :S
415 415
 
416 416
 				// If there are plural forms in the source string,
417 417
 				// then the translated string must contain plural
Please login to merge, or discard this patch.
server/includes/core/class.operations.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -2065,9 +2065,9 @@  discard block
 block discarded – undo
2065 2065
 		$messageProps = [];
2066 2066
 		// It stores the values that is exception allowed or not false -> not allowed
2067 2067
 		$isExceptionAllowed = true;
2068
-		$delete = $actionType == 'delete';	// Flag for MeetingRequest Class whether to send update or cancel mail.
2069
-		$basedate = false;	// Flag for MeetingRequest Class whether to send an exception or not.
2070
-		$isReminderTimeAllowed = true;	// Flag to check reminder minutes is in range of the occurrences
2068
+		$delete = $actionType == 'delete'; // Flag for MeetingRequest Class whether to send update or cancel mail.
2069
+		$basedate = false; // Flag for MeetingRequest Class whether to send an exception or not.
2070
+		$isReminderTimeAllowed = true; // Flag to check reminder minutes is in range of the occurrences
2071 2071
 		$properties = $GLOBALS['properties']->getAppointmentProperties();
2072 2072
 		$send = false;
2073 2073
 		$oldProps = [];
@@ -3016,7 +3016,7 @@  discard block
 block discarded – undo
3016 3016
 			 * convert flags of PR_MESSAGE_FLAGS property to flags that is
3017 3017
 			 * used in mapi_message_setreadflag.
3018 3018
 			 */
3019
-			$flag = MAPI_DEFERRED_ERRORS;		// set unread flag, read receipt will be sent
3019
+			$flag = MAPI_DEFERRED_ERRORS; // set unread flag, read receipt will be sent
3020 3020
 
3021 3021
 			if (($flags & MSGFLAG_RN_PENDING) && isset($msg_action['send_read_receipt']) && $msg_action['send_read_receipt'] == false) {
3022 3022
 				$flag |= SUPPRESS_RECEIPT;
Please login to merge, or discard this patch.
server/includes/core/class.entryid.php 1 patch
Spacing   +35 added lines, -36 removed lines patch added patch discarded remove patch
@@ -54,13 +54,13 @@  discard block
 block discarded – undo
54 54
 		$entryId = strtoupper($entryid);
55 55
 
56 56
 		$res = [
57
-			'abFlags' => '',		// BYTE[4],   4 bytes,  8 hex characters
58
-			'guid' => '',		// GUID,     16 bytes, 32 hex characters
59
-			'version' => '',		// ULONG,     4 bytes,  8 hex characters
60
-			'type' => '',		// ULONG,     4 bytes,  8 hex characters
61
-			'uniqueId' => '',		// ULONG,    16 bytes,  32 hex characters
62
-			'server' => '',		// CHAR,     variable length
63
-			'padding' => '',		// TCHAR[3],  4 bytes,  8 hex characters (upto 4 bytes)
57
+			'abFlags' => '', // BYTE[4],   4 bytes,  8 hex characters
58
+			'guid' => '', // GUID,     16 bytes, 32 hex characters
59
+			'version' => '', // ULONG,     4 bytes,  8 hex characters
60
+			'type' => '', // ULONG,     4 bytes,  8 hex characters
61
+			'uniqueId' => '', // ULONG,    16 bytes,  32 hex characters
62
+			'server' => '', // CHAR,     variable length
63
+			'padding' => '', // TCHAR[3],  4 bytes,  8 hex characters (upto 4 bytes)
64 64
 		];
65 65
 
66 66
 		$res['length'] = strlen($entryId);
@@ -99,13 +99,13 @@  discard block
 block discarded – undo
99 99
 		$entryId = strtoupper($entryid);
100 100
 
101 101
 		$res = [
102
-			'abFlags' => '',		// BYTE[4],   4 bytes,  8 hex characters
103
-			'guid' => '',		// GUID,     16 bytes, 32 hex characters
104
-			'version' => '',		// ULONG,     4 bytes,  8 hex characters
105
-			'type' => '',		// ULONG,     4 bytes,  8 hex characters
106
-			'id' => '',		// ULONG,     4 bytes,  8 hex characters
107
-			'server' => '',		// CHAR,     variable length
108
-			'padding' => '',		// TCHAR[3],  4 bytes,  8 hex characters (upto 4 bytes)
102
+			'abFlags' => '', // BYTE[4],   4 bytes,  8 hex characters
103
+			'guid' => '', // GUID,     16 bytes, 32 hex characters
104
+			'version' => '', // ULONG,     4 bytes,  8 hex characters
105
+			'type' => '', // ULONG,     4 bytes,  8 hex characters
106
+			'id' => '', // ULONG,     4 bytes,  8 hex characters
107
+			'server' => '', // CHAR,     variable length
108
+			'padding' => '', // TCHAR[3],  4 bytes,  8 hex characters (upto 4 bytes)
109 109
 		];
110 110
 
111 111
 		$res['length'] = strlen($entryId);
@@ -184,13 +184,13 @@  discard block
 block discarded – undo
184 184
 		$entryId = strtoupper($entryId);
185 185
 
186 186
 		$res = [
187
-			'abFlags' => '',		// BYTE[4],   4 bytes,  8 hex characters
188
-			'guid' => '',		// GUID,     16 bytes, 32 hex characters
189
-			'version' => '',		// ULONG,     4 bytes,  8 hex characters
190
-			'type' => '',		// ULONG,     4 bytes,  8 hex characters
191
-			'id' => '',		// ULONG,    16 bytes,  32 hex characters
192
-			'extid' => '',		// CHAR,     variable length
193
-			'padding' => '',		// TCHAR[3],  4 bytes,  8 hex characters (upto 4 bytes)
187
+			'abFlags' => '', // BYTE[4],   4 bytes,  8 hex characters
188
+			'guid' => '', // GUID,     16 bytes, 32 hex characters
189
+			'version' => '', // ULONG,     4 bytes,  8 hex characters
190
+			'type' => '', // ULONG,     4 bytes,  8 hex characters
191
+			'id' => '', // ULONG,    16 bytes,  32 hex characters
192
+			'extid' => '', // CHAR,     variable length
193
+			'padding' => '', // TCHAR[3],  4 bytes,  8 hex characters (upto 4 bytes)
194 194
 		];
195 195
 
196 196
 		$res['length'] = strlen($entryId);
@@ -634,8 +634,7 @@  discard block
 block discarded – undo
634 634
 			}
635 635
 		}
636 636
 		elseif ($checkValue !== null && $val != $checkValue) {
637
-			$user = $GLOBALS["mapisession"] !== null ? $GLOBALS["mapisession"]->getUserName() :
638
-					"<mapisession not yet initialized>";
637
+			$user = $GLOBALS["mapisession"] !== null ? $GLOBALS["mapisession"]->getUserName() : "<mapisession not yet initialized>";
639 638
 			error_log(sprintf(
640 639
 				"Unexpected value in store entryid for user %s. Entryid: %s key: '%s' value: '%s' expected: %s",
641 640
 				$user,
@@ -665,13 +664,13 @@  discard block
 block discarded – undo
665 664
 		$entryId = strtoupper($entryId);
666 665
 
667 666
 		$res = [
668
-			'providerguid' => '',			// GUID,     16 bytes, 32 hex characters
669
-			'messagetype' => '',			// UINT,      2 bytes,  4 hex characters
670
-			'folderdbguid' => '',			// GUID,     16 bytes, 32 hex characters
671
-			'foldercounter' => '',		// ULONG,     6 bytes, 12 hex characters
672
-			'padding' => '',					// TCHAR[3],  2 bytes,  4 hex characters
673
-			'messagedbguid' => '',		// GUID,     16 bytes, 32 hex characters
674
-			'messagecounter' => '',	// ULONG,     6 bytes, 12 hex characters
667
+			'providerguid' => '', // GUID,     16 bytes, 32 hex characters
668
+			'messagetype' => '', // UINT,      2 bytes,  4 hex characters
669
+			'folderdbguid' => '', // GUID,     16 bytes, 32 hex characters
670
+			'foldercounter' => '', // ULONG,     6 bytes, 12 hex characters
671
+			'padding' => '', // TCHAR[3],  2 bytes,  4 hex characters
672
+			'messagedbguid' => '', // GUID,     16 bytes, 32 hex characters
673
+			'messagecounter' => '', // ULONG,     6 bytes, 12 hex characters
675 674
 		];
676 675
 
677 676
 		if (!$entryId) {
@@ -731,12 +730,12 @@  discard block
 block discarded – undo
731 730
 		$entryId = strtoupper($entryId);
732 731
 
733 732
 		$res = [
734
-			'abflags' => '',					// BYTE[4],   4 bytes,  8 hex characters
735
-			'providerguid' => '',			// GUID,     16 bytes, 32 hex characters
736
-			'foldertype' => '',				// UINT,      2 bytes,  4 hex characters
737
-			'folderdbguid' => '',			// GUID,     16 bytes, 32 hex characters
738
-			'foldercounter' => '',		// ULONG,     6 bytes, 12 hex characters
739
-			'padding' => '',					// TCHAR[3],  2 bytes,  4 hex characters
733
+			'abflags' => '', // BYTE[4],   4 bytes,  8 hex characters
734
+			'providerguid' => '', // GUID,     16 bytes, 32 hex characters
735
+			'foldertype' => '', // UINT,      2 bytes,  4 hex characters
736
+			'folderdbguid' => '', // GUID,     16 bytes, 32 hex characters
737
+			'foldercounter' => '', // ULONG,     6 bytes, 12 hex characters
738
+			'padding' => '', // TCHAR[3],  2 bytes,  4 hex characters
740 739
 		];
741 740
 
742 741
 		if (!$entryId) {
Please login to merge, or discard this patch.