Inspection of "Merge branch 'indexer' into 'master'" - grommunio/grommunio-web - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 47e36c...1b8f90 )

unknown

created 2024-12-12 18:04 UTC

Status

Switch Indentation +24 added lines, -24 removed lines patch added patch discarded remove patch

@@ -45,37 +45,37 @@
 block discarded – undo
 
 			case 'server.index.load.custom':
 				switch ($data['name']) {
-				case 'files_get_recipients':
-					RecipientHandler::doGetRecipients();
-					break;
+					case 'files_get_recipients':
+						RecipientHandler::doGetRecipients();
+						break;
 
-				case 'download_file':
-					DownloadHandler::doDownload();
-					break;
+					case 'download_file':
+						DownloadHandler::doDownload();
+						break;
 
-				case 'upload_file':
-					UploadHandler::doUpload();
-					break;
+					case 'upload_file':
+						UploadHandler::doUpload();
+						break;
 
-				case 'form':
-					if (isset($_GET['backend'])) {
-						$backend = urldecode($_GET["backend"]);
-					}
-					else {
-						$backend = '';
-					}
-					$backendstore = Files\Backend\BackendStore::getInstance();
+					case 'form':
+						if (isset($_GET['backend'])) {
+							$backend = urldecode($_GET["backend"]);
+						}
+						else {
+							$backend = '';
+						}
+						$backendstore = Files\Backend\BackendStore::getInstance();
 
-					if ($backendstore->backendExists($backend)) {
-						$backendInstance = $backendstore->getInstanceOfBackend($backend);
-						$formdata = $backendInstance->getFormConfig();
+						if ($backendstore->backendExists($backend)) {
+							$backendInstance = $backendstore->getInstanceOfBackend($backend);
+							$formdata = $backendInstance->getFormConfig();
 
-						exit($formdata);
-					}
+							exit($formdata);
+						}
 
-						exit("Specified backend does not exist!");
+							exit("Specified backend does not exist!");
 
-					break;
+						break;
 			}
 			break;
 		}

Please login to merge, or discard this patch.

plugins/smime/php/lib/X509.php 1 patch

Switch Indentation +25 added lines, -25 removed lines patch added patch discarded remove patch

@@ -15,31 +15,31 @@
 block discarded – undo
 		$tag = $this->peek();
 
 		switch ($tag) {
-		case 0:
-			$res['otherName'] = $this->oid(-6);
-			break;
-
-		case 1:
-			$res['rfc822Name'] = $this->next(-22);
-			break;
-
-		case 2:
-			$res['dNSName'] = $this->next(-22);
-			break;
-
-		case 4:
-			$this->next(4);
-			$res['directoryName'] = $this->name();
-			$res['directoryName_'] = $this->nameasstring($res['directoryName']);
-			break;
-
-		case 6:
-			$res['uniformResourceIdentifier'] = $this->next(-22);
-			break;
-
-		default:
-			throw new \Exception("Unsupported GeneralName: {$tag}");
-#                trigger_error("Unsupported GeneralName: $tag", E_USER_ERROR);
+			case 0:
+				$res['otherName'] = $this->oid(-6);
+				break;
+
+			case 1:
+				$res['rfc822Name'] = $this->next(-22);
+				break;
+
+			case 2:
+				$res['dNSName'] = $this->next(-22);
+				break;
+
+			case 4:
+				$this->next(4);
+				$res['directoryName'] = $this->name();
+				$res['directoryName_'] = $this->nameasstring($res['directoryName']);
+				break;
+
+			case 6:
+				$res['uniformResourceIdentifier'] = $this->next(-22);
+				break;
+
+			default:
+				throw new \Exception("Unsupported GeneralName: {$tag}");
+	#                trigger_error("Unsupported GeneralName: $tag", E_USER_ERROR);
 		}
 
 		return $res;

Please login to merge, or discard this patch.

plugins/smime/php/class.certificate.php 1 patch

Switch Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -33,14 +33,14 @@
 block discarded – undo
 		}
 
 		switch ($this->status) {
-		case 'good':
-			return OCSP_CERT_STATUS_GOOD;
+			case 'good':
+				return OCSP_CERT_STATUS_GOOD;
 
-		case 'revoked':
-			return OCSP_CERT_STATUS_REVOKED;
+			case 'revoked':
+				return OCSP_CERT_STATUS_REVOKED;
 
-		default:
-			return OCSP_CERT_STATUS_UNKOWN;
+			default:
+				return OCSP_CERT_STATUS_UNKOWN;
 		}
 	}
 }

Please login to merge, or discard this patch.

plugins/smime/php/class.pluginsmimemodule.php 1 patch

Switch Indentation +50 added lines, -50 removed lines patch added patch discarded remove patch

@@ -29,62 +29,62 @@
 block discarded – undo
 			if (!isset($actionType))
 				continue;
 			switch ($actionType) {
-			case 'certificate':
-				$data = $this->verifyCertificate($actionData);
-				$response = [
-					'type' => 3,
-					'status' => $data['status'],
-					'message' => $data['message'],
-					'data' => $data['data'],
-				];
-				$this->addActionData('certificate', $response);
-				$GLOBALS['bus']->addData($this->getResponseData());
-				break;
+				case 'certificate':
+					$data = $this->verifyCertificate($actionData);
+					$response = [
+						'type' => 3,
+						'status' => $data['status'],
+						'message' => $data['message'],
+						'data' => $data['data'],
+					];
+					$this->addActionData('certificate', $response);
+					$GLOBALS['bus']->addData($this->getResponseData());
+					break;
 
-			case 'passphrase':
-				$data = $this->verifyPassphrase($actionData);
-				$response = [
-					'type' => 3,
-					'status' => $data['status'],
-				];
-				$this->addActionData('passphrase', $response);
-				$GLOBALS['bus']->addData($this->getResponseData());
-				break;
+				case 'passphrase':
+					$data = $this->verifyPassphrase($actionData);
+					$response = [
+						'type' => 3,
+						'status' => $data['status'],
+					];
+					$this->addActionData('passphrase', $response);
+					$GLOBALS['bus']->addData($this->getResponseData());
+					break;
 
-			case 'changepassphrase':
-				$data = $this->changePassphrase($actionData);
-				if ($data === CHANGE_PASSPHRASE_SUCCESS) {
-					// Reset cached passphrase.
-					$encryptionStore = EncryptionStore::getInstance();
-					withPHPSession(function () use ($encryptionStore) {
-						$encryptionStore->add('smime', '');
-					});
-				}
-				$response = [
-					'type' => 3,
-					'code' => $data,
-				];
-				$this->addActionData('changepassphrase', $response);
-				$GLOBALS['bus']->addData($this->getResponseData());
-				break;
+				case 'changepassphrase':
+					$data = $this->changePassphrase($actionData);
+					if ($data === CHANGE_PASSPHRASE_SUCCESS) {
+						// Reset cached passphrase.
+						$encryptionStore = EncryptionStore::getInstance();
+						withPHPSession(function () use ($encryptionStore) {
+							$encryptionStore->add('smime', '');
+						});
+					}
+					$response = [
+						'type' => 3,
+						'code' => $data,
+					];
+					$this->addActionData('changepassphrase', $response);
+					$GLOBALS['bus']->addData($this->getResponseData());
+					break;
 
-			case 'list':
-				$data = $this->getPublicCertificates();
-				$this->addActionData('list', $data);
-				$GLOBALS['bus']->addData($this->getResponseData());
-				break;
+				case 'list':
+					$data = $this->getPublicCertificates();
+					$this->addActionData('list', $data);
+					$GLOBALS['bus']->addData($this->getResponseData());
+					break;
 
-			case 'delete':
-				// FIXME: handle multiple deletes? Separate function?
-				$entryid = $actionData['entryid'];
-				$root = mapi_msgstore_openentry($this->store);
-				mapi_folder_deletemessages($root, [hex2bin($entryid)]);
+				case 'delete':
+					// FIXME: handle multiple deletes? Separate function?
+					$entryid = $actionData['entryid'];
+					$root = mapi_msgstore_openentry($this->store);
+					mapi_folder_deletemessages($root, [hex2bin($entryid)]);
 
-				$this->sendFeedback(true);
-				break;
+					$this->sendFeedback(true);
+					break;
 
-			default:
-				$this->handleUnknownActionType($actionType);
+				default:
+					$this->handleUnknownActionType($actionType);
 			}
 		}
 		catch (Exception $e) {

Please login to merge, or discard this patch.

		@@ -45,37 +45,37 @@
		block discarded – undo
45	45
46	46	case 'server.index.load.custom':
47	47	switch ($data['name']) {
48		- case 'files_get_recipients':
49		- RecipientHandler::doGetRecipients();
50		- break;
	48	+ case 'files_get_recipients':
	49	+ RecipientHandler::doGetRecipients();
	50	+ break;
51	51
52		- case 'download_file':
53		- DownloadHandler::doDownload();
54		- break;
	52	+ case 'download_file':
	53	+ DownloadHandler::doDownload();
	54	+ break;
55	55
56		- case 'upload_file':
57		- UploadHandler::doUpload();
58		- break;
	56	+ case 'upload_file':
	57	+ UploadHandler::doUpload();
	58	+ break;
59	59
60		- case 'form':
61		- if (isset($_GET['backend'])) {
62		- $backend = urldecode($_GET["backend"]);
63		- }
64		- else {
65		- $backend = '';
66		- }
67		- $backendstore = Files\Backend\BackendStore::getInstance();
	60	+ case 'form':
	61	+ if (isset($_GET['backend'])) {
	62	+ $backend = urldecode($_GET["backend"]);
	63	+ }
	64	+ else {
	65	+ $backend = '';
	66	+ }
	67	+ $backendstore = Files\Backend\BackendStore::getInstance();
68	68
69		- if ($backendstore->backendExists($backend)) {
70		- $backendInstance = $backendstore->getInstanceOfBackend($backend);
71		- $formdata = $backendInstance->getFormConfig();
	69	+ if ($backendstore->backendExists($backend)) {
	70	+ $backendInstance = $backendstore->getInstanceOfBackend($backend);
	71	+ $formdata = $backendInstance->getFormConfig();
72	72
73		- exit($formdata);
74		- }
	73	+ exit($formdata);
	74	+ }
75	75
76		- exit("Specified backend does not exist!");
	76	+ exit("Specified backend does not exist!");
77	77
78		- break;
	78	+ break;
79	79	}
80	80	break;
81	81	}

		@@ -15,31 +15,31 @@
		block discarded – undo
15	15	$tag = $this->peek();
16	16
17	17	switch ($tag) {
18		- case 0:
19		- $res['otherName'] = $this->oid(-6);
20		- break;
21		-
22		- case 1:
23		- $res['rfc822Name'] = $this->next(-22);
24		- break;
25		-
26		- case 2:
27		- $res['dNSName'] = $this->next(-22);
28		- break;
29		-
30		- case 4:
31		- $this->next(4);
32		- $res['directoryName'] = $this->name();
33		- $res['directoryName_'] = $this->nameasstring($res['directoryName']);
34		- break;
35		-
36		- case 6:
37		- $res['uniformResourceIdentifier'] = $this->next(-22);
38		- break;
39		-
40		- default:
41		- throw new \Exception("Unsupported GeneralName: {$tag}");
42		-# trigger_error("Unsupported GeneralName: $tag", E_USER_ERROR);
	18	+ case 0:
	19	+ $res['otherName'] = $this->oid(-6);
	20	+ break;
	21	+
	22	+ case 1:
	23	+ $res['rfc822Name'] = $this->next(-22);
	24	+ break;
	25	+
	26	+ case 2:
	27	+ $res['dNSName'] = $this->next(-22);
	28	+ break;
	29	+
	30	+ case 4:
	31	+ $this->next(4);
	32	+ $res['directoryName'] = $this->name();
	33	+ $res['directoryName_'] = $this->nameasstring($res['directoryName']);
	34	+ break;
	35	+
	36	+ case 6:
	37	+ $res['uniformResourceIdentifier'] = $this->next(-22);
	38	+ break;
	39	+
	40	+ default:
	41	+ throw new \Exception("Unsupported GeneralName: {$tag}");
	42	+ # trigger_error("Unsupported GeneralName: $tag", E_USER_ERROR);
43	43	}
44	44
45	45	return $res;

		@@ -33,14 +33,14 @@
		block discarded – undo
33	33	}
34	34
35	35	switch ($this->status) {
36		- case 'good':
37		- return OCSP_CERT_STATUS_GOOD;
	36	+ case 'good':
	37	+ return OCSP_CERT_STATUS_GOOD;
38	38
39		- case 'revoked':
40		- return OCSP_CERT_STATUS_REVOKED;
	39	+ case 'revoked':
	40	+ return OCSP_CERT_STATUS_REVOKED;
41	41
42		- default:
43		- return OCSP_CERT_STATUS_UNKOWN;
	42	+ default:
	43	+ return OCSP_CERT_STATUS_UNKOWN;
44	44	}
45	45	}
46	46	}

		@@ -29,62 +29,62 @@
		block discarded – undo
29	29	if (!isset($actionType))
30	30	continue;
31	31	switch ($actionType) {
32		- case 'certificate':
33		- $data = $this->verifyCertificate($actionData);
34		- $response = [
35		- 'type' => 3,
36		- 'status' => $data['status'],
37		- 'message' => $data['message'],
38		- 'data' => $data['data'],
39		- ];
40		- $this->addActionData('certificate', $response);
41		- $GLOBALS['bus']->addData($this->getResponseData());
42		- break;
	32	+ case 'certificate':
	33	+ $data = $this->verifyCertificate($actionData);
	34	+ $response = [
	35	+ 'type' => 3,
	36	+ 'status' => $data['status'],
	37	+ 'message' => $data['message'],
	38	+ 'data' => $data['data'],
	39	+ ];
	40	+ $this->addActionData('certificate', $response);
	41	+ $GLOBALS['bus']->addData($this->getResponseData());
	42	+ break;
43	43
44		- case 'passphrase':
45		- $data = $this->verifyPassphrase($actionData);
46		- $response = [
47		- 'type' => 3,
48		- 'status' => $data['status'],
49		- ];
50		- $this->addActionData('passphrase', $response);
51		- $GLOBALS['bus']->addData($this->getResponseData());
52		- break;
	44	+ case 'passphrase':
	45	+ $data = $this->verifyPassphrase($actionData);
	46	+ $response = [
	47	+ 'type' => 3,
	48	+ 'status' => $data['status'],
	49	+ ];
	50	+ $this->addActionData('passphrase', $response);
	51	+ $GLOBALS['bus']->addData($this->getResponseData());
	52	+ break;
53	53
54		- case 'changepassphrase':
55		- $data = $this->changePassphrase($actionData);
56		- if ($data === CHANGE_PASSPHRASE_SUCCESS) {
57		- // Reset cached passphrase.
58		- $encryptionStore = EncryptionStore::getInstance();
59		- withPHPSession(function () use ($encryptionStore) {
60		- $encryptionStore->add('smime', '');
61		- });
62		- }
63		- $response = [
64		- 'type' => 3,
65		- 'code' => $data,
66		- ];
67		- $this->addActionData('changepassphrase', $response);
68		- $GLOBALS['bus']->addData($this->getResponseData());
69		- break;
	54	+ case 'changepassphrase':
	55	+ $data = $this->changePassphrase($actionData);
	56	+ if ($data === CHANGE_PASSPHRASE_SUCCESS) {
	57	+ // Reset cached passphrase.
	58	+ $encryptionStore = EncryptionStore::getInstance();
	59	+ withPHPSession(function () use ($encryptionStore) {
	60	+ $encryptionStore->add('smime', '');
	61	+ });
	62	+ }
	63	+ $response = [
	64	+ 'type' => 3,
	65	+ 'code' => $data,
	66	+ ];
	67	+ $this->addActionData('changepassphrase', $response);
	68	+ $GLOBALS['bus']->addData($this->getResponseData());
	69	+ break;
70	70
71		- case 'list':
72		- $data = $this->getPublicCertificates();
73		- $this->addActionData('list', $data);
74		- $GLOBALS['bus']->addData($this->getResponseData());
75		- break;
	71	+ case 'list':
	72	+ $data = $this->getPublicCertificates();
	73	+ $this->addActionData('list', $data);
	74	+ $GLOBALS['bus']->addData($this->getResponseData());
	75	+ break;
76	76
77		- case 'delete':
78		- // FIXME: handle multiple deletes? Separate function?
79		- $entryid = $actionData['entryid'];
80		- $root = mapi_msgstore_openentry($this->store);
81		- mapi_folder_deletemessages($root, [hex2bin($entryid)]);
	77	+ case 'delete':
	78	+ // FIXME: handle multiple deletes? Separate function?
	79	+ $entryid = $actionData['entryid'];
	80	+ $root = mapi_msgstore_openentry($this->store);
	81	+ mapi_folder_deletemessages($root, [hex2bin($entryid)]);
82	82
83		- $this->sendFeedback(true);
84		- break;
	83	+ $this->sendFeedback(true);
	84	+ break;
85	85
86		- default:
87		- $this->handleUnknownActionType($actionType);
	86	+ default:
	87	+ $this->handleUnknownActionType($actionType);
88	88	}
89	89	}
90	90	catch (Exception $e) {

grommunio / grommunio-web

Push — master ( 47e36c...1b8f90 )

Status

Category

Switch Indentation +24 added lines, -24 removed lines patch added patch discarded remove patch

Switch Indentation +25 added lines, -25 removed lines patch added patch discarded remove patch

Switch Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

Switch Indentation +50 added lines, -50 removed lines patch added patch discarded remove patch