ListNotifier::update() - Code Metrics - Inspection of "lang: typo succesful -> successful" - grommunio/grommunio-web - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — master ( 647c72...cd42b5 )

unknown

created 2022-05-28 23:49 UTC

ListNotifier::update() B

↳ Parent: ListNotifier

Complexity

Conditions	11
Paths	11

Size

Total Lines	62
Code Lines	37

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	11
eloc	37
nc	11
nop	3
dl	0
loc	62
rs	7.3166
c	0
b	0
f	0

How to fix Long Method Complexity

<?php
	/**
	 * ListNotifier
	 *
	 * Generates notifications for changes to the
	 * folder contents.
	 */
	class ListNotifier extends Notifier
	{
		/**
		 * @return Number Return the bitmask of events which are handled
		 * by this notifier. The bitmask can consist of the 
		 * OBJECT_SAVE, OBJECT_DELETE, TABLE_SAVE, TABLE_DELETE, REQUEST_START and REQUEST_END flags
		 */
		public function getEvents()
		{
			return OBJECT_SAVE | TABLE_SAVE | TABLE_DELETE;
		}

		/**
		 * Obtain the list of Message Properties which should be returned
		 * to the client when a Message was changed.
		 * @return Array The properties mapping
		 */
		protected function getPropertiesList()
		{
			return Array();
		}
	
		/**
		 * If an event elsewhere has occurred, it enters in this method. This method
		 * executes one ore more actions, depends on the event.
		 * @param int $event Event.
		 * @param string $entryid Entryid.
		 * @param array $data array of data.
		 */
		public function update($event, $entryid, $props)
		{
			switch ($event) {
				case TABLE_SAVE:
					$data = array();

					if (isset($props[PR_STORE_ENTRYID])) {
						$store = $GLOBALS["mapisession"]->openMessageStore($props[PR_STORE_ENTRYID]);

						if (isset($props[PR_ENTRYID])) {
							$properties = $this->getPropertiesList();
							$data = $GLOBALS["operations"]->getMessageProps($store, $GLOBALS["operations"]->openMessage($store, $props[PR_ENTRYID]), $properties);
							$this->addNotificationActionData("update", array( "item" => array($data) ));
						} else if (isset($props[PR_PARENT_ENTRYID])) {
							// An object was created inside this folder for which we don't know the entryid
							// this can happen when we copy or move a message. Just tell the javascript that
							// this folder has a new object.
							$folder = mapi_msgstore_openentry($store, $props[PR_PARENT_ENTRYID]);
							$folderProps = mapi_getprops($folder, array(PR_ENTRYID, PR_PARENT_ENTRYID, PR_STORE_ENTRYID, PR_CONTENT_COUNT, PR_CONTENT_UNREAD, PR_DISPLAY_NAME));

							$data = array(
								"item" => array(
									array(
										"content_count" => $folderProps[PR_CONTENT_COUNT],
										"content_unread" => $folderProps[PR_CONTENT_UNREAD],
										// Add store_entryid,entryid of folder and display_name of folder 
										// to JSON data in order to refresh the list.
										"store_entryid" => bin2hex($folderProps[PR_STORE_ENTRYID]),
										"parent_entryid" => bin2hex($folderProps[PR_PARENT_ENTRYID]),
										"entryid" => bin2hex($folderProps[PR_ENTRYID]),
										"display_name" => $folderProps[PR_DISPLAY_NAME]
									)
								)
							);

							$this->addNotificationActionData("newobject", $data);
						}
					}
					break;
				case TABLE_DELETE:
					$folderEntryID = isset($props[PR_PARENT_ENTRYID]) ? $props[PR_PARENT_ENTRYID] : false;

					if (isset($props[PR_ENTRYID]) && $folderEntryID) {
						$data = array();
						$data["parent_entryid"] = bin2hex($folderEntryID);

						if (is_array($props[PR_ENTRYID])) {
							$data["entryid"] = array();
						
							foreach ($props[PR_ENTRYID] as $entryid) {

								array_push($data["entryid"], bin2hex($entryid));
							}
						} else {
							$data["entryid"] = bin2hex($props[PR_ENTRYID]);
						}
						
						$this->addNotificationActionData("delete", array( "item" => array($data) ));
					}
					break;
			}

			$GLOBALS["bus"]->addData($this->createNotificationResponseData());
		}
	}
?>



1			<?php
2			/**
3			* ListNotifier
4			*
5			* Generates notifications for changes to the
6			* folder contents.
7			*/
8			class ListNotifier extends Notifier
9			{
10			/**
11			* @return Number Return the bitmask of events which are handled
12			* by this notifier. The bitmask can consist of the
13			* OBJECT_SAVE, OBJECT_DELETE, TABLE_SAVE, TABLE_DELETE, REQUEST_START and REQUEST_END flags
14			*/
15			public function getEvents()
16			{
17			return OBJECT_SAVE \| TABLE_SAVE \| TABLE_DELETE;
18			}
19
20			/**
21			* Obtain the list of Message Properties which should be returned
22			* to the client when a Message was changed.
23			* @return Array The properties mapping
24			*/
25			protected function getPropertiesList()
26			{
27			return Array();
28			}
29
30			/**
31			* If an event elsewhere has occurred, it enters in this method. This method
32			* executes one ore more actions, depends on the event.
33			* @param int $event Event.
34			* @param string $entryid Entryid.
35			* @param array $data array of data.
36			*/
37			public function update($event, $entryid, $props)
38			{
39			switch ($event) {
40			case TABLE_SAVE:
41			$data = array();
42
43			if (isset($props[PR_STORE_ENTRYID])) {
44			$store = $GLOBALS["mapisession"]->openMessageStore($props[PR_STORE_ENTRYID]);
45
46			if (isset($props[PR_ENTRYID])) {
47			$properties = $this->getPropertiesList();
48			$data = $GLOBALS["operations"]->getMessageProps($store, $GLOBALS["operations"]->openMessage($store, $props[PR_ENTRYID]), $properties);
49			$this->addNotificationActionData("update", array( "item" => array($data) ));
50			} else if (isset($props[PR_PARENT_ENTRYID])) {
51			// An object was created inside this folder for which we don't know the entryid
52			// this can happen when we copy or move a message. Just tell the javascript that
53			// this folder has a new object.
54			$folder = mapi_msgstore_openentry($store, $props[PR_PARENT_ENTRYID]);
55			$folderProps = mapi_getprops($folder, array(PR_ENTRYID, PR_PARENT_ENTRYID, PR_STORE_ENTRYID, PR_CONTENT_COUNT, PR_CONTENT_UNREAD, PR_DISPLAY_NAME));
56
57			$data = array(
58			"item" => array(
59			array(
60			"content_count" => $folderProps[PR_CONTENT_COUNT],
61			"content_unread" => $folderProps[PR_CONTENT_UNREAD],
62			// Add store_entryid,entryid of folder and display_name of folder
63			// to JSON data in order to refresh the list.
64			"store_entryid" => bin2hex($folderProps[PR_STORE_ENTRYID]),
65			"parent_entryid" => bin2hex($folderProps[PR_PARENT_ENTRYID]),
66			"entryid" => bin2hex($folderProps[PR_ENTRYID]),
67			"display_name" => $folderProps[PR_DISPLAY_NAME]
68			)
69			)
70			);
71
72			$this->addNotificationActionData("newobject", $data);
73			}
74			}
75			break;
76			case TABLE_DELETE:
77			$folderEntryID = isset($props[PR_PARENT_ENTRYID]) ? $props[PR_PARENT_ENTRYID] : false;
78
79			if (isset($props[PR_ENTRYID]) && $folderEntryID) {
80			$data = array();
81			$data["parent_entryid"] = bin2hex($folderEntryID);
82
83			if (is_array($props[PR_ENTRYID])) {
84			$data["entryid"] = array();
85
86			foreach ($props[PR_ENTRYID] as $entryid) {
			0 ignored issues – show introduced 2022-05-28 00:11 UTC by Report Bug Copy Issue Report `$entryid` is overwriting one of the parameters of this function. Loading history...
87			array_push($data["entryid"], bin2hex($entryid));
88			}
89			} else {
90			$data["entryid"] = bin2hex($props[PR_ENTRYID]);
91			}
92
93			$this->addNotificationActionData("delete", array( "item" => array($data) ));
94			}
95			break;
96			}
97
98			$GLOBALS["bus"]->addData($this->createNotificationResponseData());
99			}
100			}
101			?>
			0 ignored issues – show Best Practice introduced 2022-05-28 23:59 UTC by Report Bug Copy Issue Report It is not recommended to use PHP's closing tag `?>` in files other than templates. Using a closing tag in PHP files that only contain PHP code is not recommended as you might accidentally add whitespace after the closing tag which would then be output by PHP. This can cause severe problems, for example headers cannot be sent anymore. A simple precaution is to leave off the closing tag as it is not required, and it also has no negative effects whatsoever. Loading history...
102

grommunio / grommunio-web

Push — master ( 647c72...cd42b5 )

ListNotifier::update() B

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like