Test Failed
Branch develop (82f08a)
by Andreas
15:40
created
server/includes/modules/class.contactitemmodule.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -108,7 +108,7 @@  discard block
 block discarded – undo
108 108
 	 * @return bool true on success or false on failure
109 109
 	 */
110 110
 	public function save($store, $parententryid, $entryid, $action) {
111
-		$properiesToDelete = [];		// create an array of properties which should be deleted
111
+		$properiesToDelete = []; // create an array of properties which should be deleted
112 112
 		// this array is passed to $GLOBALS['operations']->saveMessage() function
113 113
 
114 114
 		if (!$store && !$parententryid) {
@@ -449,7 +449,7 @@  discard block
 block discarded – undo
449 449
 
450 450
 		// UTC time
451 451
 		$startDateUTC = $actionProps[$type];
452
-		$dueDateUTC = $actionProps[$type] + (24 * 60 * 60);	// ONE DAY is added to set duedate of item.
452
+		$dueDateUTC = $actionProps[$type] + (24 * 60 * 60); // ONE DAY is added to set duedate of item.
453 453
 
454 454
 		// get local time from UTC time
455 455
 		$recur = new Recurrence($store, []);
Please login to merge, or discard this patch.
server/includes/modules/class.resolvenamesmodule.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -242,7 +242,7 @@  discard block
 block discarded – undo
242 242
 		$abHierarchyRows = mapi_table_queryallrows($hierarchyTable, [PR_AB_PROVIDER_ID, PR_ENTRYID]);
243 243
 
244 244
 		// Look for the 'Contacts Folders'
245
-		for ($i = 0,$len = count($abHierarchyRows); $i < $len; ++$i) {
245
+		for ($i = 0, $len = count($abHierarchyRows); $i < $len; ++$i) {
246 246
 			// Check if the folder matches the Contact Provider GUID
247 247
 			if ($abHierarchyRows[$i][PR_AB_PROVIDER_ID] == MUIDZCSAB) {
248 248
 				$abContactContainerEntryid = $abHierarchyRows[$i][PR_ENTRYID];
@@ -258,7 +258,7 @@  discard block
 block discarded – undo
258 258
 			$abContactContainerHierarchyRows = mapi_table_queryallrows($abContactContainerHierarchyTable, [PR_DISPLAY_NAME, PR_OBJECT_TYPE, PR_ENTRYID]);
259 259
 
260 260
 			// Loop through all the contact folders found under the 'Contacts Folders' hierarchy
261
-			for ($j = 0,$len = count($abContactContainerHierarchyRows); $j < $len; ++$j) {
261
+			for ($j = 0, $len = count($abContactContainerHierarchyRows); $j < $len; ++$j) {
262 262
 				// Open, get contents table, restrict, sort and then merge the result in the list of $rows
263 263
 				$abContactFolder = mapi_ab_openentry($ab, $abContactContainerHierarchyRows[$j][PR_ENTRYID]);
264 264
 				$abContactFolderTable = mapi_folder_getcontentstable($abContactFolder, MAPI_DEFERRED_ERRORS);
Please login to merge, or discard this patch.
server/includes/modules/class.addressbooklistmodule.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -851,7 +851,7 @@
 block discarded – undo
851 851
 								],
852 852
 								[
853 853
 									RES_OR,
854
-									$tempRestrictions,     // all group restrictions
854
+									$tempRestrictions, // all group restrictions
855 855
 								],
856 856
 							],
857 857
 						],
Please login to merge, or discard this patch.
server/includes/modules/class.listmodule.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -507,12 +507,12 @@
 block discarded – undo
507 507
 		$data["search_meta"]["searchfolder_entryid"] = $entryid;
508 508
 		$data["search_meta"]["search_store_entryid"] = $action["store_entryid"];
509 509
 		$data["search_meta"]["searchstate"] = $searchState;
510
-		$data["search_meta"]["results"] = $numberOfResults;		// actual number of items that we are sending to client
510
+		$data["search_meta"]["results"] = $numberOfResults; // actual number of items that we are sending to client
511 511
 
512 512
 		$data["page"] = [];
513 513
 		$data["page"]["start"] = 0;
514 514
 		$data["page"]["rowcount"] = $rowCount;
515
-		$data["page"]["totalrowcount"] = $totalRowCount;	// total number of items
515
+		$data["page"]["totalrowcount"] = $totalRowCount; // total number of items
516 516
 
517 517
 		if (!empty($listData)) {
518 518
 			$data["item"] = array_merge([], $listData);
Please login to merge, or discard this patch.
server/includes/modules/class.delegatesmodule.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -575,7 +575,7 @@
 block discarded – undo
575 575
 		];
576 576
 
577 577
 		$rule[PR_RULE_NAME] = '';
578
-		$rule[PR_RULE_PROVIDER_DATA] = '';		// 0 byte binary string
578
+		$rule[PR_RULE_PROVIDER_DATA] = ''; // 0 byte binary string
579 579
 		$rule[PR_RULE_STATE] = ST_ENABLED;
580 580
 		$rule[PR_RULE_LEVEL] = 0;
581 581
 		$rule[PR_RULE_SEQUENCE] = 0;
Please login to merge, or discard this patch.
server/includes/modules/class.hierarchymodule.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -315,7 +315,7 @@
 block discarded – undo
315 315
 								throw new MAPIException(null, MAPI_E_NO_ACCESS);
316 316
 							}
317 317
 
318
-							$noPermissionFolders = array_filter($data['item'][0]['folders']['item'], function ($item) {
318
+							$noPermissionFolders = array_filter($data['item'][0]['folders']['item'], function($item) {
319 319
 								return $item['props']['access'] === 0;
320 320
 							});
321 321
 							if (count($noPermissionFolders) >= $folders) {
Please login to merge, or discard this patch.
server/includes/core/class.properties.php 1 patch
Spacing   +22 added lines, -22 removed lines patch added patch discarded remove patch
@@ -247,14 +247,14 @@  discard block
 block discarded – undo
247 247
 			$properties["reminderset"] = "PT_BOOLEAN:PSETID_Common:" . PidLidReminderSet;
248 248
 			$properties["flag_request"] = "PT_STRING8:PSETID_Common:" . PidLidFlagRequest;
249 249
 			$properties["flag_due_by"] = "PT_SYSTIME:PSETID_Common:" . PidLidReminderSignalTime;
250
-			$properties["updatecounter"] = "PT_LONG:PSETID_Appointment:" . PidLidAppointmentSequence;                                     // AppointmentSequenceNumber
251
-			$properties["last_updatecounter"] = "PT_LONG:PSETID_Appointment:0x8203";                        // AppointmentLastSequence
250
+			$properties["updatecounter"] = "PT_LONG:PSETID_Appointment:" . PidLidAppointmentSequence; // AppointmentSequenceNumber
251
+			$properties["last_updatecounter"] = "PT_LONG:PSETID_Appointment:0x8203"; // AppointmentLastSequence
252 252
 			$properties["busystatus"] = "PT_LONG:PSETID_Appointment:" . PidLidBusyStatus;
253 253
 			$properties["intendedbusystatus"] = "PT_LONG:PSETID_Appointment:" . PidLidIntendedBusyStatus;
254 254
 			$properties["start"] = "PT_SYSTIME:PSETID_Appointment:" . PidLidAppointmentStartWhole;
255 255
 			$properties["responselocation"] = "PT_STRING8:PSETID_Meeting:0x2";
256 256
 			$properties["location"] = "PT_STRING8:PSETID_Appointment:" . PidLidLocation;
257
-			$properties["requestsent"] = "PT_BOOLEAN:PSETID_Appointment:0x8229";            // PidLidFInvited, MeetingRequestWasSent
257
+			$properties["requestsent"] = "PT_BOOLEAN:PSETID_Appointment:0x8229"; // PidLidFInvited, MeetingRequestWasSent
258 258
 			$properties["startdate"] = "PT_SYSTIME:PSETID_Appointment:" . PidLidAppointmentStartWhole;
259 259
 			$properties["duedate"] = "PT_SYSTIME:PSETID_Appointment:" . PidLidAppointmentEndWhole;
260 260
 			$properties["commonstart"] = "PT_SYSTIME:PSETID_Common:0x8516";
@@ -262,11 +262,11 @@  discard block
 block discarded – undo
262 262
 			$properties["recurring"] = "PT_BOOLEAN:PSETID_Appointment:" . PidLidRecurring;
263 263
 			$properties["clipstart"] = "PT_SYSTIME:PSETID_Appointment:" . PidLidClipStart;
264 264
 			$properties["clipend"] = "PT_SYSTIME:PSETID_Appointment:" . PidLidClipEnd;
265
-			$properties["start_recur_date"] = "PT_LONG:PSETID_Meeting:0xD";                         // StartRecurTime
266
-			$properties["start_recur_time"] = "PT_LONG:PSETID_Meeting:0xE";                         // StartRecurTime
267
-			$properties["end_recur_date"] = "PT_LONG:PSETID_Meeting:0xF";                           // EndRecurDate
268
-			$properties["end_recur_time"] = "PT_LONG:PSETID_Meeting:0x10";                          // EndRecurTime
269
-			$properties["is_exception"] = "PT_BOOLEAN:PSETID_Meeting:0xA";                          // LID_IS_EXCEPTION
265
+			$properties["start_recur_date"] = "PT_LONG:PSETID_Meeting:0xD"; // StartRecurTime
266
+			$properties["start_recur_time"] = "PT_LONG:PSETID_Meeting:0xE"; // StartRecurTime
267
+			$properties["end_recur_date"] = "PT_LONG:PSETID_Meeting:0xF"; // EndRecurDate
268
+			$properties["end_recur_time"] = "PT_LONG:PSETID_Meeting:0x10"; // EndRecurTime
269
+			$properties["is_exception"] = "PT_BOOLEAN:PSETID_Meeting:0xA"; // LID_IS_EXCEPTION
270 270
 			// Propose new time properties
271 271
 			$properties["proposed_start_whole"] = "PT_SYSTIME:PSETID_Appointment:" . PidLidAppointmentProposedStartWhole;
272 272
 			$properties["proposed_end_whole"] = "PT_SYSTIME:PSETID_Appointment:" . PidLidAppointmentProposedEndWhole;
@@ -645,7 +645,7 @@  discard block
 block discarded – undo
645 645
 			$properties = [];
646 646
 			$properties["entryid"] = PR_ENTRYID;
647 647
 			$properties["parent_entryid"] = PR_PARENT_ENTRYID;
648
-			$properties["store_entryid"] = PR_STORE_ENTRYID;	// is this required ???
648
+			$properties["store_entryid"] = PR_STORE_ENTRYID; // is this required ???
649 649
 			$properties["icon_index"] = PR_ICON_INDEX;
650 650
 			$properties["message_class"] = PR_MESSAGE_CLASS;
651 651
 			$properties["message_flags"] = PR_MESSAGE_FLAGS;
@@ -961,9 +961,9 @@  discard block
 block discarded – undo
961 961
 			$properties["appointment_location"] = "PT_STRING8:PSETID_Appointment:" . PidLidLocation;
962 962
 			$properties["appointment_recurring_pattern"] = "PT_STRING8:PSETID_Appointment:0x8232";
963 963
 			$properties["appointment_recurring"] = "PT_BOOLEAN:PSETID_Appointment:" . PidLidRecurring;
964
-			$properties["appointment_startdate_recurring"] = "PT_SYSTIME:PSETID_Appointment:" . PidLidClipStart;	// ClipStart
965
-			$properties["appointment_enddate_recurring"] = "PT_SYSTIME:PSETID_Appointment:" . PidLidClipEnd;		// ClipEnd
966
-			$properties["appointment_exception"] = "PT_BOOLEAN:PSETID_Meeting:0xA";						// LID_IS_EXCEPTION
964
+			$properties["appointment_startdate_recurring"] = "PT_SYSTIME:PSETID_Appointment:" . PidLidClipStart; // ClipStart
965
+			$properties["appointment_enddate_recurring"] = "PT_SYSTIME:PSETID_Appointment:" . PidLidClipEnd; // ClipEnd
966
+			$properties["appointment_exception"] = "PT_BOOLEAN:PSETID_Meeting:0xA"; // LID_IS_EXCEPTION
967 967
 			$properties["appointment_location"] = "PT_STRING8:PSETID_Appointment:" . PidLidLocation;
968 968
 			// Propose new time properties
969 969
 			$properties["proposed_start_date"] = "PT_SYSTIME:PSETID_Appointment:" . PidLidAppointmentProposedStartWhole;
@@ -1250,18 +1250,18 @@  discard block
 block discarded – undo
1250 1250
 			$properties["object_type"] = PR_OBJECT_TYPE;
1251 1251
 
1252 1252
 			$properties["recurring"] = "PT_BOOLEAN:PSETID_Appointment:" . PidLidRecurring;
1253
-			$properties["reminder"] = "PT_BOOLEAN:PSETID_Common:" . PidLidReminderSet;				// PidLidReminderSet
1254
-			$properties["reminder_minutes"] = "PT_LONG:PSETID_Common:" . PidLidReminderDelta;			// PidLidReminderDelta
1255
-			$properties["reminder_time"] = "PT_SYSTIME:PSETID_Common:" . PidLidReminderTime;			// PidLidReminderTime
1256
-			$properties["flagdueby"] = "PT_SYSTIME:PSETID_Common:" . PidLidReminderSignalTime;				// PidLidReminderSignalTime
1257
-
1258
-			$properties["task_duedate"] = "PT_SYSTIME:PSETID_Task:" . PidLidTaskDueDate;				// PidLidTaskDueDate
1259
-			$properties["task_startdate"] = "PT_SYSTIME:PSETID_Task:" . PidLidTaskStartDate;			// PidLidTaskStartDate
1260
-			$properties["task_resetreminder"] = "PT_BOOLEAN:PSETID_Task:0x8107";		// PidLidTaskResetReminder
1261
-			$properties["task_recurring"] = "PT_BOOLEAN:PSETID_Task:0x8126";			// PidLidTaskFRecurring
1253
+			$properties["reminder"] = "PT_BOOLEAN:PSETID_Common:" . PidLidReminderSet; // PidLidReminderSet
1254
+			$properties["reminder_minutes"] = "PT_LONG:PSETID_Common:" . PidLidReminderDelta; // PidLidReminderDelta
1255
+			$properties["reminder_time"] = "PT_SYSTIME:PSETID_Common:" . PidLidReminderTime; // PidLidReminderTime
1256
+			$properties["flagdueby"] = "PT_SYSTIME:PSETID_Common:" . PidLidReminderSignalTime; // PidLidReminderSignalTime
1257
+
1258
+			$properties["task_duedate"] = "PT_SYSTIME:PSETID_Task:" . PidLidTaskDueDate; // PidLidTaskDueDate
1259
+			$properties["task_startdate"] = "PT_SYSTIME:PSETID_Task:" . PidLidTaskStartDate; // PidLidTaskStartDate
1260
+			$properties["task_resetreminder"] = "PT_BOOLEAN:PSETID_Task:0x8107"; // PidLidTaskResetReminder
1261
+			$properties["task_recurring"] = "PT_BOOLEAN:PSETID_Task:0x8126"; // PidLidTaskFRecurring
1262 1262
 			$properties["taskmode"] = "PT_LONG:PSETID_Common:0x8518";
1263 1263
 
1264
-			$properties["appointment_recurring"] = "PT_BOOLEAN:PSETID_Appointment:" . PidLidRecurring;			// PidLidRecurring
1264
+			$properties["appointment_recurring"] = "PT_BOOLEAN:PSETID_Appointment:" . PidLidRecurring; // PidLidRecurring
1265 1265
 			$properties["appointment_startdate"] = "PT_SYSTIME:PSETID_Appointment:" . PidLidAppointmentStartWhole;
1266 1266
 			$properties["appointment_enddate"] = "PT_SYSTIME:PSETID_Appointment:" . PidLidAppointmentEndWhole;
1267 1267
 			$properties["appointment_startdate_recurring"] = "PT_SYSTIME:PSETID_Appointment:" . PidLidClipStart;
Please login to merge, or discard this patch.
server/includes/core/class.mapisession.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -1101,7 +1101,7 @@  discard block
 block discarded – undo
1101 1101
 					// Postfix display name of every contact folder with respective owner name
1102 1102
 					// it is mandatory to keep display-name different
1103 1103
 					$userStoreProps = mapi_getprops($openedUserStore, [PR_MAILBOX_OWNER_NAME]);
1104
-					for ($i = 0,$len = count($userContactFolders); $i < $len; ++$i) {
1104
+					for ($i = 0, $len = count($userContactFolders); $i < $len; ++$i) {
1105 1105
 						$userContactFolders[$i][PR_DISPLAY_NAME] = $userContactFolders[$i][PR_DISPLAY_NAME] . " - " . $userStoreProps[PR_MAILBOX_OWNER_NAME];
1106 1106
 					}
1107 1107
 
@@ -1125,7 +1125,7 @@  discard block
 block discarded – undo
1125 1125
 
1126 1126
 			// Create the lists of store entryids, folder entryids and folder names to be added
1127 1127
 			// to the profile section
1128
-			for ($i = 0,$len = count($contactFolders); $i < $len; ++$i) {
1128
+			for ($i = 0, $len = count($contactFolders); $i < $len; ++$i) {
1129 1129
 				$contact_store_entryids[] = $contactFolders[$i][PR_STORE_ENTRYID];
1130 1130
 				$contact_folder_entryids[] = $contactFolders[$i][PR_ENTRYID];
1131 1131
 				$contact_folder_names[] = $contactFolders[$i][PR_DISPLAY_NAME];
Please login to merge, or discard this patch.
server/includes/core/class.language.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -384,7 +384,7 @@  discard block
 block discarded – undo
384 384
 			if ($data_orig_strs[$i]['length'] > 0) {	// fread does not accept length=0
385 385
 				$length = $data_orig_strs[$i]['length'];
386 386
 				$orig_str = unpack('a' . $length . 'str', fread($fp, $length));
387
-				$translation_data[$i]['msgid'] = $orig_str['str'];	// unpack converts to array :S
387
+				$translation_data[$i]['msgid'] = $orig_str['str']; // unpack converts to array :S
388 388
 
389 389
 				// Find context in the original string
390 390
 				if (strpos($translation_data[$i]['msgid'], "\004") !== false) {
@@ -411,7 +411,7 @@  discard block
 block discarded – undo
411 411
 			if ($data_transl_strs[$i]['length'] > 0) {	// fread does not accept length=0
412 412
 				$length = $data_transl_strs[$i]['length'];
413 413
 				$trans_str = unpack('a' . $length . 'str', fread($fp, $length));
414
-				$translation_data[$i]['msgstr'] = $trans_str['str'];	// unpack converts to array :S
414
+				$translation_data[$i]['msgstr'] = $trans_str['str']; // unpack converts to array :S
415 415
 
416 416
 				// If there are plural forms in the source string,
417 417
 				// then the translated string must contain plural
Please login to merge, or discard this patch.