Test Failed
Branch master (2f190b)
by Mike
11:47
created
server/includes/core/class.conversion.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -76,7 +76,7 @@
 block discarded – undo
76 76
 						break;
77 77
 
78 78
 					case PT_MV_STRING8:
79
-					case PT_MV_STRING8 | MVI_FLAG:
79
+					case PT_MV_STRING8|MVI_FLAG:
80 80
 						$mv_values = explode(";", $value);
81 81
 						$values = [];
82 82
 
Please login to merge, or discard this patch.
server/includes/core/class.operations.php 1 patch
Spacing   +17 added lines, -17 removed lines patch added patch discarded remove patch
@@ -448,7 +448,7 @@  discard block
 block discarded – undo
448 448
 				],
449 449
 			]];
450 450
 
451
-			$hierarchyTable = mapi_folder_gethierarchytable($folder, CONVENIENT_DEPTH | MAPI_DEFERRED_ERRORS);
451
+			$hierarchyTable = mapi_folder_gethierarchytable($folder, CONVENIENT_DEPTH|MAPI_DEFERRED_ERRORS);
452 452
 			mapi_table_restrict($hierarchyTable, $restriction, TBL_BATCH);
453 453
 
454 454
 			// Also request PR_DEPTH
@@ -1327,7 +1327,7 @@  discard block
 block discarded – undo
1327 1327
 				if ($hardDelete === true) {
1328 1328
 					// hard delete the message if requested
1329 1329
 					// beware that folder can not be recovered after this and will be deleted from system entirely
1330
-					if (mapi_folder_deletefolder($folder, $entryid, DEL_MESSAGES | DEL_FOLDERS | DELETE_HARD_DELETE)) {
1330
+					if (mapi_folder_deletefolder($folder, $entryid, DEL_MESSAGES|DEL_FOLDERS|DELETE_HARD_DELETE)) {
1331 1331
 						$result = true;
1332 1332
 
1333 1333
 						// if exists, also delete settings made for this folder (client don't need an update for this)
@@ -1339,7 +1339,7 @@  discard block
 block discarded – undo
1339 1339
 						// TODO: check if not only $parententryid=wastebasket, but also the parents of that parent...
1340 1340
 						// if folder is already in wastebasket or softDelete is requested then delete the message
1341 1341
 						if ($msgprops[PR_IPM_WASTEBASKET_ENTRYID] == $parententryid || $softDelete === true) {
1342
-							if (mapi_folder_deletefolder($folder, $entryid, DEL_MESSAGES | DEL_FOLDERS)) {
1342
+							if (mapi_folder_deletefolder($folder, $entryid, DEL_MESSAGES|DEL_FOLDERS)) {
1343 1343
 								$result = true;
1344 1344
 
1345 1345
 								// if exists, also delete settings made for this folder (client don't need an update for this)
@@ -1380,7 +1380,7 @@  discard block
 block discarded – undo
1380 1380
 						}
1381 1381
 					}
1382 1382
 					else {
1383
-						if (mapi_folder_deletefolder($folder, $entryid, DEL_MESSAGES | DEL_FOLDERS)) {
1383
+						if (mapi_folder_deletefolder($folder, $entryid, DEL_MESSAGES|DEL_FOLDERS)) {
1384 1384
 							$result = true;
1385 1385
 
1386 1386
 							// if exists, also delete settings made for this folder (client don't need an update for this)
@@ -2113,7 +2113,7 @@  discard block
 block discarded – undo
2113 2113
 
2114 2114
 				if ($property != false) {
2115 2115
 					// Stream the body to the PR_BODY or PR_HTML property
2116
-					$stream = mapi_openproperty($message, $property, IID_IStream, 0, MAPI_CREATE | MAPI_MODIFY);
2116
+					$stream = mapi_openproperty($message, $property, IID_IStream, 0, MAPI_CREATE|MAPI_MODIFY);
2117 2117
 					mapi_stream_setsize($stream, strlen($body));
2118 2118
 					mapi_stream_write($stream, $body);
2119 2119
 					mapi_stream_commit($stream);
@@ -2192,9 +2192,9 @@  discard block
 block discarded – undo
2192 2192
 			$messageProps = [];
2193 2193
 			// It stores the values that is exception allowed or not false -> not allowed
2194 2194
 			$isExceptionAllowed = true;
2195
-			$delete = $actionType == 'delete';	// Flag for MeetingRequest Class whether to send update or cancel mail.
2196
-			$basedate = false;	// Flag for MeetingRequest Class whether to send an exception or not.
2197
-			$isReminderTimeAllowed = true;	// Flag to check reminder minutes is in range of the occurrences
2195
+			$delete = $actionType == 'delete'; // Flag for MeetingRequest Class whether to send update or cancel mail.
2196
+			$basedate = false; // Flag for MeetingRequest Class whether to send an exception or not.
2197
+			$isReminderTimeAllowed = true; // Flag to check reminder minutes is in range of the occurrences
2198 2198
 			$properties = $GLOBALS['properties']->getAppointmentProperties();
2199 2199
 			$send = false;
2200 2200
 			$oldProps = [];
@@ -3115,7 +3115,7 @@  discard block
 block discarded – undo
3115 3115
 				 * convert flags of PR_MESSAGE_FLAGS property to flags that is
3116 3116
 				 * used in mapi_message_setreadflag.
3117 3117
 				 */
3118
-				$flag = MAPI_DEFERRED_ERRORS;		// set unread flag, read receipt will be sent
3118
+				$flag = MAPI_DEFERRED_ERRORS; // set unread flag, read receipt will be sent
3119 3119
 
3120 3120
 				if (($flags & MSGFLAG_RN_PENDING) && isset($msg_action['send_read_receipt']) && $msg_action['send_read_receipt'] == false) {
3121 3121
 					$flag |= SUPPRESS_RECEIPT;
@@ -3327,7 +3327,7 @@  discard block
 block discarded – undo
3327 3327
 						$attachment = mapi_message_createattach($message);
3328 3328
 						mapi_setprops($attachment, $props);
3329 3329
 
3330
-						$imessage = mapi_attach_openobj($attachment, MAPI_CREATE | MAPI_MODIFY);
3330
+						$imessage = mapi_attach_openobj($attachment, MAPI_CREATE|MAPI_MODIFY);
3331 3331
 
3332 3332
 						// Copy the properties from the source message to the attachment
3333 3333
 						mapi_copyto($copyFrom, [], [], $imessage, 0); // includes attachments and recipients
@@ -3367,7 +3367,7 @@  discard block
 block discarded – undo
3367 3367
 						mapi_setprops($attachment, $props);
3368 3368
 
3369 3369
 						// Stream the file to the PR_ATTACH_DATA_BIN property
3370
-						$stream = mapi_openproperty($attachment, PR_ATTACH_DATA_BIN, IID_IStream, 0, MAPI_CREATE | MAPI_MODIFY);
3370
+						$stream = mapi_openproperty($attachment, PR_ATTACH_DATA_BIN, IID_IStream, 0, MAPI_CREATE|MAPI_MODIFY);
3371 3371
 						mapi_stream_write($stream, $appointmentStream);
3372 3372
 
3373 3373
 						// Commit the stream and save changes
@@ -3419,7 +3419,7 @@  discard block
 block discarded – undo
3419 3419
 							mapi_setprops($attachment, $props);
3420 3420
 
3421 3421
 							// Stream the file to the PR_ATTACH_DATA_BIN property
3422
-							$stream = mapi_openproperty($attachment, PR_ATTACH_DATA_BIN, IID_IStream, 0, MAPI_CREATE | MAPI_MODIFY);
3422
+							$stream = mapi_openproperty($attachment, PR_ATTACH_DATA_BIN, IID_IStream, 0, MAPI_CREATE|MAPI_MODIFY);
3423 3423
 							$handle = fopen($filepath, "r");
3424 3424
 							while (!feof($handle)) {
3425 3425
 								$contents = fread($handle, BLOCK_SIZE);
@@ -3561,7 +3561,7 @@  discard block
 block discarded – undo
3561 3561
 								PR_ATTACH_EXTENSION => $props[PR_ATTACH_EXTENSION] ?? '',
3562 3562
 								PR_ATTACH_FLAGS => $props[PR_ATTACH_FLAGS] ?? 0,
3563 3563
 							]);
3564
-							$newstream = mapi_openproperty($new, PR_ATTACH_DATA_BIN, IID_IStream, 0, MAPI_CREATE | MAPI_MODIFY);
3564
+							$newstream = mapi_openproperty($new, PR_ATTACH_DATA_BIN, IID_IStream, 0, MAPI_CREATE|MAPI_MODIFY);
3565 3565
 							mapi_stream_setsize($newstream, $stat['cb']);
3566 3566
 							for ($i = 0; $i < $stat['cb']; $i += BLOCK_SIZE) {
3567 3567
 								mapi_stream_write($newstream, mapi_stream_read($oldstream, BLOCK_SIZE));
@@ -3862,11 +3862,11 @@  discard block
 block discarded – undo
3862 3862
 			foreach ($recipientList as $recipientItem) {
3863 3863
 				if ($isException) {
3864 3864
 					// We do not add organizer to exception msg in organizer's calendar.
3865
-					if (isset($recipientItem[PR_RECIPIENT_FLAGS]) && $recipientItem[PR_RECIPIENT_FLAGS] == (recipSendable | recipOrganizer)) {
3865
+					if (isset($recipientItem[PR_RECIPIENT_FLAGS]) && $recipientItem[PR_RECIPIENT_FLAGS] == (recipSendable|recipOrganizer)) {
3866 3866
 						continue;
3867 3867
 					}
3868 3868
 
3869
-					$recipient[PR_RECIPIENT_FLAGS] = (recipSendable | recipExceptionalResponse | recipReserved);
3869
+					$recipient[PR_RECIPIENT_FLAGS] = (recipSendable|recipExceptionalResponse|recipReserved);
3870 3870
 				}
3871 3871
 
3872 3872
 				if (!empty($recipientItem["smtp_address"]) && empty($recipientItem["email_address"])) {
@@ -4466,7 +4466,7 @@  discard block
 block discarded – undo
4466 4466
 
4467 4467
 			$l_sNewRecipientHistoryJSON = json_encode($recipient_history);
4468 4468
 
4469
-			$stream = mapi_openproperty($store, PR_EC_RECIPIENT_HISTORY_JSON, IID_IStream, 0, MAPI_CREATE | MAPI_MODIFY);
4469
+			$stream = mapi_openproperty($store, PR_EC_RECIPIENT_HISTORY_JSON, IID_IStream, 0, MAPI_CREATE|MAPI_MODIFY);
4470 4470
 			mapi_stream_setsize($stream, strlen($l_sNewRecipientHistoryJSON));
4471 4471
 			mapi_stream_write($stream, $l_sNewRecipientHistoryJSON);
4472 4472
 			mapi_stream_commit($stream);
@@ -4674,7 +4674,7 @@  discard block
 block discarded – undo
4674 4674
 						];
4675 4675
 						mapi_setprops($inlineImage, $props);
4676 4676
 
4677
-						$stream = mapi_openproperty($inlineImage, PR_ATTACH_DATA_BIN, IID_IStream, 0, MAPI_CREATE | MAPI_MODIFY);
4677
+						$stream = mapi_openproperty($inlineImage, PR_ATTACH_DATA_BIN, IID_IStream, 0, MAPI_CREATE|MAPI_MODIFY);
4678 4678
 						mapi_stream_setsize($stream, strlen($rawImage));
4679 4679
 						mapi_stream_write($stream, $rawImage);
4680 4680
 						mapi_stream_commit($stream);
Please login to merge, or discard this patch.
server/includes/core/class.jsonrequest.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -28,7 +28,7 @@
 block discarded – undo
28 28
 		public function execute($json) {
29 29
 			/* If json_encode produces an empty string, wa-js shows an absolutely
30 30
 			 * worthless "Invalid data received from the server" dialog. */
31
-			$jsonflags = JSON_THROW_ON_ERROR | JSON_INVALID_UTF8_SUBSTITUTE;
31
+			$jsonflags = JSON_THROW_ON_ERROR|JSON_INVALID_UTF8_SUBSTITUTE;
32 32
 
33 33
 			try {
34 34
 				// decode JSON data
Please login to merge, or discard this patch.
server/includes/core/class.bus.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -205,7 +205,7 @@  discard block
 block discarded – undo
205 205
 				foreach ($this->registeredStoreNotifiers as $key => &$storeNotifier) {
206 206
 					if ($entryidCmp->compareStoreEntryIds($storeNotifier['entryid'], $storeEntryid)) {
207 207
 						foreach ($storeNotifier as $key => $notifier) {
208
-							if (isset($notifier['events']) && ($notifier['events'] & $event)) {
208
+							if (isset($notifier['events']) && ($notifier['events']&$event)) {
209 209
 								if (!isset($updatedNotifiers[$key])) {
210 210
 									if (isset($this->notifiers[$key]) && is_object($this->notifiers[$key])) {
211 211
 										$this->notifiers[$key]->update($event, $entryID, $data);
@@ -225,7 +225,7 @@  discard block
 block discarded – undo
225 225
 				if (($entryID === REQUEST_ENTRYID && $folderNotifier['entryid'] === REQUEST_ENTRYID) ||
226 226
 					($entryidCmp->compareEntryIds($folderNotifier['entryid'], $entryID))) {
227 227
 					foreach ($folderNotifier as $key => $notifier) {
228
-						if (isset($notifier['events']) && ($notifier['events'] & $event)) {
228
+						if (isset($notifier['events']) && ($notifier['events']&$event)) {
229 229
 							if (!isset($updatedNotifiers[$key])) {
230 230
 								if (isset($this->notifiers[$key]) && is_object($this->notifiers[$key])) {
231 231
 									$this->notifiers[$key]->update($event, $entryID, $data);
Please login to merge, or discard this patch.
server/includes/core/class.indexsqlite.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -21,7 +21,7 @@
 block discarded – undo
21 21
 		$r3 = ($eid >> 32) & 0xFF;
22 22
 		$r4 = ($eid >> 24) & 0xFF;
23 23
 		$r5 = ($eid >> 16) & 0xFF;
24
-		$value = $r0 | ($r1 << 8) | ($r2 << 16) | ($r3 << 24) | ($r4 << 32) | ($r5 << 40);
24
+		$value = $r0|($r1 << 8)|($r2 << 16)|($r3 << 24)|($r4 << 32)|($r5 << 40);
25 25
 
26 26
 		return $value;
27 27
 	}
Please login to merge, or discard this patch.
server/includes/core/class.settings.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -514,7 +514,7 @@  discard block
 block discarded – undo
514 514
 				}
515 515
 
516 516
 				try {
517
-					$stream = mapi_openproperty($this->store, PR_EC_WEBACCESS_SETTINGS_JSON, IID_IStream, STGM_TRANSACTED, MAPI_CREATE | MAPI_MODIFY);
517
+					$stream = mapi_openproperty($this->store, PR_EC_WEBACCESS_SETTINGS_JSON, IID_IStream, STGM_TRANSACTED, MAPI_CREATE|MAPI_MODIFY);
518 518
 					mapi_stream_setsize($stream, strlen($settings));
519 519
 					mapi_stream_write($stream, $settings);
520 520
 					mapi_stream_commit($stream);
@@ -540,7 +540,7 @@  discard block
 block discarded – undo
540 540
 
541 541
 			// Check if the settings have been changed.
542 542
 			if ($this->persistentSettingsString !== $persistentSettings) {
543
-				$stream = mapi_openproperty($this->store, PR_EC_WEBAPP_PERSISTENT_SETTINGS_JSON, IID_IStream, STGM_TRANSACTED, MAPI_CREATE | MAPI_MODIFY);
543
+				$stream = mapi_openproperty($this->store, PR_EC_WEBAPP_PERSISTENT_SETTINGS_JSON, IID_IStream, STGM_TRANSACTED, MAPI_CREATE|MAPI_MODIFY);
544 544
 				mapi_stream_setsize($stream, strlen($persistentSettings));
545 545
 				mapi_stream_write($stream, $persistentSettings);
546 546
 				mapi_stream_commit($stream);
Please login to merge, or discard this patch.
server/includes/core/class.colors.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -297,7 +297,7 @@
 block discarded – undo
297 297
 			$r = intval($m[1]);
298 298
 			$g = intval($m[2]);
299 299
 			$b = intval($m[3]);
300
-			if ($r < 0 || $r > 255 || $g < 0 || $g > 255 | $b < 0 || $b > 255) {
300
+			if ($r < 0 || $r > 255 || $g < 0 || $g > 255|$b < 0 || $b > 255) {
301 301
 				// Not a valid color
302 302
 				return null;
303 303
 			}
Please login to merge, or discard this patch.
server/includes/core/class.todolist.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -204,7 +204,7 @@  discard block
 block discarded – undo
204 204
 								[
205 205
 									RES_CONTENT,
206 206
 									[
207
-										FUZZYLEVEL => FL_PREFIX | FL_IGNORECASE,
207
+										FUZZYLEVEL => FL_PREFIX|FL_IGNORECASE,
208 208
 										ULPROPTAG => PR_MESSAGE_CLASS,
209 209
 										VALUE => "IPM.Appointment",
210 210
 									],
@@ -217,7 +217,7 @@  discard block
 block discarded – undo
217 217
 								[
218 218
 									RES_CONTENT,
219 219
 									[
220
-										FUZZYLEVEL => FL_PREFIX | FL_IGNORECASE,
220
+										FUZZYLEVEL => FL_PREFIX|FL_IGNORECASE,
221 221
 										ULPROPTAG => PR_MESSAGE_CLASS,
222 222
 										VALUE => "IPM.Activity",
223 223
 									],
@@ -230,7 +230,7 @@  discard block
 block discarded – undo
230 230
 								[
231 231
 									RES_CONTENT,
232 232
 									[
233
-										FUZZYLEVEL => FL_PREFIX | FL_IGNORECASE,
233
+										FUZZYLEVEL => FL_PREFIX|FL_IGNORECASE,
234 234
 										ULPROPTAG => PR_MESSAGE_CLASS,
235 235
 										VALUE => "IPM.StickyNote",
236 236
 									],
@@ -422,7 +422,7 @@  discard block
 block discarded – undo
422 422
 												[
423 423
 													RES_CONTENT,
424 424
 													[
425
-														FUZZYLEVEL => FL_PREFIX | FL_IGNORECASE,
425
+														FUZZYLEVEL => FL_PREFIX|FL_IGNORECASE,
426 426
 														ULPROPTAG => PR_MESSAGE_CLASS,
427 427
 														VALUE => "IPM.Task.",
428 428
 													],
@@ -430,7 +430,7 @@  discard block
 block discarded – undo
430 430
 												[
431 431
 													RES_CONTENT,
432 432
 													[
433
-														FUZZYLEVEL => FL_FULLSTRING | FL_IGNORECASE,
433
+														FUZZYLEVEL => FL_FULLSTRING|FL_IGNORECASE,
434 434
 														ULPROPTAG => PR_MESSAGE_CLASS,
435 435
 														VALUE => "IPM.Task",
436 436
 													],
Please login to merge, or discard this patch.
server/includes/download_attachment.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -228,21 +228,21 @@
 block discarded – undo
228 228
 			[
229 229
 				[RES_CONTENT,
230 230
 					[
231
-						FUZZYLEVEL => FL_FULLSTRING | FL_IGNORECASE,
231
+						FUZZYLEVEL => FL_FULLSTRING|FL_IGNORECASE,
232 232
 						ULPROPTAG => PR_ATTACH_CONTENT_ID,
233 233
 						VALUE => [PR_ATTACH_CONTENT_ID => $this->attachCid],
234 234
 					],
235 235
 				],
236 236
 				[RES_CONTENT,
237 237
 					[
238
-						FUZZYLEVEL => FL_FULLSTRING | FL_IGNORECASE,
238
+						FUZZYLEVEL => FL_FULLSTRING|FL_IGNORECASE,
239 239
 						ULPROPTAG => PR_ATTACH_CONTENT_LOCATION,
240 240
 						VALUE => [PR_ATTACH_CONTENT_LOCATION => $this->attachCid],
241 241
 					],
242 242
 				],
243 243
 				[RES_CONTENT,
244 244
 					[
245
-						FUZZYLEVEL => FL_FULLSTRING | FL_IGNORECASE,
245
+						FUZZYLEVEL => FL_FULLSTRING|FL_IGNORECASE,
246 246
 						ULPROPTAG => PR_ATTACH_FILENAME,
247 247
 						VALUE => [PR_ATTACH_FILENAME => $this->attachCid],
248 248
 					],
Please login to merge, or discard this patch.