grommunio / grommunio-web

server/includes/templates/login.php

Braces +1 added lines, -1 removed lines

@@ -97,7 +97,7 @@
 			<?php include '/etc/grommunio-web/disclaimer.html'; ?>
 		</div>
 		<?php }
-		elseif (file_exists('disclaimer.html')) { ?>
+elseif (file_exists('disclaimer.html')) { ?>
 		<div class="disclaimer">
 			<?php include 'disclaimer.html'; ?>
 		</div>

plugins/filesbackendDefault/php/class.plugindefault.php

Braces +4 added lines, -8 removed lines

@@ -10,15 +10,13 @@ 
     /**
      * Constructor.
      */
-    public function __construct()
-    {
+    public function __construct() {
     }
 
     /**
      * Called to initialize the plugin and register for hooks.
      */
-    public function init()
-    {
+    public function init() {
         $this->registerHook('server.core.settings.init.before');
     }
 
@@ -28,8 +26,7 @@ 
      * @param string $eventID Identifier of the hook
      * @param array  $data    Reference to the data of the triggered hook
      */
-    public function execute($eventID, &$data)
-    {
+    public function execute($eventID, &$data) {
         switch ($eventID) {
             case 'server.core.settings.init.before':
                 $this->onBeforeSettingsInit($data);
@@ -43,8 +40,7 @@ 
      *
      * @param array $data Reference to the data of the triggered hook
      */
-    public function onBeforeSettingsInit(&$data)
-    {
+    public function onBeforeSettingsInit(&$data) {
         $data['settingsObj']->addSysAdminDefaults([
             'zarafa' => [
                 'v1' => [

plugins/filesbackendSeafile/php/class.backend.php

Braces +72 added lines, -81 removed lines

@@ -100,8 +100,7 @@ 
     /**
      * Seafile backend constructor
      */
-    public function __construct()
-    {
+    public function __construct() {
         // initialization
         $this->debug = PLUGIN_FILESBROWSER_LOGLEVEL === 'DEBUG';
 
@@ -132,19 +131,20 @@ 
      * @throws BackendException if connection is not successful
      * @return boolean true if action succeeded
      */
-    public function open()
-    {
+    public function open() {
         $url = $this->config->getApiUrl();
 
         try {
             $this->sso->open();
-        } catch (Throwable $throwable) {
+        }
+        catch (Throwable $throwable) {
             $this->backendException($throwable);
         }
 
         try {
             $this->seafapi = new SeafileApi($url, $this->config->user, $this->config->pass);
-        } catch (Throwable $throwable) {
+        }
+        catch (Throwable $throwable) {
             $this->backendException($throwable);
         }
 
@@ -160,15 +160,15 @@ 
      *
      * @return array
      */
-    public function ls($dir, $hidefirst = true)
-    {
+    public function ls($dir, $hidefirst = true) {
         $timer = new Timer();
         $this->log("[LS] '$dir'");
 
         if ('' === trim($dir, '/')) {
             try {
                 $listing = $this->seafapi->listLibraries();
-            } catch (Throwable $throwable) {
+            }
+            catch (Throwable $throwable) {
                 $this->backendException($throwable);
             }
             goto result;
@@ -183,7 +183,8 @@ 
 
         try {
             $listing = $this->seafapi->listItemsInDirectory($lsDir->lib, $lsDir->path ?? '');
-        } catch (Throwable $throwable) {
+        }
+        catch (Throwable $throwable) {
             $this->backendException($throwable);
         }
 
@@ -221,8 +222,7 @@ 
      * @throws BackendException
      * @return bool
      */
-    public function mkcol($dir)
-    {
+    public function mkcol($dir) {
         $timer = new Timer();
         $this->log("[MKCOL] '$dir'");
 
@@ -231,17 +231,20 @@ 
             try {
                 $result = $this->seafapi->createLibrary($dir);
                 unset($result);
-            } catch (Throwable $throwable) {
+            }
+            catch (Throwable $throwable) {
                 $this->backendException($throwable);
             }
             $success = true;
-        } else {
+        }
+        else {
             // create directory within library
             $lib = $this->seafapi->getLibraryFromPath($dir)->id;
             [, $path] = explode('/', trim($dir, '/'), 2);
             try {
                 $result = $this->seafapi->createNewDirectory($lib, $path);
-            } catch (Throwable $throwable) {
+            }
+            catch (Throwable $throwable) {
                 $this->backendException($throwable);
             }
             $success = 'success' === $result;
@@ -258,8 +261,7 @@ 
      * @throws BackendException
      * @return bool
      */
-    public function delete($path)
-    {
+    public function delete($path) {
         $timer = new Timer();
         $this->log("[DELETE] '$path'");
 
@@ -268,15 +270,18 @@ 
             try {
                 $this->seafapi->deleteLibraryByName($path);
                 $result = 'success';
-            } catch (Throwable $throwable) {
+            }
+            catch (Throwable $throwable) {
                 $this->backendException($throwable);
             }
-        } else {
+        }
+        else {
             // delete file or directory within library
             $deletePath = $this->splitGrommunioPath($path);
             try {
                 $result = $this->seafapi->deleteFile($deletePath->lib, $deletePath->path);
-            } catch (Throwable $throwable) {
+            }
+            catch (Throwable $throwable) {
                 $this->backendException($throwable);
             }
         }
@@ -294,8 +299,7 @@ 
      * @throws BackendException
      * @return bool
      */
-    public function move($src_path, $dst_path, $overwrite = false)
-    {
+    public function move($src_path, $dst_path, $overwrite = false) {
         $timer = new Timer();
         $this->log("[MOVE] '$src_path' -> '$dst_path'");
 
@@ -323,7 +327,8 @@ 
             try {
                 $this->seafapi->renameLibrary($src->libName, $dst->libName);
                 $result = true;
-            } catch (Throwable $throwable) {
+            }
+            catch (Throwable $throwable) {
                 $this->backendException($throwable);
             }
             goto done;
@@ -345,7 +350,8 @@ 
         if ($isIntraLibTransaction && $pathsHaveSameDirNames) {
             try {
                 $result = $this->seafapi->renameFile($src->lib, $src->path, basename($dst->path));
-            } catch (Throwable $throwable) {
+            }
+            catch (Throwable $throwable) {
                 $this->backendException($throwable);
             }
             goto done;
@@ -355,7 +361,8 @@ 
         if (isset($src->path, $dst->lib)) {
             try {
                 $result = $this->seafapi->moveFile($src->lib, $src->path, $dst->lib, $dirNames[1]);
-            } catch (Throwable $throwable) {
+            }
+            catch (Throwable $throwable) {
                 $this->backendException($throwable);
             }
         }
@@ -381,8 +388,7 @@ 
      *
      * @return boolean true if action succeeded
      */
-    public function get($path, &$buffer)
-    {
+    public function get($path, &$buffer) {
         $timer = new Timer();
         $this->log("[GET] '$path'");
 
@@ -390,7 +396,8 @@ 
 
         try {
             $result = $this->seafapi->downloadFileAsBuffer($src->lib, $src->path);
-        } catch (Throwable $throwable) {
+        }
+        catch (Throwable $throwable) {
             $this->backendException($throwable);
         }
 
@@ -414,8 +421,7 @@ 
      *
      * @return boolean true if action succeeded
      */
-    public function get_file($srcpath, $localpath)
-    {
+    public function get_file($srcpath, $localpath) {
         $timer = new Timer();
         $this->log("[GET_FILE] '$srcpath' -> '$localpath'");
 
@@ -423,7 +429,8 @@ 
 
         try {
             $result = $this->seafapi->downloadFileToFile($src->lib, $src->path, $localpath);
-        } catch (Throwable $throwable) {
+        }
+        catch (Throwable $throwable) {
             $this->backendException($throwable);
         }
 
@@ -441,8 +448,7 @@ 
      *
      * @return boolean true if action succeeded
      */
-    public function put($path, $data)
-    {
+    public function put($path, $data) {
         $timer = new Timer();
         $this->log(sprintf("[PUT] start: path: %s (%d)", $path, strlen($data)));
 
@@ -451,7 +457,8 @@ 
         try {
             /** @noinspection PhpUnusedLocalVariableInspection */
             $result = $this->seafapi->uploadBuffer($target->lib, $target->path, $data);
-        } catch (Throwable $throwable) {
+        }
+        catch (Throwable $throwable) {
             $this->backendException($throwable);
         }
 
@@ -469,8 +476,7 @@ 
      *
      * @return boolean true if action succeeded
      */
-    public function put_file($path, $filename)
-    {
+    public function put_file($path, $filename) {
         $timer = new Timer();
         $this->log(sprintf("[PUT_FILE] %s -> %s", $filename, $path));
 
@@ -485,7 +491,8 @@ 
         if ($target->path === null && $target->libName !== null) {
             try {
                 $defaultLibrary = $this->seafapi->getDefaultLibrary();
-            } catch (Throwable $throwable) {
+            }
+            catch (Throwable $throwable) {
                 $this->backendException($throwable);
             }
             if (isset($defaultLibrary->repo_id, $defaultLibrary->exists) && true === $defaultLibrary->exists) {
@@ -498,7 +505,8 @@ 
         try {
             /** @noinspection PhpUnusedLocalVariableInspection */
             $result = $this->seafapi->uploadFile($target->lib, $target->path, $filename);
-        } catch (Throwable $throwable) {
+        }
+        catch (Throwable $throwable) {
             $this->backendException($throwable);
         }
 
@@ -516,8 +524,7 @@ 
      * @param $backend_config
      * @return void
      */
-    public function init_backend($backend_config)
-    {
+    public function init_backend($backend_config) {
         $config = $backend_config;
 
         if ($backend_config["use_zarafa_credentials"]) {
@@ -530,7 +537,8 @@ 
                     $config['user'] = $encryptionStore->get('username');
                     $config['password'] = $encryptionStore->get('password');
                 }
-            } else {
+            }
+            else {
                 $config['user'] = ConfigUtil::loadSmtpAddress();
                 $password = $_SESSION['password'];
                 if (function_exists('openssl_decrypt')) {
@@ -551,11 +559,11 @@ 
      * @return false|string
      * @noinspection PhpMultipleClassDeclarationsInspection Grommunio has a \JsonException shim
      */
-    public function getFormConfig()
-    {
+    public function getFormConfig() {
         try {
             $json = json_encode($this->metaConfig, JSON_THROW_ON_ERROR);
-        } catch (JsonException $e) {
+        }
+        catch (JsonException $e) {
             $this->log(sprintf('[%s]: %s', get_class($e), $e->getMessage()));
             $json = false;
         }
@@ -563,8 +571,7 @@ 
         return $json;
     }
 
-    public function getFormConfigWithData()
-    {
+    public function getFormConfigWithData() {
         return $this->getFormConfig();
     }
 
@@ -576,8 +583,7 @@ 
      *
      * @return void
      */
-    public function set_debug($debug)
-    {
+    public function set_debug($debug) {
         $this->debug = (bool)$debug;
     }
 
@@ -595,8 +601,7 @@ 
      * @return bool
      * @noinspection PhpReturnDocTypeMismatchInspection Upstream Interface Issue
      */
-    public function copy_coll($src_path, $dst_path, $overwrite = false)
-    {
+    public function copy_coll($src_path, $dst_path, $overwrite = false) {
         $this->backendError(self::SFA_ERR_UNIMPLEMENTED, 'Not implemented');
     }
 
@@ -610,8 +615,7 @@ 
      * @return bool
      * @noinspection PhpReturnDocTypeMismatchInspection Upstream Interface Issue
      */
-    public function copy_file($src_path, $dst_path, $overwrite = false)
-    {
+    public function copy_file($src_path, $dst_path, $overwrite = false) {
         $this->backendError(self::SFA_ERR_UNIMPLEMENTED, 'Not implemented');
     }
 
@@ -623,8 +627,7 @@ 
      * @return bool
      * @noinspection PhpReturnDocTypeMismatchInspection Upstream Interface Issue
      */
-    public function exists($path)
-    {
+    public function exists($path) {
         $this->backendError(self::SFA_ERR_UNIMPLEMENTED, 'Not implemented');
     }
 
@@ -635,8 +638,7 @@ 
      * @throws BackendException if request is not successful
      * @return array directory info
      */
-    public function gpi($path)
-    {
+    public function gpi($path) {
         $this->log("[GPI] '$path'");
         $list = $this->ls(dirname($path), false); // get contents of the parent dir
 
@@ -656,8 +658,7 @@ 
      * @return bool
      * @noinspection PhpReturnDocTypeMismatchInspection Upstream Interface Issue
      */
-    public function is_dir($path)
-    {
+    public function is_dir($path) {
         $this->backendError(self::SFA_ERR_UNIMPLEMENTED, 'Not implemented');
     }
 
@@ -669,8 +670,7 @@ 
      * @return bool
      * @noinspection PhpReturnDocTypeMismatchInspection Upstream Interface Issue
      */
-    public function is_file($path)
-    {
+    public function is_file($path) {
         $this->backendError(self::SFA_ERR_UNIMPLEMENTED, 'Not implemented');
     }
 
@@ -684,11 +684,11 @@ 
      * @throws BackendException
      * @return String
      */
-    public function getServerVersion()
-    {
+    public function getServerVersion() {
         try {
             return $this->seafapi->getServerVersion();
-        } catch (Throwable $throwable) {
+        }
+        catch (Throwable $throwable) {
             $this->backendException($throwable);
         }
     }
@@ -703,8 +703,7 @@ 
      * @noinspection PhpMissingParamTypeInspection
      * @noinspection PhpUnusedParameterInspection
      */
-    public function getQuotaBytesUsed($dir)
-    {
+    public function getQuotaBytesUsed($dir) {
         $return = $this->seafapi->checkAccountInfo();
 
         return ($return->usage ?? 0) * self::QUOTA_MULTIPLIER_SEAFILE_TO_GROMMUNIO;
@@ -716,8 +715,7 @@ 
      * @noinspection PhpUnusedParameterInspection
      * @noinspection PhpMissingParamTypeInspection
      */
-    public function getQuotaBytesAvailable($dir)
-    {
+    public function getQuotaBytesAvailable($dir) {
         $return = $this->seafapi->checkAccountInfo();
         $avail = $return->total - $return->usage;
         if (-2 === (int)$return->total) {
@@ -734,8 +732,7 @@ 
     /**
      * Initialise form fields
      */
-    private function init_form()
-    {
+    private function init_form() {
         $this->metaConfig = [
             "success" => true,
             "metaData" => [
@@ -861,8 +858,7 @@ 
      * @throws BackendException
      * @return no-return
      */
-    private function backendError(int $errorCode, string $title = null)
-    {
+    private function backendError(int $errorCode, string $title = null) {
         $message = $this->parseErrorCodeToMessage($errorCode);
         $title = $this->backendTransName;
         $this->backendErrorThrow($title, $message, $errorCode);
@@ -877,8 +873,7 @@ 
      * @throws BackendException
      * @return no-return
      */
-    private function backendErrorThrow(string $title, string $message, int $code = 0)
-    {
+    private function backendErrorThrow(string $title, string $message, int $code = 0) {
         /** {@see \Files\Backend\Exception} */
         $exception = new BackendException($message, $code);
         $exception->setTitle($title);
@@ -892,8 +887,7 @@ 
      * @throws BackendException
      * @return no-return
      */
-    private function backendException(Throwable $t)
-    {
+    private function backendException(Throwable $t) {
         // if it is already a backend exception, throw it.
         if ($t instanceof BackendException) {
             throw $t;
@@ -926,8 +920,7 @@ 
      * @throws BackendException
      * @return void
      */
-    private function backendExceptionSeafapi(Exception $exception)
-    {
+    private function backendExceptionSeafapi(Exception $exception) {
         $code = $exception->getCode();
         $message = $exception->getMessage();
 
@@ -956,8 +949,7 @@ 
      *
      * @return void
      */
-    private function log(string $err_string)
-    {
+    private function log(string $err_string) {
         if ($this->debug) {
             Logger::debug(self::LOG_CONTEXT, $err_string);
             $this->debugLog($err_string, 2);
@@ -973,8 +965,7 @@ 
      *
      * @return string user friendly error message
      */
-    private function parseErrorCodeToMessage(int $error_code)
-    {
+    private function parseErrorCodeToMessage(int $error_code) {
         $error = $error_code;
 
         switch ($error) {

plugins/filesbackendSeafile/php/Model/Config.php

Braces +1 added lines, -2 removed lines

@@ -66,8 +66,7 @@
 
     private array $config = [];
 
-    public function __construct(array $config = [])
-    {
+    public function __construct(array $config = []) {
         $this->importConfigArray($config);
     }
 

plugins/filesbackendSeafile/php/Model/Timer.php

Braces +1 added lines, -2 removed lines

@@ -11,8 +11,7 @@
 {
     private float $start;
 
-    public function __construct()
-    {
+    public function __construct() {
         $this->start = microtime(true);
     }
 

plugins/filesbackendSeafile/php/class.pluginseafile.php

Braces +3 added lines, -6 removed lines

@@ -13,8 +13,7 @@ 
 	 *
 	 * @return void
 	 */
-	public function init()
-	{
+	public function init() {
 		$this->registerHook('server.core.settings.init.before');
 	}
 
@@ -24,8 +23,7 @@ 
 	 * @param String $eventID Identifier of the hook
 	 * @param Array $data Reference to the data of the triggered hook
 	 */
-	public function execute($eventID, &$data)
-	{
+	public function execute($eventID, &$data) {
 		switch ($eventID) {
 			case 'server.core.settings.init.before':
 				$this->onBeforeSettingsInit($data);
@@ -41,8 +39,7 @@ 
 	 * @param Array $data Reference to the data of the triggered hook
 	 * @return void
 	 */
-	public function onBeforeSettingsInit(&$data)
-	{
+	public function onBeforeSettingsInit(&$data) {
 		$data['settingsObj']->addSysAdminDefaults(array(
 			'zarafa' => array(
 				'v1' => array(

plugins/filesbackendSeafile/php/lib/seafapi/SeafileApi.php

Braces +15 added lines, -27 removed lines

@@ -122,8 +122,7 @@ 
      * @param string $pass
      * @param string|null $otp
      */
-    public function __construct(string $baseurl, string $user, string $pass, string $otp = null)
-    {
+    public function __construct(string $baseurl, string $user, string $pass, string $otp = null) {
         if (!(function_exists('curl_version'))) {
             throw new ConnectionException('PHP-CURL not installed', self::ERROR_CODE_NO_CURL);
         }
@@ -603,8 +602,7 @@ 
      * @throws InvalidArgumentException
      * @return array
      */
-    public function shareLibraryPathToGroup(string $lib, string $path, $group, string $permission = null)
-    {
+    public function shareLibraryPathToGroup(string $lib, string $path, $group, string $permission = null) {
         $lib = $this->verifyLib($lib);
         $path = $this->normalizePath($path);
         $pathEncoded = rawurlencode($path);
@@ -637,8 +635,7 @@ 
      * @throws InvalidArgumentException
      * @return array
      */
-    public function shareLibraryPathToUser(string $lib, string $path, string $user, string $permission = null)
-    {
+    public function shareLibraryPathToUser(string $lib, string $path, string $user, string $permission = null) {
         $lib = $this->verifyLib($lib);
         $path = $this->normalizePath($path);
         $pathEncoded = rawurlencode($path);
@@ -751,8 +748,7 @@ 
      * @throws InvalidArgumentException|Exception
      * @return string|object the common "success" or the object with error_msg property
      */
-    public function createNewDirectory(string $lib, string $path)
-    {
+    public function createNewDirectory(string $lib, string $path) {
         $lib = $this->verifyLib($lib);
         $path = $this->normalizePath($path);
         $pathEncoded = rawurlencode($path);
@@ -777,8 +773,7 @@ 
      * @throws InvalidArgumentException|Exception
      * @return string|object the common "success" or the known object with error_msg property
      */
-    public function deleteFile(string $lib, string $path)
-    {
+    public function deleteFile(string $lib, string $path) {
         $lib = $this->verifyLib($lib);
         $path = $this->normalizePath($path);
         $pathEncoded = rawurlencode($path);
@@ -827,8 +822,7 @@ 
      * @throws InvalidArgumentException|Exception
      * @return string|false on failure
      */
-    public function downloadFileAsBuffer(string $lib, string $path)
-    {
+    public function downloadFileAsBuffer(string $lib, string $path) {
         $url = $this->downloadFile($lib, $path);
 
         return $this->get($url);
@@ -852,7 +846,8 @@ 
 
         try {
             $result = $this->downloadFileToStream($lib, $path, $handle);
-        } finally {
+        }
+        finally {
             $close = fclose($handle);
         }
 
@@ -953,8 +948,7 @@ 
      * @return string|object the common "success" or the known object with error_msg property
      * @throws Exception
      */
-    public function renameFile(string $lib, string $path, string $newName)
-    {
+    public function renameFile(string $lib, string $path, string $newName) {
         $lib = $this->verifyLib($lib);
         $path = $this->normalizePath($path);
         $pathEncoded = rawurlencode($path);
@@ -1417,8 +1411,7 @@ 
      * @param array $curlOptions
      * @return bool|string
      */
-    private function get(string $url, array $curlOptions = [])
-    {
+    private function get(string $url, array $curlOptions = []) {
         $curlOptions += $this->curlSharedOptions;
 
         return $this->curlExec($url, $curlOptions);
@@ -1432,8 +1425,7 @@ 
      * @param array $curlOptions
      * @return bool|string
      */
-    private function post(string $url, array $fields = [], array $curlOptions = [])
-    {
+    private function post(string $url, array $fields = [], array $curlOptions = []) {
         $curlOptions += $this->curlSharedOptions;
         $curlOptions[CURLOPT_POST] = true;
         $curlOptions[CURLOPT_POSTFIELDS] = $fields;
@@ -1449,8 +1441,7 @@ 
      * @param array $curlOptions
      * @return bool|string
      */
-    public function put(string $url, array $fields = [], array $curlOptions = [])
-    {
+    public function put(string $url, array $fields = [], array $curlOptions = []) {
         $curlOptions += $this->curlSharedOptions;
         $curlOptions[CURLOPT_CUSTOMREQUEST] = 'PUT';
         $curlOptions[CURLOPT_POSTFIELDS] = $fields;
@@ -1465,8 +1456,7 @@ 
      * @param array $curlOptions
      * @return bool|string
      */
-    public function delete(string $url, array $curlOptions = [])
-    {
+    public function delete(string $url, array $curlOptions = []) {
 
         $curlOptions += $this->curlSharedOptions;
         $curlOptions[CURLOPT_CUSTOMREQUEST] = 'DELETE';
@@ -1484,8 +1474,7 @@ 
      * @throws InvalidResponseException
      * @return string|object|array
      */
-    private function jsonDecode(string $jsonText, int $flags = self::JSON_DECODE_ACCEPT_DEFAULT)
-    {
+    private function jsonDecode(string $jsonText, int $flags = self::JSON_DECODE_ACCEPT_DEFAULT) {
         $accept = $flags & self::JSON_DECODE_ACCEPT_MASK;
         if (0 === $accept) {
             return $jsonText;
@@ -1564,8 +1553,7 @@ 
      * @param array $options
      * @return bool|string
      */
-    private function curlExec(string $url, array $options)
-    {
+    private function curlExec(string $url, array $options) {
         $handle = curl_init($url);
         if (!($handle instanceof CurlHandle)) {
             throw new ConnectionException('Unable to initialise cURL session.', self::ERROR_CODE_NO_CURL);

plugins/filesbackendSeafile/php/lib/seafapi/autoload.php

Braces +2 added lines, -1 removed lines

@@ -20,7 +20,8 @@
         $classFileName = $basePath . str_replace('\\', '/', $classNamespaceSuffix) . '.php';
         if (is_file($classFileName)) {
             require($classFileName);
-        } else {
+        }
+        else {
             throw new \RuntimeException(sprintf('class: %s: no such file: %s', $className, $classFileName));
         }
     }

plugins/filesbackendSeafile/php/lib/seafapi/Exception/ConnectionException.php

Braces +1 added lines, -2 removed lines

@@ -59,8 +59,7 @@
         return sprintf('%s %s', $code, self::HTTP_STATUS[$code] ?? "UNKNOWN_PHRASE");
     }
 
-    public function __construct(string $message = "", int $code = 0, ?Throwable $previous = null)
-    {
+    public function __construct(string $message = "", int $code = 0, ?Throwable $previous = null) {
         // trigger E_USER_NOTICE if code is not known
         $isHttpCode = 100 <= $code && $code < 600;
         $isKnownHttpCode = $isHttpCode && isset(self::HTTP_STATUS[$code]);