CertificateTest

Complexity

Total Complexity

11

Size/Duplication

Total Lines	79
Duplicated Lines	0 %

Importance

Changes

0

11 Methods

Rating	Name	Duplication	Size	Complexity
A	testValidFrom()	0	2	1
A	testIssuer()	0	3	1
A	testValidTo()	0	2	1
A	setUp()	0	28	1
A	testExpired()	0	2	1
A	testEmailaddress()	0	2	1
A	testCAURL()	0	2	1
A	testGetName()	0	5	1
A	testDerPem()	0	7	1
A	testFingerprint()	0	3	1
A	testOCSPURL()	0	2	1

<?php

require_once 'test/smimeTest.php';
require_once 'php/class.certificate.php';
require_once 'php/util.php';

/**
 * @internal
 *
 * @coversNothing
 */
class CertificateTest extends SMIMETest {
	protected function setUp() {
		$this->countryName = "NL";

The property countryName does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

		$this->stateOrProvinceName = "Zuid Holland";

The property stateOrProvinceName does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

		$this->localityName = "Delft";

The property localityName does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

		$this->organizationName = "grommunio";

The property organizationName does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

		$this->organizationalUnitName = "Dev";

The property organizationalUnitName does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

		$this->commonName = "John";

The property commonName does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

		$this->emailAddress = "dev@grommunio.com";

The property emailAddress does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

		$dn = [
			"countryName" => $this->countryName,
			"stateOrProvinceName" => $this->stateOrProvinceName,
			"localityName" => $this->localityName,
			"organizationName" => $this->organizationName,
			"organizationalUnitName" => $this->organizationalUnitName,
			"commonName" => $this->commonName,
			"emailAddress" => $this->emailAddress,
		];
		$config = ['config' => OPENSSL_CONF_PATH];
		$daysvalid = 365;
		$privkey = openssl_pkey_new();
		$csr = openssl_csr_new($dn, $privkey, $config);

It seems like $privkey can also be of type resource; however, parameter $private_key of openssl_csr_new() does only seem to accept OpenSSLAsymmetricKey, maybe add an additional type check?

		$this->validFrom = time();

The property validFrom does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

		$this->validTo = time() + (86400 * 365);

The property validTo does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

		$sscert = openssl_csr_sign($csr, null, $privkey, $daysvalid, $config);
		openssl_x509_export($sscert, $publickey);

		$this->certdata = $publickey;

The property certdata does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

		$this->cert = new Certificate($this->certdata);

The property cert does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

	}

	public function testEmailaddress() {
		$this->assertEquals($this->cert->emailAddress(), $this->emailAddress);
	}

	public function testDerPem() {
		$pem = $this->cert->pem();
		$der = $this->cert->der();

		// FIXME: remove der2pem
		$this->assertEquals($pem, der2pem($der));
		$this->assertEquals($this->certdata, $pem);
	}

	public function testValidFrom() {
		$this->assertEquals($this->cert->validFrom(), $this->validFrom);
	}

	public function testValidTo() {
		$this->assertEquals($this->cert->validTo(), $this->validTo);
	}

	public function testExpired() {
		$this->assertEquals($this->cert->valid(), false);
	}

	public function testCAURL() {
		$this->assertEmpty($this->cert->caURL());
	}

	public function testOCSPURL() {
		$this->assertEmpty($this->cert->ocspURL());
	}

	public function testIssuer() {
		$issuer = $this->cert->issuer(true);
		$this->assertInternalType('object', $issuer);
	}

	public function testFingerprint() {
		$this->assertNotEmpty($this->cert->fingerprint());
		$this->assertNotEmpty($this->cert->fingerprint('md5'));
	}

	public function testGetName() {
		$name = $this->cert->getName();
		$this->assertContains($this->emailAddress, $name);
		$this->assertContains($this->countryName, $name);
		$this->assertContains($this->stateOrProvinceName, $name);
	}
}